d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

usr.sbin/bhyve: don't leak a FD if the device is not a tty

Browse Source 
Coverity CID:	1194193
Approved by:	markj, jhb
Differential Revision:	https://reviews.freebsd.org/D20934
This commit is contained in:
seanc 2019-07-12 18:13:58 +00:00
parent e7f77dfbc0
commit e8c1d8680e
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
usr.sbin/bhyve/uart_emul.c
View File

@ -678,9 +678,14 @@ uart_tty_backend(struct uart_softc *sc, const char *opts)
int fd;
fd = open(opts, O_RDWR | O_NONBLOCK);
if (fd < 0 || !isatty(fd))
if (fd < 0)
return (-1);
if (!isatty(fd)) {
close(fd);
return (-1);
}
sc->tty.rfd = sc->tty.wfd = fd;
sc->tty.opened = true;