d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Backport two small fixes from the MPSAFE TTY branch in Perforce:

Browse Source 
- Implement IMAXBEL. It turned out the IMAXBEL termios switch was marked
  as supported, while it had not been implemented.

- Don't go into the high watermark when in canonical mode, no data has
  been canonicalized and the input buffer is full. This caused the
  terminal to lock up. This prevented users from pressing
  backspace/^U/etc in such cases.

  This could easily be simulated by pasting a very big amount of data in
  a shell with sh(1) in canonical mode.

Obtained from:	//depot/projects/mpsafetty/...
This commit is contained in:
ed 2008-08-29 15:02:50 +00:00
parent 9805322d6a
commit e9104ac4da
2 changed files with 28 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
sys/kern/tty_ttydisc.c
View File

@ -305,7 +305,6 @@ int
ttydisc_read(struct tty *tp, struct uio *uio, int ioflag)
{
int error;
size_t c;
tty_lock_assert(tp, MA_OWNED);
@ -322,8 +321,8 @@ ttydisc_read(struct tty *tp, struct uio *uio, int ioflag)
else
error = ttydisc_read_raw_interbyte_timer(tp, uio, ioflag);
c = ttyinq_bytesleft(&tp->t_inq);
if (c >= tp->t_inlow) {
if (ttyinq_bytesleft(&tp->t_inq) >= tp->t_inlow ||
ttyinq_bytescanonicalized(&tp->t_inq) == 0) {
/* Unset the input watermark when we've got enough space. */
tty_hiwat_in_unblock(tp);
}
@ -1001,7 +1000,20 @@ parmrk:
print:
/* See if we can store this on the input queue. */
if (ttyinq_write_nofrag(&tp->t_inq, ob, ol, quote) != 0) {
/* We cannot. Enable the input watermark. */
if (CMP_FLAG(i, IMAXBEL))
ttyoutq_write_nofrag(&tp->t_outq, "\a", 1);
/*
* Prevent a deadlock here. It may be possible that a
* user has entered so much data, there is no data
* available to read(), but the buffers are full anyway.
*
* Only enter the high watermark if the device driver
* can actually transmit something.
*/
if (ttyinq_bytescanonicalized(&tp->t_inq) == 0)
return (0);
tty_hiwat_in_block(tp);
return (-1);
}

15
sys/sys/ttydisc.h
View File

@ -84,10 +84,19 @@ ttydisc_write_poll(struct tty *tp)
static __inline size_t
ttydisc_rint_poll(struct tty *tp)
{
size_t l;
tty_lock_assert(tp, MA_OWNED);
return ttyinq_bytesleft(&tp->t_inq);
/*
* XXX: Still allow character input when there's no space in the
* buffers, but we haven't entered the high watermark. This is
* to allow backspace characters to be inserted when in
* canonical mode.
*/
l = ttyinq_bytesleft(&tp->t_inq);
if (l == 0 && (tp->t_flags & TF_HIWAT_IN) == 0)
return (1);
return (l);
}
static __inline size_t