d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Protect fdc->flags within the worker thread, too.

Browse Source 
Use kthread_exit() instead of falling through the end of the worker
thread's main function.  Since kthread_exit() wakeup(9)s everyone
sleeping on the thread handle, drop the superfluous wakeup() call.
This commit is contained in:
joerg 2004-09-24 20:28:00 +00:00
parent 896afb3277
commit eba049f8c4
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
sys/dev/fdc/fdc.c
View File

@ -1140,8 +1140,10 @@ fdc_thread(void *arg)
fdc = arg;
int i;
mtx_lock(&fdc->fdc_mtx);
fdc->flags |= FDC_KTHREAD_ALIVE;
while ((fdc->flags & FDC_KTHREAD_EXIT) == 0) {
mtx_unlock(&fdc->fdc_mtx);
i = fdc_worker(fdc);
if (i && debugflags & 0x20) {
if (fdc->bp != NULL) {
@ -1151,9 +1153,12 @@ fdc_thread(void *arg)
printf("Retry line %d\n", retry_line);
}
fdc->retry += i;
mtx_lock(&fdc->fdc_mtx);
}
fdc->flags &= ~(FDC_KTHREAD_EXIT | FDC_KTHREAD_ALIVE);
wakeup(&fdc->fdc_thread);
mtx_unlock(&fdc->fdc_mtx);
kthread_exit(0);
}
/*