d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Check if the specified group is the user's primary group before

Browse Source 
iterating over the (possibly empty) list of members.  Otherwise, we
get a false negative when the target group has no members listed in
/etc/group.  This went mostly unnoticed because root is explicitly
listed as a member of wheel, so the bug is never triggered in the most
common use case, which is su(8).

PR:		109416
MFC after:	1 week
This commit is contained in:
Dag-Erling Smørgrav 2014-07-19 20:55:13 +00:00
parent e8263e185c
commit ec5622ad86
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/libpam/modules/pam_group/pam_group.c
View File

@ -96,14 +96,12 @@ pam_sm_authenticate(pam_handle_t *pamh, int flags __unused,
if ((grp = getgrnam(group)) == NULL || grp->gr_mem == NULL)
goto failed;
/* check if the group is empty */
if (*grp->gr_mem == NULL)
goto failed;
/* check membership */
/* check if user's own primary group */
if (pwd->pw_gid == grp->gr_gid)
goto found;
for (list = grp->gr_mem; *list != NULL; ++list)
/* iterate over members */
for (list = grp->gr_mem; list != NULL && *list != NULL; ++list)
if (strcmp(*list, pwd->pw_name) == 0)
goto found;