d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

MFV r294101: 6527 Possible access beyond end of string in zpool comment

Browse Source 
Reviewed by: George Wilson <george.wilson@delphix.com>
Reviewed by: Matthew Ahrens <mahrens@delphix.com>
Reviewed by: Dan McDonald <danmcd@omniti.com>
Approved by: Gordon Ross <gwr@nexenta.com>

illumos/illumos-gate@2bd7a8d078

This fixes erroneous double increments of the 'check' variable in a loop
in spa_prop_validate().  I ran into this in the clang380-import branch,
where clang 3.8.0 warns about it.  (It is already fixed there.)

MFC after:	3 days
This commit is contained in:
dim 2016-01-15 21:45:53 +00:00
parent 12fce57c8c
commit ec70d0382b
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa.c
View File

@ -610,7 +610,6 @@ spa_prop_validate(spa_t *spa, nvlist_t *props)
error = SET_ERROR(EINVAL); error = SET_ERROR(EINVAL);
break; break;
} }
check++;
} }
if (strlen(strval) > ZPROP_MAX_COMMENT) if (strlen(strval) > ZPROP_MAX_COMMENT)
error = E2BIG; error = E2BIG;