d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

o introduce u_cansee(), which performs access control checks between

Browse Source 
two subject ucreds.  Unlike p_cansee(), u_cansee() doesn't have
  process lock requirements, only valid ucred reference requirements,
  so is prefered as process locking improves.  For now, back p_cansee()
  into u_cansee(), but eventually p_cansee() will go away.

Reviewed by:	jhb, tmm
Obtained from:	TrustedBSD Project
This commit is contained in:
Robert Watson 2001-03-28 20:50:15 +00:00
parent 9ec5413762
commit ed6397209d
2 changed files with 29 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
sys/kern/kern_prot.c
View File

@ -968,27 +968,39 @@ suser_xxx(cred, proc, flag)
return (0);
}
static int
p_cansee(struct proc *p1, struct proc *p2, int *privused)
/*
* u_cansee(u1, u2): determine if u1 "can see" the subject specified by u2
* Arguments: imutable credentials u1, u2
* Returns: 0 for permitted, an errno value otherwise
* Locks: none
* References: u1 and u2 must be valid for the lifetime of the call
* u1 may equal u2, in which case only one reference is required
*/
int
u_cansee(struct ucred *u1, struct ucred *u2)
{
int error;
if ((error = prison_check(u1, u2)))
return (error);
if (!ps_showallprocs && u1->cr_uid != u2->cr_uid) {
if (suser_xxx(u1, NULL, PRISON_ROOT) == 0)
return (0);
else
return (ESRCH);
}
return (0);
}
static int
p_cansee(struct proc *p1, struct proc *p2, int *privused)
{
/* XXX: privused is going away, so don't do that here. */
if (privused != NULL)
*privused = 0;
if ((error = prison_check(p1->p_ucred, p2->p_ucred)))
return (error);
if (!ps_showallprocs && p1->p_ucred->cr_uid != p2->p_ucred->cr_uid) {
if (suser_xxx(NULL, p1, PRISON_ROOT) == 0) {
if (privused != NULL)
*privused = 1;
return (0);
}
return (ESRCH);
}
return (0);
/* Wrap u_cansee() for all functionality. */
return (u_cansee(p1->p_ucred, p2->p_ucred));
}
static int

1
sys/sys/systm.h
View File

@ -164,6 +164,7 @@ void setstatclockrate __P((int hzrate));
int suser __P((struct proc *));
int suser_xxx __P((struct ucred *cred, struct proc *proc, int flag));
int u_cansee __P((struct ucred *u1, struct ucred *u2));
char *getenv __P((char *name));
int getenv_int __P((char *name, int *data));