d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Change the order of lock reacquisition in vm_object_split() in order to

Browse Source 
simplify the code slightly.  Add a comment concerning lock ordering.
This commit is contained in:
alc 2007-03-22 07:02:43 +00:00
parent 29a0e4d380
commit efc8daaecb
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
sys/vm/vm_object.c
View File

@ -1308,6 +1308,10 @@ vm_object_split(vm_map_entry_t entry)
*/
new_object = vm_object_allocate(OBJT_DEFAULT, size);
/*
* At this point, the new object is still private, so the order in
* which the original and new objects are locked does not matter.
*/
VM_OBJECT_LOCK(new_object);
VM_OBJECT_LOCK(orig_object);
source = orig_object->backing_object;
@ -1350,9 +1354,8 @@ retry:
vm_page_unlock_queues();
VM_OBJECT_UNLOCK(new_object);
m->oflags |= VPO_WANTED;
msleep(m, VM_OBJECT_MTX(orig_object), PDROP | PVM, "spltwt", 0);
msleep(m, VM_OBJECT_MTX(orig_object), PVM, "spltwt", 0);
VM_OBJECT_LOCK(new_object);
VM_OBJECT_LOCK(orig_object);
goto retry;
}
vm_page_rename(m, new_object, idx);