Free resources and error cases; re-indent a curly brace while here.

CID:		1199366
Found with:	Coverity Prevent(tm)
MFC after:	1 week
This commit is contained in:
brueffer 2014-04-13 21:13:33 +00:00
parent f53a57bcab
commit f19c513644

View File

@ -1039,8 +1039,10 @@ ipfw_ctl(struct sockopt *sopt)
if (sopt->sopt_valsize == RULESIZE7(rule)) {
is7 = 1;
error = convert_rule_to_8(rule);
if (error)
if (error) {
free(rule, M_TEMP);
return error;
}
if (error == 0)
error = check_ipfw_struct(rule, RULESIZE(rule));
} else {
@ -1056,11 +1058,13 @@ ipfw_ctl(struct sockopt *sopt)
if (is7) {
error = convert_rule_to_7(rule);
size = RULESIZE7(rule);
if (error)
if (error) {
free(rule, M_TEMP);
return error;
}
}
error = sooptcopyout(sopt, rule, size);
}
}
}
free(rule, M_TEMP);
break;