d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

- Assert sched_lock in upcall_remove() since it is needed there and all

Browse Source 
callers already lock it there.
- Lock sched_lock slightly earlier in kse_create() so that it covers
  kg_numupcalls.
This commit is contained in:
jhb 2004-09-23 21:03:16 +00:00
parent 1f2758a712
commit f6dc0c3d5f
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sys/kern/kern_kse.c
View File

@ -111,6 +111,7 @@ void
upcall_remove(struct thread *td)
{
mtx_assert(&sched_lock, MA_OWNED);
if (td->td_upcall != NULL) {
td->td_upcall->ku_owner = NULL;
upcall_unlink(td->td_upcall);
@ -653,7 +654,9 @@ kse_create(struct thread *td, struct kse_create_args *uap)
* not help performance.
*/
PROC_LOCK(p);
mtx_lock_spin(&sched_lock);
if (newkg->kg_numupcalls >= ncpus) {
mtx_unlock_spin(&sched_lock);
PROC_UNLOCK(p);
upcall_free(newku);
return (EPROCLIM);
@ -675,7 +678,6 @@ kse_create(struct thread *td, struct kse_create_args *uap)
* Make the new upcall available to the ksegrp.
* It may or may not use it, but it's available.
*/
mtx_lock_spin(&sched_lock);
PROC_UNLOCK(p);
upcall_link(newku, newkg);
if (mbx.km_quantum)