d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Convert assertion that only vmspace owner grows the stack, into a

Browse Source 
check blocking grow from other processes accesses.

Debugger may access stack grow area with ptrace(2).  In this case,
real state of the process is to not have the stack grown, which
provides more accurate inspection.  Technical reason to avoid the grow
is to avoid applying wrong process (debugger) stack limit.

This change also has a consequence of making aio workers accesses past
the bottom of stacks into EFAULT, arguably the situation is a
programmers mistake.

Reported by:	jhb
Discussed with:	alc, jhb
Sponsored by:	The FreeBSD Foundation
MFC after:	3 days
This commit is contained in:
Konstantin Belousov 2017-07-18 20:26:41 +00:00
parent 8460de6783
commit f758aadd07
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
sys/vm/vm_map.c
View File

@ -3698,7 +3698,8 @@ vm_map_growstack(vm_map_t map, vm_offset_t addr, vm_map_entry_t gap_entry)
p = curproc;
vm = p->p_vmspace;
MPASS(map == &p->p_vmspace->vm_map);
if (map != &p->p_vmspace->vm_map)
return (KERN_FAILURE);
MPASS(!map->system_map);
guard = stack_guard_page * PAGE_SIZE;