From f7d8f2da45b3bfddc9b9f82fd847dbf5e9d6f116 Mon Sep 17 00:00:00 2001 From: hselasky Date: Fri, 23 Mar 2018 18:11:06 +0000 Subject: [PATCH] Hide verbose proclamation of error when forced in mlx5core. When mlx5_enter_error_state() operation is forced by shutdown, the messages surrounding setting the error state are not informational and confuse users. Submitted by: kib@ MFC after: 1 week Sponsored by: Mellanox Technologies --- sys/dev/mlx5/mlx5_core/mlx5_health.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sys/dev/mlx5/mlx5_core/mlx5_health.c b/sys/dev/mlx5/mlx5_core/mlx5_health.c index fb5332863fc7..449092819675 100644 --- a/sys/dev/mlx5/mlx5_core/mlx5_health.c +++ b/sys/dev/mlx5/mlx5_core/mlx5_health.c @@ -99,14 +99,16 @@ void mlx5_enter_error_state(struct mlx5_core_dev *dev, bool force) return; } - mlx5_core_err(dev, "start\n"); + if (!force) + mlx5_core_err(dev, "internal state error detected\n"); if (pci_channel_offline(dev->pdev) || in_fatal(dev) || force) { dev->state = MLX5_DEVICE_STATE_INTERNAL_ERROR; mlx5_trigger_cmd_completions(dev); } mlx5_core_event(dev, MLX5_DEV_EVENT_SYS_ERROR, 0); - mlx5_core_err(dev, "end\n"); + if (!force) + mlx5_core_err(dev, "system error event triggered\n"); unlock: mutex_unlock(&dev->intf_state_mutex);