d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Additional icache paranoia: non-PLT relocations can modify the text segment.

Browse Source 
It is then important to make sure the icache is synchronized again to
prevent (rare) random seg faults and illegal instructions.

MFC after:	3 days
This commit is contained in:
nwhitehorn 2011-12-17 16:20:27 +00:00
parent 270e7ed83a
commit f8b4a766de
2 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libexec/rtld-elf/powerpc/reloc.c
View File

@ -317,6 +317,10 @@ reloc_non_plt(Obj_Entry *obj, Obj_Entry *obj_rtld, RtldLockState *lockstate)
done:
if (cache != NULL)
free(cache);
/* Synchronize icache for text seg in case we made any changes */
__syncicache(obj->mapbase, obj->textsize);
return (r);
}

7
libexec/rtld-elf/powerpc64/reloc.c
View File

@ -313,9 +313,12 @@ reloc_non_plt(Obj_Entry *obj, Obj_Entry *obj_rtld, RtldLockState *lockstate)
}
r = 0;
done:
if (cache) {
if (cache)
munmap(cache, bytes);
}
/* Synchronize icache for text seg in case we made any changes */
__syncicache(obj->mapbase, obj->textsize);
return (r);
}