Always assign WARNS using ?=

- fix some nearby style bugs - include Makefile.inc where it makes sense and reduces duplication Approved by: ed (co-mentor)
2010-03-02 16:58:04 +00:00 · 2010-03-02 16:58:04 +00:00 · f8d1dd7a4e
commit f8d1dd7a4e
parent 1a096d21d2
21 changed files with 28 additions and 32 deletions
--- a/lib/libbsnmp/Makefile.inc
+++ b/lib/libbsnmp/Makefile.inc
@ -1,6 +1,6 @@
 # $FreeBSD$

-SHLIB_MAJOR=	5
-WARNS?=		6
 NO_WERROR=
 INCSDIR=	${INCLUDEDIR}/bsnmp
+
+.include "../Makefile.inc"
--- a/lib/libbsnmp/libbsnmp/Makefile
+++ b/lib/libbsnmp/libbsnmp/Makefile
@ -5,9 +5,8 @@
 CONTRIB= ${.CURDIR}/../../../contrib/bsnmp/lib
 .PATH: ${CONTRIB}

-LIB	= bsnmp
-SHLIBDIR ?= /lib
-WARNS	?= 6
+LIB=	bsnmp
+SHLIBDIR?= /lib

 CFLAGS+= -I${CONTRIB} -DHAVE_ERR_H -DHAVE_GETADDRINFO -DHAVE_STRLCPY
 CFLAGS+= -DHAVE_STDINT_H -DHAVE_INTTYPES_H -DQUADFMT='"llu"' -DQUADXFMT='"llx"'
--- a/lib/libpam/modules/pam_krb5/Makefile
+++ b/lib/libpam/modules/pam_krb5/Makefile
@ -29,7 +29,7 @@ SRCS=	pam_krb5.c
 MAN=	pam_krb5.8
 .if defined(_FREEFALL_CONFIG)
 CFLAGS+=-D_FREEFALL_CONFIG
-WARNS=	3
+WARNS?=	3
 .endif

 DPADD=	${LIBKRB5} ${LIBHX509} ${LIBASN1} ${LIBROKEN} ${LIBCOM_ERR} ${LIBCRYPT} ${LIBCRYPTO}
--- a/sbin/ddb/Makefile
+++ b/sbin/ddb/Makefile
@ -3,7 +3,7 @@
 PROG=	ddb
 SRCS=	ddb.c ddb_capture.c ddb_script.c
 MAN=	ddb.8
-WARNS=	3
+WARNS?=	3

 DPADD=	${LIBKVM}
 LDADD=	-lkvm
--- a/sbin/ipf/ipftest/Makefile
+++ b/sbin/ipf/ipftest/Makefile
@ -1,7 +1,5 @@
 #	$FreeBSD$

-WARNS=0
-
 PROG=		ipftest
 SRCS=		${GENHDRS} ipftest.c fil.c ip_frag.c ip_state.c ip_nat.c \
 		ip_proxy.c ip_auth.c ip_htable.c ip_lookup.c \
@ -10,6 +8,7 @@ SRCS=		${GENHDRS} ipftest.c fil.c ip_frag.c ip_state.c ip_nat.c \
 		ipf_l.c ipnat_y.c ipnat_l.c md5.c radix.c bpf_filter.c
 MAN=		ipftest.1

+WARNS?=		0
 CFLAGS+=	-DIPFILTER_LOG -DIPFILTER_COMPILED -DIPFILTER_LOOKUP \
 		-DIPFILTER_SCAN -DIPFILTER_SYNC -DIPFILTER_CKSUM -I.

--- a/share/examples/autofs/driver/Makefile
+++ b/share/examples/autofs/driver/Makefile
@ -1,11 +1,11 @@
 # $Id: Makefile,v 1.5 2004/09/08 08:27:12 bright Exp $
 # $FreeBSD$

-PROG=autodriver
+PROG=		autodriver
+NO_MAN=

 SRCS=		autodriver.c
-NO_MAN=
-WARNS=		4
+WARNS?=		4
 CFLAGS+=	-g
 BINDIR?=	/sbin

--- a/tools/regression/kqueue/Makefile
+++ b/tools/regression/kqueue/Makefile
@ -16,6 +16,6 @@ SRCS=			\
 	signal.c	\
 	user.c
 NO_MAN=
-WARNS=2
+WARNS?=	2

 .include "bsd.prog.mk"
--- a/tools/regression/priv/Makefile
+++ b/tools/regression/priv/Makefile
@ -46,7 +46,7 @@ SRCS=	main.c				\
 	priv_vm_munlock.c

 NO_MAN=
-WARNS=	3
+WARNS?=	3

 DPADD+= ${LIBIPSEC}
 LDADD+= -lipsec
--- a/tools/regression/sockets/unix_gc/Makefile
+++ b/tools/regression/sockets/unix_gc/Makefile
@ -1,7 +1,7 @@
 # $FreeBSD$

 PROG=	unix_gc
-WARNS=	3
 NO_MAN=
+WARNS?=	3

 .include <bsd.prog.mk>
--- a/tools/regression/sockets/unix_sorflush/Makefile
+++ b/tools/regression/sockets/unix_sorflush/Makefile
@ -2,6 +2,6 @@

 PROG=	unix_sorflush
 NO_MAN=
-WARNS=	3
+WARNS?=	3

 .include <bsd.prog.mk>
--- a/tools/regression/tmpfs/Makefile
+++ b/tools/regression/tmpfs/Makefile
@ -31,7 +31,7 @@ regress: ${tests}

 PROG=	h_tools
 NO_MAN=	# defined
-WARNS=	4
+WARNS?=	4

 t_sizes t_sockets t_statvfs: h_tools

--- a/tools/tools/netrate/http/Makefile
+++ b/tools/tools/netrate/http/Makefile
@ -1,8 +1,8 @@
 # $FreeBSD$

 PROG=	http
-WARNS=	3
 NO_MAN=
+WARNS?=	3
 DPADD=	${LIBPTHREAD}
 LDADD=	-lpthread

--- a/tools/tools/netrate/httpd/Makefile
+++ b/tools/tools/netrate/httpd/Makefile
@ -1,8 +1,8 @@
 # $FreeBSD$

 PROG=	httpd
-WARNS=	3
 NO_MAN=
+WARNS?=	3
 DPADD=	${LIBPTHREAD}
 LDADD=	-lpthread

--- a/tools/tools/netrate/juggle/Makefile
+++ b/tools/tools/netrate/juggle/Makefile
@ -2,9 +2,8 @@

 PROG=	juggle
 NO_MAN=
-WARNS=	3
-
-LDADD=	-lpthread
+WARNS?=	3
 DPADD=	${LIBPTHREAD}
+LDADD=	-lpthread

 .include <bsd.prog.mk>
--- a/tools/tools/netrate/tcpconnect/Makefile
+++ b/tools/tools/netrate/tcpconnect/Makefile
@ -1,7 +1,7 @@
 # $FreeBSD$

 PROG=	tcpconnect
-WARNS=	3
 NO_MAN=
+WARNS?=	3

 .include <bsd.prog.mk>
--- a/tools/tools/netrate/tcpp/Makefile
+++ b/tools/tools/netrate/tcpp/Makefile
@ -4,6 +4,6 @@ PROG=	tcpp
 INCS=	tcpp.h
 NO_MAN=	
 SRCS=	tcpp.c tcpp_client.c tcpp_server.c tcpp_util.c
-WARNS=	3
+WARNS?=	3

 .include <bsd.prog.mk>
--- a/tools/tools/netrate/tcpreceive/Makefile
+++ b/tools/tools/netrate/tcpreceive/Makefile
@ -1,7 +1,7 @@
 # $FreeBSD$

 PROG=	tcpreceive
-WARNS=	3
 NO_MAN=
+WARNS?=	3

 .include <bsd.prog.mk>
--- a/tools/tools/umastat/Makefile
+++ b/tools/tools/umastat/Makefile
@ -2,10 +2,9 @@

 PROG=	umastat
 NO_MAN=
+WARNS?=	3

 DPADD=	${LIBKVM}
 LDADD=	-lkvm

-WARNS=	3
-
 .include <bsd.prog.mk>
--- a/usr.bin/locale/Makefile
+++ b/usr.bin/locale/Makefile
@ -1,7 +1,7 @@
 # $FreeBSD$

-PROG = locale
-CFLAGS += -I${.CURDIR}/../../lib/libc/locale
-WARNS ?= 3
+PROG=	locale
+WARNS?=	3
+CFLAGS+= -I${.CURDIR}/../../lib/libc/locale

 .include <bsd.prog.mk>
--- a/usr.sbin/fwcontrol/Makefile
+++ b/usr.sbin/fwcontrol/Makefile
@ -3,7 +3,7 @@
 PROG=	fwcontrol
 SRCS=	fwcontrol.c fwcrom.c fwdv.c fwmpegts.c
 MAN=	fwcontrol.8
-WARNS=	3
+WARNS?=	3

 .PATH:	${.CURDIR}/../../sys/dev/firewire

--- a/usr.sbin/uhsoctl/Makefile
+++ b/usr.sbin/uhsoctl/Makefile
@ -2,7 +2,7 @@

 PROG=	uhsoctl
 MAN=	uhsoctl.1
-WARNS=	1
+WARNS?=	1

 DPADD=	${LIBUTIL}
 LDADD=	-lutil