From fa02fc2d8fde6b87d796c30d2200aec5567f4649 Mon Sep 17 00:00:00 2001 From: Marcelo Araujo Date: Thu, 14 Apr 2016 12:25:00 +0000 Subject: [PATCH] Use NULL instead of 0 for pointers. fopen(3) will return NULL in case it can't open the STREAM. The malloc will return a pointer to the allocated memory if successful, otherwise a NULL pointer is returned. Also add an extra DEBUG1 to print out the error to open a file. Reviewed by: ed Differential Revision: https://svnweb.freebsd.org/changeset/base/297959 --- usr.sbin/rmt/rmt.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/usr.sbin/rmt/rmt.c b/usr.sbin/rmt/rmt.c index a5c048faee2f..57c8439a70f5 100644 --- a/usr.sbin/rmt/rmt.c +++ b/usr.sbin/rmt/rmt.c @@ -84,8 +84,10 @@ main(int argc, char **argv) argc--, argv++; if (argc > 0) { debug = fopen(*argv, "w"); - if (debug == 0) + if (debug == NULL) { + DEBUG1("rmtd: error to open %s\n", *argv); exit(1); + } (void)setbuf(debug, (char *)0); } top: @@ -226,10 +228,10 @@ checkbuf(char *rec, int size) if (size <= maxrecsize) return (rec); - if (rec != 0) + if (rec != NULL) free(rec); rec = malloc(size); - if (rec == 0) { + if (rec == NULL) { DEBUG("rmtd: cannot allocate buffer space\n"); exit(4); }