From fa7831db8f27874d22fc6062578163cce53bc858 Mon Sep 17 00:00:00 2001 From: dillon Date: Tue, 25 Jan 2000 01:51:21 +0000 Subject: [PATCH] Type-o, change from[...] = 0 to fromb[...] = 0. The incorrect buffer was having its last element zero'd. It turns out not to be a security hole or to have any real effect on the code because 'from' was previously pointing to a buffer of the same size as 'fromb', and the last element in fromb is already 0 anyway due to the use of sizeof(fromb)-1 in the strncpy() call. But I'm not pressing my luck so only the type-o is being fixed. --- usr.sbin/lpr/lpd/lpd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/usr.sbin/lpr/lpd/lpd.c b/usr.sbin/lpr/lpd/lpd.c index f5df2a761eaf..47e805619013 100644 --- a/usr.sbin/lpr/lpd/lpd.c +++ b/usr.sbin/lpr/lpd/lpd.c @@ -590,7 +590,7 @@ chkhost(f) inet_ntoa(f->sin_addr)); (void) strncpy(fromb, hp->h_name, sizeof(fromb) - 1); - from[sizeof(fromb) - 1] = '\0'; + fromb[sizeof(fromb) - 1] = '\0'; from = fromb; /* Check for spoof, ala rlogind */