d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pci_ioctl: Avoid returning uninitialized error value if user provided empty buffer

Browse Source 
In the weird case where the user-provided buffer was zero bytes, we could break
out of PCIOCGETCONF and return without initializing error.  In this case,
initialize error to zero -- we successfully did nothing, as requested.

Reported by:	Coverity
Sponsored by:	Dell EMC Isilon
This commit is contained in:
Conrad Meyer 2018-03-01 01:49:36 +00:00
parent 893daee680
commit fadd3f8a66
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sys/dev/pci/pci_user.c
View File

@ -762,8 +762,10 @@ pci_ioctl(struct cdev *dev, u_long cmd, caddr_t data, int flag, struct thread *t
* tell the user that there are more matches
* left.
*/
if (cio->num_matches >= ionum)
if (cio->num_matches >= ionum) {
error = 0;
break;
}
#ifdef PRE7_COMPAT
#ifdef COMPAT_FREEBSD32