d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

iw_cxgbe: Plug a lock leak in process_mpa_request().

Browse Source 
If the parent is DEAD or connect_request_upcall() fails, the parent
mutex is left locked.  This leads to a hang when process_mpa_request()
is called again for another child of the listening endpoint.

Submitted by:	Krishnamraju Eraparaju @ Chelsio
Obtained from:	upstream iw_cxgb4
Sponsored by:	Chelsio Communications
This commit is contained in:
Navdeep Parhar 2016-05-27 23:44:33 +00:00
parent ce00342bb2
commit fc511a3302
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
sys/dev/cxgbe/iw_cxgbe/cm.c
View File

@ -1861,14 +1861,16 @@ process_mpa_request(struct c4iw_ep *ep)
/* drive upcall */
mutex_lock(&ep->parent_ep->com.mutex);
if (ep->parent_ep->com.state != DEAD) {
if(connect_request_upcall(ep))
goto err_out;
}else {
goto err_out;
}
if (connect_request_upcall(ep))
goto err_unlock_parent;
} else
goto err_unlock_parent;
mutex_unlock(&ep->parent_ep->com.mutex);
return 0;
err_unlock_parent:
mutex_unlock(&ep->parent_ep->com.mutex);
goto err_out;
err_stop_timer:
STOP_EP_TIMER(ep);
err_out: