d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

dtrace_xcall: no need for special handling of curcpu

Browse Source 
smp_rendezvous_cpus alreadt does the right thing in a very similar
fashion, so the code was kind of duplicating that.

MFC after:	3 weeks
This commit is contained in:
Andriy Gapon 2010-12-07 09:19:47 +00:00
parent 7becfa95b9
commit fe8c7b3d77
2 changed files with 6 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
sys/cddl/dev/dtrace/amd64/dtrace_subr.c
View File

@ -115,26 +115,13 @@ dtrace_xcall(processorid_t cpu, dtrace_xcall_t func, void *arg)
{
cpumask_t cpus;
critical_enter();
if (cpu == DTRACE_CPUALL)
cpus = all_cpus;
else
cpus = (cpumask_t) (1 << cpu);
cpus = (cpumask_t)1 << cpu;
/* If the current CPU is in the set, call the function directly: */
if ((cpus & (1 << curcpu)) != 0) {
(*func)(arg);
/* Mask the current CPU from the set */
cpus &= ~(1 << curcpu);
}
/* If there are any CPUs in the set, cross-call to those CPUs */
if (cpus != 0)
smp_rendezvous_cpus(cpus, NULL, func, smp_no_rendevous_barrier, arg);
critical_exit();
smp_rendezvous_cpus(cpus, smp_no_rendevous_barrier, func,
smp_no_rendevous_barrier, arg);
}
static void

19
sys/cddl/dev/dtrace/i386/dtrace_subr.c
View File

@ -115,26 +115,13 @@ dtrace_xcall(processorid_t cpu, dtrace_xcall_t func, void *arg)
{
cpumask_t cpus;
critical_enter();
if (cpu == DTRACE_CPUALL)
cpus = all_cpus;
else
cpus = (cpumask_t) (1 << cpu);
cpus = (cpumask_t)1 << cpu;
/* If the current CPU is in the set, call the function directly: */
if ((cpus & (1 << curcpu)) != 0) {
(*func)(arg);
/* Mask the current CPU from the set */
cpus &= ~(1 << curcpu);
}
/* If there are any CPUs in the set, cross-call to those CPUs */
if (cpus != 0)
smp_rendezvous_cpus(cpus, NULL, func, smp_no_rendevous_barrier, arg);
critical_exit();
smp_rendezvous_cpus(cpus, smp_no_rendevous_barrier, func,
smp_no_rendevous_barrier, arg);
}
static void