d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
249,631 Commits 4 Branches 49 Tags
Commit Graph

45 Commits

Author SHA1 Message Date
eugen
3cfe33fd3b pw(8): correct expiration period handling and command line overrides 
to preconfigured values for -e, -p and -w flags.

Use non-negative symbols instead of magic values
in passwd_val/pw_password functions.

PR:		223431
Submitted by:	Yuri Pankov (in part, patch for the manual)
Reported by:	mav (mentor)
MFC after:	3 days
Relnotes:	yes
 2017-12-09 23:34:00 +00:00
pfg
7551d83c35 various: general adoption of SPDX licensing ID tags. 
Mainly focus on files that use BSD 2-Clause license, however the tool I
was using misidentified many licenses so this was mostly a manual - error
prone - task.

The Software Package Data Exchange (SPDX) group provides a specification
to make it easier for automated tools to detect and summarize well known
opensource licenses. We are gradually adopting the specification, noting
that the tags are considered only advisory and do not, in any way,
superceed or replace the license texts.

No functional change intended.
 2017-11-27 15:37:16 +00:00
asomers
3cee0b0310 pw should sanitize the argument of -w. 
Otherwise, it will silently disable the login for the selected account if
the argument is unrecognizable.

usr.sbin/pw/pw.h
usr.sbin/pw/pw_conf.c
usr.sbin/pw/pw_user.c
	Use separate rules to validate boolean parameters and passwd
	parameters.  Error out if a password parameter cannot be parsed.

usr.sbin/pw/tests/Makefile
usr.sbin/pw/tests/crypt.c
usr.sbin/pw/tests/pw_useradd.sh
usr.sbin/pw/tests/pw_usermod.sh
	Add tests for the validation.  Also, enhance existing
	password-related tests to actually validate that the correct hash is
	written to master.passwd.

Reviewed by:	bapt
MFC after:	4 weeks
Sponsored by:	Spectra Logic Corp
Differential Revision:	https://reviews.freebsd.org/D6840
 2016-07-13 17:09:20 +00:00
bapt
ebf326060e Simplify code for parsing extra groups 2015-12-29 00:08:32 +00:00
bapt
9a7989cc8d Use intmax_t rather than long long 2015-08-02 19:49:24 +00:00
bapt
069c5cd075 Fix build on 32bits 2015-08-02 13:50:11 +00:00
bapt
4469579834 Cleanup a bit includes 2015-08-02 13:22:46 +00:00
bapt
4f6bdcfb5d Rewrite parsing subcommands arguments of pw(8) 
Now each subcommands checks its arguments in a dedicated functions.

This helps improving input validation, code readability/maintainability
While here:
- Add a -y option to pw userdel/usermod so it can maintain NIS servers if
  nispasswd is not defined in pw.conf(5)
- Allow pw -r <rootdir> to remove directory with userdel -r
- Fix bug when renaming a user which was not renaming the user name it groups
  it is a member of.
- Only parse pw.conf(5) when needed.
 2015-08-02 12:47:50 +00:00
bapt
e83b0ae9f0 Remove things that crept in after badly checked revert 2015-08-01 12:20:55 +00:00
bapt
8fa8b523a2 Partial revert of r286152 
More work needed on the cli validation
 2015-08-01 12:18:48 +00:00
bapt
353f021396 Fix build 2015-08-01 11:52:48 +00:00
bapt
626fd041e6 Fix formatting of new code 
Fix sorting or errstr
Remove useless initialisation or errstr

Reported by:	bde
 2015-08-01 11:31:59 +00:00
bapt
9a71628c9f Validate expiration days and password days from commmand line and pw.conf 2015-08-01 10:25:55 +00:00
bapt
10ba8e17a1 Validate the max_uid/max_gid boundaries and entry type in pw.conf 2015-08-01 10:10:13 +00:00
bapt
5acf1473e1 Cast uid/git to uintmax_t when using printf-like functions so the size of 
uid/gid size remains a implementation detail
 2015-08-01 09:55:47 +00:00
bapt
be61586cab Replace custom string array with stringlist(3) 2015-07-11 23:07:17 +00:00
bapt
dc90f50e54 Remove useless cast in printf and printf-like functions: 
use %u for uid_t and gid_t
 2015-05-31 22:07:03 +00:00
bapt
7b87a7e6ff Move cleanup functions to the right place 2015-05-31 12:04:06 +00:00
bapt
5da06ca262 Remove useless test before free() 2015-05-31 11:56:59 +00:00
bapt
b65872777d Return early in case we cannot read the configuration file 
This drops one level of indentation
 2015-05-31 11:55:28 +00:00
bapt
6097f34be5 Use calloc(3) instead of malloc(3) + memset(3) 
While here check the return of calloc(3)
 2015-05-10 11:18:01 +00:00
bapt
7b3f5d741e The initial logic for allocating the new string was wrong, the conversion 
to strndup(3) duplicated the same mistake, actually strdup(3) is good enough
to allocate the new string.
 2015-05-10 10:15:36 +00:00
bapt
091698a77d Use strndup(3) instead of malloc(3) + memcpy(3) 
Check the return of strndup
 2015-05-10 10:02:09 +00:00
bapt
065d18b9ef Remove useless call to extendarray 2015-05-10 09:33:15 +00:00
bapt
ee9e5523ab Remove now unused LNBUFSZ buffer size 2015-05-09 22:08:30 +00:00
bapt
6fcebe0418 Return from the function as early as possible 
This reduces the depth of the if statements and improves clarity of the code
 2015-05-09 21:53:33 +00:00
bapt
33ff7a2e5e Use sbuf(9) instead of homebrewed buffered string 2015-05-09 19:00:16 +00:00
bapt
418b7ad781 Simplify reading pw.conf(5) by using getline(3) 2014-04-22 21:07:56 +00:00
jkim
2a03b255b4 Stop hard-coding default directory mode as 0777. 2011-03-08 20:13:29 +00:00
le
f17fbfd9be Add home directory creation mode to pw.conf(5) and be a bit 
more specific about the effect of the current umask on -M.
 2007-03-30 11:23:10 +00:00
brian
9e766e7f13 Handle snprintf() returning < 0 (not just -1) 
MFC after:	2 weeks
 2001-08-20 15:09:34 +00:00
brian
d48c427cd5 Handle snprintf() returning -1. 
MFC after:	2 weeks
 2001-08-20 13:24:39 +00:00
dougb
1fd2c926a8 Make the comment generated in /etc/pw.conf match reality 
PR:				misc/23451
Submitted by:	Ben Rosengart, ben@narcissus.net
 2000-12-18 01:35:56 +00:00
davidn
14da5481e1 Catch up to the fact that we now have tcsh in the tree. 2000-07-16 01:46:26 +00:00
peter
efabb9ccb1 $Id$ -> $FreeBSD$ 1999-08-28 01:35:59 +00:00
davidn
92f725d0a6 Remove some more warnings. 1999-07-28 12:49:34 +00:00
davidn
aea1f6bc3c 1) Do not blindly ignore file update errors which may occur due to concurrent 
updating
2) Add -V <etcdir>, which allows maintaining user/group database in alternate
   locations other than /etc.
 1999-02-23 07:15:11 +00:00
charnier
c4198a70c7 Use err(3) instead of local redefinition. Add rcsid string. 1997-10-10 06:23:42 +00:00
davidn
00e1cd92d7 Unquote default group in pw.conf. 
PR: 4365
Submitted by: "Andrew L. Moore" <alm@mclink.com>
 1997-09-01 09:33:08 +00:00
peter
b782f4df30 Revert $FreeBSD$ to $Id$ 1997-02-22 16:15:28 +00:00
jkh
808a36ef65 Make the long-awaited change from $Id$ to $FreeBSD$ 
This will make a number of things easier in the future, as well as (finally!)
avoiding the Id-smashing problem which has plagued developers for so long.

Boy, I'm glad we're not using sup anymore.  This update would have been
insane otherwise.
 1997-01-14 07:20:47 +00:00
davidn
ced6786ae2 Adds optional NIS passwd file updating and optionally rebuilding 
NIS maps.

Suggested by:	Peter Wemm
 1997-01-05 07:15:37 +00:00
davidn
ae5c463397 1) 200 users per group limitation removed and pw 
will handle lines of any length in /etc/group.
2)	Fixed bug with usermod -d not updating user's home
	directory.
3)	Minor formatting display changes/fixes with *show -P.
 1996-12-21 15:35:45 +00:00
joerg
7b15aed015 Copyright update by the author, to be more in line with our sample 
copyright.

Submitted by:	David Nugent
 1996-12-10 23:59:04 +00:00
joerg
4a198ee0cb pw(8) -- a backend utility to manage the user and group databases. 
sysinstall's new User&group menu will use it, hence it's a 2.2
candidate despite of providing new functionality.

Submitted by:	David L. Nugent, <davidn@blaze.net.au>
 1996-12-09 14:05:35 +00:00