d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
239,853 Commits 4 Branches 49 Tags
Commit Graph

14 Commits

Author SHA1 Message Date
asomers
9e66c6e8f0 Speed up pw operations that edit /etc/group or /etc/passwd 
r285050 fixed a bug in pw that could lead to /etc/passwd or /etc/group
corruption on power loss. However, it fixed it by opening those files with
O_SYNC, which is very slow, especially on ZFS. This change replaces O_SYNC
with appropriately placed fsync()s instead, which is much faster. Using a
ZFS tmpdir, the time to run pw's kyua tests drops from 245s to 35s.

Reviewed by:	allanjude, bapt, vangyzen, garga
Tested on pfSense by:	garga
MFC after:	4 weeks
Sponsored by:	Spectra Logic Corp
Differential Revision:	https://reviews.freebsd.org/D8319
 2016-11-18 16:07:08 +00:00
asomers
5e03799fd4 Close some file descriptor leaks in pw 
MFC after:	4 weeks
Sponsored by:	Spectra Logic Corp
Differential Revision:	https://reviews.freebsd.org/D8245
 2016-10-21 20:17:19 +00:00
bapt
4469579834 Cleanup a bit includes 2015-08-02 13:22:46 +00:00
bapt
4f6bdcfb5d Rewrite parsing subcommands arguments of pw(8) 
Now each subcommands checks its arguments in a dedicated functions.

This helps improving input validation, code readability/maintainability
While here:
- Add a -y option to pw userdel/usermod so it can maintain NIS servers if
  nispasswd is not defined in pw.conf(5)
- Allow pw -r <rootdir> to remove directory with userdel -r
- Fix bug when renaming a user which was not renaming the user name it groups
  it is a member of.
- Only parse pw.conf(5) when needed.
 2015-08-02 12:47:50 +00:00
bapt
f8a287817e Remove some uneeded headers 2015-05-09 19:29:55 +00:00
bapt
1bf34f2c1b In NIS mode first chmod(2) the temporary file and is succeed then rename(2) 2012-11-20 14:05:46 +00:00
bapt
7df2814837 Correctly set the password file mode after renaming in NIS mode 2012-11-20 10:59:41 +00:00
bapt
cfea627c58 Teach pw(8) about how to use pw/gr API to reduce code duplication 
MFC after:	2 months
 2012-10-30 08:00:53 +00:00
peter
efabb9ccb1 $Id$ -> $FreeBSD$ 1999-08-28 01:35:59 +00:00
davidn
aea1f6bc3c 1) Do not blindly ignore file update errors which may occur due to concurrent 
updating
2) Add -V <etcdir>, which allows maintaining user/group database in alternate
   locations other than /etc.
 1999-02-23 07:15:11 +00:00
charnier
c4198a70c7 Use err(3) instead of local redefinition. Add rcsid string. 1997-10-10 06:23:42 +00:00
peter
b782f4df30 Revert $FreeBSD$ to $Id$ 1997-02-22 16:15:28 +00:00
jkh
808a36ef65 Make the long-awaited change from $Id$ to $FreeBSD$ 
This will make a number of things easier in the future, as well as (finally!)
avoiding the Id-smashing problem which has plagued developers for so long.

Boy, I'm glad we're not using sup anymore.  This update would have been
insane otherwise.
 1997-01-14 07:20:47 +00:00
davidn
ced6786ae2 Adds optional NIS passwd file updating and optionally rebuilding 
NIS maps.

Suggested by:	Peter Wemm
 1997-01-05 07:15:37 +00:00