Commit Graph

36 Commits

Author SHA1 Message Date
Warner Losh
e8d2bea9cb Close the fp rather than the fd since we fdopen the fd so we don't
leak the FILE *.

CID: 978383
2017-12-28 05:34:29 +00:00
Pedro F. Giffuni
8a16b7a18f General further adoption of SPDX licensing ID tags.
Mainly focus on files that use BSD 3-Clause license.

The Software Package Data Exchange (SPDX) group provides a specification
to make it easier for automated tools to detect and summarize well known
opensource licenses. We are gradually adopting the specification, noting
that the tags are considered only advisory and do not, in any way,
superceed or replace the license texts.

Special thanks to Wind River for providing access to "The Duke of
Highlander" tool: an older (2014) run over FreeBSD tree was useful as a
starting point.
2017-11-20 19:49:47 +00:00
Warner Losh
fbbd9655e5 Renumber copyright clause 4
Renumber cluase 4 to 3, per what everybody else did when BSD granted
them permission to remove clause 3. My insistance on keeping the same
numbering for legal reasons is too pedantic, so give up on that point.

Submitted by:	Jan Schaumann <jschauma@stevens.edu>
Pull Request:	https://github.com/freebsd/freebsd/pull/96
2017-02-28 23:42:47 +00:00
Eitan Adler
50e04779c4 Check the return error of set[e][ug]id. While this can never fail in the
current version of FreeBSD, this isn't guarenteed by the API.
Custom security modules, or future implementations of the setuid and
setgid may fail.

Submitted by:	Erik Cederstrand
Approved by:	cperciva
MFC after:	3 days
2012-10-22 03:07:05 +00:00
Gleb Smirnoff
586fbee643 Add multibyte char support.
PR:		165429
Submitted by:	amdmi3
2012-03-21 08:03:07 +00:00
Ed Schouten
d7698e0766 Add missing static keywords to wall(1) 2011-11-06 08:18:55 +00:00
David E. O'Brien
b0023655af If one's message is longer than the buffer size, then we reset 'cnt' at the
wrong point and the actual column # get out of sync across the buffer size.
2011-07-12 00:31:11 +00:00
Joel Dahl
da52b4caaf Remove the advertising clause from UCB copyrighted files in usr.bin. This
is in accordance with the information provided at
ftp://ftp.cs.berkeley.edu/pub/4bsd/README.Impt.License.Change

Also add $FreeBSD$ to a few files to keep svn happy.

Discussed with:	imp, rwatson
2010-12-11 08:32:16 +00:00
Ed Schouten
ab90a4d1e2 Perform all trivial ports to utmpx for usr.bin/.
They were already converted to use libulog, so it's easy to convert them
to utmpx.
2010-01-13 18:09:54 +00:00
Ed Schouten
645e7f1b9d Add missing `void' keyword. 2009-12-29 22:32:43 +00:00
Ed Schouten
bd76376f80 Let wall(1) use utmpx.
Because our implementation guarantees the strings inside struct utmpx to
be null terminated, we don't need to copy everything out, which makes
the code nicer to read.

Also set WARNS to 6 and add $FreeBSD$ to keep SVN silent.
2009-12-05 20:05:25 +00:00
David Schultz
3c58f6ddbd Fix some bugs in wall(1):
- Handle wrapping correctly when \r appears in the input, and don't
  remove the \r from the output.
- For lines longer than 79 characters, don't drop every 80th character.
- Style: Braces around compound while statement.

PR:		114498
Submitted by:	Niclas Zeising <niclas.zeising@gmail.com> (earlier version)
2008-01-15 07:40:30 +00:00
Olivier Houchard
b457a3e19c In wall and who, check that the utmp entry isn't stalled, as it is done in w.
Apparently with the new pts code stalled entries are printed, when they are
not with the BSD ptys.

Submitted by:	Michal Mertl <mime at traveller dot cz>
2006-02-21 13:01:00 +00:00
Tim J. Robbins
ca78e3fb20 Remove "sleeper" nonsense. 2003-02-21 08:46:44 +00:00
Mark Murray
075f293932 WARNS=2 fix, use __FBSDID().
Not added to Makefile as WARNS=2 will be made default.
2001-12-11 22:22:15 +00:00
Dima Dorfman
728d043e5b - Move the prototype of ttymsg() into ttymsg.h. syslogd and talkd
also use this, and they shouldn't have to have their own prototypes.

- Silence warnings about constness and signedness in ttymsg().  This
  includes changing the return value to a `const char *', and changing
  the types of `left' and `wret' (both byte counts) to ssize_t.

Reviewed by:	bde
2001-09-09 14:23:31 +00:00
Ruslan Ermilov
2cfec5ade4 Make ``wall -g'' really DTRT.
Reviewed by:	imp, markm
2001-09-05 15:31:07 +00:00
Kris Kennaway
a47f98edb4 When opening the file to broadcast, do it with the user's gid, not the
egid (tty).

Obtained from:	OpenBSD
Submitted by:	Maxime Henrion <mux@qualys.com>
Reviewed by:	imp
2001-05-08 11:11:42 +00:00
Warner Losh
003ff9433b Add -g group to usage message.
Don't treat pointer as a boolean, but instead test it against NULL.
Add warning for groups that don't exist

Submitted by: ru
2001-03-02 07:30:37 +00:00
Warner Losh
6a20d55a59 o Add support for wall -g. This will send a message to all members of
a given group.
o Minor code style cleanups while I'm here

Reviewed by: bde, kris, markm, audit@
2001-03-01 05:43:12 +00:00
Kris Kennaway
56e7ae90cb Cleanup this code a bit by attempting to sync it up with NetBSD and
with each other.

Reviewed by:	markm, dwmalone
2000-11-26 22:36:35 +00:00
Nick Hibma
80af0816cd Instead of printing '(null)' if there is no tty, print 'no tty'.
In the case where the program is executed by a daemon running in the
background the terminal might not have a tty. The '(null)' is confusing.
2000-10-02 17:31:57 +00:00
Jeroen Ruigrok van der Werven
6e5d42b9b0 Let wall report the local timezone as well on output.
PR:		17867
Submitted by:	Joel Ray Holveck <joelh@gnu.org>
Nagged by:	nrahlstr
2000-07-27 07:58:47 +00:00
Daniel Baker
c87eca8b08 column counter (cnt) not reset to 0 on display of '\r' which could cause
unnecessary forced linewraps on some terminals.

Submitted by:	David McNett <nugget@slacker.com>
1999-09-01 23:07:29 +00:00
Daniel Baker
b4d6ab014c Corrected apparent omission in program logic which was causing the
insertion of redundant crlf's.  Eliminated the venetian-blind effect
in walled text.

Submitted by:	David McNett <nugget@slacker.com>
1999-09-01 22:21:24 +00:00
Peter Wemm
c3aac50f28 $Id$ -> $FreeBSD$ 1999-08-28 01:08:13 +00:00
Matthew Dillon
98df703fe0 PR: bin/8680
Increase the size of a number of buffers and replace strcpy/strcat/sprintf
    with snprintf().  There was a minor and possibly not exploitable security
    hole related to one sprintf().
1998-12-13 03:42:51 +00:00
Andrey A. Chernov
580117026e Change manual declarations of some functions to proper includes
Rewrote allowed character test to be more efficient
Fix screen position calculations: control and 8bit characters was
not counted properly
1997-09-15 01:03:16 +00:00
Philippe Charnier
752d887a62 Use err(3). Add usage(). 1997-08-25 06:43:22 +00:00
Andrey A. Chernov
01f6848c9c Add locale-independent control checks for security reason 1997-05-14 09:37:54 +00:00
Andrey A. Chernov
9566348d5c Localize it 1997-05-13 11:30:01 +00:00
Andrey A. Chernov
fc092135ab Fix 8bit chars handling 1997-04-08 13:52:53 +00:00
Warner Losh
1c8af87873 compare return value from getopt against -1 rather than EOF, per the final
posix standard on the topic.
1997-03-29 04:34:07 +00:00
Alexander Langer
f20e416903 Fix some improperly wrapped lines in the code. 1996-08-11 02:20:05 +00:00
Guido van Rooij
acc879c13f The talkd security hole can ealso be exploited by wall (and thus rwall).
write and talk are not affected.
Now print out escape sequences in the same way as is done by write(1).
1994-10-23 15:33:55 +00:00
Rodney W. Grimes
9b50d90275 BSD 4.4 Lite Usr.bin Sources 1994-05-27 12:33:43 +00:00