d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
247,743 Commits 4 Branches 49 Tags
Commit Graph

203 Commits

Author SHA1 Message Date
pfg
4736ccfd9c sys: further adoption of SPDX licensing ID tags. 
Mainly focus on files that use BSD 3-Clause license.

The Software Package Data Exchange (SPDX) group provides a specification
to make it easier for automated tools to detect and summarize well known
opensource licenses. We are gradually adopting the specification, noting
that the tags are considered only advisory and do not, in any way,
superceed or replace the license texts.

Special thanks to Wind River for providing access to "The Duke of
Highlander" tool: an older (2014) run over FreeBSD tree was useful as a
starting point.
 2017-11-20 19:43:44 +00:00
tuexen
41648a46b7 Fix an accounting bug where data was counted twice if on the read 
queue and on the ordered or unordered queue.
While there, improve the checking in INVARIANTs when computing the
a_rwnd.

MFC after:	3 days
 2017-11-05 11:59:33 +00:00
tuexen
2e0c4e791c Fix a signed/unsigned warning. 
MFC after:	1 week
 2017-10-18 21:08:35 +00:00
tuexen
dab7a8b847 Abort an SCTP association, when a DATA chunk is followed by an unknown 
chunk with a length smaller than the minimum length.

Thanks to Felix Weinrank for making me aware of the problem.
MFC after:	3 days
 2017-10-18 20:17:44 +00:00
tuexen
bbb2153a14 Code cleanup, not functional change. 
This avoids taking a pointer of a packed structure which allows simpler
compilation of the userland stack.

MFC after:	1 week
 2017-10-14 10:02:59 +00:00
tuexen
7ff23453d1 Free the control structure after using is, not before. 
Found by Coverity while scanning the usrsctp library.
MFC after:	1 week
 2017-09-21 09:47:56 +00:00
tuexen
862561790e No need to wakeup, since sctp_add_to_readq() does it. 
MFC after:	1 week
 2017-09-21 09:18:05 +00:00
tuexen
7e36a33d6e Remove a no longer used variable. 
Reported by:	Felix Weinrank
MFC after:	1 week
 2017-09-19 15:00:19 +00:00
tuexen
45d9e3e378 Fix an accounting bug and use sctp_timer_start to start a timer. 
MFC after:	1 week
 2017-09-17 09:27:27 +00:00
tuexen
91bb3c532b Remove duplicate statement. 2017-07-25 11:05:53 +00:00
tuexen
e79328a85f Fix the explicit EOR mode. If the final messages is not complete, send 
an ABORT.
Joint work with rrs@
MFC after:	1 week
 2017-07-20 11:09:33 +00:00
tuexen
75df636424 Avoid shadowed variables. 
MFC after:	1 week
 2017-07-19 15:12:23 +00:00
tuexen
afa6a856b4 Fix the accounting and add code to detect errors in accounting. 
Joint work with rrs@
MFC after:	1 week
 2017-07-19 12:27:40 +00:00
tuexen
6266aedc70 Whitespace changes. 
The toolchain for processing the sources has been updated. No functional
change.

MFC after:	3 days
 2016-12-26 11:06:41 +00:00
tuexen
37db8550fe Fix the handling of buffered messages in stream reset deferred handling. 
Thanks to Eugen-Andrei Gavriloaie for reporting the issue and providing
substantial help in nailing down the issue.

MFC after:	1 week
 2016-12-17 22:31:30 +00:00
tuexen
5b3872f772 Ensure that the reported ppid and tsn are taken from the first fragment. 
This fixes a bug where the wrong ppid was reported, if
* I-DATA was used on the first fragement was not received first
* DATA was used and different ppids where used.

Thanks to Julian Cordes for making me aware of the issue.

MFC after:	1 week
 2016-12-11 13:26:35 +00:00
tuexen
07971cc856 Don't bundle a SACK chunk with a SHUTDOWN chunk if it is not required. 
MFC after:	1 week
 2016-12-09 17:58:07 +00:00
tuexen
ec64726461 Cleanup the names of SSN, SID, TSN, FSN, PPID and MID. 
This made a couple of bugs visible in handling SSN wrap-arounds
when using DATA chunks. Now bulk transfer seems to work fine...
This fixes the issue reported in
https://github.com/sctplab/usrsctp/issues/111

MFC after:	1 week
 2016-12-07 19:30:59 +00:00
tuexen
ae1856036a Whitespace changes. 
The tools using to generate the sources has been updated and produces
different whitespaces. Commit this seperately to avoid intermixing
these with real code changes.

MFC after:	3 days
 2016-12-06 10:21:25 +00:00
tuexen
ca10f858be Fix the handling of unordered fragmented user messages using DATA chunks. 
There were two bugs:
* There was an accounting bug resulting in reporting a too small a_rwnd.
* There are a bug when abandoning messages in the reassembly queue.

MFC after:	4 weeks
 2016-09-21 08:28:18 +00:00
tuexen
899f803567 Improve a consistency check to not detect valid cases for 
unordered user messages using DATA chunks as invalid ones.
While there, ensure that error causes are provided when
sending ABORT chunks in case of reassembly problems detected.
Thanks to Taylor Brandstetter for making me aware of this problem.
MFC after:	3 days
 2016-08-10 17:19:33 +00:00
tuexen
1f7e02ab3c Fix various bugs in relation to the I-DATA chunk support 
This is joint work with rrs.

MFC after:	3 days
 2016-08-06 12:33:15 +00:00
tuexen
eeeff2b433 Use correct order of conditions to avoid NULL deref. 
MFC after:	3 days
X-MFC with:	r302935
 2016-07-19 11:16:44 +00:00
tuexen
0ad05f701a Fix the PR-SCTP behaviour. 
This is done by rrs@.

MFC after:	3 days
 2016-07-17 13:14:51 +00:00
tuexen
56cb57f2f0 Add missing sctps_reasmusrmsgs counter. 
Joint work with rrs@.
MFC after:	3 days
 2016-07-17 08:31:21 +00:00
tuexen
fd44b2ea42 Deal with a portential memory allocation failure, which was reported 
by the clang static code analyzer.
Joint work with rrs@.

MFC after:	3 days
 2016-07-16 12:25:37 +00:00
tuexen
4575027dc3 Don't free a data chunk twice. 
Found by the clang static code analyzer running for the userland stack.

MFC after:	3 days
 2016-07-16 08:11:43 +00:00
tuexen
f9a4fa815c Fix a locking bug which only shows up on Mac OS X. 
MFC after: 1 week
 2016-05-14 13:44:49 +00:00
tuexen
6d95624949 Retire net.inet.sctp.strict_sacks and net.inet.sctp.strict_data_order 
sysctl's, since they where only there to interop with non-conformant
implementations. This should not be a problem anymore.
 2016-05-12 16:34:59 +00:00
tuexen
766ed501bc Use a format string in snprintf() for consistency. 
This was reported by Radek Malcic when using the userland stack in
combination with MinGW.

MFC after: 1 week
 2016-05-12 14:41:53 +00:00
tuexen
dae8bb36cc Undo a spell fix introduced in r298942, which breaks compilation. 2016-05-02 21:23:05 +00:00
pfg
779a64139d netinet/sctp*: minor spelling fixes in comments. 
No functional change.

Reviewed by:	tuexen
 2016-05-02 20:56:11 +00:00
tuexen
be1074b698 Don't use the control argument after calling sctp_add_to_readq(). 
This breaks the userland stack. There should be no functional change
for the FreeBSD kernel stack.
While there, use consistent variable nameing.
 2016-04-27 18:58:47 +00:00
tuexen
f78898772a Address issues found by the XCode code analyzer. 2016-04-18 20:16:41 +00:00
tuexen
20ff6f8501 Fix signed/unsigned warnings. 2016-04-18 11:39:41 +00:00
tuexen
81d44bca71 Fix a warning about an unused variable. 2016-04-18 09:39:46 +00:00
tuexen
d1da7b18c1 Put panic() calls under INVARIANTS. 2016-04-18 09:29:14 +00:00
tuexen
00659be9d2 Cleanup debug output. 2016-04-18 06:58:07 +00:00
tuexen
f48ddca9de Don't use anonymous unions. 2016-04-18 06:38:53 +00:00
rrs
28010098ff This is work done by Michael Tuexen and myself at the IETF. This 
adds the new I-Data (Interleaved Data) message. This allows a user
to be able to have complete freedom from Head Of Line blocking that
was previously there due to the in-ability to send multiple large
messages without the TSN's being in sequence. The code as been
tested with Michaels various packet drill scripts as well as
inter-networking between the IETF's location in Argentina and Germany.
 2016-04-07 09:10:34 +00:00
tuexen
1af093855e Improve compilation on windows 64-bit (for the userland stack). 
MFC after:	1 week
 2016-03-27 10:04:25 +00:00
tuexen
785250e758 Add const to several constants. Thanks to Nicholas Nethercote for 
providing the patch via
https://bugzilla.mozilla.org/show_bug.cgi?id=1255655

MFC after:	1 week
 2016-03-23 13:28:04 +00:00
tuexen
c3101aede2 Stop processing of a SACK when the association has been aborted. 
MFC after: 3 days
 2015-12-21 18:52:02 +00:00
tuexen
e5fb4876d3 Ensure that outgoing streams get reset when they run dry. 
MFC after:	1 week
 2015-12-03 15:19:29 +00:00
tuexen
61b7939ede Use the correct length. The wrong one was too large. 
MFC after: 3 days
 2015-11-06 22:08:05 +00:00
tuexen
8e41cfecc9 Fix typos in field names of struct sctp_extrcvinfo. 
Provide defines to allow applications to compile.
Thanks to Jens Hoelscher for making me aware of the typos.

MFC after: 1 week
 2015-11-06 13:08:16 +00:00
tuexen
5429764526 Cleanup the handling of error causes for ERROR chunks. This fixes 
an inconsistency of the padding handling. The final padding is
now considered to be a chunk padding.

MFC after:	1 week
 2015-09-12 17:08:51 +00:00
tuexen
1947f60716 Ensure that ERROR chunks are always padded by implementing this 
in the routine, which queues an ERROR chunk, instead on relyinh
on the callers to do so. Since one caller missed this, this actially
fixes a bug.

MFC after:	1 week
 2015-09-11 13:54:33 +00:00
tuexen
7f035ef5b6 Don't take the port numbers for packets containing ABORT chunks from 
a freed mbuf. Just use them from the stcb.

MFC after: 3 days
 2015-08-02 16:07:30 +00:00
tuexen
a7c1a8d16f Fix a typo reported by Erik Cederstrand. 
MFC after: 	1 week
 2015-07-28 08:50:13 +00:00