d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
221,550 Commits 4 Branches 49 Tags 2 GiB
156fd4834a
Commit Graph

390 Commits

Author SHA1 Message Date
brd
0dba15bee9 Really fix the pw_usernext tests. 
PR:		197612
Approved by:	will
 2015-02-15 21:42:10 +00:00
brd
a446d16b44 Remove an extra curly bracket that was causing intermittent failures. 
PR:		197612
Submitted by:	Robert O'Niel <oneil.rs@gmail.com>
Approved by:	will
 2015-02-14 18:22:31 +00:00
brd
4b28934517 Add tests for `pw usernext'. 
PR:		197120
Submitted by:	Robert O'Neil <oneil.rs@gmail.com>
Approved by:	will
 2015-02-09 21:15:52 +00:00
bapt
798d728a63 Revert r277652 
uid and gid are never and should never be negative. The pw(8) manpage clearly
states the -u and -g arguments are for uids/gids, hence using negative values is
abusing a bug in former versions of pw(8)
 2015-01-26 16:50:42 +00:00
bapt
d39bfa5fd5 Allow negative numbers in -u and -g options 
PR:		196514
MFC after:	1 week
 2015-01-24 19:13:03 +00:00
brd
a9f7c229c6 Add tests for pw -N 
PR:		150449
Submitted by:	Robert O'Neil <oneil.rs@gmail.com>
Approved by:	will
 2014-12-16 14:50:33 +00:00
brd
2220b51696 Restructure to make it easier to extend in the future 
Reviewed by:	will
Suggested by:	ngie
 2014-12-09 23:26:47 +00:00
brd
0534d4b8fc Add some tests for user modification. [1] 
Fix a missing test in the Makefile from my previous commit.

PR:		195834 [1]
Submitted by:	Robert O'Neil <oneil.rs@gmail.com>
Approved by:	will
 2014-12-09 22:11:56 +00:00
brd
37438c711e Break out the tests into a file per command and clean up some long lines 
Approved by:	will
 2014-12-09 21:43:03 +00:00
brd
eced0880b9 Add more tests for pw(8) useradd. 
PR:		195832
Submitted by:	Robert O'Neil <oneil.rs@gmail.com>
Approved by:	will
 2014-12-09 20:36:07 +00:00
brd
57a84aae16 Convert to LIBADD. 
Reviewed by:	bapt
 2014-11-24 21:49:01 +00:00
brd
d92ed3c4d8 Replace the pw(1) calls with a variable, to make it easier to to change across all the tests as needed. 
Reviewed by:	will
 2014-11-19 23:07:46 +00:00
sjg
b137080f19 Merge from head@274682 2014-11-19 01:07:58 +00:00
brd
3a05a8b85c Clean up some language 
Reviewed by:	will
 2014-11-17 15:44:00 +00:00
brd
f50123356c Add a test for locking and unlocking user accounts 
Submitted by:	Robert O'Neil <oneil.rs@gmail.com>
Reviewed by:	will
 2014-11-15 05:12:30 +00:00
bapt
76d74e0d6c Fix wrong message when using pw -V with a non existent directory 
Add a regression test about it

PR:		194971
Submitted by:	Freddy DISSAUX <bugzilla@dsx.bsdsx.fr>
 2014-11-12 22:27:53 +00:00
ngie
d1d15c667e Require root when running the pw_delete and pw_modify test programs (pw(8) 
requires it)
 2014-11-03 09:26:39 +00:00
ngie
75dd7696e6 Integrate usr.sbin/useradd/t_useradd.sh from NetBSD into FreeBSD as pw_test 
- Suffix useradd/userdel commands with pw
- Remove the atf_expect_fail for bin/39546

Phabric: D921
Reviewed by: brd
Sponsored by: EMC / Isilon Storage Division
 2014-11-03 06:07:55 +00:00
bapt
ed7e3cf94c Fix renaming a group via the gr_copy function 
Add a regression test to pw(8) because the bug was discovered via using:
pw groupmod

PR:		187189
Reported by:	mcdouga9@egr.msu.edu
Tested by:	mcdouga9@egr.msu.edu
Patch by:	Marc de la Gueronniere
 2014-10-28 16:27:29 +00:00
bapt
6021153528 Ensure pw userdel -u <invalid> do not try to remove root 
Check the uid passed is actually a number as early as possible

MFC after:	1 week
 2014-10-28 15:46:22 +00:00
bapt
74a34200a6 Fix atf syntax 2014-10-28 15:33:15 +00:00
bapt
a06e911fb2 Do not delete the group wheel when bad argument is passed to pw groupdel -g 
Check that the -g argument is actually a number, if not report an error.
This argument is converted without checking with atoi(3) later so without this
check it converts any alpha entries into 0 meaning it deletes the group wheel

Add a regression test about it

PR:		90114
Reported by:	bkoenig@cs.tu-berlin.de
MFC after:	1 week
 2014-10-28 14:54:04 +00:00
bapt
3256c62527 Fix a regression in pw usermod -G list 
The user was perperly adding the to different groups from "list" but was not
removed from the other groups it could have belong to.
While here add a regression test about this bug

PR:		185666
Reported by:	sub.mesa@gmail.com
MFC after:	1 week
 2014-10-28 14:19:17 +00:00
bapt
2e5eee16fd When a group is renamed then the group has been invalidated for sure. 
In that case get the group information using the new name.

Add a regression test about this bug

PR:		193704
Reported by:	az
 2014-10-28 11:20:30 +00:00
des
2d1d129f30 Two more places where login_setcryptfmt() defaults to MD5 were missed 
in r252688.

MFC after:	3 days
 2014-10-09 17:39:11 +00:00
brd
3eac2e9a5c - Add some tests for modifying groups 
Reviewed by:	will
 2014-10-06 00:16:23 +00:00
brd
1319daf668 - Add a test for bug 191427 where pw(8) will go into an infinite loop 
Reviewed by:	will
MFC after:	1 month
 2014-10-02 19:53:37 +00:00
sjg
d7cd1d425c Merge head from 7/28 2014-08-19 06:50:54 +00:00
mjg
534f953696 pw: fix up deletion of users from groups 
Previuosly given 'foo,bar' members, removing 'foo' would result in an
infinite loop.

PR:		191427
Submitted by:	Voradesh Yenbut <yenbut cs.washington.edu>
MFC after:	1 week
 2014-06-27 18:51:19 +00:00
bapt
9afcc43d24 Fix changing the username 
PR:		189172
Submitted by:	fullermd@over-yonder.net
MFC after:	1 week
 2014-06-20 10:38:08 +00:00
bapt
85394787a6 Removed compatibility with pre FreeBSD 2.2 pw_mkdb command 
Fix some broken indentattion

PR:		189173
Submitted by:	fullermd@over-yonder.net
MFC after:	1 week
 2014-06-20 10:34:32 +00:00
sjg
5860f0d106 Updated dependencies 2014-05-16 14:09:51 +00:00
sjg
1a7e48acf1 Updated dependencies 2014-05-10 05:16:28 +00:00
sjg
5e568154a0 Merge head 2014-04-28 07:50:45 +00:00
bapt
418b7ad781 Simplify reading pw.conf(5) by using getline(3) 2014-04-22 21:07:56 +00:00
dteske
7863d1acd7 Fix pw(8) deletion of group "username" on userdel even if group "username" 
is not associated with user "username". E.g., user "foo" has primary group
"wheel" and is unassociated with group "foo", yet userdel would delete the
group "foo" when deleting user "foo" (despite the fact that user "foo" is
not associated with group "foo" in any way).

Patch committed with minor style(9) changes.

PR:		bin/169471
Submitted by:	Alexander Pyhalov <apyhalov@gmail.com>
 2014-03-13 18:16:42 +00:00
julian
6272e5df18 Part 2 of bug 187310.. had to commit separately due to local confusion. 
Don't let pw crash when give certain input.

PR:		187310
Submitted by:	Kim Shrier
MFC after:	1 week
 2014-03-06 19:58:03 +00:00
julian
d8e87db471 Stop pw(8) from segfaulting when given certain input 
PR:187310
Submitted by:	Kim Shrier
Obtained from:	bug
MFC after:	1 week
 2014-03-06 19:26:08 +00:00
sjg
62bb106222 Merge from head 2013-09-05 20:18:59 +00:00
des
54d398971f Fall back to sha512 if passwd_format is not set. 
MFC after:	3 days
 2013-07-04 07:59:11 +00:00
des
6732f8a6e3 There is no reason to disallow setting the password or account expiry 
date to the current date.

MFC after:	3 days
 2013-07-03 09:48:24 +00:00
kientzle
c49ebfc982 Fix -Wunsequenced warning 
Submitted by:	  dt71@gmx.com
 2013-06-29 15:54:17 +00:00
joel
d1ce45a46f mdoc sweep 2013-05-13 18:13:50 +00:00
sjg
6d37b86f2b Updated dependencies 2013-03-11 17:21:52 +00:00
sjg
0ee5295509 Updated dependencies 2013-02-16 01:23:54 +00:00
obrien
3028e3f8ab Sync with HEAD. 2013-02-08 16:10:16 +00:00
deischen
bb6c47e42f Prevent a null pointer dereference in pw userdel when deleting 
a user whose group != username.
 2013-02-01 05:19:49 +00:00
eadler
aa508f10e8 Remove unused variables 
Approved by:	cperciva
MFC After:	3 days
 2013-01-16 05:03:49 +00:00
mjg
580a3aadfb pw: free group returned by gr_add 2013-01-06 21:56:58 +00:00
bapt
cdddb6f42a Simplify vnextgrent and vnextpwent reusing pw_scan and gr_scan from libutil. 2012-12-27 19:43:29 +00:00
bapt
a7f43aa146 Fix a regression in "pw group show" introduced r242349: 
print a newline after printing each group line.

PR:		bin/174731
Submitted by:	Jan Beich <jbeich@tormail.org>
 2012-12-27 14:44:13 +00:00
bapt
e5fca3f7cb Simplify the code by using the new gr_add function 2012-12-27 14:35:06 +00:00
bapt
219a9acfae Simplify copying of group members by using memcpy 
Submitted by:	Christoph Mallon <christoph.mallon@gmx.de>
 2012-12-26 23:16:24 +00:00
bapt
bc1ecc20ad Fix off-by-one error in memory allocation: j entries, one new and a null 
terminator is j + 2.

Submitted by:	Christoph Mallon <christoph.mallon@gmx.de>
 2012-12-26 23:14:33 +00:00
bapt
13dabd466a In case of the deletion of a user those whole database has to be regenerated, 
otherwise the user planned to be deleted remain in the pwd.db while removed from
the plain text password file.
 2012-12-26 18:28:17 +00:00
bapt
d1e0080a5e Fix creating a user and adding it to a group 
Reported by:	"Sam Fourman Jr." <sfourman@gmail.com>, dim
 2012-12-26 18:14:45 +00:00
eadler
3b3a43cfae Simplify string duplication: use strdup instead of malloc + strcpy 
Submitted by:	db
Approved by:	cperciva
MFC after:	2 weeks
 2012-12-05 13:56:56 +00:00
eadler
dff4ef46f6 Avoid overflowing the file buffer 
Submitted by:	db
Approved by:	cperciva
MFC after:	2 weeks
 2012-12-05 13:56:52 +00:00
eadler
91505a4776 Use strdup instead of malloc + strcpy 
Submitted by:	db
Approved by:	cperciva
MFC after:	2 weeks
 2012-12-05 13:56:49 +00:00
eadler
b0ad1517b2 Avoid overflow of file buffer 
Submitted by:	db
Approved by:	cperciva
MFC after:	2 weeks
 2012-12-05 13:56:46 +00:00
eadler
dd0944c119 Remove useless check for NULL prior to free. 
Approved by:	cperciva
MFC after:	2 weeks
 2012-12-05 13:56:43 +00:00
bapt
1bf34f2c1b In NIS mode first chmod(2) the temporary file and is succeed then rename(2) 2012-11-20 14:05:46 +00:00
bapt
7df2814837 Correctly set the password file mode after renaming in NIS mode 2012-11-20 10:59:41 +00:00
sjg
778e93c51a Sync from head 2012-11-04 02:52:03 +00:00
bapt
cfea627c58 Teach pw(8) about how to use pw/gr API to reduce code duplication 
MFC after:	2 months
 2012-10-30 08:00:53 +00:00
bapt
d80e087677 Do not treat empty name as an uid 0 
Reported by:	Robert Bonomi <bonomi@mail.r-bonomi.com>
 2012-10-01 17:00:33 +00:00
bapt
750731b250 Remove useless atoi(3), previous strspn(3) makes sure that a_name->val is a 
number.
This also allow pw user show to work as expected.

PR:		bin/172112
Submitted by:	"Ilya A. Arkhipov" <rum1cro@yandex.ru>
MFC after:	1 month
 2012-10-01 16:42:07 +00:00
kevlo
a93e845e54 Make sure that each va_start has one and only one matching va_end, 
especially in error cases.
 2012-09-28 07:51:30 +00:00
marcel
9dd41e3647 Sync FreeBSD's bmake branch with Juniper's internal bmake branch. 
Requested by: Simon Gerraty <sjg@juniper.net>
 2012-08-22 19:25:57 +00:00
kevlo
1381e63d6c Handle NULL return from crypt(3). Mostly from DragonFly 2012-02-22 06:27:20 +00:00
kevlo
a6e5cd41ae readlink len-1 2012-02-14 10:17:03 +00:00
uqs
415a3a9b96 Spelling fixes for usr.sbin/ 2011-12-30 10:58:14 +00:00
eadler
50c4635b88 - document the -l option to usermod 
PR:		docs/161588
Submitted by:	"Luchesar V. ILIEV" <luchesar.iliev@gmail.com>
Approved by:	gjb
MFC after:	1 week
 2011-12-22 03:36:54 +00:00
dim
8521853f9c In usr.sbin/pw/pw_user.c, use the correct printf length modifier for a 
ptrdiff_t.

MFC after:	1 week
 2011-12-17 23:46:47 +00:00
delphij
48395f1e91 Backout r223115 which potentially caused a POLA violation, by restoring 
historic behavior (create the default base directory in pw.conf) before
I came up with a better fix for this.

Requested by:	nwhitehorn
Approved by:	re (kib)
 2011-07-31 03:00:00 +00:00
delphij
5bae35960f Don't attempt to create the base directory when -d is specified. 
MFC after:	1 month
 2011-06-15 19:09:58 +00:00
jkim
2a03b255b4 Stop hard-coding default directory mode as 0777. 2011-03-08 20:13:29 +00:00
jkim
bb6fc35ada Do not let pw.conf(5) or -M option affect creation of basehome, e.g., /home. 
When the basehome does not exist, it creates all intermediate directories as
required, which is logically equivalent to mkdir(1) with -m and -p options.
However, it modifies all intermediate directories, not just the final home
directory unlike mkdir.  This problem was introduced in two revisions, i.e.,
r1.59 (SVN r167919) and r1.60 (SVN r168044).

MFC after:	1 month
 2011-02-04 19:49:02 +00:00
uqs
8ae3afcfad mdoc: drop redundant .Pp and .LP calls 
They have no effect when coming in pairs, or before .Bl/.Bd
 2010-10-08 12:40:16 +00:00
jkim
0e16801b84 Revert the unrelated patch crept in the previous commit. 2010-10-05 18:47:51 +00:00
jkim
e9d0730bf8 Prefer pmap_unmapbios() over pmap_unmapdev(). The binary does not change 
after this because pmap_unmapbios() is a macro for pmap_unmapdev() on amd64.
 2010-10-05 18:38:23 +00:00
ed
073cafdd42 The last big commit: let usr.sbin/ use WARNS=6 by default. 2010-01-02 11:07:44 +00:00
ed
1112c6186a Make pw(8) build without <utmp.h>. 
The size of the username record in utmp files should not influence the
maximum username length. Right now ut_user/ut_name is big enough, so in
this case it's dead code anyway.
 2009-12-06 01:27:28 +00:00
ache
396faad5a1 Use arc4random_uniform() to avoid "modulo bias" 
Remove pw_getrand() unneded now: arc4random_uniform() is stronger then
pw_getrand()'s MD5 tricks (inactive) and its active version, mixing
arc4random() bytes in one, not make things better at all.
 2008-08-16 15:41:03 +00:00
jhb
42cd7531f9 Before updating the password database, the pw(8) utility first performs a 
sanity check by invoking "pwd_mkdb -C".  However, if this failed it
silently returned success.  Fix this so it fails the update operation
instead.

MFC after:	1 week
 2008-07-17 13:47:59 +00:00
antoine
13eb949886 - Increase the size of the salt in pw(8) from 8 to 32 (same as in pam_unix(8)). 
This makes blowfish password hashes look normal when set using
pw(8)/adduser(8). [1]
- Make it possible to have a '/' in the salt.

PR:		121146 [1]
Submitted by:	Jaakko Heinonen [1]
Approved by:	rwatson (mentor)
MFC after:	1 month
 2008-05-27 19:04:31 +00:00
scf
c88c109632 Add the groupmod '-d' option to pw to allow the deletion of existing users 
from a group without the need to perform the same operation by replacing
the existing list via the '-M' option.  The '-M' option requires someone
to fetch the existing members with pw, deleting the undesired members from
the list and sending the altered list back to pw.

Approved by:	wes (mentor)
MFC after:	5 days
 2008-02-23 01:25:22 +00:00
scf
9787c9bf4e style(9) (verified no object changes) 
Approved by:	wes (mentor)
MFC after:	5 days
 2008-02-23 01:17:42 +00:00
mtm
e6e79b3074 Clarify in what formats the grouplist for the '-G' switch may be accepted. 
Submitted by: Eygene Ryabinkin <rea-fbsd@codelabs.ru>
 2008-01-25 15:54:14 +00:00
le
23c32e03dd Do the right thing with symlinks in the skeleton directory. 
PR:     bin/63659
 2007-03-30 13:18:52 +00:00
le
6eee3cc935 Accept passwords which contain whitespace. 
PR:     bin/53434
 2007-03-30 12:57:25 +00:00
le
f17fbfd9be Add home directory creation mode to pw.conf(5) and be a bit 
more specific about the effect of the current umask on -M.
 2007-03-30 11:23:10 +00:00
le
2f93827b34 Add -M argument to usage() output. 2007-03-30 10:02:47 +00:00
le
b25ea91d22 Introduce the new option -M to allow to set the permissions of 
the user's newly created home directory.  If omitted, it's derived
from the current umask.

PR:      bin/16880, bin/83253 (partially), bin/104248
MFC in:  1 month
 2007-03-26 23:29:20 +00:00
trhodes
0fdaf2aeff Better mdoc(7). Bump doc date. 
Kicked by:	ru
 2006-10-09 19:01:02 +00:00
trhodes
3d3e3d31c4 Note the naming convention of files in share/skel and explain the "dot" 
prefix is removed.

PR:	103828
 2006-10-09 17:57:40 +00:00
maxim
4af3cb5278 o Fix groupadd getopt line and make 'pw groupadd -o' work. 
PR:		bin/100684
Submitted by:	Devon H. O'Dell
MFC after:	3 weeks
 2006-09-18 14:00:39 +00:00
pjd
16e9258f60 Change /home symbolic link, so it will point to usr/home instead of /usr/home. 
Previous symlink was confusing:

	# cd /jails/virtual_system_1/home
	# realpath .
	/usr/home

...and slower.

OK'ed by:	rwatson, phk
 2005-07-31 08:25:53 +00:00
stefanf
ce3085bbfb Remove unused variables. 2005-04-09 14:59:10 +00:00
stefanf
e1328da3d7 The variable `arglist' has internal linkage in pw.c, don't declare it as extern 
here.
 2005-02-10 09:05:27 +00:00
ru
c05985f13f Sort sections. 2005-01-18 20:02:45 +00:00
ru
6cc4b6c220 Added the EXIT STATUS section where appropriate. 2005-01-17 07:44:44 +00:00
stefanf
d768a89209 Don't rely on NULL being a pointer, add a cast before passing it to a variadic 
function.
 2004-10-03 14:40:27 +00:00
ru
6294018a20 Mechanically kill hard sentence breaks. 2004-07-02 23:13:00 +00:00
robert
0f9ac8040a Use strlcpy(3) to replace the idiomatic 
strncpy(d, s, l);
  d[l - 1] = '\0';

statements.
 2004-06-17 14:07:16 +00:00
robert
2211cbc1f6 Fix a bug which occurred when the home directory given by the 
-d option was equal to the one already saved and which caused
the pw utility to avoid updating values passed by other options
processed before the -d option in the code path.

Spotted by: Richard Caley <rjc@interactive.co.uk>
 2004-06-17 10:29:12 +00:00
kensmith
7d850e0369 Shift file locking to source file instead of temp file. This fixes 
data buffering issue that corrupts files if two pw(8)'s run at the
same time as well as changing pw(8) so it uses the same locking
mechanism as PAM, vipw(8), pwd_mkdb(8), etc.

PR:		bin/23501
Submitted by:	Alex Kapranoff <alex (at) kapran (dot) bitmcnit (dot) bryansk (dot) su>
Approved by:	rwatson (mentor)
MFC after:	5 days
 2004-03-08 20:31:37 +00:00
iedowse
94e2d83c18 Add a -H <fd>' option that is like -h <fd>', but accepts an already 
encrypted password on the specified file descriptor.

PR:		bin/22033
MFC after:	2 weeks
 2004-01-11 18:28:08 +00:00
ru
1c23ef339b mdoc(7): Use the new feature of the .In macro. 2003-09-08 19:57:22 +00:00
charnier
aafcecac3c The .Xr utility. Spelling. Put NIS under .Tn 2003-06-08 14:28:38 +00:00
trhodes
66cc770e2b Add information about the log file. 
PR:		35575
Submitted by:	"Simon L. Nielsen" <simon@nitro.dk> (original version)
 2003-05-08 00:28:36 +00:00
obrien
a920d12f89 style.Makefile(5) 2003-04-04 17:49:21 +00:00
ache
76e83c6399 There is no sense to use random random() and arc4random() in the same program. 
Switch to arc4random() completely.
 2003-02-11 02:17:11 +00:00
gad
b9c46dc8f9 Changes so the 'pw' command will allow '$' as the last character in a userid 
or group name (mainly for the benefit of samba).  This pretty much rewrites
he pw_checkname() routine, but should work exactly the same except for the
above change, and that error messages are somewhat more informative.

PR:		28733 46890
Inspired by:	example patch written by Terry Lambert
Reviewed by:	no objections on freebsd-arch and freebsd-current
MFC plans:	no plans, but will do if people want it in stable.
 2003-01-28 01:21:57 +00:00
fjoe
b24e1d7b2a Do not expose password if it is empty and PWF_STANDARD format is requested 
MFC after:	1 week
 2003-01-23 19:51:48 +00:00
ru
041d1287e8 Uniformly refer to a file system as "file system". 
Approved by:	re
 2002-12-12 17:26:04 +00:00
charnier
d2168fe021 The .Nm utility 2002-07-14 14:47:15 +00:00
alfred
db007fe41c de-__P() 2002-07-11 19:07:35 +00:00
dd
51373f0ac8 Lists follow a colon, not a semicolon. 2002-06-30 04:51:04 +00:00
sada
e5bf02e8eb `pw useradd' could be used with -w without -D option. 
PR:		docs/39770
Submitted by:	sada
Approved by:	dd
 2002-06-26 05:09:12 +00:00
dwmalone
46a7644f58 Print a long with %ld not %d. (We possibly should be using %j here, but 
that can be fixed when the many other warnings here are being fixed.)

PR:		39741
Submitted by:	Dan Lukes <dan@obluda.cz>
MFC after:	1 week
 2002-06-24 11:33:17 +00:00
dd
63c3074b59 In the words of the submitter: 
This patch explains -F for usershow and groupshow.  Because "groupmod
 ... -F" doesn't do anything, the patch also drops that from groupmod's
 command line args.

PR:		35955
Submitted by:	Mike DeGraw-Bertsch <mbertsch@radioactivedata.org>
 2002-04-05 08:39:31 +00:00
dd
c48c9a8ae4 Document the -7 option for usershow. 
PR:		36735
Submitted by:	Mike DeGraw-Bertsch <mbertsch@radioactivedata.org>
 2002-04-05 08:31:17 +00:00
keramida
9148cdcb62 Merge a duplicate description of the -L option into the first one. 
PR:		docs/34782
MFC after:	1 week
 2002-03-08 00:36:36 +00:00
nectar
deebe243c0 Use correct mode for temporary file. 
Reported by:	ryan beasley <ryanb@goddamnbastard.org>
 2001-12-20 16:03:04 +00:00
ache
990d7c4236 Change rmskey() to rmopie() - we don't have skey anymore 2001-10-19 10:45:14 +00:00
dd
3c48707476 For new users, create the home directory before sending the welcome 
mail, if configured to do so.  Some sites have setups where the user's
mail is delivered to their home directory, so sending mail before is
exists didn't work.

PR:		29892
 2001-09-03 14:12:42 +00:00
dd
b9e2a3df4b Unbreak group operations by reverting previous delta which removed the 
assignment of `l' in `gr_update' to the return value of snprintf.  It
claimed to have fixed the case where snprintf returned -1--in fact, it
broke the entire routine.  Not setting `l' here causes fileupdate() to
invariably fail with EINVAL because it does its own check to assert
that the parameter isn't -1.
 2001-08-30 06:32:17 +00:00
joerg
7cdb2456bc Properly initialize the random number generator in pw_getpass(). 
Right now, the automatically generated passwords have been rather
predictable. :-(

MFC after:	1 day
 2001-08-21 13:33:20 +00:00
joerg
637fbcbedb Fix a typo in a variable name that made pw(8) coredump when using 
USE_MD5RAND.

MFC after:	2 days
 2001-08-21 10:29:01 +00:00
brian
9e766e7f13 Handle snprintf() returning < 0 (not just -1) 
MFC after:	2 weeks
 2001-08-20 15:09:34 +00:00
brian
d48c427cd5 Handle snprintf() returning -1. 
MFC after:	2 weeks
 2001-08-20 13:24:39 +00:00
obrien
9c97c8f02d Perform a major cleanup of the usr.sbin Makefiles. 
These are not perfectly in agreement with each other style-wise, but they
are orders of orders of magnitude more consistent style-wise than before.
 2001-07-20 06:20:32 +00:00
obrien
be022bb715 Remove GCC'isms in CFLAGS. 2001-07-20 04:23:13 +00:00
dd
911ca14c87 Remove whitespace at EOL. 2001-07-15 08:06:20 +00:00
dd
eaa6ee03b8 mdoc(7) police: remove extraneous .Pp before and/or after .Sh. 2001-07-09 09:54:33 +00:00
brian
8636b161b3 Fix the type of the NULL arg to execl() 
Idea from: Theo de Raadt <deraadt@openbsd.org>
 2001-07-09 09:24:06 +00:00
ru
88bd9429d1 Don't override the default BINMODE. 
Submitted by:	bde
 2001-07-05 15:25:05 +00:00
kris
5a1251c5ff Fix a harmless format string bogon and mark a function as __printflike(). 
There is still one instance of non-constant format string use inside that
function, but it's hard to fix.

MFC after:	1 week
 2001-07-05 08:01:15 +00:00
dd
e3cab8dc0c Include missing header files which define functions for which gcc has 
builtints (e.g., exit, strcmp).
 2001-06-24 20:25:23 +00:00
dd
a284c32828 CND has been unused for two years, and RND has been unused for five 
years; remove them from CFLAGS.

PR:		23712
Submitted by:	Volker Stolz <stolz@i2.informatik.rwth-aachen.de>
 2001-06-19 00:39:29 +00:00
ru
afd506414e - Backout botched attempt to introduce MANSECT feature. 
- MAN[1-9] -> MAN.
 2001-03-26 14:42:20 +00:00
ache
f55dab1d8b Use %c for expire/change dates 2001-03-21 13:46:09 +00:00
ru
97b1481159 mdoc(7) police: simplify bogus ``.Ql Fl'' constructs. 2001-03-16 14:11:41 +00:00
dd
24b0122a84 Document the lock and unlock commands. This fixes a segmentation fault. 
PR:		25187
Approved by:	nik
 2001-03-14 03:24:30 +00:00
dd
bfdb3b217b Document the lock and unlock commands. 
PR:		25187
Approved by:	nik
 2001-03-14 03:22:28 +00:00
kris
1854a6d141 Switch from using rand() or random() to a stronger, more appropriate PRNG 
(random() or arc4random())

Reviewed by:	bde
 2001-03-05 02:15:38 +00:00
ru
66cd8f698e mdoc(7) police: split punctuation characters + misc fixes. 2001-02-01 16:44:04 +00:00
ru
ffef081534 Prepare for mdoc(7)NG. 2001-01-16 09:39:23 +00:00
peter
ee9f6ce82c Fix typo: s/memberhip/membership/ 
Submitted by:  Peter Avalos <pavalos@theshell.com>
 2001-01-02 04:01:59 +00:00
ben
aa10518020 Convert to use the <sys/queue.h> macros rather than fiddling with the queue 
structure internals.

Reviewed by:	markm
 2000-12-29 18:04:54 +00:00
dougb
1fd2c926a8 Make the comment generated in /etc/pw.conf match reality 
PR:				misc/23451
Submitted by:	Ben Rosengart, ben@narcissus.net
 2000-12-18 01:35:56 +00:00
obrien
c2ee1dcc02 Add `_PATH_DEVZERO'. 
Use _PATH_* where where possible.
 2000-12-09 09:35:55 +00:00
ru
71e2293ad4 mdoc(7) police: use the new features of the Nm macro. 2000-11-20 20:10:44 +00:00
green
67c40ef892 Add working and easy crypt(3)-switching. Yes, we need a whole new API 
for crypt(3) by now.  In any case:

Add crypt_set_format(3) + documentation to -lcrypt.
Add login_setcryptfmt(3) + documentation to -lutil.
Support for switching crypt formats in passwd(8).
Support for switching crypt formats in pw(8).

The simple synopsis is:
edit login.conf; add a passwd_format field set to "des" or "md5"; go nuts :)

Reviewed by:	peter
 2000-08-22 02:15:54 +00:00
davidn
35b42ab19e Move test for -w flag outside of the code dealing with -D (defaults). 
This should cause -w's argument not to be ignored in the usermod case,
so it will affect modification of the user's password instead of using
the pw.conf (or internal default=no '*') password method.
PR:		bin/11168
 2000-07-20 05:11:56 +00:00
davidn
94db016d55 Allow -g with an empty argument in the -D case. This allows -g "" to set 
no default group (and thus fall back to user-based groups instead).
PR:		bin/5717
 2000-07-20 04:37:00 +00:00
davidn
c4d081a807 Fix another missed case where usermod would not set the "modified" flag: 
-h - to set no password. But only mark modified if the account is not
already locked (i.e. first char of crypt password field is '*').
PR:		bin/19999
 2000-07-20 00:09:29 +00:00
davidn
14da5481e1 Catch up to the fact that we now have tcsh in the tree. 2000-07-16 01:46:26 +00:00
davidn
092cc1f8f9 Support propogation of file flags when building a homedir from the 
skeleton directory.
sprintf() -> snprintf() cleanup.
PR:		bin/8756
Submitted by:	"Nickolay N. Dudorov" <nnd@itfs.nsk.su>
 2000-07-13 23:52:49 +00:00
davidn
93ab0f9072 Fix breakage introduced by bypassing update for additional 'mod' 
functionality when nothing had actually changed; -d changes would
not set the 'something had changed flag'. Actually test for a
change in homedir.
PR:		bin/19649
 2000-07-03 12:13:10 +00:00
davidn
c85586d6d2 Don't dereference NULL in the userdel case. 2000-06-26 01:11:44 +00:00
ache
659df59b0e Localize ctype too. 
Add weekday to showuser expired fields
 2000-06-24 13:36:13 +00:00
ache
77729ceb43 Localize time/date. 
Use ISO 8601 date in logs.
Fix wrong argument type in ctype functions.
 2000-06-22 16:48:41 +00:00
davidn
15756f138e Fix obvious braino in assignment statement. usermod -g should work again. 
PR:		17877
Submitted by:	pius@zyan.com
 2000-06-18 02:48:56 +00:00
davidn
4a7877f9e8 Be a little more strict about handling command line args. This allows user and 
group names like 'help' 'mod' 'user' 'group' etc. to work correctly without
requiring the -n style invocation.
PR:		misc/17069
 2000-06-18 02:39:17 +00:00
davidn
1553afea75 Fix a long-standing bug in the rename case previously masked by another bug 
just fixed in .db file updating.
 2000-06-18 02:18:15 +00:00
davidn
faaa880c55 Second and hopefully final fix to .db sync when renaming a user; we must run 
a full reindex in this case to remove the old record. #ifdef -u capability
since this is available on FreeBSD only.
PR: bin/16418
Problem pointed out by:	Masachika ISHIZUKA <ishizuka@ish.org>
 2000-06-18 02:16:07 +00:00
davidn
bb77488761 Fix db syncronization when username is changed with -l under usermod. 
pw(8) was calling pwd_mkdb -u oldusername instead of newusername, so
the update appears to have failed until the next full pwd_mkdb
syncronization.

PR:		bin/16418
 2000-06-06 07:33:00 +00:00
jake
961b97d434 Back out the previous change to the queue(3) interface. 
It was not discussed and should probably not happen.

Requested by:		msmith and others
 2000-05-26 02:09:24 +00:00
jake
d93fbc9916 Change the way that the queue(3) structures are declared; don't assume that 
the type argument to *_HEAD and *_ENTRY is a struct.

Suggested by:	phk
Reviewed by:	phk
Approved by:	mdodd
 2000-05-23 20:41:01 +00:00
sheldonh
244b8ead7d Remove more single-space hard sentence breaks. 2000-03-02 14:54:02 +00:00
sheldonh
b2240fc1c0 Remove single-space hard sentence breaks. These degrade the quality 
of the typeset output, tend to make diffs harder to read and provide
bad examples for new-comers to mdoc.
 2000-03-01 14:09:25 +00:00
davidn
1b86060031 Portability fixes for other bsd4.4 derivatives. 2000-01-15 00:20:22 +00:00
peter
d44e2d4226 Revert the libcrypt/libmd stuff back to how it was. This should not have 
happened as it was working around problems elsewhere (ie: binutils/ld
not doing the right thing according to the ELF design).  libcrypt has
been adjusted to not need the runtime -lmd.  It's still not quite right
(ld is supposed to work damnit) but at least it doesn't impact all the
users of libcrypt in Marcel's cross-build model.
 1999-12-18 13:55:17 +00:00
marcel
e32efbad28 Add libmd (or move it after libcrypt). We don't want the linker to be 
smart because it will definitely get it wrong. This popped up during
cross-linking.
 1999-12-16 10:55:45 +00:00
davidn
9c3494a4dc Don't try updating the passwd file if no data has changed. This allows things 
like "pw usermod <name> -m" to work for non-local NIS users; since no attempt
is made to update the password entry, the home directory will be created and
populated as expected without error.
 1999-10-26 15:07:20 +00:00
davidn
091d630070 Add new functionality "lock" and "unlock" to provide a simple password 
locking mechanism for users. This works by prepending the string
"*LOCKED*" to the password field in master.passwd to prevent successful
decoding.
 1999-10-26 08:34:09 +00:00
davidn
297001db2a Missed statement in password update relating to the previous change 
to fileupdate() which prevented pwd_mkdb(1) from being run.
 1999-10-26 08:30:20 +00:00
davidn
7f7ff280d1 Clean up error handling in fileupdate(), which now returns 0 on success 
instead of a boolean. This replicated through he front-end sub-functions
relating to add, delete, modify entries in passwd & group files
Errno is now preserved so output of errc()/warnc() will be less obfuscated
by subsequent errors when reporting the problem.

Add more intelligent error handling when attempting to modify/delete NIS
entries with no corresponding local database entry.

[MFC to stable in a couple of weeks to keep both in sync]
 1999-10-26 04:27:14 +00:00
sheldonh
1f6d5bd10b Only do a full pwd_mkdb for deletions; other operations may use the -u 
option as an optimization.

PR:	13346
Submitted by:	Neil Blakey-Milner <nbm@rucus.ru.ac.za>
 1999-08-30 10:35:38 +00:00
peter
efabb9ccb1 $Id$ -> $FreeBSD$ 1999-08-28 01:35:59 +00:00
davidn
92f725d0a6 Remove some more warnings. 1999-07-28 12:49:34 +00:00
davidn
d70ee45d7f Fix date parsing to allow '0' (none) date value. 1999-03-15 08:16:01 +00:00
davidn
2b92c5716f Add the ability to print user records in unix version 7 (old) format. 1999-03-02 00:53:33 +00:00
davidn
e0514a77ef Fix minor nit with command line parsing for pw -V DIR action. 1999-02-23 11:01:50 +00:00
davidn
a5b26be1a1 Fix tpyo (sic) and missing 'else' (bad cut n' paste). 1999-02-23 10:35:47 +00:00
davidn
aea1f6bc3c 1) Do not blindly ignore file update errors which may occur due to concurrent 
updating
2) Add -V <etcdir>, which allows maintaining user/group database in alternate
   locations other than /etc.
 1999-02-23 07:15:11 +00:00
des
6d5fc29071 Don't assume a_name is a number just because the first character 
is a digit.

PR:		bin/9484
Submitted by:	Matthew D. Fuller <fullermd@futuresouth.com>
 1999-02-08 21:26:44 +00:00
davidn
43bf26e477 Remove bogus file locking in main(). 1999-01-08 10:52:38 +00:00
billf
b9b93bcb85 -Clarification of last commit- 
The char that the random letters and numbers are being pulled from is
ended with a '\0'. Using sizeof() includes this '\0' in the 'pool' of
possible characters. This patch decrements by one the size so we don't
accidently end the new password prematurly.
 1999-01-04 14:07:53 +00:00
billf
4d4062708c Let's make sure we're at the end of the password string before we apply a \0 
and terminate it. This patch ensures passwords will be the correct length of 8,
which is what is implied in the source (but not reflected in the man page).

PR:		bin/7817
Reviewed by:	Alfred Perlstein <bright@hotjobs.com>
Submitted by:	Hiroshi Nishikawa <nis@pluto.dti.ne.jp>
 1999-01-02 04:37:46 +00:00
joerg
e35d117052 Fix the spelling of `FreeBSD'. 
Submitted by:	Peter Philipp <pjp@bsd-daemon.net>
 1998-12-27 12:01:07 +00:00
obrien
0337d32241 Remove useless `BINOWN=root' now that it is the default. 1998-09-19 22:42:14 +00:00
jkoshy
37eda2089d Fix inappropriate use of .Ql macro. 
PR:		docs/7905
Submitted by:	kuma@jp.freebsd.org
 1998-09-18 04:45:43 +00:00
jkoshy
640c398571 The `group{del,mod,show}' take require a '[group|gid]' argument. 
PR: docs/7788
 1998-08-31 04:49:04 +00:00
nate
cd5930392d - On second thought, attempt to get the read-only lock, but don't 
consider it a exit failure if it doesn't work.  This means that root
  processes can safely get the lock, but normal processes can still use
  the 'pw' utility to get information (which may change out from under
  them.)
 1998-08-04 22:31:26 +00:00
nate
cb1f81bd1c - Removed read-only lock from 'pw'. This removes portions of the FIX 
from PR/6787, but allow non-root users to use pw to get password
  information.  However, this should be safe since the fixes for
  disallowing multiple instances from modifying the DB are still intact.

Bug noted by:	 dima@best.net (Dima Ruban)
 1998-08-04 22:20:11 +00:00
nate
e5267d9c1b Fix race condition in pw caused by multiple instances of pwd_mkdb being 
run at the same time.

Notes:
    The fileupdate function is still somewhat broken.  Instead of
    returning a failure code if it can't modify the original file it
    renames the .new file and continues as though nothing is wrong.
    This will cause the lock on the original file to be lost and could
    lead to a similar race condition.  I left that portion of the code
    alone since I feel that the maintainer of the code would have a
    better concept of how he wants to handle errors in that function
    than I do.

PR:		bin/6787
Submitted by:	Craig Spannring <cts@internetcds.com>
 1998-07-16 17:18:25 +00:00
charnier
b32e728fc6 .Nm pw -> .Nm. 1998-03-23 08:28:12 +00:00