Commit Graph

46 Commits

Author SHA1 Message Date
Colin Percival
c28f49d439 In the error handling path, don't call close(fd) if the error we're
handling is that fd = open(foo) is -1.  This bug is harmless since
close(-1) just returns an error (which the code ignores).

Found by:	Coverity Prevent(tm)
CID:		1503 (in userland test run)
2007-05-22 04:21:00 +00:00
Ruslan Ermilov
a89237ae95 Sync program's usage() with manpage's SYNOPSIS. 2005-02-09 17:37:39 +00:00
Warner Losh
130d846d9b Remove the clause 3, per berkeley and mail from rwatson representing
that nai was OK with all third clause removals.
2005-01-10 08:21:45 +00:00
Mark Murray
0f66784721 Turn malloc+snprintf into asnprintf.
Submitted by:	David Hill <hill at phobia dot em ess>
2003-10-14 20:42:13 +00:00
Mark Murray
40feca3a99 Fix a bazillion warnings. This makes almost the whole of src/bin/*
WARNS=6, std=c99 clean.

Tested on:	i386, alpha
2003-05-03 16:39:34 +00:00
David E. O'Brien
4fe0d77843 Make count a size_t as that is what is compared against and how it is used. 2003-05-02 06:36:52 +00:00
David E. O'Brien
09a80d4867 Quiet warnings about copyright[]. 2003-05-01 16:58:57 +00:00
Mark Murray
d8456c7ada Dekerberise. The corresponding userland stuff has been dekerberised
for ages, and no-one seems to have noticed. Viva PAM!
2002-10-16 16:10:46 +00:00
Tim J. Robbins
76900889fa Clean up use of <stdarg.h> macros: always call va_end after va_start,
reset with a call to va_start before each use of the va_list.

Obtained from:	NetBSD
2002-10-06 11:14:21 +00:00
Philippe Charnier
7e61a4ae7b While removing a memory leak, rev 1.32 introduced a
free-memory-and-reuse-it-after. Correct both problems and
make rcp -r work again under /etc/malloc.conf -> AJ.
2002-10-06 09:09:27 +00:00
Tim J. Robbins
8b9f20c622 Use %jd in format string and cast argument to intmax_t instead of using
%qd to print struct stat.st_size. Remove WARNS=0 and WFORMAT=0 from
Makefile.

Tested on:	alpha, sparc64, i386
2002-10-06 03:50:06 +00:00
Hajimu UMEMOTO
cc0f2cfaca IPv6 support for rcp.
You cannot specify a raw IPv6 address for now.

MFC after:	1 week
2002-08-09 16:12:08 +00:00
Matthew Dillon
5ad9e45f96 err() is documented as allowing NULL for the format string but GCC isn't
happy about it any more so change the usage to make buildworld work again.
2002-07-10 20:44:55 +00:00
David E. O'Brien
2749b14129 Consistently use FBSDID 2002-06-30 05:15:05 +00:00
Juli Mallett
6953dff37c Use size_t consistently and complete some uncompleted code resulting in a
memory leak by assigning and freeing a variable appropriately as well as
keeping track of the amount of allocated ram properly.

MFC after:	1 month
2002-06-20 06:00:51 +00:00
Dag-Erling Smørgrav
99b82bb76a Use <paths.h> rather than "pathnames.h", and fix a couple of whitespace nits.
Sponsored by:	DARPA, NAI Labs
2002-05-08 00:47:01 +00:00
Warner Losh
46251dde8f o __P has been reoved
o Old-style K&R declarations have been converted to new C89 style
o register has been removed
o prototype for main() has been removed (gcc3 makes it an error)
o int main(int argc, char *argv[]) is the preferred main definition.
o Attempt to not break style(9) conformance for declarations more than
  they already are.
2002-02-02 06:48:10 +00:00
Jim Pirzyk
af8dcd940f Fixed two bugs, first not allowing '.' as a valid login name character
in okname() in util.c and second, returning != 0 when you do have an
error from okname in two places in rcp.c.

Thanks to Garrett for the POSIX defintion of valid login and group names.

PR:		bin/25757
MFC after:	3 weeks
2001-05-30 16:19:13 +00:00
Warner Losh
fe8dce6c66 Use PATH_MAX instead of MAXPATHLEN.
Also use sizeof(path) in preference to PATH_MAX.
2001-05-30 03:33:32 +00:00
Kris Kennaway
a2e73040f4 -Wnon-const-format sweep: make format strings const char *'s, add
__printflike()/__printf0like() to function prototypes, as appropriate.

Reviewed by:	bde, -audit
2001-04-17 07:46:38 +00:00
Mark Murray
96ccf174ec Use libcrypto inst=ead if libdes. 2000-02-24 21:21:15 +00:00
Mark Murray
69746547bd Fix for new Kerberos4. 1999-09-19 22:11:15 +00:00
Peter Wemm
2a4562393f $Id$ -> $FreeBSD$ 1999-08-27 23:15:48 +00:00
Bruce Evans
8c024a04db Improved error handling in rev.1.18: don't ignore failure of execve().
Fixed some style bugs in rev.1.18.
1999-07-04 15:42:04 +00:00
Dmitrij Tejblum
f15076c04a Quick fix to allow transfer files >2GB. 1999-04-25 10:36:00 +00:00
Mark Murray
bacda65d14 Add JKH's auth.conf-file parser to turn Kerberos on/off in userland. 1998-10-09 06:31:45 +00:00
Bruce Evans
06db156986 Fixed printf format errors (time_t is not necessarily long). 1998-08-02 14:25:24 +00:00
Philippe Charnier
1aad99bc66 Correct use of .Nm. Add rcsid. 1998-05-18 06:40:56 +00:00
Mark Murray
4eff93dd4e KTH announced a weakness in their implementation of KerberosIV.
FreeBSD was not vulnerable, but their fix had some useful features.
Incorporate the best of those - rcp(1) no longer needs to be SUID
to root.
1998-03-26 18:15:00 +00:00
Wolfram Schneider
ac105a5777 Add -P option to cp(1) for local to local copying.
Pointed out by: bde
1997-12-08 21:02:36 +00:00
Wolfram Schneider
f1f5ba1e4c Use cp -R' instead cp -r' for local to local coping
(e.g.: rcp -r /tmp/1 /tmp/2). See the cp(1) manpage for more details.
1997-12-07 20:49:39 +00:00
Mark Murray
8a7ad3adf7 Change to use the new KTH Kerberos.
Also make -Wall a bit quieter.
1997-09-28 08:32:59 +00:00
Philippe Charnier
43d30a79be Correct usage string. Man page don't reflect reality for now. 1997-06-06 06:43:19 +00:00
Joerg Wunsch
7e97db380c Ensure string termination after strncpy().
PR:		2997
Submitted by:	Philippe Charnier <charnier@xp11.frmug.org>
1997-05-09 16:00:35 +00:00
Warner Losh
93ef08af3e compare return value from getopt against -1 rather than EOF, per the final
posix standard on the topic.
1997-03-28 15:24:41 +00:00
Peter Wemm
b97fa2ef50 Revert $FreeBSD$ to $Id$ 1997-02-22 14:13:04 +00:00
Jordan K. Hubbard
1130b656e5 Make the long-awaited change from $Id$ to $FreeBSD$
This will make a number of things easier in the future, as well as (finally!)
avoiding the Id-smashing problem which has plagued developers for so long.

Boy, I'm glad we're not using sup anymore.  This update would have been
insane otherwise.
1997-01-14 07:20:47 +00:00
Steve Price
78b09ffeaf -Wall cleaning. 1996-12-14 06:08:03 +00:00
Nate Williams
2b240fd84f ts_sec -> tv_sec
ts_nsec -> tv_nsec
1996-09-20 04:45:59 +00:00
Mark Murray
bbff7ca556 #include <kerberosIV/des.h> -> #include <des.h> 1996-02-11 09:18:18 +00:00
Paul Traina
a03b5a5efb Close bin/937 - handle negative timestamps 1996-02-08 21:06:40 +00:00
Mark Murray
776955d918 Updating /usr/include/kerberosIV/des.h so eBones will build breaks
rcp and rlogin.
(patch supplied)

Submitted by:  John Capo <jc@irbs.com>
1995-09-10 14:59:51 +00:00
Rodney W. Grimes
2162b2d226 Remove trailing whitespace.
Reviewed by:	phk
1995-05-30 00:07:29 +00:00
Joerg Wunsch
0fd510b71a You will find enclosed some changes to make gcc -Wall more happy in
/usr/src/bin. Note that some patches are still needed in that directory.

I (Joerg) finished most of Philippe's cleanup.  /bin/sh will still
need *allot* of work, however.

Submitted by:	charnier@lirmm.fr (Philippe Charnier)
1995-03-19 13:29:28 +00:00
David Greenman
89730b290a Added $Id$ 1994-09-24 02:59:15 +00:00
Rodney W. Grimes
4b88c807ea BSD 4.4 Lite bin Sources 1994-05-26 06:18:55 +00:00