Commit Graph

351 Commits

Author SHA1 Message Date
jb
f21cd75f30 Add #include stdlib.h to get prototypes. 1998-05-09 09:24:12 +00:00
jb
005dd2f7a4 Change prototype for addbuf to make it compatible with tputs now that
there is a prototype to check it against.
1998-05-09 09:22:33 +00:00
jb
6ebc5834dc Add #include string.h, stdlib.h and termcap.h to get prototypes.
Change prototype for addbuf to make it compatible with tputs now that
there is a prototype to check it against.
1998-05-09 09:21:28 +00:00
jb
93326f26e1 Add #include string to get prototypes. 1998-05-09 09:19:24 +00:00
jb
11929d69ae Add 'extern' to those arrays that are declared and initialised
in other files.
1998-05-09 09:18:33 +00:00
jb
f7925067df Add #include string.h to get prototypes. 1998-05-09 08:46:53 +00:00
jb
2289cf3713 Add #include stdlib.h to get prototypes. 1998-05-09 08:45:53 +00:00
jb
6061aa32dc Add #include string.h to get prototypes. 1998-05-09 08:17:46 +00:00
jb
4b1fdc389c Alphas don't necessarily have speakers. 1998-05-09 08:16:53 +00:00
bde
9667ed0a16 Added y.tab.h to SRCS. This should have been used to get dependencies
on y.tab.h generated.  It will soon be used to tell bsd.dep.mk that
y.tab.h itself needs to be generated.
1998-05-05 13:16:35 +00:00
bde
f701fbc7d5 Fixed races in `make -jN' using new yacc rules. 1998-05-04 20:09:06 +00:00
peter
e823d46696 *** empty log message *** 1998-04-27 04:26:56 +00:00
charnier
cb6ac53866 Exit(-1) -> exit(1). 1998-04-01 06:16:17 +00:00
charnier
237c19bc20 Add prototypes, usage(). Add Id. 1998-04-01 06:15:37 +00:00
charnier
27d5314a37 Add Id. 1998-04-01 06:14:35 +00:00
charnier
12946fc00d Use .An/.Aq. 1998-04-01 06:14:16 +00:00
charnier
e28dd83911 Use Id instead of Header. 1998-04-01 06:13:47 +00:00
bde
8609d653b2 Don't use the FreeBSD misfeature DPSRCS or give explicit dependencies
on generated headers.  Just put generated headers in SRCS so that
bsd.*.mk can generate better dependencies.
1998-03-06 07:00:28 +00:00
alex
d7635f84c9 Teruillian --> Tertullian
PR:		5928
Submitted by:	Doug <Studded@dal.net>
1998-03-06 01:49:14 +00:00
jkh
441f3c9dac Wargh! Who went and changed all the getopt() comparisons from -1 to
EOF?  The getopt(3) manpage clearly states that the return value is *-1*,
not EOF!  Besides, getopt(3) isn't reading from a file. :)

Noticed-while:	merging to 2.2 (where this is correct).
1998-03-01 05:10:28 +00:00
steve
7759b26c4b Fix a core dump caused by negative numbers.
PR:		5858
Submitted by:	Max Euston <meuston@jmrodgers.com>
1998-02-26 21:13:17 +00:00
steve
f06e5a50b1 Be sure to set the value of Tbl.str_numstr before any call to
do_order or randomize so that they actually work.

PR:		5791
1998-02-20 00:47:49 +00:00
jdp
70250f0cc5 Disable boggle. It is being removed due to trademark violations. 1998-02-11 19:52:53 +00:00
bde
a610e87ce4 Fixed long lines in install rule. Fixed other bogons while I was here:
- removed vestigal rule for a Lite1 `.0' manpage.
- don't duplicate defaults in the `all' dependencies.
- removed bogus dependency of `setup' on monsters.asc.
- compile `setup' with the usual CFLAGS.
- create monster files at build time, not at install time.
- don't be so repetitive in the install rule.
- fixed too-global replacement of `install' by ${INSTALL}.

Long lines made disgustingly longer by: previous commit.
1998-01-16 09:43:47 +00:00
phk
c904575f90 spelling error. 1998-01-15 11:36:03 +00:00
imp
683c0565d2 Avoid fclose(NULL).
Submitted by:	 OpenBSD (Theo de Raadt)
1998-01-07 00:12:04 +00:00
eivind
d12a7eca9e Fix phantasia.
Noticed by:	max
1998-01-05 17:28:01 +00:00
jkh
fac1bc9849 Remove bogus declaration of calloc() that broke the build. Test, folks,
test!
1997-09-26 06:25:42 +00:00
ache
24ebd3d8b6 Remove unused file 1997-09-24 23:37:07 +00:00
ache
2c123b9bff Convert to random() 1997-09-24 23:33:25 +00:00
ache
ee017c7e5d Fix turn right
Submitted by: "Klaus-J. Wolf" <Yanestra@t-online.de>
1997-09-24 23:18:44 +00:00
ache
9cacac2173 Oops, miss one rand() lcation... 1997-09-24 23:15:00 +00:00
ache
d820189bdb Convert to random() 1997-09-24 23:09:34 +00:00
ache
f9b741be26 Convert to random() and automatically fix bug with RAND_MAX is too large 1997-09-24 23:00:29 +00:00
ache
0465821611 Convert to random() 1997-09-24 22:55:14 +00:00
ache
6f55e94584 Move under HIDEGAME, add revoke
Cleanup
Convert to random()
1997-09-24 22:50:24 +00:00
ache
3cf3c55356 Cleanup
Convert to random()
1997-09-24 22:40:45 +00:00
ache
518e6e69bd Convert to random()
Cleanup
1997-09-24 22:33:22 +00:00
ache
513b27d707 Cleanup.
Convert to random()
1997-09-24 22:29:08 +00:00
ache
64369fc926 Revoke properly by setgid, not by setuid, overlooked in games
uid->gid change
1997-09-24 21:29:58 +00:00
ache
44591d995a Remove setuid, priveledges already revoked early in the right way 1997-09-24 21:25:48 +00:00
ache
afaf9afc77 Cleanup.
Initialize random
1997-09-24 21:16:13 +00:00
ache
b78f1ac8f7 Use include for malloc declaration 1997-09-24 21:09:17 +00:00
ache
d7d1a88a74 Fix longstanding bug: it was impossible to save to the same file twice
since it was deleted on exit.
1997-09-24 21:05:08 +00:00
ache
4b745741b3 Fix revoke to use setgid instead of setuid,since games uid changed to
gid and this place overlooked
1997-09-24 20:52:59 +00:00
ache
2fcd0934d3 Revoke privs before shell exit
Includes cleanup
Use getlogin()
Fix names in FILES section
Convert to random()
1997-09-24 20:48:39 +00:00
ache
5449271204 Oops, to many zeroes was in usleep arg 1997-09-24 20:19:59 +00:00
ache
705dab002e Headers cleanup.
Add revoke before shell exit.
Fix mail sending procedure.
Convert to random()
Implement nap.
1997-09-24 20:17:43 +00:00
ache
5c7d6617c8 Remove conflicting malloc declaration 1997-09-24 19:26:20 +00:00
ache
6dbfe3ba60 Remove setuid, uneeded now 1997-09-24 18:03:26 +00:00
ache
5a3be138e3 Back out all my changes and restore v1.5 because there is no
setuid games now, hack problem fixed differently by hackdir permissions
1997-09-24 17:46:33 +00:00
ache
96676824f3 Make hack non-setuid back, it is possible because hackdir hierarchy
are not more readable/writeable by anyone except "games" group
1997-09-24 17:43:46 +00:00
ache
60b87f45b8 Includes cleanup
Fix nonull flag detecting from termcap
Use usleep to handle nonull case
Prevent overflow on genocided getenv
Install most files not owned by games.games to prevent
data modifications
Fix path for gethdate()
1997-09-24 12:29:25 +00:00
ache
73e522e820 Use SUIDGAME hook now 1997-09-24 10:00:29 +00:00
ache
f0c1bc5306 Back out previous fix (not work) and add more general SUIDGAME hook instead 1997-09-24 09:56:34 +00:00
ache
115d7275ba Since hack suid now, add -fschg to install flags to prevent this
binary to be overwritted
1997-09-24 09:45:57 +00:00
ache
3fadb9c289 Revoke privs once at earlier stage and not mess with setegid in save
Fix save: missing creation modes arg and wrong symlink test
Small C cleanup
1997-09-24 09:42:33 +00:00
ache
4ee52dafc7 Simplify revoke 1997-09-24 09:24:10 +00:00
ache
20d6ff62f0 Open score file and do revoke as early as possible 1997-09-24 09:21:55 +00:00
ache
77b0d128db Simplify revoke 1997-09-24 09:14:38 +00:00
ache
c332edcb08 Make hack suid "games" (additionly to sgid "games" as run),
it is needed for savegames and bones, they
intendent to not be altered by user and can't be pre-created as scorefile.
Clear savegames on install: target too, not only bones
Install rumors not readable by all.
Cleanup includes a little.
1997-09-24 08:58:44 +00:00
ache
8a2532864c Allow BINMODE to be overwritted (use ?=) 1997-09-24 08:39:58 +00:00
ache
8ac875c94c Simplify revoke 1997-09-24 08:09:04 +00:00
ache
92a326af9b Do not swap uids on log writting but open it first, then revoke
Simplify revoke
1997-09-24 07:10:47 +00:00
ache
ac34d7a572 Put comment indicating revoke 1997-09-24 07:03:30 +00:00
ache
141cdcdf1d Simplify revoke 1997-09-24 07:00:45 +00:00
ache
3e97e057a5 Oops, fix my error from prev commit (revoke simplification) 1997-09-24 06:54:15 +00:00
ache
875c6f8600 Simplify revoke 1997-09-24 06:49:22 +00:00
ache
8acbd05f99 Revoke sgid privs early and not svap uids on saved game at all 1997-09-24 06:47:15 +00:00
ache
369ad2ce73 Cleanup
Simplify revoke: only sgid needed to be revoked
Use srandomdev
1997-09-24 06:39:23 +00:00
ache
904e937fbc Use srandomdev 1997-09-24 06:22:40 +00:00
ache
6dda81e2d7 Use srandomdev
Cleanup
1997-09-24 06:11:10 +00:00
ache
f3087f06ac Use srandomdev 1997-09-24 05:28:05 +00:00
ache
7798c29559 Use srandomdev 1997-09-24 05:18:42 +00:00
ache
7e983e5099 Use srandomdev() 1997-09-24 05:14:27 +00:00
ache
78f940e7b6 Use srandomdev 1997-09-24 04:53:49 +00:00
ache
297678a001 Use srandomdev 1997-09-24 04:48:24 +00:00
ache
76a1985253 Beforeinstall logfile to prevent it owned by first user who run the game 1997-09-24 04:35:22 +00:00
ache
d41c14dad8 Beforeinstall scorefile to prevent it owned by first user who
run the game
1997-09-24 04:00:29 +00:00
ache
3cb287c630 Beforeinstall scorefile to prevent it owned by first who run the game 1997-09-24 03:43:30 +00:00
ache
88bcce4b07 Installed scenarios was unreadable with change games uid->gid, fix it
Beforeinstall score file to the right place
Use srandomdev
Remove revoke, it broke scores and scenarios
Fix names in FILES manpage section
1997-09-24 03:28:24 +00:00
ache
d6530ba40d Pre-create score file to prevent it owned by first user who run
canfield
Fix scorefile name in manpage
Use srandomdev
Remove revoke, the game already revoked in another place
Fix bug with missing getuid()
1997-09-24 02:56:53 +00:00
ache
ace16f9a4b Beforeinstall scores and log file to prevent them owned by
first who run snake
snake.c: cleanup, use srandomdev() now, fix created file permissions
1997-09-24 02:34:53 +00:00
ache
3f8a108727 Install scorefile as group games writeable
Remove revoke from game, score can't work with revoke
1997-09-24 02:16:50 +00:00
ache
0d91fed910 Beforeinstall log and score files to prevent owning of them by first
user who run game
Slightly modify game to understand pre-created score file
1997-09-24 01:27:26 +00:00
ache
ca54550bb7 Install empty rogue.scores file to prevent it owned by
first user who run rogue
1997-09-24 00:17:13 +00:00
ache
fa23c77f0f Do not install 3 files writeable by all (666), change it to 664 1997-09-24 00:07:08 +00:00
phk
2d831c7d21 Many places in the code NULL is used in integer context, where
plain 0 should be used.  This happens to work because we #define
NULL to 0, but is stylistically wrong and can cause problems
for people trying to port bits of code to other environments.

PR:		2752
Submitted by:	Arne Henrik Juul <arnej@imf.unit.no>
1997-09-18 13:45:34 +00:00
ache
93105e4a32 Remove revoke privs, not needed 1997-09-16 01:22:47 +00:00
ache
1525d264ab Remove HIDEGAME, it is not a game 1997-09-16 01:19:26 +00:00
peter
03e311c034 Disable tetris 1997-09-11 02:52:59 +00:00
ache
4bd2b1cbec Describe morse locale features better 1997-09-01 14:10:38 +00:00
ache
ac3253d328 Fix Cyrillic (KOI8-R) code table detection and processing
Remove yet one setuid()
1997-09-01 13:58:22 +00:00
ache
3afe2b17e3 Remove HIDEGAME and revoke, it is not a game to hide it 1997-09-01 11:53:14 +00:00
ache
8522624aad Remove so-called revoke, this game never installed sguid 1997-09-01 11:40:18 +00:00
ache
4010a61b30 Remove so-called revoke, this game not installed sguid 1997-09-01 11:31:56 +00:00
ache
29f93ed7df Remove so-called revoke, this game not installd sguid 1997-09-01 11:24:35 +00:00
ache
a537a20819 Remove so-called revoke, this game not installed sguid 1997-09-01 11:22:08 +00:00
eivind
d8e95d8c1a Change games from setuid games to setgid games.
Reviewed by:	maybe@yes.no
Obtained from:	OpenBSD (mostly deraadt@openbsd.org)
1997-09-01 00:34:51 +00:00
jmg
d840732075 minor fortune fixes:
o	convert a ' to "
   o	remove a stray "
   o	format some attributations properly
1997-08-23 10:35:16 +00:00
jlemon
b88565f4e1 A ':' in the data file was always interpreted as a category divider,
even if escaped.  Changed code so that the next character after a '\'
    is skipped.  This should not cause a buffer overflow, as backslashes
    at the end of a line are handled earlier in the code.

    Also correct a slight grammatical nit in the bard datfile.

PR:	3777, 3917
1997-08-18 20:26:32 +00:00
steve
c8b8aa249f Merge Lite2 changes.
PR:		bin/2599
Submitted by:	Julian Assange <proff@iq.org>
1997-08-11 04:23:05 +00:00
steve
7a5541cde7 Show the real revision date and not the date that this
manpage is being viewed.
1997-06-23 04:03:49 +00:00
max
4db3a07a68 Typo fix.
PR:		3662
Submitted by:	Matthew Hunt <mph@pobox.com>
1997-06-14 19:30:27 +00:00
ache
aee8cc2f52 Remove srandomdev fallback code 1997-06-14 00:37:08 +00:00
phk
28dfe89a8d This file was somewhat out of date :-) 1997-06-07 09:30:11 +00:00
ache
4caf82f971 Remove some duplicated and incomplete entries 1997-06-05 04:06:13 +00:00
jmg
5942cb7bb5 a bunch of formatting (\t -> \t\t) changes... so I was board one night.. :) 1997-05-23 09:58:43 +00:00
asami
0f22a3c4f9 Remove explicit rule for setup. This effectively deletes revisions 1.2
and 1.3 as well.
1997-05-13 07:26:19 +00:00
asami
6c574c5c4f Add ${CFLAGS} and ${LDFLAGS} to the setup command line. 1997-05-13 05:52:40 +00:00
ache
d2ba14107c Use srandomdev() now
Add range checking for invalid denominator values
1997-03-30 23:33:29 +00:00
ache
c9bb29c92e Use srandomdev() to initialize generator 1997-03-24 14:39:24 +00:00
mpp
51216478d9 Typo police. 1997-03-24 00:18:19 +00:00
peter
f8bf6e7f2d Merge from Lite2 so that it compiles 1997-03-12 03:51:01 +00:00
peter
11a20b812b Man page is .6, not .0 - crept in from Lite2 1997-03-12 03:43:15 +00:00
peter
4e71b57c3c factor.6, not factor.0 (crept in from 4.4Lite2) 1997-03-12 03:33:16 +00:00
peter
4f07d6ce62 Merge from Lite2 (oops, nearly forgot these ones) 1997-03-11 17:25:32 +00:00
peter
8d3716cd7d This commit was generated by cvs2svn to compensate for changes in r23704,
which included commits to RCS files with non-trunk default branches.
1997-03-11 14:39:26 +00:00
peter
8d369a0bd2 Import some CSRG 4.4BSD-Lite2 games 1997-03-11 14:39:26 +00:00
ache
db776ff976 Fix srandom arg type accodring to Lite2
Use ^ getpid() instead of + getpid()
1997-03-11 14:08:34 +00:00
ache
25a7568187 Fix srandom arg type according to Lite2 1997-03-11 14:06:52 +00:00
ache
d7897ffa5f Make /dev/urandom fd static, or it pick up random descriptor
(stack garbadge) and read from it

Should go into 2.2
1997-03-08 18:01:40 +00:00
ache
78407f0914 Back out MAXLOGNAME fix, Bruce points that copyinstr require NUL 1997-03-03 07:59:54 +00:00
ache
05c8126ef7 Add +1 to NUL terminate after MAXLOGNAME 1997-03-02 21:52:02 +00:00
eivind
8db9f05d1b Actually remove sys/time.h hack; fix typo.
Pointed out by:	bde
1997-02-26 20:10:45 +00:00
mpp
67b46541d3 Allow fortune to use /dev/urandom if available to obtain its random
numbers.  If /dev/urandom is unavailable, it will fall back to
using the random() function.

I did this because I'm sick of seeing the same handful of fortunes
over and over, and I've seen the exact same fortune one too many times
when starting up two login shells at the same time.

2.2 safe.
1997-02-23 23:03:47 +00:00
eivind
ee4a78d281 Fix sizeof/strlen typo and limit scanf length.
scanf spotted by:	Aarn Bornstein <aaronb@j51.com>
1997-02-23 05:15:52 +00:00
eivind
9b98797d29 Add setuid() before running the pager - from the code audit.
Submitted by:	Mark Huizer <xaa@stack.nl>
1997-02-23 03:29:36 +00:00
peter
fda548cb83 Revert $FreeBSD$ to $Id$ 1997-02-22 14:46:58 +00:00
mpp
58f212920d #include <string.h> to help silence -Wall. 1997-02-20 23:11:22 +00:00
eivind
27eb6d09a0 Remove buffer overflow and tempfile race, remove <sys/time.h> hack (and
need for it), change definition of setbit() macro and friends to be
compatible with <sys/param.h>.
The bugs were discovered and fixed as a result of the FreeBSD code audit.

Submitted by:	Aaron Bornstein <aaronb@j51.com>, Mark Huizer <xaa@stack.nl>
1997-02-20 03:04:54 +00:00
max
fa88f399c7 List -h option also in the SYNOPSIS line. 1997-02-15 11:22:19 +00:00
max
87555db6e8 Added an option `-h' which gives you usage info.
(According to the original man page, giving `-' by itself as the argument
is supposed to do this, but it seems that it never worked that way.)
1997-02-15 06:12:07 +00:00
max
37e9ffbc31 Make the description of command-line args match the reality.
- Options must be preceeded by a `-'.
  - Backgammon doesn't give, and hasn't given you any usage info.
    (Maybe this should be fixed in the program.)
1997-02-11 18:52:55 +00:00
imp
9b5899c452 Buffer overflow from OpenBSD
1.3 deraadt:
	buf oflow, felix@mamba.pond.sub.org
Obtained from: OpenBSD

Not sure how to exploit this, but may be a backmerge candidate.
1997-02-09 04:47:19 +00:00
wosch
facc59a057 444 -> ${NOBINMODE}
/usr/share -> ${SHAREDIR}
/usr/games -> ${BINDIR}
1997-02-09 02:52:41 +00:00
wosch
2b48486081 $* -> "$@"
use exec for last command in shell script
1997-02-09 01:09:33 +00:00
phk
1ecb1791d7 The fact that people can't put the proper source on Kierkegaards
most famous insult to humanity can be forgiven, afterall, it
almost underlines the quote with irony, if one knows the context.

But to misspell the name of Alfred E. Neuman ...
1997-02-03 20:15:11 +00:00
max
b0c88e4d21 Instead of swapping ruid and euid before and after touching user's file,
simply drop the privilege right after the program is started.
Thanks to bde for giving me good suggestion about this problem.
1997-02-01 21:30:50 +00:00
max
0343f28794 Include string.h for prototype of strdup(). 1997-02-01 02:54:12 +00:00
max
bd5d098ad1 Style police:
- Indentation corrections
  - Spaces -> tabs.
  - func() -> func () (To be consistent with the original code.)
  - Check if getopt() returns -1, not EOF.

Suggested by:	bde
1997-01-31 15:04:23 +00:00
max
0988434e5d Better handling of command-line argument:
1. Pass argc and argv to getarg and process them with getopt().
  2. Instead of using an array to save arg characters, use array of
    pointers and call backgammon/teachgammon with execv, instead of execl.

This should fix problems with calling teachgammon.
2.2 candidate.
1997-01-30 07:12:59 +00:00
max
c2172b20d2 Oops, setreuid() also needed before and after opening/closing the recover file
in recover().
2.2 candidate.
1997-01-30 01:51:45 +00:00
max
9abde98e48 Do getreuid(geteuid(), getuid()) before opening file to save the game and
after closing it.
This fixes bug that user couldn't save the game in progress.
2.2 candidate.
1997-01-30 01:29:28 +00:00
mpp
6b982f9262 Correct some grammar. Closes PR# 2520.
Submitted by:	 John-Mark Gurney <gurney_j@efn.org>
1997-01-26 05:07:58 +00:00
max
534aae0b9e Fix typo in instruction message. 1997-01-23 09:02:49 +00:00
max
25753ac2ab When calling recover() from getarg(), also check to see if the first
character of the argument being processed isn't '\0'.

This fixes problem with backgammon exiting abnormally when you answer 'y' to
the question it asks if you need instruction for the game.

2.2 cnadidate, maybe?
1997-01-23 04:41:01 +00:00
jkh
808a36ef65 Make the long-awaited change from $Id$ to $FreeBSD$
This will make a number of things easier in the future, as well as (finally!)
avoiding the Id-smashing problem which has plagued developers for so long.

Boy, I'm glad we're not using sup anymore.  This update would have been
insane otherwise.
1997-01-14 07:20:47 +00:00
mpp
00f3741fc0 Fix some typos and remove a couple of duplicate
fortunes.  Closes PR#s 2358 and 2402.

Submitted by:	John-Mark Gurney <gurney_j@efn.org>
1997-01-08 07:04:44 +00:00
bde
4fca167e06 Use ${COPY} instead of -c for installing non-source files. 1997-01-01 04:22:23 +00:00