Commit Graph

54 Commits

Author SHA1 Message Date
glebius
75fb40625d The last change is not needed for HEAD.
Explained by:	ru
2007-03-30 08:23:59 +00:00
glebius
7c280152d9 Do not build the libedit support if NO_LIBPTHREAD is defined.
PR:		bin/104478
Submitted by:	Mike Durian <durian shadetreesoftware.com>
2007-03-28 14:04:35 +00:00
kevlo
5a57d3e796 getopt(3) returns -1, not EOF. 2007-02-06 08:48:28 +00:00
ru
eeb150355b Push the detection of threading libs support down to ngctl/Makefile
as the latter can be built without threading (with the loss of line
editing functionality).

Pointed by:	glebius
2006-11-27 16:55:14 +00:00
ru
5227aad232 Fix "make checkdpadd". 2006-11-26 14:43:03 +00:00
kan
8c74632d44 Silence GCC4 signed/unsigned pointer mismatch warning. 2006-09-21 01:48:47 +00:00
glebius
03ea83713a - Pass pointer to fd_set in ReadSockets.
- style(9) nits.

Submitted by:	ru
2006-08-08 07:04:40 +00:00
glebius
b513ad862a Add line edit and history support to ngctl(8) via editline(3).
Details:
- The main thread runs editline(3) functions, that can block.
- A separate thread is launched to monitor netgraph sockets.
- The access to the descriptors is protected by a mutex. At
  runtime the monitoring thread owns the mutex. When the main
  thread reads a command from el_gets() it asks the monitoring
  thread to release a mutex and sleep until the main thread
  processes the command.

This makes ngctl(8) depend on libedit, and libpthread. Thus, the
new functionality isn't compiled in if release is being built
with -DRELEASE_CRUNCH.

PR:		bin/87352
Reviewed by:	ru, Nuno Antunes <nuno.antunes gmail.com>
2006-08-07 14:17:05 +00:00
stefanf
ff68c8b4d3 Don't use empty braces ("{}") to initialise arrays. This is a syntax
error in ISO C (both 90 and 99).
2006-07-17 08:35:47 +00:00
glebius
0552c3f9ac Style: space after "return". 2006-06-28 10:38:38 +00:00
glebius
ae95ee086e Unnest includes before forthcoming editing. 2006-05-24 14:46:55 +00:00
ru
918851f101 - Reduce the number of netgraph messages when listing
nodes from (N + 1) to 1, where N is the number of
  nodes in the system.

- Implement "ls -l" which runs the "show" command for
  each node.

In collaboration with:	glebius
2005-02-09 16:17:33 +00:00
maxim
ba4f5d9f13 Backout rev. 1.17 per ru@ request: there are net.graph.recvspace and
net.graph.maxdgram sysctls.
2005-02-04 20:09:11 +00:00
ru
6cc4b6c220 Added the EXIT STATUS section where appropriate. 2005-01-17 07:44:44 +00:00
maxim
52c7e742ee Increase a socket receive buffer size. This helps 'ngctl list'
to deal with a big number of nodes.

Submitted by:		archie
Approved by:		archie
Reported and tested:	Konstantin Timashkov
MFC after:		1 month
2004-11-25 09:27:56 +00:00
ru
6294018a20 Mechanically kill hard sentence breaks. 2004-07-02 23:13:00 +00:00
ru
63673a77c6 Get rid of all (but one in write.c) static size buffers. 2004-01-27 21:52:52 +00:00
ru
0455fe1058 Make this WARNS=3 clean. 2004-01-26 10:27:18 +00:00
green
ab0602c74b Add a GraphViz-exporting ngctl(8) "dot" command. You can now create
very useful .dot files of your netgraph(4) to quickly visualize the
nodes, hooks and edges.  An example of this can be found here:
	http://people.freebsd.org/~green/sample-netgraph-dot.ps
If anyone would like to refine the output further, please do so.
2004-01-09 03:19:40 +00:00
charnier
3d7bd9d590 Use fprintf() instead of errx() when displaying usage string. The program name
will not be written twice.
2004-01-04 16:11:29 +00:00
harti
173237aab3 Get rid of the old constants which did not include the trailing NUL
and use the new constants which do.
2003-11-12 13:04:44 +00:00
fenner
42f2975f17 Add missing "of". 2002-12-14 00:20:43 +00:00
des
4d6b787d2d Usage style sweep: spell "usage" with a small 'u'.
Also change one case of blatant __progname abuse (several more remain)
This commit does not touch anything in src/{contrib,crypto,gnu}/.
2002-04-22 13:44:47 +00:00
archie
8a9a43ad04 Add ngctl "write" command.
MFC after:	1 week
2002-01-22 22:01:25 +00:00
ru
bde8ec1b70 mdoc(7) police: utilize the new .Ex macro. 2001-08-15 09:09:47 +00:00
obrien
9c97c8f02d Perform a major cleanup of the usr.sbin Makefiles.
These are not perfectly in agreement with each other style-wise, but they
are orders of orders of magnitude more consistent style-wise than before.
2001-07-20 06:20:32 +00:00
obrien
be022bb715 Remove GCC'isms in CFLAGS. 2001-07-20 04:23:13 +00:00
dd
911ca14c87 Remove whitespace at EOL. 2001-07-15 08:06:20 +00:00
ru
0d5f9334cf mdoc(7) police: removed HISTORY info from the .Os call. 2001-07-10 15:12:08 +00:00
ru
afd506414e - Backout botched attempt to introduce MANSECT feature.
- MAN[1-9] -> MAN.
2001-03-26 14:42:20 +00:00
ru
f10dc9aca1 Set the default manual section for usr.sbin/ to 8. 2001-03-20 18:17:26 +00:00
phk
0c8f9ebda9 Unrevert something which shouldn't have been reverted in the previous revert.
(Yes, I'm going to bed now to get some much needed sleep...)
2001-03-17 11:43:36 +00:00
phk
400aa0706c Backout my previous commit, it appearantly doesn't work for asynchronous
messages.
2001-03-17 08:59:31 +00:00
phk
4c843bf603 Add -ledit to ngctl.
Somebody submitted this long time ago, and it has been sitting in my
tree for months because I thought archie would pick it up.

Submitted by:	(sorry, lost track)
2001-03-16 19:35:07 +00:00
ru
c23c39b3a4 mdoc(7) police: removed history info from the .Os FreeBSD call. 2000-12-14 11:52:05 +00:00
ru
eb8c554f56 mdoc(7) police: use certified section headers wherever possible. 2000-11-17 11:44:16 +00:00
ben
5eea8e98aa remove trailing periods from SEE ALSO. 2000-11-15 17:27:54 +00:00
archie
62118ce696 Fix bug in "read" command.
Submitted by:	Dave Cornelius <dc@packetdesign.com>
2000-10-10 01:34:20 +00:00
archie
a5f47e2718 Remove unused variable.
PR:		bin/20052
Submitted by:	Alex Kapranoff <alex@kapran.bitmcnit.bryansk.su>
2000-07-20 17:17:49 +00:00
phk
0cb13df515 Yellow hat this way: forgot cvs add. 2000-07-03 17:39:24 +00:00
phk
aec15566c7 Experiemntal ascii based device configuration mechanism.
This may or may not survive, decision will be made well before 5.0-R
2000-07-03 13:34:18 +00:00
archie
f1f4c483fe When the 'msg' command is used from the command line, check for a
synchronous reply, and display it (if any) before exiting.

Requested by:	phk
2000-06-20 18:51:38 +00:00
archie
6ea7de0367 Field structure changed name from 'typename' -> 'type_name'. 2000-05-01 23:30:46 +00:00
archie
7ee0a0e187 Remove erroneous built-in help information for the 'msg' command. 2000-03-13 19:23:16 +00:00
sheldonh
b2240fc1c0 Remove single-space hard sentence breaks. These degrade the quality
of the typeset output, tend to make diffs harder to read and provide
bad examples for new-comers to mdoc.
2000-03-01 14:09:25 +00:00
archie
ee893a1be4 No need to try loading ng_socket.ko, as NgMkSockNode() does that
for us now if necessary.
2000-01-28 00:50:28 +00:00
julian
443430016e Manual page style work.
Submitted by:	Alexey Zelkin <phantom@FreeBSD.org>
thanks!
1999-12-21 01:25:21 +00:00
archie
81fceb37a9 Add two new generic control messages, NGM_ASCII2BINARY and
NGM_BINARY2ASCII, which convert control messages to ASCII and back.
This allows control messages to be sent and received in ASCII form
using ngctl(8), which makes ngctl a lot more useful.

This also allows all the type-specific debugging code in libnetgraph
to go away -- instead, we just ask the node itself to do the ASCII
translation for us.

Currently, all generic control messages are supported, as well as
messages associated with the following node types: async, cisco,
ksocket, and ppp.

See /usr/share/examples/netgraph/ngctl for an example of using this.

Also give ngctl(8) the ability to print out incoming data and
control messages at any time.  Eventually nghook(8) may be subsumed.

Several other misc. bug fixes.

Reviewed by:	julian
1999-11-30 02:45:32 +00:00
archie
625e9e0395 Limit COPTS added by Makefile to just '-Wall'. 1999-10-28 20:17:13 +00:00
archie
869bd7a8e7 If we get an EPROTONOSUPP error when trying to create the netgraph socket
node, it's most likely because the "ng_socket.ko" KLD is not loaded yet.
So make an attempt to load it before giving up.
1999-10-27 22:17:18 +00:00