Hartmut Brandt
0ce37001aa
Now that there are no users of Lst_ForEach and Lst_ForEachFrom are left
...
delete these two macros and all the associated stuff.
2005-03-16 16:11:11 +00:00
Hartmut Brandt
0bcbcabd26
Replace Lst_ForEach by LST_FOREACH.
2005-03-16 16:02:09 +00:00
Hartmut Brandt
a238417909
Replace another bunch of Lst_ForEachs by LST_FOREACHs and simplify code.
2005-03-16 12:22:15 +00:00
Hartmut Brandt
363fa56a62
Fix a comment.
2005-03-16 08:06:28 +00:00
Hartmut Brandt
0bcd542606
Get rid of another bunch of Lst_ForEach in favour of LST_FOREACH and
...
simplify code accordingly.
2005-03-16 08:04:45 +00:00
Hartmut Brandt
d2f389f5e4
Ups. Revert the last commits. These have been committed by accident.
2005-03-15 15:10:51 +00:00
Hartmut Brandt
d735bf8813
modifier_M: instead of going through the string twice to compute the
...
size of the buffer we need, just allocate the possible maximum.
Patch: 7.117
Submitted by: Max Okumoto <okumoto@ucsd.edu>
2005-03-15 15:05:14 +00:00
Hartmut Brandt
77f4b22417
Style: Move a variable from a local scope up to the begin of the function.
...
Rename result variable so common code becomes more visible.
Rename freePtr to freeResult to make clear what pointer must be freed.
Patch: 7.116, 7.116a
Submitted by: Max Okumoto <okumoto@ucsd.edu>
2005-03-15 14:52:10 +00:00
Hartmut Brandt
49fe6e22fd
Get rid of a number of Lst_ForEach calls in favour of LST_FOREACH
...
and simplify the printing functions.
2005-03-15 14:28:39 +00:00
Hartmut Brandt
ca98b031fd
VarParseLong: move the detection of the modifier separator ':' into
...
the loop. Add a comment why the 'consumed' variable is updated.
Rename lengthPtr to consumed.
Patch: 7.115
Submitted by: Max Okumoto <okumoto@ucsd.edu>
2005-03-15 14:27:29 +00:00
Hartmut Brandt
dd37002304
Yet another version of passing the last line to ParseFinishLine().
...
It turns out that some ports use the obscure feature of spreading
a dependency block across multiple include files. While this seems
bad style, allow it for now and call said function only at end of
all input to process the really last line of everything.
2005-03-15 14:25:24 +00:00
Hartmut Brandt
f321cf01e1
Get rid of another Lst_ForEach in favour of LST_FOREACH. Get rid
...
of the now unused struct LstSrc and collapes two functions into one.
2005-03-14 17:04:58 +00:00
Hartmut Brandt
03ecd4b822
ParseModifier(): rename rw_str to value and reindent cleanup section.
...
ParseRestModifier() and ParseRestEnd(): move advancement of ptr to remove
a confusing calculation.
VarParseLong(): cleanup calculation of consumed.
Patch: 7.114
Submitted by: Max Okumoto <okumoto@ucsd.edu>
2005-03-14 17:03:34 +00:00
Hartmut Brandt
e0da09426f
Move the creation of a Src structure into its own function.
2005-03-14 12:04:20 +00:00
Hartmut Brandt
b33cc19c5f
Split off two function from VarParseLong to handle modifiers and the
...
actual variable lookup. Consistently rename lengthPtr to consumed.
Update a number of comments to match the code.
Patch: 7.111-113
Submitted by: Max Okumoto <okumoto@ucsd.edu>
2005-03-14 12:03:30 +00:00
Hartmut Brandt
8cb809ea3f
Convert a couple of other uses of Lst_ForEach to LST_FOREACH and
...
simplify code.
2005-03-14 08:29:58 +00:00
Hartmut Brandt
c2d34cc331
Simplify the print routines by using LST_FOREACH instead of Lst_ForEach
...
and inlining the small printing utility functions.
Create a function that can be used to produce printable representations
of flag words.
2005-03-11 13:24:08 +00:00
Hartmut Brandt
7985e10d29
Remove leading underscores from the pathname defines. All identifiers
...
with leading underscore followed by an uppercase letter are in the
implementation namespace.
2005-03-11 13:02:38 +00:00
Hartmut Brandt
2c9d008998
Remove the leading underscore from structure tags. All identifiers
...
with a leading underscore are in the implementation namespace.
2005-03-11 12:57:25 +00:00
Hartmut Brandt
941266174e
Style: Fix indentation.
2005-03-11 12:40:55 +00:00
Hartmut Brandt
b13ac84d46
Call ParseFinishLine() also for the last line in a file. This
...
patch differs from the previous one in that it calls the function
only when a real file hits EOF. The bodies of .for loops are also
handled as files, but for these we don't want to end a dependency block
on the 'EOF' as in:
foo:
do-this
.for ...
do-something
.endfor
do-more
2005-03-11 11:29:39 +00:00
Hartmut Brandt
520fec816c
Back out the last commit. It turns out that this breaks more than
...
it fixes. This should fix the buildworld breakage.
2005-03-11 07:53:32 +00:00
Hartmut Brandt
da559dbfd0
Constify Var_Dump and simplify it by inlining VarPrintVar.
2005-03-10 15:38:01 +00:00
Hartmut Brandt
248cf569be
Call ParseFinishLine() for the last line of a file too.
2005-03-10 15:30:09 +00:00
Hartmut Brandt
6dfe1d848e
Reorganize Suff_EndTransform to be called only for nodes for
...
which it is needed (transforms).
2005-03-10 14:54:47 +00:00
Hartmut Brandt
8c87f5a0c7
Style: fix function style before working on it (mainly intendation).
2005-03-10 10:16:03 +00:00
Hartmut Brandt
a2e5fa0890
Implement a new macro LST_NEXT which is like Lst_Succ but doesn't check
...
for its argument to be non-NULL.
2005-03-09 16:53:31 +00:00
Hartmut Brandt
0d037244ba
Split SuffExpandChildren into three functions: one that skips
...
variables and expands archive specifications, one that expands
wild cards and a driver that loops over the children list and
expands each child if necessary replacing it with it's expansions.
2005-03-09 16:51:43 +00:00
Hartmut Brandt
4ca8a80cb5
Var_Subst() cannot return NULL so there is no reason to check
...
for it.
2005-03-09 07:53:03 +00:00
Hartmut Brandt
0fdac3eed6
Style: fix indentation of SuffExpandChildren before working on it.
2005-03-08 16:30:32 +00:00
Hartmut Brandt
e390545124
Use Buf_Peel to get rid of a local variable.
2005-03-08 14:37:47 +00:00
Hartmut Brandt
d5247abc18
Use the Buf_Peel function to get to the string contained into a
...
buffer without using an extra local variable.
2005-03-08 14:33:58 +00:00
Hartmut Brandt
1a67f7b6d6
Remove useless local prototypes.
2005-03-08 14:30:18 +00:00
Hartmut Brandt
0c270d9eb0
Style: fix indentation.
2005-03-08 14:29:23 +00:00
Hartmut Brandt
7ca80f1cbc
Use the new Buf_Peel function to simplify things.
...
Remove an unused struct definition.
2005-03-08 13:15:51 +00:00
Hartmut Brandt
3509f4d713
Create a new function Buf_Peel that returns the string from inside
...
a Buffer and frees the Buffer.
2005-03-08 13:15:18 +00:00
Hartmut Brandt
1753d0e6a4
Add a debugging function that prints a message and appends the
...
current strerror.
2005-03-08 07:47:14 +00:00
Hartmut Brandt
a0aea18e18
Mark functions that don't return as dead.
2005-03-08 07:45:50 +00:00
Hartmut Brandt
34d49b885f
Finish constification of Var_Parse() and Var_Subst().
...
Patch: 0.18, 0.8, 7.110
Submitted by: Max Okumoto <okumoto@ucsd.edu>
2005-03-08 07:43:57 +00:00
Hartmut Brandt
b37a89c4d4
Constify the callers of brk_string in this file.
...
Patch: 7.108
Submitted by: Max Okumoto <okumoto@ucsd.edu>
2005-03-07 16:23:53 +00:00
Hartmut Brandt
f4d3f46b2e
Style: fix indendation of VarModify().
...
Patch: 7.107
Submitted by: Max Okumoto <okumoto@ucsd.edu>
2005-03-07 16:14:50 +00:00
Hartmut Brandt
3cc51195c4
Constify the input argument to brk_string.
...
Patch: 7.106
Submitted by: Max Okumoto <okumoto@ucsd.edu>
2005-03-07 16:10:39 +00:00
Hartmut Brandt
c4487a484d
Factor out the 'S' modifier into its own function. Move a variable
...
that is now used for both the 'M'/'N' branch and the 'S' branch of
the switch statement into a common scope.
Patch: 7.102-105
Submitted by: Max Okumoto <okumoto@ucsd.edu>
2005-03-07 16:08:39 +00:00
Hartmut Brandt
ec3074aef1
Move the 'M' and 'N' modifiers into their own function.
...
Patch: 7.101
Submitted by: Max Okumoto <okumoto@ucsd.edu>
2005-03-07 12:43:59 +00:00
Hartmut Brandt
573d78add6
Style: remove unneeded parantheses in conditionals.
2005-03-03 11:34:04 +00:00
Hartmut Brandt
b6bda8ea9d
Constify the code paths for the 'M' and 'N' modifiers.
...
Patch: 7.100
Submitted by: Max Okumoto <okumoto@ucsd.edu>
2005-03-03 11:26:28 +00:00
Hartmut Brandt
179fc89109
Fix parsing of archives: in System V archive format the member names
...
is terminated with a slash. Although we are not System V, ar has
been configured to put that slash in. This format allows filenames
with trailing spaces.
2005-03-03 10:46:23 +00:00
Hartmut Brandt
5c78dee378
Fix parsing of archive specifications on the target side of
...
dependency lines. It seems that nobody is actually is using
the archive-feature of make.
2005-03-03 10:09:39 +00:00
Hartmut Brandt
49f5e8346a
Update the description comment of the function to reflect the
...
previous change.
2005-03-03 10:07:28 +00:00
Hartmut Brandt
d0330ee675
Transform VarParseLong() so that the lifetime and the constness of
...
variables gets clearer. Transform if() conditions to make the flow
clearer.
Patch: 7.93-99
Submitted by: Max Okumoto <okumoto@ucsd.edu>
2005-03-03 07:25:04 +00:00