d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
94,138 Commits 4 Branches 49 Tags 2 GiB
45feeef2ed
Commit Graph

239 Commits

Author SHA1 Message Date
des
8af1bcf602 Don't close a FILE * which we know is bogus. 2003-08-29 15:54:12 +00:00
des
a1cad5ae8b Some servers respond to RETR in active mode with 125 (connection already 
open) rather than 150 (opening connection).  There's no reason why we
shouldn't accept that.

PR:		misc/42172
MFC in:		3 days
 2003-08-19 11:43:11 +00:00
ru
35d5e319f1 Make sure the crypto versions of libfetch and fetch(1) appear in 
the "crypto" distribution.

Approved by:	des
 2003-07-22 13:54:31 +00:00
trhodes
3514f4bda7 Add an EXAMPLES section. 
PR:		43899
Reviewed by:	des, ru
 2003-06-10 20:41:18 +00:00
ru
9bcac8799e Assorted mdoc(7) fixes. 
Approved by:	re (blanket)
 2003-05-22 13:02:28 +00:00
des
e5d2d778eb Retire the useless NOSECURE knob. 
Approved by:	re (scottl)
 2003-05-19 15:52:01 +00:00
des
9e8300e563 Mark libfetch as c99-clean. Always build at WARNS level 2 rather than 
juggling with levels 2 and 3, as this has lead to world breakage for
NOCRYPT users in the past.
 2003-05-01 14:39:43 +00:00
des
32c9a8b0bd Don't dereference flags if NULL (see http.c rev 1.87) 2003-03-29 15:15:38 +00:00
mtm
a65d822bcd The flags passed in to _ftp_get_proxy may be null 
Approved by:	des, markm (mentor)(implicit)
 2003-03-19 21:39:00 +00:00
des
2d46bf6bbe Don't parse the proxy URL unless we're actually going to use it. No real 
functional difference, but debugging output will be less confusing.
 2003-03-11 08:20:58 +00:00
des
66c619c7d8 Add and document support for a FETCH_BIND_ADDRESS environment variable 
specifying a local address to bind sockets to.  Caveat: lightly tested.

PR:		bin/37572
 2003-03-03 12:35:03 +00:00
markm
21f0f28e47 No need for the OPENSSL_NO_KRB5 switch anymore. 
Fixed by:	nectar
 2003-01-31 23:26:55 +00:00
markm
0d82b8beac Adjust for OpenSSL 0.9.7. 2003-01-28 23:03:15 +00:00
des
7a494517a4 style(9): add parentheses to sizeof even when not strictly required. 
MFC after:	3 days
 2003-01-28 08:04:40 +00:00
jwd
24a72fc271 Fix signed/unsigned comparison warning/error from 'make release' 2003-01-28 00:33:53 +00:00
des
b80b0e22d8 Document .netrc support. 2003-01-22 18:27:25 +00:00
des
48ceb170df Hook in the .netrc code + don't use pointers as if they were booleans. 2003-01-22 17:54:49 +00:00
des
ae10e138a9 Experimental support for .netrc. 2003-01-22 17:53:58 +00:00
des
cead81021c Initialization paranoia. 2003-01-22 17:53:15 +00:00
des
a5ab2dd958 A negative offset means "get it all". 2003-01-22 17:52:27 +00:00
des
a91193c322 Set auto-retry mode to avoid some spurious errors. 
Submitted by:	Andre Albsmeier <andre.albsmeier@siemens.com>
MFC after:	7 days
 2003-01-03 02:45:10 +00:00
schweikh
fec6546e12 english(4) police. 2002-12-27 12:15:40 +00:00
jake
4cbd3579e8 Reduce WARNS level to 3 in the non-crypto case to fix make release on sparc64. 
This may only be turning up now to changes in the cpp predefines for sparc64,
which may be turning on more strict alignment checking.

Approved by:	re
 2002-12-04 04:34:59 +00:00
des
b8dad5d242 Implement and document support for an HTTP_REFERER environment variable. 
PR:		28171
Submitted by:	Andre Albsmeier <andre.albsmeier@mchp.siemens.de>
Approved by:	re (bmah)
MFC after:	1 week
 2002-11-28 12:07:15 +00:00
fenner
1a1a58e225 Fix two typos. 2002-11-08 19:10:05 +00:00
des
799d66dac6 Use __func__ and break a long line. 2002-10-30 15:01:29 +00:00
des
216181b022 Fix a bug in fenner's _fetch_writev() patch (rev 1.36) 
Submitted by:	fenner
 2002-10-30 14:25:00 +00:00
des
a8da55afda Recognize the (incorrect) error code a MediaHawk server sends in reply to 
unrecognized commands such as MDTM.

Requested by:	Stephen Roome <stephen_roome@pepcross.com>
 2002-10-30 06:06:16 +00:00
des
deb00535da Clarify my feelings towards fetch / libfetch. 2002-10-30 04:53:58 +00:00
des
f8f3fd44d8 Recommit the non-broken parts of 1.34 and 1.37. 
Change the type and name of a variable introduced in 1.33.
 2002-10-30 04:43:00 +00:00
des
007c9b98da Don't forget to set the error flag when _fetch_read() returns -1. 2002-10-30 04:42:01 +00:00
imp
ef2e40e300 Reinstate revs 1.35-36 and 1.38. Revisions 1.34 and 1.37 were specifically 
the root cause of the bus errors I was experiencing.

Submitted by:	fenner
Tested by:	obrien
Prompted by:	peter
 2002-10-30 00:17:16 +00:00
obrien
ce6ecab91b Fix `pkg_add -r' by backing out revs 1.34-1.38. 
Revs 1.37-8 produce a bus error in some environments.
Revs 1.34-6 do not bus error, but write corrupted files.
 2002-10-29 12:17:43 +00:00
des
8f1da1ac7d libfetch is now WARNS5 clean in the non-SSL case. 2002-10-28 10:37:31 +00:00
des
d3836d6963 Fix an off-by-one error (> where >= should have been used) which caused 
_fetch_writev() to incorrectly report EPIPE in certain cases.

Also fix a number of const warnings by using __DECONST(), plus a signed /
unsigned comparison by casting the rhs to ssize_t.

Submitted by:	fenner, Craig Rodrigues <rodrigc@attbi.com>
 2002-10-28 10:19:03 +00:00
fenner
519bc6cb16 Up WARNS to 3 if not building with crypto. 
Approved by:	des
 2002-10-28 01:41:28 +00:00
des
37b3ac0423 Slight amendment to rev 1.34: instead of considering any short read an 
error, only report an error if no data was read at all (unless len was
0 to start with).  Otherwise, the final read of practically any transfer
will end in a fatal error.
 2002-10-27 17:20:49 +00:00
des
34e6c489c7 Introduce _fetch_writev(), which is the conn_t version of writev(2). In 
the SSL case, it is no different from the old _fetch_write(), but in the
non-SSL case it uses writev(2) to send the entire vector as a single
packet (provided it can fit in one packet).  Implement _fetch_write()
and _fetch_putln() in terms of _fetch_writev().

This should improve performance in the non-SSL case (by reducing protocol
overhead) and solve the problem where too-smart-for-their-own-good
firewalls reject FTP packets that do not end in CRLF.

PR:		bin/44123
Submitted by:	fenner
 2002-10-27 16:11:21 +00:00
des
c118e55b51 Eliminate two cases of undefined behaviour: total in _fetch_write() was 
not initialized before use, and _http_growbuf() did not return a value
on success.

Reported by:	Peter Edwards <pmedwards@eircom.net>
MFC after:	2 weeks
 2002-10-27 15:43:40 +00:00
des
cd8380e0b1 Back out the previous commit, and fix the bug rather than try to hide its 
symptoms: make timeouts and short transfers fatal, and set errno to an
appropriate value (ETIMEDOUT for a timeout, EPIPE for a short transfer).

MFC after:	2 weeks
 2002-10-27 15:08:21 +00:00
njl
06c0d543e0 The FTP connection caching needs a better interface -- connections are 
closed through _fetch_close() which is the only one who knows the connection
REALLY was closed (since ref -> 0).  However, FTP keeps its own local
cached_connection and checks if it is valid by comparing it to NULL.  This
is bogus since it may have been freed elsewhere by _fetch_close().

This change checks if we are closing the cached_connection and the ref is 1
(soon to be 0).  If so, set cached_connection to NULL so we don't
accidentally reuse it.  The REAL fix should be to move connection caching
to the common.c level (_fetch_* functions) and NULL the cache(s) in
_fetch_close().  Then all layers could benefit from caching.
 2002-10-25 01:17:32 +00:00
obrien
ddccb9e2b3 Use a warns setting we can catch regressions with. 2002-10-20 23:50:28 +00:00
tjr
8ed112060e When recycling a cached connection, increment the reference count so that 
the heap block does not get freed and reused. This should fix the
pkg_add -r crashes that have been happening for months.
 2002-10-20 10:36:27 +00:00
ru
48afd8f904 HTTP authentication got broken in rev. 1.49. 2002-10-03 10:42:19 +00:00
peter
0a7f0ba37e Zap now-unused SHLIB_MINOR 2002-09-28 00:25:32 +00:00
alfred
4f92df742a Fix an infinite loop when _fetch_read() can return 0 (if the 
connection is broken), take this into account and return at this
point.
 2002-09-20 21:50:57 +00:00
fenner
dd87f608a3 Make _fetch_connect() always set the error code. 
Tell ftp that _fetch_connect() always sets the error code (http already knew)
 2002-09-17 05:54:33 +00:00
des
4732944265 Surround prototypes with __BEGIN_DECLS / __END_DECLS. 
PR:		misc/40399
MFC after:	3 days
 2002-07-22 16:11:39 +00:00
ume
eb16909ba9 Cope with 2292bis-01 getaddrinfo (no NI_WITHSCOPEID, always attach 
scope identifier).

Approved by:	des
MFC after:	3 weeks
 2002-07-02 11:09:02 +00:00
des
0fa910cfde Reintroduce debugging code that somehow got lost in a previous revision. 2002-06-24 12:18:41 +00:00