d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
112,334 Commits 4 Branches 49 Tags 2 GiB
4666872d3b
Commit Graph

407 Commits

Author SHA1 Message Date
harti
d1c5c1813a Let the buffer just use the default size by specifying 0 as the size 
instead of specifying the default size explicitely.

Submitted by:	Max Okumoto <okumoto@ucsd.edu>
 2005-02-10 14:53:29 +00:00
harti
f247b32ef0 Mark the modification of the input string (which should really be const) 
with a comment.

Submitted by:	Max Okumoto <okumoto@ucsd.edu>
 2005-02-10 14:52:14 +00:00
harti
9c56ede2b6 Style nits: 
Move some assignments nearer to where they actually used. Convert a loop
from a for() to a while() to make it clearer and add braces to the long
body of it. Split assignment from variable declaration.

Submitted by:	Max Okumoto <okumoto@ucsd.edu>
 2005-02-10 14:50:34 +00:00
harti
374fae4a38 Describe a pre-condition of Var_Parse(). 
Submitted by:	Max Okumoto <okumoto@ucsd.edu>
 2005-02-10 14:43:22 +00:00
harti
41f26b3bb5 Remove a comment that's not actual anymore. 
Submitted by:	Max Okumoto <okumoto@ucsd.edu>
 2005-02-10 14:41:22 +00:00
harti
1735ff6669 Fix spacing by converting mixes of space and tab to tab. Also add a number 
of empty lines in appropriate places.

Submitted by:	Max Okumoto <okumoto@ucsd.edu>
 2005-02-10 14:39:05 +00:00
harti
7e0569095f Initialise the status variable. W_SETTERMSIG uses its value. 
Submitted by:	stefanf
 2005-02-10 14:32:14 +00:00
harti
ac0decfad8 Lst_Append returns void, so the other case of the ? statement 
should also be void.

Submitted by:	stefanf
 2005-02-10 14:25:12 +00:00
harti
c299702086 Use defines for character constants for open and closing braces and 
parantheses. This helps editors to find its way through the horrible
mess of Var_Parse. Rewrite a for() loop into a while() to make it clearer.

Submitted by:	Max Okumoto <okumoto@ucsd.edu>
 2005-02-09 18:44:09 +00:00
harti
9c4d6c6307 While working on constification temporarily disable -Werror. Things are too 
twisted.
 2005-02-09 13:22:02 +00:00
harti
bfa90db5b7 Untangle VarFind and, while rewriting most of the function, fix the 
intendation. (A large part of the function was already at intendation 8).
 2005-02-09 13:13:59 +00:00
harti
0fce40c381 Introduce VarCreate and VarDestroy functions and used them where 
appropriate.

Submitted by:	Max Okumoto <okumoto@ucsd.edu>
 2005-02-09 09:53:28 +00:00
harti
3d0eb6600e Remove an unneeded check. 2005-02-07 16:33:57 +00:00
harti
15f29409ba Introduce a typedef for variable value modifation functions and use it 
where appropriate.

Submitted by:	Max Okumoto <okumoto@ucsd.edu>
 2005-02-07 16:27:19 +00:00
harti
c300f77198 Make the intention of a loop clearer. 
Submitted by:	Max Okumoto <okumoto@ucsd.edu>
 2005-02-07 15:51:51 +00:00
harti
4dd5217a47 Introduce Buf_StripNewLines() and use it where appropriate. 
Submitted by:	Max Okumoto <okumoto@ucsd.edu>
 2005-02-07 11:27:47 +00:00
harti
92a5e4fdd6 Invent a Buf_AppendRange function that appends a non-NUL-terminated string 
given by a pointer to the start of the string and a pointer one behind
the end.

Submitted by:	Max Okumoto <okumoto@ucsd.edu>
 2005-02-07 07:54:23 +00:00
harti
c45831f7c6 Invent a Buf_Append function to append a NUL-terminated string 
and use it thoughout the code.

Submitted by:	Max Okumoto <okumoto@ucsd.edu>
 2005-02-07 07:49:16 +00:00
harti
43632a424a Where the returned line length from Buf_GetAll is not used just pass 
a NULL to the function. Delete the now unused local variables.

Submitted by:	Max Okumoto <okumoto@ucsd.edu>
 2005-02-04 16:53:35 +00:00
harti
44af3ae976 Rewrite of the buf code: 
- convert Buf_AddByte from a macro to a function
- move #define's into the header file
- remove unused field in struct Buffer
- remove size fields - they can be easily computed
- inline Buf_OvAddByte

Submitted by:	Max Okumoto <okumoto@ucsd.edu>
 2005-02-04 16:48:35 +00:00
harti
6861248dfc None of the users of Buf_Discard used it to get rid of only a part of 
the buffer. So replace Buf_Discard by Buf_Clear which just gets rid
of the entire contents.

Submitted by:	Max Okumoto <okumoto@ucsd.edu>
 2005-02-04 13:34:16 +00:00
harti
9c5690ecb4 Inline the ADDWORD() macro in the two places where it is used. It just 
obfuscates the code.

Submitted by:	Max Okumoto <okumoto@ucsd.edu>
 2005-02-04 13:29:50 +00:00
harti
d01d054183 Use _exit() instead of exit() when the exec() after a vfork() fails. 
Submitted by:	Max Okumoto <okumoto@ucsd.edu>
 2005-02-04 13:26:37 +00:00
harti
930c7a333a Move PrintAddr() from util.c into suff.c - the only file where it is 
actuall used, and make it static.

Submitted by:	Max Okumoto <okumoto@ucsd.edu>
 2005-02-04 13:23:39 +00:00
harti
92c06224cb General whitespace cleanup: remove mixes of tabs and spaces, remove 
space after function names, remove spaces on emtpy lines.

Submitted by:	Max Okumoto <okumoto@ucsd.edu>
 2005-02-04 12:38:57 +00:00
harti
4a76daab98 Minor cleanup: make brk_string to return argc only if the pointer to it 
was non-NULL. This let's us eliminated an otherwise unused variable.

shellneeded can never return -1 so there is no need to check for it and
hence no need for a variable to hold the returned value.

Submitted by:	Max Okumoto <okumoto@ucsd.edu> (partly)
 2005-02-04 12:30:54 +00:00
harti
ec85d83f9f Further constification. Use a temporary hack (copying the input string) 
until Var_Subst is fixed.

Submitted by:	Max Okumoto <okumoto@ucsd.edu>
 2005-02-04 12:10:20 +00:00
harti
297b2c0b1b Use an extra variable to assign to instead of missusing an input 
parameter. This will help in constification.

Submitted by:	Max Okumoto <okumoto@ucsd.edu>
 2005-02-04 08:31:42 +00:00
harti
f95865e632 Replace space, tab mixes by tabs. 
Submitted by:	Max Okumoto <okumoto@ucsd.edu>
 2005-02-04 08:15:11 +00:00
harti
2eff456e45 Use tabs to move to the comments instead of wild mixes of tabs and spaces. 
Submitted by:	Max Okumoto <okumoto@ucsd.edu>
 2005-02-04 08:11:58 +00:00
harti
ef354ab8d7 Style: line up with tabulators. 2005-02-04 08:03:55 +00:00
harti
ee5929c16a Use a typedef for the conditional handler function so that declaring 
pointers to these functions is easier.

Submitted by:	Max Okumoto <okumoto@ucsd.edu>
 2005-02-04 08:02:41 +00:00
harti
81deb36901 Style: remove a space between a function name and the opening 
paranthesis.

Submitted by:	Max Okumoto <okumoto@ucsd.edu>
 2005-02-04 07:56:40 +00:00
harti
5f05e672b6 Some more easy constification. 
Submitted by:	Max Okumoto <okumoto@ucsd.edu>
 2005-02-04 07:51:00 +00:00
harti
cde8b61542 Constify an argument to a function. 
Submitted by:	Max Okumoto <okumoto@ucsd.edu>
 2005-02-03 11:51:25 +00:00
harti
0bc036b793 Get rid of a number of unneccessary memory allocations. 
Submitted by:	Max Okumoto <okumoto@ucsd.edu>
 2005-02-03 11:36:19 +00:00
harti
3b3f6b62d1 Make enomem static - it's referenced only in util.c. 
Submitted by:	Max Okumoto <okumoto@ucsd.edu>
 2005-02-02 11:25:05 +00:00
harti
f41efac821 Remove a couple of unused buffer functions. 
Submitted by:	Max Okumoto <okumoto@ucsd.edu>
 2005-02-02 11:21:26 +00:00
harti
e55f5e8b6f Convert several typedefs from beeing pointers to structs to be the structs 
itself. This will ease constification (think of what 'const Ptr foo'
means if Ptr is a pointer to a struct).

Submitted by:	Max Okumoto <okumoto@ucsd.edu>
 2005-02-02 07:36:18 +00:00
harti
69532337be Move all the remaining list functions into one C-file and remove 
double documentation comments. Remove the 3rd clause (from 4) of the
BSD license because these files have only the UCB copyright.

Submitted by:	Max Okumoto <okumoto@ucsd.edu>
 2005-02-01 15:28:41 +00:00
harti
9c48e16769 Remove debugging stuff that crept in in the previous commit. 2005-02-01 11:39:45 +00:00
harti
b24cc98851 Clean up include files and file including. Split nonints.h into pieces 
that get included just where they are needed. All headers include the
headers that they need to compile (just with an empty .c file). Sort
includes alphabetically where apropriate and fix some duplicate commenting
for struct Job, struct GNode and struct Shell by removing one version and
inlining the comments into the structure declaration (the comments have been
somewhat outdated).

This patch does not contain functional changes (checked with md5).

Submitted by:	Max Okumoto <okumoto@ucsd.edu>
 2005-02-01 10:50:37 +00:00
harti
17159f0f8b Fix quoting of the MAKEFLAGS environment variable by only quoting spaces 
and tabs. This is still not correct for command line variable values
ending in a backslash because this would require a larger effort.
Document this limitation in the BUGS section of the man page. The
quoting is mostly compatible with that of gmake and smake.

Tested by:	Max Okumoto and Joerg Sonnenberger from DragonFly BSD
Reviewed by:	ru (man page, partly)
 2005-01-26 18:19:39 +00:00
ru
7f3c7f0d46 Sort sections. 2005-01-18 13:43:56 +00:00
ru
169f1013f0 Scheduled mdoc(7) sweep. 2005-01-11 10:32:52 +00:00
ru
c1a820195c NOSHARED -> NO_SHARED 2004-12-21 09:59:45 +00:00
harti
835198efc5 Fix compilation for the USE_KQUEUE case. 
Submitted by:	Emil Mikulic <emikulic@dmr.ath.cx>
 2004-12-20 10:21:27 +00:00
harti
1c86b95b10 maxJobs is declared extern in job.h so it cannot be static in job.c. 
PR:		bin/75210
Submitted by:	Andreas Jochens; Robert Millan <rmh@debian.org>
 2004-12-20 10:14:05 +00:00
harti
ebeffbcdeb Remove all the cleanup functions. There is no reason to free memory 
just before exiting (especially given the number of memory leaks) -
it just costs time.
 2004-12-17 13:20:19 +00:00
ru
de05db1167 Fix a long-standing bug when make(1) is passed the -V and 
-f options in MAKEFLAGS environment variable, and some of
these options are also specified on the command line.

Thanks to:	marcel
Reviewed by:	harti
 2004-12-16 19:46:50 +00:00