d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
244,596 Commits 4 Branches 49 Tags 2 GiB
5210116662
Commit Graph

189 Commits

Author SHA1 Message Date
trasz
6a793c73c6 Constify. 
Sponsored by:	The FreeBSD Foundation
 2014-04-16 11:01:59 +00:00
trasz
6c1910fb63 Properly pass the initiator address when running in proxy mode. 
Sponsored by:	The FreeBSD Foundation
 2014-04-16 11:00:10 +00:00
trasz
fdee78839e Use socket address from accept(2) instead of retrieving it via 
getpeername(2).

Sponsored by:	The FreeBSD Foundation
 2014-04-16 10:49:48 +00:00
trasz
b9b743fae9 Rework the way we enable CTL iSCSI port. Previously conf_apply() 
needed it to be already enabled, because listening in proxy mode
requires it; however, it's conf_apply() that opens pidfiles,
so it resulted in port being enabled before pidfile was opened.
This was not so bad, but it was also disabled when pidfile couldn't
be opened due to ctld already running; this means that starting
second ctld instance screwed up the first.

Sponsored by:	The FreeBSD Foundation
 2014-04-16 10:43:12 +00:00
trasz
9f88148032 Properly identify target portal when running in proxy mode. While here, 
remove CTL_ISCSI_CLOSE, it wasn't used or implemented anyway.

Sponsored by:	The FreeBSD Foundation
 2014-04-16 10:29:34 +00:00
trasz
6886f6fa4f Make it possible for the iSCSI target side to operate in both normal 
and ICL_KERNEL_PROXY mode, and fix some bit rot so the latter actually
works again.

Sponsored by:	The FreeBSD Foundation
 2014-04-16 10:06:37 +00:00
trasz
16b4ecc28d Stop treating LUN 0 as mandatory. There is no reason to do that. 
Suggested by:	mav@
MFC after:	1 month
Sponsored by:	The FreeBSD Foundation
 2014-04-15 14:55:56 +00:00
trasz
f1f4cd9f22 Make the error message more clear. 
Sponsored by:	The FreeBSD Foundation
 2014-03-19 13:00:44 +00:00
rwatson
a400e9c007 Update most userspace consumers of capability.h to use capsicum.h instead. 
auditdistd is not updated as I will make the change upstream and then do a
vendor import sometime in the next week or two.

MFC after:	3 weeks
 2014-03-16 11:04:44 +00:00
trasz
22da121a75 Make the debug messages during ctld(8) shutdown less confusing. 
Sponsored by:	The FreeBSD Foundation
 2014-02-11 11:38:44 +00:00
trasz
e1b3e5b339 Show proper configuration file line numbers in error messages. 
Sponsored by:	The FreeBSD Foundation
 2014-02-11 11:37:49 +00:00
trasz
a0a9d5e257 Make ctld error out on invalid characters in ctl.conf. 
Sponsored by:	The FreeBSD Foundation
 2014-02-11 11:36:15 +00:00
trasz
7ca282e9cb Improve error reporting. 
Sponsored by:	The FreeBSD Foundation
 2014-02-11 11:35:26 +00:00
trasz
35478760f6 So, it turns out SIGCHLD is discarded by default, so we have to set up 
a dummy handler to make it interrupt an ioctl(2) or select(2).

This makes those short-lived ctld(8) zombies disappear.

Sponsored by:	The FreeBSD Foundation
 2014-02-11 11:33:44 +00:00
trasz
d223366773 Use new auth-type "deny" instead of using "chap" with no chap entries; 
it's cleaner this way, and gives better feedback to the user.

Sponsored by:	The FreeBSD Foundation
 2014-02-11 11:32:36 +00:00
trasz
7f7fd0dbc0 Use "default" as default discovery-auth-group, instead of "no-access". 
It doesn't change visible behaviour, as previously auth-group "default"
wasn't redefinable, so by default access was always denied.

Sponsored by:	The FreeBSD Foundation
 2014-02-11 11:31:08 +00:00
trasz
87a841d29a Update manual page to match recent auth-group "default" changes. 
Sponsored by:	The FreeBSD Foundation
 2014-02-11 11:29:58 +00:00
trasz
e4d2947104 Add a new auth-group "default", defaulting to deny, and make it possible 
to redefine it.  From now on, assigning auth-group to a target is no longer
mandatory.

Sponsored by:	The FreeBSD Foundation
 2014-02-11 11:29:05 +00:00
trasz
7dbe2512bb Make it possible to redefine portal-group "default". 
Sponsored by:	The FreeBSD Foundation
 2014-02-11 11:27:25 +00:00
trasz
f5f5c39110 Add auth-type. 
Sponsored by:	The FreeBSD Foundation
 2014-02-11 11:26:05 +00:00
trasz
e8652707f0 Rename a variable, no functional changes. 
Sponsored by:	The FreeBSD Foundation
 2014-02-11 11:14:50 +00:00
trasz
5f228e3b08 Yacc cleanup; no functional changes. 
Sponsored by:	The FreeBSD Foundation
 2014-02-11 11:11:37 +00:00
trasz
760495fbd7 Make function ordering slightly more logical; no functional changes. 
Sponsored by:	The FreeBSD Foundation
 2014-02-11 11:10:01 +00:00
trasz
fec3636fbd Implement initiator-name and initiator-portal restrictions. 
Sponsored by:	The FreeBSD Foundation
 2014-02-11 11:08:04 +00:00
trasz
b84432b20c Daemonize after applying configuration, not before, so that 
any problems - including "daemon already running" - are visible
on the terminal and not just in logs.

Sponsored by:	The FreeBSD Foundation
 2014-02-11 10:59:57 +00:00
trasz
e4b6e911a2 Empty data segment during Login Phase is rather unlikely, but it's 
not, by itself, a protocol error.  This fixes interoperability with
OpenBSD initiator.

Sponsored by:	The FreeBSD Foundation
 2014-02-11 10:58:32 +00:00
trasz
1d16ec7cee The log_whatever() routines don't accept NULL for format strings, 
so mark them as __printflike instead of__printf0like.

Sponsored by:	The FreeBSD Foundation
 2014-02-11 10:56:43 +00:00
trasz
f0306f793f Improve check for duplicated paths. It shows the warning twice for 
every path (once for each duplicate found), but it should do for now.

Sponsored by:	The FreeBSD Foundation
 2014-02-11 10:55:32 +00:00
trasz
942aab7c51 Refactor. 
Sponsored by:	The FreeBSD Foundation
 2014-02-11 10:53:08 +00:00
trasz
9e76667e13 Fix handling for empty auth-groups. Without it, ctld child process 
would either exit on assertion, or, if assertions are not enabled,
fail to authenticate the target.

MFC after:	2 days
Sponsored by:	The FreeBSD Foundation
 2013-12-10 17:27:11 +00:00
trasz
6149217d80 Grammar fix. 
MFC after:	3 days
Sponsored by:	The FreeBSD Foundation
 2013-12-02 09:47:22 +00:00
trasz
e3b2accfd9 Fix typos. 
MFC after:	3 days
Sponsored by:	The FreeBSD Foundation
 2013-12-02 09:23:34 +00:00
trasz
c5a7ee0968 Fix typo. 
Submitted by:	feld@
MFC after:	3 days
Sponsored by:	The FreeBSD Foundation
 2013-11-10 13:16:28 +00:00
trasz
33f6245f1b Plug memory leaks. 
Coverity CID:	1087993, 1087992
Approved by:	re (marius)
Sponsored by:	FreeBSD Foundation
 2013-10-09 13:28:45 +00:00
trasz
05bb4f6fbc Fix off-by-one. 
Coverity CID:	1011375
Approved by:	re (glebius)
Sponsored by:	FreeBSD Foundation
 2013-10-09 12:17:40 +00:00
trasz
84d8bf623b Fix several problems in the new iSCSI stack; this includes interoperability 
fix for LIO (Linux target), removing possibility for the target to avoid mutual
CHAP by choosing to skip authentication altogether, and fixing truncated error
messages in iscsictl(8) output.  This also fixes several of the problems found
with Coverity.

Note that this change requires world rebuild.

Coverity CID:	1088038, 1087998, 1087990, 1088004, 1088044, 1088041, 1088040
Approved by:	re (blanket)
Sponsored by:	FreeBSD Foundation
 2013-09-18 21:15:21 +00:00
trasz
2320759748 Make iscsictl(8) automatically try to load the iscsi module. While here, 
improve module loading in iscsid(8) and ctld(8).

Approved by:	re (delphij)
 2013-09-18 08:37:14 +00:00
joel
44f767ab70 Minor mdoc fixes. 
Approved by:	re (blanket)
 2013-09-14 21:43:18 +00:00
trasz
a992abf041 Bring in the new iSCSI target and initiator. 
Reviewed by:	ken (parts)
Approved by:	re (delphij)
Sponsored by:	FreeBSD Foundation
 2013-09-14 15:29:06 +00:00