d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
165,111 Commits 4 Branches 49 Tags
Commit Graph

165111 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
edwin
9f84f21465 When there is a problem with writing, also bail out. 
Found with the clang checker.
 2010-06-05 12:49:39 +00:00
edwin
b69bd66456 Make clang happier by removing unused assignments. 2010-06-05 12:31:08 +00:00
edwin
8ba0b1c6aa Fix warnings about uninitialized variables. 
It was mostly harmless since strftime() only used %a and %b anyway.

Found with:   Coverity Prevent(tm)
CID:          7769
 2010-06-05 11:41:46 +00:00
edwin
4648b36108 Fix: when unable to parse the sequence string, erase everything. 
Found with:   Coverity Prevent(tm)
CID:          7888
 2010-06-05 11:32:31 +00:00
edwin
387baf087f Fix memory-leak at the processing of multiple calendars. 
Found with:   Coverity Prevent(tm)
CID:          7085
 2010-06-05 11:12:35 +00:00
edwin
81217ca03a Properly check the return value of chdir, even if it is a "this 
should not happen" case.

Found with:   Coverity Prevent(tm)
CID:          4932
 2010-06-05 11:06:56 +00:00
mav
ae16fdcca7 Remove some dead and incorrect code. 
Found with:   Coverity Prevent(tm)
CID:          4562
 2010-06-05 10:16:23 +00:00
mav
ced689a069 Add allocation error hadling. 
Found with:   Coverity Prevent(tm)
CID:          3897
 2010-06-05 09:31:13 +00:00
mav
505be0fb99 Fix possible use after free. 
Found with:   Coverity Prevent(tm)
CID:          4634
 2010-06-05 08:58:03 +00:00
trasz
0bb05a5f0f Don't try to copy a socket after "xxx is a socket (not copied)." message. 
Previously, it would either try to copy it anyway and fail (without -R),
or create fifo instead of the socket (with -R).

Found with:	Coverity Prevent
CID:		5623
MFC after:	2 weeks
 2010-06-05 08:50:39 +00:00
mav
0f3a1006c2 Fix use after free on error. 
Found with:   Coverity Prevent(tm)
CID:          4722
 2010-06-05 08:44:40 +00:00
mav
508015d598 Fix double free on error. 
Found with:   Coverity Prevent(tm)
CID:          4573
 2010-06-05 08:36:37 +00:00
mav
facac1187d Plug memory leak to silent Coverity. Error is still not really handled. 
Found with:   Coverity Prevent(tm)
CID:          4137
 2010-06-05 08:21:18 +00:00
mav
ade9ce1cf5 Plug memory leak to silent Coverity. Error is still not really handled. 
Found with:   Coverity Prevent(tm)
CID:          4196
 2010-06-05 08:16:21 +00:00
mav
ba504a17ee Fix attach errors handling. 
Found with:   Coverity Prevent(tm)
CID:          3477
 2010-06-05 08:14:19 +00:00
trasz
e949899e57 Plug resource leak. 
Found with:	Coverity Prevent
CID:		7040
 2010-06-05 08:11:11 +00:00
mav
265a7f94f2 Plug memory leak to silent Coverity. Error is still not really handled. 
Found with:   Coverity Prevent(tm)
CID:          4130
 2010-06-05 08:07:54 +00:00
mav
d49dd00196 Fix attach errors handling. 
Found with:   Coverity Prevent(tm)
CID:          3424
 2010-06-05 08:02:19 +00:00
trasz
b0cd47b602 Make sure not to pass NULL to g_orphan_provider(). 
Found with:	Coverity Prevent
CID:		3411
 2010-06-05 08:00:52 +00:00
trasz
46a01349e9 Don't use pointer to 64 bit value (id_t) to point to 32 bit value (uid_t). 
Found with:	Coverity Prevent
CID:		7466, 7467
MFC after:	2 weeks
 2010-06-05 07:40:32 +00:00
alc
cf537cadd5 Don't set PG_WRITEABLE in pmap_enter() unless the page is managed. 2010-06-05 06:56:06 +00:00
mjacob
bcf3a93c49 Make the internal target > SPC2 (so REPORT LUNS can be tested). 
Give the NIL inquiry data real values other than just plain 0x7f
in the first byte.

MFC after:	2 weeks
 2010-06-05 00:56:15 +00:00
mjacob
b471c2cbb2 I was getting panics in sleepq_add for the second sleep in isp_kthread. 
I don't know why- but it occurred to me in looking at the second sleep
is that all I want is a pause- not an actual sleep. So do that instead.

MFC after:	2 weeks
 2010-06-05 00:55:21 +00:00
mdf
624cd0ffbf - Add myself to committers-src.dot 
- Add myself to calendar.freebsd

Approved by:	zml (mentor)
 2010-06-04 17:54:30 +00:00
yongari
85ef5a9b82 Don't blindly set IFF_DRV_OACTIVE when sge_encap() fails. If there 
is no queued frame, IFF_DRV_OACTIVE would never be cleared.

Submitted by:	Nikolay Denev < ndenev <> gmail at com >
MFC after:	4 days
 2010-06-04 17:11:33 +00:00
cperciva
4adc6d09d8 Declare ip6 as (struct in6_addr *) instead of (struct in_addr *). This is 
a harmless bug since we never actually use ip6 as anything other than an
opaque pointer.

Found with:	Coverty Prevent(tm)
CID:		4319
MFC after:	1 month
 2010-06-04 14:38:24 +00:00
maxim
03bbab0211 o The typo was intended as it stated in the comment. Revert last. 
Spotted by:	dfr
 2010-06-04 14:22:49 +00:00
avg
0dfde2cbbd scsi_cd: pass correct pointer to free() 
Found with:	Coverity Prevent(tm)
CID:		2986
MFC after:	4 days
 2010-06-04 13:55:55 +00:00
maxim
aa2a5c4ca5 o Makefile BSDfication. 
PR:		misc/147461 (with my changes)
Submitted by:	Erik Cederstrand
 2010-06-04 08:19:43 +00:00
maxim
34798567b5 o Fix typo: .uudef -> .undef. 
PR:		misc/147462
Submitted by:	Erik Cederstrand
 2010-06-04 08:14:30 +00:00
mav
d08eeebaec Fix PCH chipset IDs. They are 0x3bxx, not 0x3axx. 
Pointy hat to:	me
 2010-06-04 07:35:59 +00:00
brian
bf8440aa76 Explain that setting an absolute day value can fail and that the month should 
usually be set first when using -v.

Adjust an example that sets the day to 30 before setting the month to 3 in
accordance with this approach as the example would always fail in February!

PR:		147354
MFC after:	2 weeks
 2010-06-04 06:56:58 +00:00
jchandra
e9a1a12ab4 Make vm_contig_grow_cache() extern, and use it when vm_phys_alloc_contig() 
fails to allocate MIPS page table pages.  The current usage of VM_WAIT in
case of vm_phys_alloc_contig() failure is not correct, because:

"There is no guarantee that any of the available free (or cached) pages
after the VM_WAIT will fall within the range of suitable physical
addresses.  Every time this function sleeps and a single page is freed
(or cached) by someone else, this function will be reawakened.  With
a little bad luck, you could spin indefinitely."

We also add low and high parameters to vm_contig_grow_cache() and
vm_contig_launder() so that we restrict vm_contig_launder() to the range
of pages we are interested in.

Reported by: alc

Reviewed by:	alc
Approved by:	rrs (mentor)
 2010-06-04 06:35:36 +00:00
ae
152e4bab37 - Add myself to committers-src.dot 
- Add myself to calendar.freebsd

Approved by:	kib (mentor)
 2010-06-03 21:12:51 +00:00
trasz
c476826d40 Make chown(1) emit more useful error message when user/group name is invalid. 2010-06-03 20:46:23 +00:00
kib
06a4e12f93 Do not leak vm page lock in vm_contig_launder(), vm_pageout_page_lock() 
always returns with the page locked.

Submitted by:	alc
Pointy hat to:	kib
 2010-06-03 18:34:34 +00:00
ed
294b044a4b Use -Wl,-N instead of the undocumented -N option for GCC. 
GCC forwards the -N flag directly to ld. This flag is not documented and
not supported by (for example) Clang. Just use -Wl,-N.

Submitted by:	Pawel Worach
 2010-06-03 17:42:32 +00:00
jhb
16dab63fe9 Assert that the thread lock is held in sched_pctcpu() instead of 
recursively acquiring it.  All of the current callers already hold the
lock.

MFC after:	1 month
 2010-06-03 16:02:11 +00:00
trasz
7c23796624 Don't forget to free the string in error case. 
Found with:	Coverity Prevent
CID:		6585
 2010-06-03 14:51:29 +00:00
trasz
307713b0cf _posix1e_acl_sort() never returns anything other than 0; change its 
return type to void and update callers.  This simplifies code and
fixes one place where the returned value was not actually checked.

Found with:	Coverity Prevent
CID:		4791
 2010-06-03 14:29:17 +00:00
trasz
26f044985f Fix usage of uninitialized variable. 
Found with:	Coverity Prevent
CID:		7517
MFC after:	2 weeks
 2010-06-03 14:27:18 +00:00
trasz
45e71b2250 The 'acl_cnt' field is unsigned; no point in checking if it's >= 0. 
Found with:	Coverity Prevent
CID:		6192
 2010-06-03 14:16:58 +00:00
trasz
0463f9931f The 'acl_cnt' field is unsigned; no point in checking if it's >= 0. 
Found with:	Coverity Prevent
CID:		6193
 2010-06-03 14:15:08 +00:00
trasz
253bf0319d The 'acl_cnt' field is unsigned; no point in checking if it's >= 0. 
Found with:	Coverity Prevent
CID:		3688
 2010-06-03 13:45:27 +00:00
trasz
9985f972fd The 'acl_cnt' field is unsigned; no point in checking if it's >= 0. 
Found with:	Coverity Prevent
CID:		3684
 2010-06-03 13:43:58 +00:00
trasz
cbfca8b888 The acl_cnt field is unsigned; no point in checking if it's >= 0. 
Found with:	Coverity Prevent
CID:		3683
 2010-06-03 13:41:55 +00:00
marius
37567a7281 - Mention that VTOC8 labels are found in Fujitsu SPARC64 machines as well. 
- Add information regarding VTOC8 bootrstrap code and how it's handled with
  r208777 in place.
- Document the mapping of partition types to VTOC8 tags.
- Add examples for VTOC8 to the respective section.
- Eliminated hard sentence breaks.

Reviewed by:	marcel (slightly buggy version)
MFC after:	3 days
 2010-06-03 13:04:56 +00:00
marius
2972c267be - In gpart_bootfile_read() fix an off-by-one error preventing the bootstrap 
file to be of maximum size.
- Add special handling required for SMI/VTOC8 disklabel partcode, i.e. avoid
  overwriting the label when writing the bootstrap code to the partition
  starting at 0 and install it to all partitions when the -i option is omitted
  just like geom_sunlabel(4) and sunlabel(8) do by default.
- Add missing prototypes.
- Add const where applicable.

Reviewed by:	marcel
MFC after:	3 days
 2010-06-03 13:01:55 +00:00
marius
14260af9f9 Avoid possible NULL-dereferences. 
Found with:	Coverity Prevent(tm)
CID:		3428
MFC after:	3 days
 2010-06-03 12:09:02 +00:00
mm
df50b677c0 Fix freeing space after deleting large files with holes. 
OpenSolaris onnv revision:	9950:78fc41aa9bc5

Approved by:	pjd, delphij (mentor)
Obtained from:	OpenSolaris (Bug ID 6792701)
MFC after:	3 days
 2010-06-03 11:08:46 +00:00