Commit Graph

121643 Commits

Author SHA1 Message Date
rwatson
2ad9f38f26 Replace strncpy() with strlcpy() when parsing login time limit strings
from /etc/login.conf, or an unterminated string buffer could result.
Probably, login_times.c should reject excessively long time strings as
unparseable, rather than truncating, which might render an invalid
string valid.

Found with:	Coverity Prevent (tm)
Reviewed by:	csjp
MFC after:	3 days
2006-01-16 00:52:20 +00:00
rwatson
0254c18ba2 Remove unnecessary and undesirable 'static' from function-local keg
list, which could cause problems for multi-threaded applications
using libmemstat to monitor UMA in more than one thread
simultaneously.

MFC after:	3 days
2006-01-16 00:37:20 +00:00
marcel
7a98306144 Define NO_TLS on ia64. The dynamic TLS implementation on ia64 is
broken for non-threaded shared processes in that __tls_get_addr()
assumes the thread pointer is always initialized. This is not the
case. When arenas_map is referenced in choose_arena() and it is
defined as a thread-local variable, it will result in a SIGSEGV.

PR: ia64/91846 (describes the TLS/ia64 bug).
2006-01-16 00:32:46 +00:00
rwatson
b4fd2a3c90 Fix typo in comment.
MFC after:	3 days
2006-01-16 00:28:11 +00:00
ceri
e99c7472a9 Add ntp.cgi.cz.
PR:		bin/90095
Submitted by:	Jakub Chromy <hicks at cgi dott cz>
Approved by:	jhb (proxy mentor)
MFC after:	3 days
2006-01-15 23:15:41 +00:00
ceri
a415f589c8 Marius Nuennerich pointed out that nextboot(8) configured boot options
were now sticky.  This script was deleting /boot/nextkernel on boot, but
there is no code in the tree that creates that file since revision 1.15
of src/sbin/reboot/reboot.c.
nextboot(8) creates /boot/nextboot.conf, so remove that instead.

Approved by:	jhb (proxy mentor)
MFC after:	1 week
2006-01-15 23:12:26 +00:00
ceri
022ec5bd3c Preserve any additional arguments to ifconfig that were specified in the
DHCP case too.

PR:		bin/74406
Approved by:	jhb (proxy mentor)
MFC after:	3 days
2006-01-15 23:00:07 +00:00
ceri
a11fe8f43e If sysinstall was used to configure an anonymous FTP area, it was
possible for information to be copied from the group file to the group
file in the FTP area.  This patch based on a patch from Zak Johnson
<zakj at nox dot cx>.

PR:		bin/25851
Submitted by:	Ted Mittelstaedt <tedm at toybox punkt placo period com>
Approved by:	jhb (proxy mentor)
MFC after:	3 days
MFC to:		RELENG_5, RELENG_6
Security:	Prevents possible group information leakage
2006-01-15 22:57:17 +00:00
ceri
676a8bba52 Correct obsolete chown syntax.
PR:		bin/90057
Submitted by:	Charlie M. McDonald <BoredOutkast at yahoo punkt com>
Approved by:	jhb (mentor by proxy)
MFC to:		RELENG_5, RELENG_6
MFC After:	3 days
2006-01-15 22:42:38 +00:00
imp
7be11cb1d9 Happy new year, a little late 2006-01-15 22:06:10 +00:00
iedowse
08f12da89e Work around a problem seen on VIA EHCI controllers where occasionally
an interrupt appears to occur before the transfer has been marked
as completed. This caused umass transfers to get stuck, especially
when writing large files. The workaround sets up a timer that
rechecks for missed completed transfers if some operations are still
pending. Other suggested workarounds, such as performing a PCI read
immediately after acknowledging the interrupts, do not appear to
help.

Obtained from:	OpenBSD
2006-01-15 21:03:19 +00:00
iedowse
057cec0ceb Set sc_dying to 1 when detaching. In NetBSD and OpenBSD this was
done by the DVACT_DEACTIVATE case in *hci_activate(), but we don't
use that code in FreeBSD so it was never set.
2006-01-15 20:41:04 +00:00
iedowse
fa768cddb0 The ehci driver doesn't use the transfer `hcpriv' field, so don't
bother setting it to NULL in ehci_root_ctrl_done().
2006-01-15 20:32:52 +00:00
csjp
4c05286a61 Validate that the supplied file is not empty before trying mmap(2) it
and access the pages associated with it.

Submitted by:	Wojciech A. Koszek
PR:		bin/91411
MFC after:	1 week
2006-01-15 20:30:13 +00:00
csjp
4f56714639 vfs_busy can only return something useful if MNTK_UNMOUNT has been set.
Since we are using vfs_busy() on a freshly allocated mount structure, use
(void) to show that we do not care about the return value.

Found with:	Coverity Prevent (tm)
MFC after:	2 weeks
2006-01-15 20:14:11 +00:00
rwatson
04dec30982 Cast VFS_STATFS() in vfs_domount() to (void) to indicate that ignoring the
return value is intentional: this is simply an attempt to pre-cache the
statfs state.

Found with:	Coverity Prevent (tm)
MFC after:	3 days
2006-01-15 20:01:05 +00:00
ru
938be08b69 Fix an off-by-one bug.
Submitted by:	Ulrich Spoerlein
2006-01-15 19:17:13 +00:00
rwatson
ea56477c5e Modify the IP fragment reassembly code so that it uses a new UMA zone,
ipq_zone, to allocate fragment headers from, rather than using cast mbuf
storage.  This was one of the few remaining uses of mbuf storage for
local data structures that relied on dtom().  Implement the resource
limit on ipq's using UMA zone limits, but preserve current sysctl
semantics using a sysctl proc.

MFC after:	3 weeks
2006-01-15 18:58:21 +00:00
brueffer
602aa13ac2 Bump date for previous commit before ru can hit me with his mdoc-stick. 2006-01-15 18:40:52 +00:00
brueffer
ac1b59fb6d Mention the fire screensaver.
Submitted by:	rionda
2006-01-15 18:30:40 +00:00
rwatson
f5d75ace11 Staticize ipqlock, since it is local to ip_input.c.
MFC after:	3 days
2006-01-15 17:05:48 +00:00
rwatson
a447e5c6e2 Don't leak mbufs and mbuf clusters in several error-handling situations
in the if_an receive routine.

Found with:	Coverity Prevent (tm)
MFC after:	1 week
2006-01-15 12:09:03 +00:00
rwatson
428bff839a If frame length is excessive, don't leak an mbuf and cluster when
abandoning processing.

Found with:	Coverity Prevent (tm)
MFC after:	1 week
2006-01-15 12:06:09 +00:00
imp
f3be6cf764 I don't believe these are used at all, and can be safely removed 2006-01-15 06:49:28 +00:00
imp
d0c0ffbbce Add support for the Compaq LTE docking station. It includes a plug
and play device with the ID of PNP8160.  Sotr them while I'm here.

Submitted by:	Sean Shapira    sds at jazzie dotty com
MFC After: 1 week
2006-01-15 04:10:47 +00:00
rwatson
22ae7554fa Rename uid and gid arguments to vaccess() prototype to match vaccess()
implementation in vfs_subr.c.  No functional change.

MFC after:	3 days
2006-01-15 02:01:51 +00:00
csjp
ef078951d6 Initialize ki to p->p_aioinfo after we know it's going to be referencing
a valid kaioinfo structure. This avoids a potential NULL pointer dereference.

Found with:	Coverity Prevent(tm)
MFC after:	2 weeks
2006-01-15 01:55:45 +00:00
bz
68b7569e60 Remove unused code.
Found with:	Coverity Prevent(tm)
2006-01-15 01:39:01 +00:00
csjp
d7fc1b7da4 Fix potential overrun of static stack allocated array which stores
the rules. If an array is N elements large, we can only access
elements 0..(N-1).

MFC after:	1 week
Found with:	Coverity Prevent(tm)
2006-01-15 01:02:20 +00:00
flz
a09ac92281 I missed a whitespace in the generated commit message.
Approved by:	ssouhlal (implicit)
2006-01-15 01:01:46 +00:00
ariff
dcf12cc171 Add another inverted EAPD quirk for Gateway 7326GZ.
Tested by:	Jeff Cross <jeff.cross at averageadmins.com>
MFC after:	3 days
2006-01-14 23:37:08 +00:00
mlaier
b96a262dce Move m_adj after checking that m_dup succeeded.
Found with:	Coverity Prevent(tm)
MFC after:	3 days
2006-01-14 22:19:17 +00:00
glebius
0b544658fc Initialize variable.
Found with:	Coverity Prevent(tm)
2006-01-14 21:49:31 +00:00
glebius
60e9860657 Make code simplier fixing memory leak.
Found with:	Coverity Prevent(tm)
2006-01-14 21:28:30 +00:00
ru
729a1ef9f4 Don't pollute output when "make" is run with -s.
Approved by:	kan
2006-01-14 20:48:50 +00:00
ru
af650f8533 AMD64 also supports disk slices. 2006-01-14 20:47:11 +00:00
ru
0cba5143c7 Ignore spurious '\0' first character read on a serial console.
This allows me to "boot -a" over a serial console.  Tested on
several machines.
2006-01-14 20:45:02 +00:00
scottl
2fb685782c Check the return value of copyin.
Found by: Coverity Prevent (tm)
2006-01-14 17:59:28 +00:00
brooks
8378b93876 When SC_DISABLE_KDBKEY or SC_DISABLE_REBOOT are not defined allow the
same behavior to be controlled by the sysctls, hw.syscons.kbd_kbdkey
and hw.syscons.kbd_reboot respectively.

Apologies to the submitter for taking so long to commit this simple
change.

PR:		kern/72728
Submitted by:	Luca Morettoni <morettoni at libero dot it>
MFC After:	3 days
2006-01-14 17:57:17 +00:00
scottl
cb60aeaf06 Don't base the number of jumbo segments on page size, instead base it on the
fact that jumbo desriptors are defined to have 3 segments.

Found by: Coverity Prevent(tm)
2006-01-14 17:42:22 +00:00
scottl
ec415604ac Free the newtag if we exit with a failure from alloc_bounce_zone().
Found by: Coverity Prevent(tm)
2006-01-14 17:22:47 +00:00
gnn
33105fb85b Check the correct TTL in both the IPv6 and IPv4 cases.
Submitted by:	glebius
Reviewed by:	gnn, bz
Found with:     Coverity Prevent(tm)
2006-01-14 16:39:31 +00:00
scottl
801f6ef27b Don't allocate an asr_ccb in asr_attach, it hasn't been needed for years. 2006-01-14 16:01:01 +00:00
scottl
13ebfcda1c Replace bogus code with real code. 2006-01-14 15:59:54 +00:00
scottl
55c9e2ca5f Rename driver_t variables. Use device_printf() instead of homerolled printf.
Use the provided softc instead of rolling our own.
2006-01-14 15:51:42 +00:00
bz
0b25aee5f4 The LinkSys EG1032 is supported by re(4) not nge(4) [1].
I couldn't find the ID for the EG1064 anywhere in our sources
so I removed the reference for now.

Pointed out by:	Robert Huff <roberthuffi at rcn dot com> [1]
Reviewed by:	simon
2006-01-14 15:35:21 +00:00
mjacob
c70a5f4668 Incorporate the O_NONBLOCK open semantics of Linux and Solaris. This allows
an application to upon a tape (yea, even the non-control device) even if
it cannot establish a mount session. If the open cannot establish a mount
session and O_NONBLOCK was specified, the tape becomes 'open pending mount'.
All I/O operations that would require access to a tape thereafter until
a close attempt to initiate the mount session. If the mount session succeeds,
the tape driver transitions to full open state, else returns an appropriate
I/O error (ENXIO).

At the same time, add a change that remembers whether tape is being opened
read-only. If so, disallow 'write' operations like writing filemarks that
bypass the normal read-only filtering operations that happen in the write(2)
syscall.

Reviewed by:	ken, justin, grog
MFC after:	2 weeks
Suggested by:	The Bacula Team
2006-01-14 14:32:41 +00:00
glebius
906a70beb3 Remove dead code.
Found with:	Coverity Prevent(tm)
2006-01-14 14:17:27 +00:00
joel
48240df74c - Add comments about snd_au88x0.
-  Clarify that snd_audiocs is for sparc64 only.
-  Expand snd_ich and snd_t4dwave comments.

Reviewed by:	ariff
2006-01-14 13:22:12 +00:00
glebius
b2c3d92e40 UMA can return NULL not only in case when our zone is full, but
also in case of generic memory shortage. In the latter case we may
not find an old entry.

Found with:	Coverity Prevent(tm)
2006-01-14 13:04:08 +00:00