Commit Graph

8545 Commits

Author SHA1 Message Date
glebius
a64dcf26c8 No need to run buildworld before generate-release.sh. 2012-01-14 18:16:10 +00:00
ed
1d219ec710 Regenerate src.conf(5). 2012-01-13 15:43:01 +00:00
rea
c797a8475b rc.d: document 'quiet' prefix and fix dhclient/devd interaction
Document the current semantics of the 'quiet' command prefix
in the rc.subr(8).

Fix dhclient rc.d script: it should not call err() for
non-DHCP-enabled interface when it is called from devd, because the
latter just blindly calls 'service dhclient quietstart' on each "link
up" event.

Since the 'quietstart' will silence the message "Cannot 'start' <foo>.
Set <foo>_enable to YES in /etc/rc.conf or use 'onestart' instead of
'start'." and running dhclient on the non-DHCP-enabled interface is
the same thing as running the service <foo> without <foo>_enable set,
such modification is in sync with the current semantics of the 'quiet'
prefix.

Approved by: glebius
Reviewed by: freebsd-rc list
MFC after:	2 weeks
2012-01-12 06:48:11 +00:00
melifaro
0730e7f5be Add setsockopt(2) example to ng_ksocket(4).
While here, fix formatting a bit

Approved by:     kib(mentor)
MFC after:       2 weeks
2012-01-10 12:45:24 +00:00
uqs
a6fa5fdce7 Apply Typo-B-Gone 2000 [TM] 2012-01-05 21:43:33 +00:00
uqs
962d9f7018 Pull up vendor changes to mdoc(7)
This switches us to using -isoC-2011 as the symbol name which is used by
groff and mdocml. It follows the change to 4 digit years as done with
IEEE Std 1003 post-1999.

MFC after:	2 weeks (groff changes only)
2012-01-05 21:36:12 +00:00
brueffer
8952a0a413 Fix typo.
MFC after:	1 week
2012-01-05 11:16:42 +00:00
ed
3e678d58aa Reimplement <tgmath.h> on top of __generic().
The macro construction used now, is almost identical to the code
provided in C11 proposal N1404. This new version doesn't seem to
introduce any regressions according to the regression test in tools/,
but still seems to malfunction with Clang on certain aspects.

The new code does work successfully with GCC 4.2, 4.6 and 4.7. With 4.7,
it also works when __generic() is implemented on top of _Generic().

Discussed with:	stefanf
2012-01-05 10:46:22 +00:00
rwatson
0494e8ff39 Add WITHOUT_CAPSICUM src.conf(5) define, which can be used to compile out
use of Capsicum by userspace applications.

MFC after:	3 weeks
Sponsored by:	Google, Inc.
2012-01-02 21:57:58 +00:00
ed
eed6691a08 Fix sloppyness in memcchr() man page.
I was considering adding it to libc as well, but last minute I thought
it would be good enough to add it to libkern exclusively. I forgot to
rename the man page and hook it up.
2012-01-01 20:59:42 +00:00
ed
5f479a9ff5 Fix typo; return -> returns. 2012-01-01 20:30:48 +00:00
ed
a201da7178 Introducing memcchr(3).
It seems two of the file system drivers we have in the tree, namely ufs
and ext3, use a function called `skpc()'. The meaning of this function
does not seem to be documented in FreeBSD, but it turns out one needs to
be a VAX programmer to understand what it does.

SPKC is an instruction on the VAX that does the opposite of memchr(). It
searches for the non-equal character. Add a new function called
memcchr() to the tree that has the following advantages over skpc():

- It has a name that makes more sense than skpc(). Just like strcspn()
  matches the complement of strspn(), memcchr() is the complement of
  memchr().

- It is faster than skpc(). Similar to our strlen() in libc, it compares
  entire words, instead of single bytes. It seems that for this routine
  this yields a sixfold performance increase on amd64.

- It has a man page.
2012-01-01 20:26:11 +00:00
lstewart
8a799f2a2f Revert r228986 until it can be reworked to avoid panicing the kernel when the
same interface is attached multiple times with different DLTs, as is done in
net80211 for example.

Reported by:	adrian
2011-12-31 07:21:28 +00:00
lstewart
1b1510811a - Introduce the net.bpf.tscfg sysctl tree and associated code so as to make one
aspect of time stamp configuration per interface rather than per BPF
  descriptor. Prior to this, the order in which BPF devices were opened and the
  per descriptor time stamp configuration settings could cause non-deterministic
  and unintended behaviour with respect to time stamping. With the new scheme, a
  BPF attached interface's tscfg sysctl entry can be set to "default", "none",
  "fast", "normal" or "external". Setting "default" means use the system default
  option (set with the net.bpf.tscfg.default sysctl), "none" means do not
  generate time stamps for tapped packets, "fast" means generate time stamps for
  tapped packets using a hz granularity system clock read, "normal" means
  generate time stamps for tapped packets using a full timecounter granularity
  system clock read and "external" (currently unimplemented) means use the time
  stamp provided with the packet from an underlying source.

- Utilise the recently introduced sysclock_getsnapshot() and
  sysclock_snap2bintime() KPIs to ensure the system clock is only read once per
  packet, regardless of the number of BPF descriptors and time stamp formats
  requested. Use the per BPF attached interface time stamp configuration to
  control if sysclock_getsnapshot() is called and whether the system clock read
  is fast or normal. The per BPF descriptor time stamp configuration is then
  used to control how the system clock snapshot is converted to a bintime by
  sysclock_snap2bintime().

- Remove all FAST related BPF descriptor flag variants. Performing a "fast"
  read of the system clock is now controlled per BPF attached interface using
  the net.bpf.tscfg sysctl tree.

- Update the bpf.4 man page.

Committed on behalf of Julien Ridoux and Darryl Veitch from the University of
Melbourne, Australia, as part of the FreeBSD Foundation funded "Feed-Forward
Clock Synchronization Algorithms" project.

For more information, see http://www.synclab.org/radclock/

In collaboration with:	Julien Ridoux (jridoux at unimelb edu au)
2011-12-30 08:57:58 +00:00
delphij
4b4e03aec0 Import the first release of HighPoint RocketRAID 27xx SAS 6Gb/s HBA card
driver.  This driver works for FreeBSD/i386 and FreeBSD/amd64 platforms.

Many thanks to HighPoint for providing this driver.

MFC after:	2 weeks
2011-12-28 23:26:58 +00:00
ed
88405d6b4d Document restriction on 32-bits and 64-bits datatypes. 2011-12-27 22:14:35 +00:00
ed
cbd2bf6e79 Add missing \.
While sorting the MLINKS by name, I forgot to re-add it.
2011-12-27 13:01:10 +00:00
ed
f175ea262c Add manual page for atomic operations. 2011-12-27 12:58:54 +00:00
jh
c2dfd4451c Follow style(9) more closely in the example. 2011-12-21 17:03:30 +00:00
mav
0517523a4f Add some more cross-references. 2011-12-20 17:44:25 +00:00
mav
dff6a31a10 Fix copy-paste typo. 2011-12-20 17:32:13 +00:00
mav
46767d49f7 Add timecounters(4) man page alike to eventtimers(4). 2011-12-20 17:10:34 +00:00
mav
49c984362d s/LAPIC/local APIC/ to closer follow Intel documents.
Submitted by:	jhb
2011-12-20 15:19:33 +00:00
mav
1eeaa2989f Remove extra "and" left from earlier version. 2011-12-20 14:12:50 +00:00
glebius
8c74bad9f3 Restore a feature that was present in 5.x and 6.x, and was cleared in
7.x, 8.x and 9.x with pf(4) imports: pfsync(4) should suppress CARP
preemption, while it is running its bulk update.

However, reimplement the feature in more elegant manner, that is
partially inspired by newer OpenBSD:

- Rename term "suppression" to "demotion", to match with OpenBSD.
- Keep a global demotion factor, that can be raised by several
  conditions, for now these are:
  - interface goes down
  - carp(4) has problems with ip_output() or ip6_output()
  - pfsync performs bulk update
- Unlike in OpenBSD the demotion factor isn't a counter, but
  is actual value added to advskew. The adjustment values for
  particular error conditions are also configurable, and their
  defaults are maximum advskew value, so a single failure bumps
  demotion to maximum. This is for POLA compatibility, and should
  satisfy most users.
- Demotion factor is a writable sysctl, so user can do
  foot shooting, if he desires to.
2011-12-20 13:53:31 +00:00
mav
7cd583b49a Add apic(4) man page, now mostly to cover its event timer functionality. 2011-12-20 13:49:52 +00:00
mav
cb7060fb00 Add eventtimers(9) man page, describing related KPIs.
Sponsored by:	iXsystems, Inc.
MFC after:	1 month
2011-12-20 11:40:22 +00:00
jhb
68a134710c Add a TASK_INITIALIZER() macro that can be used to statically
initialize a task structure.

Reviewed by:	gj
MFC after:	2 weeks
2011-12-19 18:55:13 +00:00
ru
a6ba1663e4 Fixed some of markup.
Reviewed by:	jhb
2011-12-17 06:57:35 +00:00
mav
bdf9f67646 Some formatting fixes.
Submitted by:	ru
2011-12-16 14:19:46 +00:00
glebius
27a36f6ac8 A major overhaul of the CARP implementation. The ip_carp.c was started
from scratch, copying needed functionality from the old implemenation
on demand, with a thorough review of all code. The main change is that
interface layer has been removed from the CARP. Now redundant addresses
are configured exactly on the interfaces, they run on.

The CARP configuration itself is, as before, configured and read via
SIOCSVH/SIOCGVH ioctls. A new prefix created with SIOCAIFADDR or
SIOCAIFADDR_IN6 may now be configured to a particular virtual host id,
which makes the prefix redundant.

ifconfig(8) semantics has been changed too: now one doesn't need
to clone carpXX interface, he/she should directly configure a vhid
on a Ethernet interface.

To supply vhid data from the kernel to an application the getifaddrs(8)
function had been changed to pass ifam_data with each address. [1]

The new implementation definitely closes all PRs related to carp(4)
being an interface, and may close several others. It also allows
to run a single redundant IP per interface.

Big thanks to Bjoern Zeeb for his help with inet6 part of patch, for
idea on using ifam_data and for several rounds of reviewing!

PR:		kern/117000, kern/126945, kern/126714, kern/120130, kern/117448
Reviewed by:	bz
Submitted by:	bz [1]
2011-12-16 12:16:56 +00:00
kib
b646d3f699 Document 'findstack'.
MFC after:	1 week
2011-12-16 11:52:33 +00:00
np
65b6b4fa8f Many updates to cxgbe(4)
- Device configuration via plain text config file.  Also able to operate
  when not attached to the chip as the master driver.

- Generic "work request" queue that serves as the base for both ctrl and
  ofld tx queues.

- Generic interrupt handler routine that can process any event on any
  kind of ingress queue (via a dispatch table).

- A couple of new driver ioctls.  cxgbetool can now install a firmware
  to the card ("loadfw" command) and can read the card's memory
  ("memdump" and "tcb" commands).

- Lots of assorted information within dev.t4nex.X.misc.*  This is
  primarily for debugging and won't show up in sysctl -a.

- Code to manage the L2 tables on the chip.

- Updates to cxgbe(4) man page to go with the tunables that have changed.

- Updates to the shared code in common/

- Updates to the driver-firmware interface (now at fw 1.4.16.0)

MFC after:	1 month
2011-12-16 02:09:51 +00:00
jhb
6d1299a388 Add a helper API to allow in-kernel code to map portions of shared memory
objects created by shm_open(2) into the kernel's address space.  This
provides a convenient way for creating shared memory buffers between
userland and the kernel without requiring custom character devices.
2011-12-14 22:22:19 +00:00
joel
c6a888391d Add SEE ALSO. 2011-12-14 19:48:21 +00:00
mav
93b09a6b44 After several suggestions from people, move eventtimers page from 7 to 4. 2011-12-14 15:19:40 +00:00
glebius
a4234fdf18 More MLINKS for rtalloc.9 2011-12-14 14:55:19 +00:00
glebius
3c35ef76bc Update this page to describe modern interfaces. 2011-12-14 14:52:50 +00:00
ed
145914e3e7 Change targ(4) to use cdevpriv, instead of multiple character devices.
Also update the manpage and the scsi_target example program accordingly.

Discussed on:	scsi@
Tested by:	Chuck Tuffli <chuck tuffli net>
2011-12-13 21:26:33 +00:00
ru
6487a966c8 The "inet" keyword in the "ifconfig_IF_aliasN" is mandatory for
IPv4 aliases to work since network.subr@197139.

MFC after:	3 days
2011-12-13 08:23:03 +00:00
eadler
805302f099 - Add support for ASCII art splash screens in TheDraw format
PR:		kern/143370
Submitted by:	Antony Mawer <antony@mawer.org>
Reviewed by:	gjb (doc)
Reviewed by:	des (style)
Approved by:	ed
MFC after:	1 month
2011-12-12 21:12:07 +00:00
fabient
e31b2d85e2 Add watchdog support for VIA south bridge chipset.
Tested on VT8251, VX900 but CX700, VX800, VX855 should works.

MFC after:	1 month
Sponsored by: NETASQ
2011-12-12 09:50:33 +00:00
gjb
405220fbc9 Minor whitespace cleanup to make.conf(5).
MFC after:	1 week
X-MFC-With:	228418
2011-12-11 20:01:37 +00:00
gjb
3e732791dc Document the SVN variable needs to be set in make.conf(5) when SVN_UPDATE
is set.

PR:		163162
Submitted by:	Oliver Hartmann <ohartman!zedat.fu-berlin.de>
Patch by:	Benjamin Kaduk <kaduk!mit.edu> (original)
MFC after:	1 week
2011-12-11 19:53:11 +00:00
yongari
78a31892a1 After r228293, et(4) supports altq(4). 2011-12-09 19:17:51 +00:00
jh
a274e72947 sbuf_data() hasn't returned NULL for overflowed buffers since r71721. 2011-12-09 13:28:41 +00:00
jh
e24a247476 - Fix markup.
- Remove trailing whitespace.
2011-12-09 13:15:19 +00:00
gjb
9bcc23b795 As of r226865, daily_scrub_zfs_default_threshold is 35 days; document
accordingly.

PR:		162890
Submitted by:	Oliver Hartmann (ohartman ! mail.zedat.fu-berlin.de)
Patch by:	Niclas Zeising (niclas.zeising ! gmail.com)
MFC after:	1 week
X-Need-MFC:	r226865
2011-12-08 23:58:26 +00:00
mav
f8f306b32a Mention that Cold Presence Detection feature used for hot-plug detection
when interface power management is enabled.
2011-12-06 09:12:11 +00:00
yongari
15257e476a Add more controllers that support jumbo frame. 2011-12-02 19:01:26 +00:00
mav
9be1bfa322 Add hw.ahci.force tunable to control whether AHCI drivers should attach
to known AHCI-capable chips (AMD/NVIDIA), configured for legacy emulation.

Enabled by default to get additional performance and functionality of AHCI
when it can't be enabled by BIOS. Can be disabled to honor BIOS settings if
needed for some reason.

MFC after:	1 month
2011-12-02 12:52:33 +00:00
fjoe
25bbb2595f Regen. 2011-12-02 09:28:19 +00:00
lstewart
313c864179 Add a man page describing the feed-forward clock kernel support, including how
to enable and configure the functionality.

Committed on behalf of Julien Ridoux and Darryl Veitch from the University of
Melbourne, Australia, as part of the FreeBSD Foundation funded "Feed-Forward
Clock Synchronization Algorithms" project.

For more information, see http://www.synclab.org/radclock/

Discussed with:	Julien Ridoux (jridoux at unimelb edu au)
Submitted by:	Julien Ridoux (jridoux at unimelb edu au)
2011-12-01 07:41:30 +00:00
fjoe
457df496e1 Regen. 2011-11-30 18:24:43 +00:00
dim
45cfbee432 Regenerate src.conf.5. 2011-11-28 17:58:57 +00:00
philip
f3d31009fe Only install the sfxge(4) manpage on amd64, while the driver is amd64-only.
Pointed out by:	bz
2011-11-28 16:25:27 +00:00
rwatson
b433b3878b Add an introductory Capsicum man page providing a high-level description of
its mechanisms, pointing at other pertinent man pages, and cautioning about
the experimental status of Capsicum in FreeBSD.

MFC after:	3 days
Sponsored by:	Google, Inc.
2011-11-27 19:44:15 +00:00
gjb
b62a6b0ed1 Remove a seemingly unnecessary [1] ellipsis from netmap.4.
Spotted by:	manlint [1]
2011-11-27 06:55:57 +00:00
marius
2f543fefda Deorbit the broken amd(4) (see PR 124667), which was superseded by esp(4)
as of r227006.
2011-11-25 19:29:21 +00:00
marius
c20986bc61 - Add a DEVMETHOD_END alias for KOBJMETHOD_END so that along with 'driver_t'
and DEVMETHOD() we can fully hide the explicit mention of kobj(9) from
  device drivers.
- Update the example in driver.9 to use DEVMETHOD_END.

Submitted by:	jhb
MFC after:	3 days
2011-11-22 19:31:43 +00:00
jh
62da5e13f7 Append unit number to the WMI status device name to allow attaching
multiple acpi_wmi(4) instances.

PR:		kern/162491
Reviewed by:	avg
2011-11-22 16:44:50 +00:00
miwi
a17b08b121 - Add missing usb and ucom devices
PR:		usb/160301
Submitted by:	Garrett Cooper <gcooper@ixsystems.com>
Reviewed by:	hselasky
Approved by:	hselasky, rwatson (mentor)
MFC after:	3 Days
2011-11-20 12:18:21 +00:00
kib
0683c66aa5 Update the manpage for r227697.
MFC after:	3 weeks
2011-11-19 07:52:39 +00:00
grehan
1a42b19ed0 Import virtio base, PCI front-end, and net/block/balloon drivers.
Tested on Qemu/KVM, VirtualBox, and BHyVe.

Currently built as modules-only on i386/amd64. Man pages not yet hooked
up, pending review.

Submitted by:	Bryan Venteicher  bryanv at daemoninthecloset dot org
Reviewed by:	bz
MFC after:	4 weeks or so
2011-11-18 05:43:43 +00:00
brueffer
4531804934 Some cleanup:
- Start sentences on new lines
- Mark up sysctl variables
- Use %d in sysctl variables to denote the index, as we do in other manpages
2011-11-17 17:57:35 +00:00
luigi
b97eb69f80 Bring in support for netmap, a framework for very efficient packet
I/O from userspace, capable of line rate at 10G, see

	http://info.iet.unipi.it/~luigi/netmap/

At this time I am bringing in only the generic code (sys/dev/netmap/
plus two headers under sys/net/), and some sample applications in
tools/tools/netmap. There is also a manpage in share/man/man4 [1]

In order to make use of the framework you need to build a kernel
with "device netmap", and patch individual drivers with the code
that you can find in

	sys/dev/netmap/head.diff

The file will go away as the relevant pieces are committed to
the various device drivers, which should happen in a few days
after talking to the driver maintainers.

Netmap support is available at the moment for Intel 10G and 1G
cards (ixgbe, em/lem/igb), and for the Realtek 1G card ("re").
I have partial patches for "bge" and am starting to work on "cxgbe".
Hopefully changes are trivial enough so interested third parties
can submit their patches. Interested people can contact me
for advice on how to add netmap support to specific devices.

CREDITS:
    Netmap has been developed by Luigi Rizzo and other collaborators
    at the Universita` di Pisa, and supported by EU project CHANGE
    (http://www.change-project.eu/)
    The code is distributed under a BSD Copyright.

[1] In my opinion is a bad idea to have all manpage in one directory.
  We should place kernel documentation in the same dir that contains
  the code, which would make it much simpler to keep doc and code
  in sync, reduce the clutter in share/man/ and incidentally is
  the policy used for all of userspace code.
  Makefiles and doc tools can be trivially adjusted to find the
  manpages in the relevant subdirs.
2011-11-17 12:17:39 +00:00
pjd
a3e664d830 Constify arguments for locking KPIs where possible.
This enables locking consumers to pass their own structures around as const and
be able to assert locks embedded into those structures.

Reviewed by:	ed, kib, jhb
2011-11-16 21:51:17 +00:00
pjd
f01187d1ea Constify stack argument for functions that don't modify it.
Reviewed by:	ed, kib, jhb
2011-11-16 19:06:55 +00:00
philip
d8198c572a Add the sfxge(4) device driver, providing support for 10Gb Ethernet adapters
based on Solarflare SFC9000 family controllers.  The driver supports jumbo
frames, transmit/receive checksum offload, TCP Segmentation Offload (TSO),
Large Receive Offload (LRO), VLAN checksum offload, VLAN TSO, and Receive Side
Scaling (RSS) using MSI-X interrupts.

This work was sponsored by Solarflare Communications, Inc.

My sincere thanks to Ben Hutchings for doing a lot of the hard work!

Sponsored by:	Solarflare Communications, Inc.
MFC after:	3 weeks
2011-11-16 17:11:13 +00:00
marius
4b6458192f As it turns out, r186347 actually is insufficient to avoid the use of the
curthread-accessing part of mtx_{,un}lock(9) when using a r210623-style
curthread implementation on sparc64, crashing the kernel in its early
cycles as PCPU isn't set up, yet (and can't be set up as OFW is one of the
things we need for that, which leads to a chicken-and-egg problem). What
happens is that due to the fact that the idea of r210623 actually is to
allow the compiler to cache invocations of curthread, it factors out
obtaining curthread needed for both mtx_lock(9) and mtx_unlock(9) to
before the branch based on kobj_mutex_inited when compiling the kernel
without the debugging options. So change kobj_class_compile_static(9)
to just never acquire kobj_mtx, effectively restricting it to its
documented use, and add a kobj_init_static(9) for initializing objects
using a class compiled with the former and that also avoids using mutex(9)
(and malloc(9)). Also assert in both of these functions that they are
used in their intended way only.
While at it, inline kobj_register_method() and kobj_unregister_method()
as there wasn't much point for factoring them out in the first place
and so that a reader of the code has to figure out the locking for
fewer functions missing a KOBJ_ASSERT.
Tested on powerpc{,64} by andreast.

Reviewed by:	nwhitehorn (earlier version), jhb
MFC after:	3 days
2011-11-15 20:11:03 +00:00
nwhitehorn
1db8769eb7 Further automate production release generation by naming files the right
things and generating checksums.

MFC after:	1 week
2011-11-15 18:49:27 +00:00
brueffer
f110f19836 Remove list nesting in the hardware notes section, thus making it compatible with
the hardware notes generation script.

MFC after:	3 days
2011-11-14 22:57:47 +00:00
yongari
effdb2f02f Clarify hw.ti.%d.dac tunable. 2011-11-14 22:16:12 +00:00
yongari
81c8906c6b Document newly introduced a loader tunable and sysctl variables. 2011-11-14 21:59:49 +00:00
andre
6521dad4b6 mdoc fix for r227499.
Reported by:	brueffer
2011-11-14 15:57:03 +00:00
andre
e974c1d18b Remove mention of ss_fltsz and ss_fltsz_local which were retired in r226447. 2011-11-14 15:14:42 +00:00
andre
f43f28646d Note the ip_len bug fixed in r226105 in the BUGS section. 2011-11-14 15:10:42 +00:00
brueffer
ff3a96fee1 Grammar and mdoc cleanup.
MFC after:	3 days
2011-11-12 10:17:23 +00:00
brueffer
e4b966f3b7 Reword a sentence in the HARDWARE section a little to make it more suitable
for automatic hardware notes generation.

MFC after:	3 days
2011-11-11 12:06:09 +00:00
pluknet
63c8a789c1 Sync definitions with <sys/mtio.h> header. 2011-11-10 11:17:40 +00:00
yongari
38c2b29e64 Document TI_SF_BUF_JUMBO and Xr altq. 2011-11-08 18:36:59 +00:00
yongari
680bf11700 ti(4) supports altq(4). 2011-11-08 18:35:11 +00:00
marius
dcec53dee9 Add missing comma.
Submitted by:	brueffer
2011-11-06 21:54:27 +00:00
marius
cbbd957faf Commit man page update missed in r227006. 2011-11-06 21:33:50 +00:00
brueffer
744cbe301c Add qlxgb(4).
MFC after:	3 days
2011-11-06 20:59:07 +00:00
brueffer
1e26c5740e Write QLogic consistently.
MFC after:	3 days
2011-11-06 20:37:17 +00:00
jmg
4f47980127 group functions together by function...
document knlist_delete, and better document what knlist_clear does...  Note
that both of these functions may sleep, and also unlock/relock the list
lock...

document knlist_init_mtx (forgotten by kib)...

other minor improvements

Reviewed by:	ru (previous rev)
MFC after:	1 week
2011-11-05 17:55:49 +00:00
bz
fd2aad9556 Add QLogic 10 Gigabit Ethernet & CNA Adapter Driver version 1.30
for 3200 and 8200 series cards.

Submitted by:	David C Somayajulu (david.somayajulu@qlogic.com),
		Qlogic Corporation
MFC After:	3 days
2011-11-03 21:20:22 +00:00
yongari
332e83efa6 axe(4) got VLAN over-sized frame support.
Add axe(4) to the list of interfaces that support VLAN over-sized frame.
2011-10-25 19:10:10 +00:00
yongari
4b38738773 AX88178/AX88772A/AX88772B supports VLAN over-sized frame.
Xr vlan.
2011-10-25 19:04:56 +00:00
yongari
036925291e All dc(4) controllers support VLAN over-sized frame.
Xr vlan
2011-10-24 21:01:20 +00:00
yongari
e62913d090 Add ALi/ULi M5261/M5263 to supported hardware chipets. 2011-10-24 20:57:50 +00:00
mm
87ac018dc5 Add information about static_ndp_pairs to rc.conf(5) manual page
Submitted by:	Sergey Kandaurov <pluknet@FreeBSD.org>
MFC after:	3 days
2011-10-23 10:20:31 +00:00
hrs
6989630abd Fix typos. 2011-10-23 07:38:55 +00:00
hrs
01ff83332e - Add description that IPv6 configuration will be ignored if $ifconfig_IF_ipv6
is empty.
- Move a configuration example "inet6 accept_rtadv" to just after the manual
  GUA configuration.
- Add an example of $ipv6_prefix_IF.
2011-10-23 06:34:52 +00:00
nwhitehorn
9181ea7a73 Fix missing space in SEE ALSO section.
Submitted by:	novel
2011-10-23 02:52:20 +00:00
glebius
ceb3756810 Spelling.
Submitted by:	dougb
2011-10-21 20:23:40 +00:00
glebius
885aceb259 Note that it is still not possible to guard special kind of allocations, those
that have special relationships with uma(9). Currently only mbuf clusters.
2011-10-21 13:54:17 +00:00
nwhitehorn
2cd40fe2b6 Add support for special keys (volume/brightness/eject) on Apple laptops with
ADB keyboards.

Submitted by:	Justin Hibbits <jrh29 at alumni dot cwru dot edu>
MFC after:	9.0-RELEASE
2011-10-16 21:01:42 +00:00
eadler
9d7884364e - change "is is" to "is" or "it is"
- change "the the" to "the"

Approved by:	lstewart
Approved by:	sahil (mentor)
MFC after:	3 days
2011-10-16 14:30:28 +00:00
glebius
e999aa7f37 Document that memguard(9) now can guard uma(9) allocations. 2011-10-12 18:46:48 +00:00
glebius
4b0faaa8bc Fix date in last commit.
Noticed by:	Larry Rosenman <ler lerctr.org>
2011-10-11 18:26:31 +00:00
glebius
3047071308 Properly document default number of rx/tx descriptors for Intel cards. 2011-10-11 15:41:07 +00:00
gjb
22eb5e925a Bump .Dd to reflect the date of the last content change, so MFC content
makes sense.

Pointy-hat to:		gjb (myself)
2011-10-09 20:21:07 +00:00
des
650dd4c77f Mention tdsignal(9).
MFC after:	1 week
2011-10-07 22:14:18 +00:00
obrien
4b04845b06 Disallow various debug.kdb sysctl's when securelevel is raised.
PR:	161350
2011-10-07 05:47:30 +00:00
delphij
9da6f154d2 Add the 9750 SATA+SAS 6Gb/s RAID controller card driver, tws(4). Many
thanks for their contiued support to FreeBSD.

This is version 10.80.00.003 from codeset 10.2.1 [1]

Obtained from:	LSI http://kb.lsi.com/Download16574.aspx [1]
2011-10-04 21:40:25 +00:00
gjb
51241a49ef Whitespace cleanup in build(7).
MFC after:	1 week
Need-MFC:	225858
2011-09-29 02:57:08 +00:00
gjb
6b6cf4114d Document, and provide an example for, PORTS_MODULES in build(7).
PR:		161017
Submitted by:	gcooper
MFC after:	1 week
2011-09-29 02:52:33 +00:00
pluknet
c76aaf56c6 Fix typo in OSIOCGIFADDR.
MFC after:	3 days
2011-09-27 07:05:41 +00:00
gabor
72ce933d13 - Move misplaced reference [1]
- Sort references [1]
- s/Since/Because/ [2]

Submitted by:	arundel [1],
		Chad Perrin <perrin@apotheon.com> [2]
MFC after:	3 days
2011-09-27 07:00:24 +00:00
hrs
9d87be50d4 - Document $ipv6_cpe_wanif.
- Emphasize $ipv6_enable and $ipv6_prefer are deprecated.
- Add more detail descriptions about $ipv6_activate_all_interfaces.
- Add some more examples of $ifconfig_IF_ipv6.
- rtsold(8) and rtadvd(8) can be used even when ipv6_gateway_enable=NO now.

Approved by:	re (kib)
2011-09-19 16:00:55 +00:00
lstewart
b7af600f40 Rename the cc.4 and cc.9 modular congestion control related man pages to
mod_cc.4 and mod_cc.9 respectively to avoid any possible confusion with the cc.1
gcc man page. Update references to these man pages where required.

Requested by:	Grenville Armitage
Approved by:	re (kib)
MFC after:	3 days
2011-09-15 12:15:36 +00:00
dougb
1209837866 Correct the RFC number for the description of IPv6 privacy addressing
Reviewed by:	bz
Approved by:	re (kib)
2011-09-15 09:22:49 +00:00
adrian
f23b1f625d Ensure that ta_pending doesn't overflow u_short by capping its value at USHRT_MAX.
If it overflows before the taskqueue can run, the task will be
re-added to the taskqueue and cause a loop in the task list.

Reported by:	Arnaud Lacombe <lacombar@gmail.com>
Submitted by:	Ryan Stone <rysto32@gmail.com>
Reviewed by:	jhb
Approved by:	re (kib)
MFC after:	1 day
2011-09-15 08:42:06 +00:00
kib
0edd8a1458 Document vm_page_aflag_set(9), vm_page_aflag_clear(9) and vm_page_reference(9).
Retire vm_page_flag_set() and vm_page_flag_clear() functions.

Reviewed by:	alc
Approved by:	re (bz)
2011-09-06 10:40:21 +00:00
brueffer
68e09a12b6 Wording, grammar and markup cleanup.
PR:		159948
Submitted by:	Ben Kaduk <kaduk@mit.edu>
Approved by:	re (kib)
2011-09-02 18:52:28 +00:00
brueffer
56a7a5d12f Remove an incorrect apostrophe.
PR:		160267
Submitted by:	Warren Block <wblock@wonkity.com>
Approved by:	re (kib)
MFC after:	1 week
2011-09-02 18:37:48 +00:00
rse
3eabc3bd67 Fix a little typo and get rid of a cryptic description by aligning the
text to the remaining description.

Approved by: re
2011-09-02 18:13:46 +00:00
brueffer
c2db418e2d Remove broken link to supported wifi cards. There doesn't appear to
be an equivalent list anywhere else.

PR:		157778
Submitted by:	Ted Mittelstaedt <tedm@mittelstaedt.us>
Approved by:	re (blackend)
MFC after:	1 week
2011-08-28 10:10:31 +00:00
brueffer
6e223065c4 Remove information and MLINK for MULTI_DRIVER_MODULE().
The macro was removed in r121129 almost 8 years ago.

PR:		150244
Submitted by:	Gireesh Nagabhushana <dngireesh@avrita.com>
Approved by:	re (kib)
2011-08-27 22:08:01 +00:00
jhb
904cb55f96 - Replace references to sio(4) with uart(4) instead.
- We no longer use the same data structure in as NetBSD in pucdata.c.
- ppc(4) has had a puc(4) attachment for a while now.

Approved by:	re (blackend)
MFC after:	3 days
2011-08-26 19:44:39 +00:00
brueffer
1fcff6eeb6 Fix the manpage section number, thus unbreaking the hardware notes build. (1)
Also hook up vxge(4) to the build.

Submitted by:	simon (1)
Approved by:	re (blackend)
2011-08-26 17:35:22 +00:00
attilio
53c60682f4 Fix an error in the generation of the manpage after r225177.
Sponsored by:	Sandvine Incorporated
Submitted by:	jkim
Approved by:	re (bz)
MFC after:	3 weeks
X-MFC:		r225177
2011-08-25 17:42:27 +00:00
attilio
683d7a54ce Fix a deficiency in the selinfo interface:
If a selinfo object is recorded (via selrecord()) and then it is
quickly destroyed, with the waiters missing the opportunity to awake,
at the next iteration they will find the selinfo object destroyed,
causing a PF#.

That happens because the selinfo interface has no way to drain the
waiters before to destroy the registered selinfo object. Also this
race is quite rare to get in practice, because it would require a
selrecord(), a poll request by another thread and a quick destruction
of the selrecord()'ed selinfo object.

Fix this by adding the seldrain() routine which should be called
before to destroy the selinfo objects (in order to avoid such case),
and fix the present cases where it might have already been called.
Sometimes, the context is safe enough to prevent this type of race,
like it happens in device drivers which installs selinfo objects on
poll callbacks. There, the destruction of the selinfo object happens
at driver detach time, when all the filedescriptors should be already
closed, thus there cannot be a race.
For this case, mfi(4) device driver can be set as an example, as it
implements a full correct logic for preventing this from happening.

Sponsored by:	Sandvine Incorporated
Reported by:	rstone
Tested by:	pluknet
Reviewed by:	jhb, kib
Approved by:	re (bz)
MFC after:	3 weeks
2011-08-25 15:51:54 +00:00
hselasky
727eb4fe39 Add new USB ID.
Approved by:    re (kib)
MFC after:      1 week
PR:		usb/159836
2011-08-20 14:21:32 +00:00
mav
8837eae24c Update ata(4) manual page, reflecting migration to CAM-based ATA stack
(`options ATA_CAM` enabled by default).

Approved by:	re (kib)
2011-08-17 19:43:41 +00:00
glebius
4d0a111492 Fix a couple of issues in last commit.
Submitted by:	maxim
Approved by:	re (kib)
2011-08-15 13:33:28 +00:00
glebius
eb0477f78d Describe how carp(4) status changes can be processed with
help of devd(8).

Submitted by:	"Alexander V. Chernikov" <melifaro ipfw.ru>
Approved by:	re (kib)
2011-08-15 12:08:41 +00:00
rmacklem
72d7cb1657 Change "options NFSCLIENT" to "options NFSCL" in diskless.8,
since that is now the default NFS client.
This is a content change.

Reported by:	shuvaev at physik.uni-wuerzburg.de
Approved by:	re (hrs)
2011-08-08 13:13:22 +00:00
gjb
7aff360292 Provide a more user friendly URL to the IETF site in gif(4).
Pointed out by:		dougb
MFC after:		3 days
Approved by:		re (hrs)
2011-08-02 01:48:45 +00:00
delphij
5ef08898c2 Add PCI ID for RocketRAID 4321 and 4322. A FreeNAS user have tested the
change on RocketRAID 4322.

Sponsored by:	iXsystems, Inc.
MFC after:	3 days
Approved by:	re (kib)
2011-08-01 21:12:41 +00:00
joel
3eae9025cf I've rewritten most of this file so assign the copyright to me.
Approved by:	re (kib)
2011-08-01 15:56:40 +00:00
kib
664d9b6f47 Fix markup.
Approved by:	re (hrs)
2011-08-01 08:52:05 +00:00
gjb
6ce53b0b08 Update vfs_getopt(9) to reflect 32-bit to 64-bit change from
r224290.

PR:		159324
Submitted by:	Brandon Gooch (jamesbrandongooch % gmail ! com)
Approved by:	re (kib)
2011-07-31 21:04:47 +00:00
gjb
51a24f8417 mdoc(7) fix for the pcm(4) manual
Spotted by:	manlint
Approved by:	re (kib)
2011-07-31 15:23:21 +00:00
joel
8a12085f21 Add a better description, a few examples and a couple of minor fixes.
Reviewed by:	brueffer
Approved by:	re (kib)
2011-07-30 23:09:52 +00:00
avg
188ae5a78b update smp related documentation after recent changes
Remove references to machdep.hlt_logical_cpus and
machdep.hlt_cpus sysctls and tunables.
Document machdep.hyperthreading_allowed and
hint.lapic.X.disabled tunables.

Prompted by:	ru
Proofreading:	bf
Reviewed by:	jhb
Approved by:	re (kib)
2011-07-30 20:42:14 +00:00
gjb
2f371a18c9 Fix various broken links in manual pages.
Submitted by:	Michiel Overtoom (motoom % xs4all nl)
PR:		159130 159131 159132 159133 159134
		159135 159136 159137 158138 159144
Approved by:	re (kib)
MFC after:	3 days
2011-07-23 22:55:32 +00:00
gjb
2c393993a1 Remove an extra '.It' from axe(4).
Reported by:	manlint
2011-07-15 15:56:23 +00:00
emaste
d213ff44f3 Remove note that claims pthread_set_name_np is for debugging only.
As Garrett points out,
  It is no more a debugging interface than setproctitle(3), and has not
  been since the name started getting stuffed into the kernel.  This
  statement may have made sense when the name was only visible in thread
  state dumps and the debugger.
PR:		threads/158815
Submitted by:	wollman@
2011-07-15 01:50:40 +00:00
yongari
8de1278b63 Document AX88772B and AX88760. AX88760 is treated as AX88772A in
driver.
Mention all ASIX USB controllers that are supported by axe(4).
Reword media types and explicly mention AX88178 is the only
controller that supports gigabit link.
While I'm here use shorten model instead of showing all controller
model numbers.
2011-07-14 17:34:59 +00:00
ivoras
03559906f7 Sort Xr's by number then by name
Nitpicked by: niclas zeising at gmail.com :)
2011-07-12 14:18:54 +00:00
ivoras
dbca92999e Cross reference nanobsd(8) 2011-07-10 20:15:21 +00:00
alc
89719a0968 Remove the old vm_map_clean man page. 2011-07-09 19:09:20 +00:00
alc
ddb151456e vm_map_clean() was long ago renamed to vm_map_sync(). Also, it no longer
acquires Giant.

MFC after:	1 week
2011-07-09 19:05:28 +00:00
alc
17591f511a Oops. These changes should have been included in r223891.
MFC after:	1 week
2011-07-09 18:09:57 +00:00
alc
0bfba50130 Remove manual pages for functions that no longer exist.
MFC after:	1 week
2011-07-09 18:05:27 +00:00
kib
350f61d08c Document copyin_nofault, copyout_nofault, uiomove_nofault.
Submitted by:	alc
2011-07-09 15:24:12 +00:00
mdf
d825d95c9f Add an option to have a fail point term only execute when run by a
specified pid.  This is helpful for automated testing involving a global
knob that would otherwise be executed by many other threads.

MFC after: 1 week
2011-07-08 20:41:12 +00:00
bz
9cad5bfef3 Add infrastructure to allow all frames/packets received on an interface
to be assigned to a non-default FIB instance.

You may need to recompile world or ports due to the change of struct ifnet.

Submitted by:	cjsp
Submitted by:	Alexander V. Chernikov (melifaro ipfw.ru)
		(original versions)
Reviewed by:	julian
Reviewed by:	Alexander V. Chernikov (melifaro ipfw.ru)
MFC after:	2 weeks
X-MFC:		use spare in struct ifnet
2011-07-03 12:22:02 +00:00
yongari
431ae8d898 Document two known hardware errata which requires manual link
configuration.

Submitted by:	Aries Lee (arieslee <> jmicron com)
2011-06-29 17:32:52 +00:00
glebius
448b26fea8 Document that autoSrcAddr isn't re-enabled on NGM_SHUTDOWN.
Submitted by:	Vadim Goncharov <vadim_nuclight mail.ru>
2011-06-23 10:43:36 +00:00
dougb
1175683ecd Add the netwait rc.d script. It waits for the specified period for the
network to become active.

PR:		conf/151063
Submitted by:	Jeremy Chadwick <freebsd@jdc.parodius.com>
2011-06-19 22:48:40 +00:00
dougb
7622e8e87a Add rc.d/kld to load kernel modules after local disks are up.
This method is many times faster than doing it in /boot/loader.conf.
2011-06-18 19:41:05 +00:00
bz
55526da099 Install symlinks for m_tag_* mbuf tag functions to the mbuf_tags.9 man page.
MFC after:	1 week
2011-06-18 13:08:46 +00:00
bz
c1a32a7f36 Correct a typo in the function name.
MFC after:	1 week
2011-06-18 13:03:06 +00:00
ed
93d2d762ed Regenerate src.conf.5. 2011-06-17 21:31:13 +00:00
ed
3228f6f97d Update manpage. 2011-06-17 20:49:30 +00:00
bcr
812705c73f Fix some wording and grammar in the BUGS section.
PR:             docs/157901
Submitted by:   Niclas Zeising (niclas dot zeising at gmail dot com)
Reviewed by:    mav
MFC after:      3 days
2011-06-16 19:57:07 +00:00
ru
3fa3d79859 It's a bit odd, but "make update" in src/ can also update the ports/,
doc/, and now www/ trees, but only using the "cvsup" transport.

When "make update" is run using a tree's makefile, it can also use
"cvs" (except for www/) and "svn" (only src/).

Clean up documentation and code regarding "make update":

- Increase oddness by adding support for WWWSUPFILE and NO_WWWUPDATE to
  Makefile.inc1 (analogous to PORTSSUPFILE/NO_PORTSUPDATE and
  DOCSUPFILE/NO_DOCUPDATE; WWWSUPFILE already supported by www/Makefile).

- Document all trees that support CVS_UPDATE.

- Document all trees that support SUP_UPDATE.

- Document SVN_UPDATE.

- Document NO_WWWUPDATE.

- make.conf(5) mistakenly said that *SUPFILE* had defaults.

- Add an example entry for WWWSUPFILE.
2011-06-16 12:28:37 +00:00
delphij
b13895d9ea Use .Dq instead of hardcoding `` and ''.
Suggested by:	gjb
2011-06-08 00:31:10 +00:00
delphij
f5a66a355e Add a special mount option "failok" to indicate that the administrator wants
the system to proceed to boot without bailing out into single user mode,
even when the file system can not be successfully mounted.

This option is implemented in mount(8) and not passed into kernel.

MFC after:	1 month
2011-06-07 18:48:49 +00:00
avg
effca0c019 amdsbwd: update to support SB8xx southbridges
Many thanks to Tino <tinotom@gmail.com> for drawing my attention to
this, for doing a lot of testing and providing great feedback.
Many thanks to AMD for continuing to release public specifications for
their chipsets.

PR:		kern/157568
Tested by:	Tino <tinotom@gmail.com>
MFC after:	1 week
2011-06-07 06:18:02 +00:00
jkim
165e30068e Revert r222152. The root cause was analysed and better fix is upcoming.
Discussed with:	delphij
2011-06-06 22:18:40 +00:00
avg
2406f0bc26 amdsbwd.4: fix history to reflect correct releases
Pointed out by:	ru
MFC after:	4 days
2011-06-05 19:25:30 +00:00
avg
afe8c865a6 amdsbwd.4: fix spelling of my name
Pointed out by:	ru
MFC after:	3 days
2011-06-05 19:20:39 +00:00
hselasky
e9d242e0e4 Rename recently added USB serial driver.
Suggested by:	YongHyeon PYUN
MFC after:	7 days
2011-06-04 20:40:24 +00:00
uqs
75c697f88d mdoc: reorder sections consistently 2011-06-02 09:56:53 +00:00
hselasky
3e0b323798 Add support for new USB serial driver.
Submitted by:	Lev Serebryakov, lev @
MFC after:	14 days
2011-06-01 17:58:27 +00:00
nwhitehorn
f863f8506b It is generally considered useful for release media to have kernels on them.
Submitted by:	joel
2011-05-31 12:59:15 +00:00
bcr
48c330cbba Bump document date.
I accidently committed the actual change (typo fix) in r222492, which
is a completely unrelated change.
2011-05-30 10:28:55 +00:00
bcr
9650be17d6 Add a short description about NO_CHECKSUM.
PR:		docs/155980
Submitted by	KOIE Hidetaka (koie at suri co jp)
MFC after:	7 days
2011-05-30 10:23:59 +00:00
adrian
812bf1366e Mention in ath(4) that ath_pci is required now. 2011-05-30 10:12:17 +00:00
adrian
7c45802086 Add ath_ahb and ath_pci module manpages. 2011-05-30 10:07:46 +00:00
adrian
7061cb6756 Update chipset support list for ath_hal. 2011-05-30 10:02:51 +00:00
bcr
900f95596c Mention that jumbo frame support is disabled on PCIe VT6130/VT6132
controllers because of TX MAC hangs when trying to send a frame
that is larger than 4K (see r200759).

PR:		docs/156742
Submitted by:	Michael Moll (kvedulv at kvedulv dot de)
Reviewed by:	yongari@
MFC after:	6 days
2011-05-29 11:10:56 +00:00
ru
2628ba45f7 [mdoc] Fixed .Dt call. 2011-05-25 14:13:53 +00:00
bcr
5ef0b44826 Add a description to the checksum target about not only
being able to verify, but also having the ability to
fetch distfiles that are missing or failed the checksum
calculation

PR:		docs/138887
Submitted by:	Radim Kolar (hsn at sendmail dot cz)
MFC after:	5 days
2011-05-25 08:42:01 +00:00
yongari
364291c0f2 Add 88E8075 Yukon Supreme to the list of supported hardware list. 2011-05-23 22:02:15 +00:00
imp
76fdab7152 regen 2011-05-22 18:34:11 +00:00
uqs
5179964e55 Re-encode files from ISO-8859-1 to UTF-8 2011-05-22 14:03:30 +00:00
delphij
b1c7404a29 Add a new knob to atkbd(4) to enable typematic rate detection on boot,
which is now disabled by default.  The detection is known to cause hangs
on boot with some new Lenovo laptops on FreeBSD/amd64.

Reported by:	gnn
Discussed with:	jkim
MFC after:	3 months
2011-05-20 22:36:17 +00:00
phk
ef4a112671 When adding examples to man-pages, try to make them at least
look like they might work.

Prodded by:	Vadim Goncharov
2011-05-19 13:42:19 +00:00
mav
d7d39d0277 Add support for "LED" enclosure management messages, defined by the AHCI.
When supported by hardware, this allows to control per-port activity, locate
and fault LEDs via the led(4) API for localization and status reporting
purposes. Supporting AHCI controllers may transmit that information to the
backplane controllers via SGPIO interface. Backplane controllers interpret
received statuses in some way (IBPI standard) to report them using present
indicators.
2011-05-17 22:07:45 +00:00
phk
7fd3026923 Try to explain what sbufs do and add an example to show it.
Clarify return values.
2011-05-17 18:24:59 +00:00
ru
fd38c14733 Document the supported hardware, somewhat.
Reviewed by:	hselasky
MFC after:	3 days
2011-05-17 11:26:59 +00:00
ru
6c1edccac2 Regen for WITH_OFED. 2011-05-17 11:08:15 +00:00
pluknet
610d830f36 Add missing section number for .Xr jail.
MFC after:	3 days
2011-05-17 10:38:44 +00:00
uqs
729a296915 More thorough mdoc and language fixes.
Submitted by:	ru
2011-05-17 09:51:02 +00:00
uqs
0c30f6cdaa Typo fix. 2011-05-17 08:13:10 +00:00
uqs
2170ac4266 Typos, wording and mdoc fixes. 2011-05-17 08:12:59 +00:00
brix
18b2666945 Add I2C bus driver for the AMD Geode LX series CS5536 Companion
Device.

Reviewed by:    jhb (newbus bits only), adrian
2011-05-15 14:01:23 +00:00
mav
1c89b601bc Fix few typos.
Submitted by:	uqs
MFC after:	1 week
2011-05-15 01:01:53 +00:00
attilio
96139278ce Disconnect sun4v architecture from the three.
Some files keep the SUN4V tags as a code reference, for the future,
if any rewamped sun4v support wants to be added again.

Reviewed by:	marius
Tested by:	sbruno
Approved by:	re
2011-05-14 01:53:38 +00:00
mdf
5e42f0aa77 Note that the _SWAP operation is supported for all list/queue types.
Also place STAILQ_REMOVE_HEAD in alphabetical order.  Lastly, document
the _SWAP macros.

PR:		kern/143033
MFC after:	1 week
2011-05-13 15:49:23 +00:00
ru
f35f139984 Regen. 2011-05-10 13:25:42 +00:00
kaiw
1e9a5e20c4 * Rewrite ar.5 mannual page to better document ar(1) archive format.
* Use more standard BSD license.

Obtained from:	elftoolchain
2011-05-07 10:44:08 +00:00
adrian
17241bdaa6 Add a manpage for geom_map(4).
Submitted by:	ray@dlink.ua
2011-05-05 14:43:35 +00:00
ae
882d371a36 Add make_dev_alias_p to MLINKS.
Pointed out by:	pjd
MFC after:	2 weeks
2011-05-05 14:13:08 +00:00