Commit Graph

7331 Commits

Author SHA1 Message Date
Xin LI
76628ce773 Save last displayed file by having the "last" pointer global and save it
during we show the first file's tail.  Instead of:

	tarsier% tail -f 1 2
	==> 1 <==
	foo
	bar

	==> 2 <==
	bar
	foo

	==> 2 <==
	bar2
	foo2

Now with this change, we have:

	tarsier% tail -f 1 2
	==> 1 <==
	foo
	bar

	==> 2 <==
	bar
	foo
	bar2
	foo2

While I'm there, move a comment to where it should belong to.  Also,
const'ify the "last" static because we will never need to change the
contents it points to.

MFC After:	1 week
2005-02-04 14:01:06 +00:00
Hartmut Brandt
b8900c134b None of the users of Buf_Discard used it to get rid of only a part of
the buffer. So replace Buf_Discard by Buf_Clear which just gets rid
of the entire contents.

Submitted by:	Max Okumoto <okumoto@ucsd.edu>
2005-02-04 13:34:16 +00:00
Hartmut Brandt
8e1c246001 Inline the ADDWORD() macro in the two places where it is used. It just
obfuscates the code.

Submitted by:	Max Okumoto <okumoto@ucsd.edu>
2005-02-04 13:29:50 +00:00
Hartmut Brandt
c8bd426d66 Use _exit() instead of exit() when the exec() after a vfork() fails.
Submitted by:	Max Okumoto <okumoto@ucsd.edu>
2005-02-04 13:26:37 +00:00
Hartmut Brandt
8ffb687e64 Move PrintAddr() from util.c into suff.c - the only file where it is
actuall used, and make it static.

Submitted by:	Max Okumoto <okumoto@ucsd.edu>
2005-02-04 13:23:39 +00:00
Hartmut Brandt
ce8c7083f4 General whitespace cleanup: remove mixes of tabs and spaces, remove
space after function names, remove spaces on emtpy lines.

Submitted by:	Max Okumoto <okumoto@ucsd.edu>
2005-02-04 12:38:57 +00:00
Hartmut Brandt
435916b011 Minor cleanup: make brk_string to return argc only if the pointer to it
was non-NULL. This let's us eliminated an otherwise unused variable.

shellneeded can never return -1 so there is no need to check for it and
hence no need for a variable to hold the returned value.

Submitted by:	Max Okumoto <okumoto@ucsd.edu> (partly)
2005-02-04 12:30:54 +00:00
Hartmut Brandt
acd5b69dd1 Further constification. Use a temporary hack (copying the input string)
until Var_Subst is fixed.

Submitted by:	Max Okumoto <okumoto@ucsd.edu>
2005-02-04 12:10:20 +00:00
Ceri Davies
fa5c581ccf Quote example file names consistently, and fix a small grammatical nit. 2005-02-04 11:37:49 +00:00
Hartmut Brandt
8cfa18d178 Use an extra variable to assign to instead of missusing an input
parameter. This will help in constification.

Submitted by:	Max Okumoto <okumoto@ucsd.edu>
2005-02-04 08:31:42 +00:00
Hartmut Brandt
fec9b45897 Replace space, tab mixes by tabs.
Submitted by:	Max Okumoto <okumoto@ucsd.edu>
2005-02-04 08:15:11 +00:00
Hartmut Brandt
f6dc7bd983 Use tabs to move to the comments instead of wild mixes of tabs and spaces.
Submitted by:	Max Okumoto <okumoto@ucsd.edu>
2005-02-04 08:11:58 +00:00
Hartmut Brandt
a9fe0a1150 Style: line up with tabulators. 2005-02-04 08:03:55 +00:00
Hartmut Brandt
141d5e9f62 Use a typedef for the conditional handler function so that declaring
pointers to these functions is easier.

Submitted by:	Max Okumoto <okumoto@ucsd.edu>
2005-02-04 08:02:41 +00:00
Hartmut Brandt
7a551242f8 Style: remove a space between a function name and the opening
paranthesis.

Submitted by:	Max Okumoto <okumoto@ucsd.edu>
2005-02-04 07:56:40 +00:00
Hartmut Brandt
e23bc3a201 Some more easy constification.
Submitted by:	Max Okumoto <okumoto@ucsd.edu>
2005-02-04 07:51:00 +00:00
Giorgos Keramidas
d8aa7ce5ca Clarify a bit the BUGS section.
PR:		docs/77024
Submitted by:	Adrian Filipi <adrian@ubergeeks.com>
Reviewed by:	ru
2005-02-03 21:16:23 +00:00
Hartmut Brandt
b26f9f6376 Constify an argument to a function.
Submitted by:	Max Okumoto <okumoto@ucsd.edu>
2005-02-03 11:51:25 +00:00
Hartmut Brandt
9ba5835fba Get rid of a number of unneccessary memory allocations.
Submitted by:	Max Okumoto <okumoto@ucsd.edu>
2005-02-03 11:36:19 +00:00
Alfred Perlstein
7fe4c24002 Modify rpcgen -t output to something that's a lot more useful in
today's modern "no sir, not today" compilers.

Basically, when building the table:

 use NULL instead of 0,
 use braces around array initializers,
 case the function pointers to xdrproc_t,
 don't cast function pointers that do not need casting.

MFC After: 1 week
2005-02-02 22:14:10 +00:00
Hartmut Brandt
b09fe25c80 Make enomem static - it's referenced only in util.c.
Submitted by:	Max Okumoto <okumoto@ucsd.edu>
2005-02-02 11:25:05 +00:00
Hartmut Brandt
6f8d22e416 Remove a couple of unused buffer functions.
Submitted by:	Max Okumoto <okumoto@ucsd.edu>
2005-02-02 11:21:26 +00:00
Hartmut Brandt
ab9e1eb050 Convert several typedefs from beeing pointers to structs to be the structs
itself. This will ease constification (think of what 'const Ptr foo'
means if Ptr is a pointer to a struct).

Submitted by:	Max Okumoto <okumoto@ucsd.edu>
2005-02-02 07:36:18 +00:00
Alexey Zelkin
3559895440 Avoid unconditional increasing of variable leading to SIGSEGV, if req'd
parameter for -lang is missing.
2005-02-01 16:01:55 +00:00
Hartmut Brandt
44ad9c662f Move all the remaining list functions into one C-file and remove
double documentation comments. Remove the 3rd clause (from 4) of the
BSD license because these files have only the UCB copyright.

Submitted by:	Max Okumoto <okumoto@ucsd.edu>
2005-02-01 15:28:41 +00:00
Hartmut Brandt
042037eb6f Remove debugging stuff that crept in in the previous commit. 2005-02-01 11:39:45 +00:00
Hartmut Brandt
7a2029bac2 Clean up include files and file including. Split nonints.h into pieces
that get included just where they are needed. All headers include the
headers that they need to compile (just with an empty .c file). Sort
includes alphabetically where apropriate and fix some duplicate commenting
for struct Job, struct GNode and struct Shell by removing one version and
inlining the comments into the structure declaration (the comments have been
somewhat outdated).

This patch does not contain functional changes (checked with md5).

Submitted by:	Max Okumoto <okumoto@ucsd.edu>
2005-02-01 10:50:37 +00:00
Poul-Henning Kamp
6b02062275 Add text about jail root directory as well.
Submitted by:	"Mark W. Krentel" <krentel@dreamscape.com>
2005-01-30 08:03:20 +00:00
Poul-Henning Kamp
5dc1f79ed8 Report jail directory if set.
Sanity-check fd_lastfile.

PR:	62699
Patch by:	"Mark W. Krentel" <krentel@dreamscape.com>
2005-01-29 11:38:00 +00:00
Ruslan Ermilov
0479aa4bad Clean up after utilizing FILES. 2005-01-28 17:13:39 +00:00
Ruslan Ermilov
254dd1666e Let bsd.prog.mk set SRCS and MAN to their default values. 2005-01-28 16:08:11 +00:00
George V. Neville-Neil
a9a2bf999b Update kdump manual page with information on the dump format.
Add a table with the different types of operations traced.

Reviewed by:	Ruslan Ermilov
Approved by:	Robert Watson (mentor)
2005-01-28 12:17:33 +00:00
Xin LI
c49d3c9bac Remove unnecessary SRCS= where could be guessed directly by our
bsd.*.mk infrasture.

Obtained from:	ru
2005-01-27 14:52:47 +00:00
Hartmut Brandt
b071ad2dca Fix quoting of the MAKEFLAGS environment variable by only quoting spaces
and tabs. This is still not correct for command line variable values
ending in a backslash because this would require a larger effort.
Document this limitation in the BUGS section of the man page. The
quoting is mostly compatible with that of gmake and smake.

Tested by:	Max Okumoto and Joerg Sonnenberger from DragonFly BSD
Reviewed by:	ru (man page, partly)
2005-01-26 18:19:39 +00:00
Xin LI
39aa7c9d16 Correct some style nits that I have mistakenly submitted as
suggestions which result in the last revision[*]:
	- style(9) and sysexits(3) suggests that we use EX_*
	  as exit values, instead of some other values like
	  those returned from a system call as errno.

Additionally, follow Ruslan's suggestion about style(9) and
other style improvements:
	- Since open(2) says that it returns -1 on errors,
	  explicitly determine whether it is returning -1
	  rather than whether the return value is less than
	  zero.
	- Only set rval when there is no previous error.
	  This distinguishes the first error that occours.
	- Use exit() in favor of return in main(), this is
	  suggested in old style(9), while the evolve has
	  fade the suggestion.
	- Add some NOTREACHED comments.
	- Add blank line after first { because no local variables
	  in usage()

Thanks to Ruslan for his tireless explaining of the code standards
and knowledge of the history of style(9).

[*] Pointy hat to:	me

Submitted by:	ru (with some minor changes)
Discussed with:	ru, ssouhlal
2005-01-26 15:17:25 +00:00
Suleiman Souhlal
87d8e3c2bb Document the recent fsync(1) changes.
Requested by:	delphij
Reviewed by:	simon, ru
Approved by:	grehan (mentor)
2005-01-26 06:42:45 +00:00
Suleiman Souhlal
379b60989a In case of error, return errno, instead of 1.
Suggested by:	delphij
Reviewed by:	delphij
Approved by:	grehan (mentor)
2005-01-26 06:39:20 +00:00
Tim J. Robbins
d99e92769c Document input line length limit. 2005-01-25 22:32:48 +00:00
Tim J. Robbins
a7a223c342 Document message length limit. 2005-01-25 22:24:04 +00:00
Suleiman Souhlal
e80dde60e3 - Make WARNS?= 6 clean
- Add WARNS?= 6

Approved by:	stefanf, grehan (mentor)
2005-01-25 14:34:57 +00:00
Suleiman Souhlal
4dd5ff1fce - Remove useless includes
- Add WARNS?= 6 to Makefile

Submitted by:	Liam J. Foy <liamfoy@gmail.com>
Approved by:	grehan (mentor)
2005-01-25 14:22:20 +00:00
Suleiman Souhlal
e5faa1a423 - Continue, in case of error.
- Add WARNS?= 6

Submitted by:	Liam J. Foy <liamfoy@gmail.com>
Approved by:	stefanf, grehan (mentor)
2005-01-25 14:12:01 +00:00
Suleiman Souhlal
46c2bd6103 - Make find(1) WARNS?= 6 clean
- Bump to WARNS?= 6

Approved by:	stefanf, grehan (mentor)
2005-01-25 14:07:25 +00:00
Juli Mallett
e2816c1489 Take a swing at using roundup(). 2005-01-25 01:35:02 +00:00
Philippe Charnier
8a579692b2 spell "file system" correctly
Approved by:	ru
2005-01-24 20:06:16 +00:00
Xin LI
7f1a765333 According to style.Makefile(5):
WARNS?= should appear before CFLAGS

Reviewed by:	ru
2005-01-23 12:29:46 +00:00
Xin LI
980b4f7474 Make sure that we don't define INET6 when NO_INET6 is defined.
Without this change, when running netstat with a kernel without
INET6 built in, you will get a complain at the end of "netstat -s"
output.

X-MFC:		NO_INET6 was called "NOINET6" on RELENG_5
2005-01-22 19:35:48 +00:00
Ruslan Ermilov
75f7ea160c Removed remnants of Kerberos support. 2005-01-21 11:22:34 +00:00
Ruslan Ermilov
02a8121a17 Removed Kerberos remnants. 2005-01-21 11:09:40 +00:00
Ruslan Ermilov
3ac17feb8a Fixed xref. 2005-01-21 10:48:35 +00:00