Commit Graph

51 Commits

Author SHA1 Message Date
Ruslan Ermilov
968ed7eedb Push the detection of threading libs support down to ngctl/Makefile
as the latter can be built without threading (with the loss of line
editing functionality).

Pointed by:	glebius
2006-11-27 16:55:14 +00:00
Ruslan Ermilov
1d5dd15d75 Fix "make checkdpadd". 2006-11-26 14:43:03 +00:00
Alexander Kabaev
9a4194814d Silence GCC4 signed/unsigned pointer mismatch warning. 2006-09-21 01:48:47 +00:00
Gleb Smirnoff
eac2afced2 - Pass pointer to fd_set in ReadSockets.
- style(9) nits.

Submitted by:	ru
2006-08-08 07:04:40 +00:00
Gleb Smirnoff
b9124a7354 Add line edit and history support to ngctl(8) via editline(3).
Details:
- The main thread runs editline(3) functions, that can block.
- A separate thread is launched to monitor netgraph sockets.
- The access to the descriptors is protected by a mutex. At
  runtime the monitoring thread owns the mutex. When the main
  thread reads a command from el_gets() it asks the monitoring
  thread to release a mutex and sleep until the main thread
  processes the command.

This makes ngctl(8) depend on libedit, and libpthread. Thus, the
new functionality isn't compiled in if release is being built
with -DRELEASE_CRUNCH.

PR:		bin/87352
Reviewed by:	ru, Nuno Antunes <nuno.antunes gmail.com>
2006-08-07 14:17:05 +00:00
Stefan Farfeleder
c3759b3a3f Don't use empty braces ("{}") to initialise arrays. This is a syntax
error in ISO C (both 90 and 99).
2006-07-17 08:35:47 +00:00
Gleb Smirnoff
9caee2ece7 Style: space after "return". 2006-06-28 10:38:38 +00:00
Gleb Smirnoff
78cdd8ed1b Unnest includes before forthcoming editing. 2006-05-24 14:46:55 +00:00
Ruslan Ermilov
62f8299baa - Reduce the number of netgraph messages when listing
nodes from (N + 1) to 1, where N is the number of
  nodes in the system.

- Implement "ls -l" which runs the "show" command for
  each node.

In collaboration with:	glebius
2005-02-09 16:17:33 +00:00
Maxim Konovalov
c44e20ebec Backout rev. 1.17 per ru@ request: there are net.graph.recvspace and
net.graph.maxdgram sysctls.
2005-02-04 20:09:11 +00:00
Ruslan Ermilov
a866e17077 Added the EXIT STATUS section where appropriate. 2005-01-17 07:44:44 +00:00
Maxim Konovalov
b5974bdbab Increase a socket receive buffer size. This helps 'ngctl list'
to deal with a big number of nodes.

Submitted by:		archie
Approved by:		archie
Reported and tested:	Konstantin Timashkov
MFC after:		1 month
2004-11-25 09:27:56 +00:00
Ruslan Ermilov
07bfccd71e Mechanically kill hard sentence breaks. 2004-07-02 23:13:00 +00:00
Ruslan Ermilov
9fe5fadaf1 Get rid of all (but one in write.c) static size buffers. 2004-01-27 21:52:52 +00:00
Ruslan Ermilov
723c1c2ee8 Make this WARNS=3 clean. 2004-01-26 10:27:18 +00:00
Brian Feldman
bbd6d60a85 Add a GraphViz-exporting ngctl(8) "dot" command. You can now create
very useful .dot files of your netgraph(4) to quickly visualize the
nodes, hooks and edges.  An example of this can be found here:
	http://people.freebsd.org/~green/sample-netgraph-dot.ps
If anyone would like to refine the output further, please do so.
2004-01-09 03:19:40 +00:00
Philippe Charnier
b00304d4a1 Use fprintf() instead of errx() when displaying usage string. The program name
will not be written twice.
2004-01-04 16:11:29 +00:00
Hartmut Brandt
9d901d3b5f Get rid of the old constants which did not include the trailing NUL
and use the new constants which do.
2003-11-12 13:04:44 +00:00
Bill Fenner
3dc331b9f4 Add missing "of". 2002-12-14 00:20:43 +00:00
Dag-Erling Smørgrav
d397408818 Usage style sweep: spell "usage" with a small 'u'.
Also change one case of blatant __progname abuse (several more remain)
This commit does not touch anything in src/{contrib,crypto,gnu}/.
2002-04-22 13:44:47 +00:00
Archie Cobbs
be44fce4fa Add ngctl "write" command.
MFC after:	1 week
2002-01-22 22:01:25 +00:00
Ruslan Ermilov
d628d776c4 mdoc(7) police: utilize the new .Ex macro. 2001-08-15 09:09:47 +00:00
David E. O'Brien
90e655ea4e Perform a major cleanup of the usr.sbin Makefiles.
These are not perfectly in agreement with each other style-wise, but they
are orders of orders of magnitude more consistent style-wise than before.
2001-07-20 06:20:32 +00:00
David E. O'Brien
ac24b049cc Remove GCC'isms in CFLAGS. 2001-07-20 04:23:13 +00:00
Dima Dorfman
f247324df7 Remove whitespace at EOL. 2001-07-15 08:06:20 +00:00
Ruslan Ermilov
a4c37c816b mdoc(7) police: removed HISTORY info from the .Os call. 2001-07-10 15:12:08 +00:00
Ruslan Ermilov
345e52e742 - Backout botched attempt to introduce MANSECT feature.
- MAN[1-9] -> MAN.
2001-03-26 14:42:20 +00:00
Ruslan Ermilov
c73e22c3d4 Set the default manual section for usr.sbin/ to 8. 2001-03-20 18:17:26 +00:00
Poul-Henning Kamp
ede53ee311 Unrevert something which shouldn't have been reverted in the previous revert.
(Yes, I'm going to bed now to get some much needed sleep...)
2001-03-17 11:43:36 +00:00
Poul-Henning Kamp
0c5c7719e6 Backout my previous commit, it appearantly doesn't work for asynchronous
messages.
2001-03-17 08:59:31 +00:00
Poul-Henning Kamp
420e745a90 Add -ledit to ngctl.
Somebody submitted this long time ago, and it has been sitting in my
tree for months because I thought archie would pick it up.

Submitted by:	(sorry, lost track)
2001-03-16 19:35:07 +00:00
Ruslan Ermilov
ed40311694 mdoc(7) police: removed history info from the .Os FreeBSD call. 2000-12-14 11:52:05 +00:00
Ruslan Ermilov
251c176f41 mdoc(7) police: use certified section headers wherever possible. 2000-11-17 11:44:16 +00:00
Ben Smithurst
76a06f8483 remove trailing periods from SEE ALSO. 2000-11-15 17:27:54 +00:00
Archie Cobbs
f35e82dfe3 Fix bug in "read" command.
Submitted by:	Dave Cornelius <dc@packetdesign.com>
2000-10-10 01:34:20 +00:00
Archie Cobbs
aec01c66a8 Remove unused variable.
PR:		bin/20052
Submitted by:	Alex Kapranoff <alex@kapran.bitmcnit.bryansk.su>
2000-07-20 17:17:49 +00:00
Poul-Henning Kamp
f05f4f8f37 Yellow hat this way: forgot cvs add. 2000-07-03 17:39:24 +00:00
Poul-Henning Kamp
7095e0970e Experiemntal ascii based device configuration mechanism.
This may or may not survive, decision will be made well before 5.0-R
2000-07-03 13:34:18 +00:00
Archie Cobbs
6ebb8ebbd1 When the 'msg' command is used from the command line, check for a
synchronous reply, and display it (if any) before exiting.

Requested by:	phk
2000-06-20 18:51:38 +00:00
Archie Cobbs
b90c94d658 Field structure changed name from 'typename' -> 'type_name'. 2000-05-01 23:30:46 +00:00
Archie Cobbs
b1ea638805 Remove erroneous built-in help information for the 'msg' command. 2000-03-13 19:23:16 +00:00
Sheldon Hearn
f2e366a105 Remove single-space hard sentence breaks. These degrade the quality
of the typeset output, tend to make diffs harder to read and provide
bad examples for new-comers to mdoc.
2000-03-01 14:09:25 +00:00
Archie Cobbs
b08b2814a1 No need to try loading ng_socket.ko, as NgMkSockNode() does that
for us now if necessary.
2000-01-28 00:50:28 +00:00
Julian Elischer
5129159789 Manual page style work.
Submitted by:	Alexey Zelkin <phantom@FreeBSD.org>
thanks!
1999-12-21 01:25:21 +00:00
Archie Cobbs
f8307e1233 Add two new generic control messages, NGM_ASCII2BINARY and
NGM_BINARY2ASCII, which convert control messages to ASCII and back.
This allows control messages to be sent and received in ASCII form
using ngctl(8), which makes ngctl a lot more useful.

This also allows all the type-specific debugging code in libnetgraph
to go away -- instead, we just ask the node itself to do the ASCII
translation for us.

Currently, all generic control messages are supported, as well as
messages associated with the following node types: async, cisco,
ksocket, and ppp.

See /usr/share/examples/netgraph/ngctl for an example of using this.

Also give ngctl(8) the ability to print out incoming data and
control messages at any time.  Eventually nghook(8) may be subsumed.

Several other misc. bug fixes.

Reviewed by:	julian
1999-11-30 02:45:32 +00:00
Archie Cobbs
fa2518ab1f Limit COPTS added by Makefile to just '-Wall'. 1999-10-28 20:17:13 +00:00
Archie Cobbs
0d6985e2c1 If we get an EPROTONOSUPP error when trying to create the netgraph socket
node, it's most likely because the "ng_socket.ko" KLD is not loaded yet.
So make an attempt to load it before giving up.
1999-10-27 22:17:18 +00:00
Archie Cobbs
142ebf4ad6 Remove extraneous -I compile flag that was used during testing. 1999-10-27 22:14:04 +00:00
Matthew Dillon
ebdb21f429 Put include <netgraph.h> back in - problem was due to a cvsup mess on
freefall.  There may also be a real problem w/ buildworld but the fix
    would go somewhere else, not here.
1999-10-24 02:58:39 +00:00
Matthew Dillon
f41f949d09 Cleanup missing includes, stale includes, and a few printf format
inconsistancies.
1999-10-23 17:45:11 +00:00