d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
90,267 Commits 4 Branches 49 Tags
Commit Graph

40112 Commits

Author SHA1 Message Date
Poul-Henning Kamp
7d4220518e Remove break after return; 
Found by:       FlexeLint
 2003-05-31 20:24:30 +00:00
Poul-Henning Kamp
9a3454805e Don't rely on boolean expression evaluating to 1 or 0 by default. 
Found by:       FlexeLint
 2003-05-31 20:23:46 +00:00
Poul-Henning Kamp
30f5ad0faf Remove unused variable(s). 
Mark a non-critical memoryleak with XXX comment

Found by:       FlexeLint
 2003-05-31 20:21:53 +00:00
Poul-Henning Kamp
1e18ce425e emove unused variable(s). 
Found by:       FlexeLint
 2003-05-31 20:19:13 +00:00
Poul-Henning Kamp
1e93e04fa9 Remove return after panic. 
Found by:       FlexeLint
 2003-05-31 20:18:23 +00:00
Poul-Henning Kamp
90471005e1 Remove needless return 
Found by:       FlexeLint
 2003-05-31 20:16:44 +00:00
Poul-Henning Kamp
4fe77d64a0 Add a couple of XXX comments where the intent is not clear. 
Found by:       FlexeLint
 2003-05-31 20:13:58 +00:00
Poul-Henning Kamp
74f1af0191 Remove unused variable(s). 
Remove break after goto

Found by:       FlexeLint
 2003-05-31 20:11:33 +00:00
Poul-Henning Kamp
b1921a6f33 Remove return after panic. 
Found by:       FlexeLint
 2003-05-31 20:09:42 +00:00
Poul-Henning Kamp
a62f80f8e0 Remove unused variable and now unbalanced call to splbio(); 
Found by:       FlexeLint
 2003-05-31 20:09:01 +00:00
Poul-Henning Kamp
21b16e9715 Wrap macro in do {...} while(0); 
Found by:       FlexeLint
 2003-05-31 20:07:16 +00:00
Poul-Henning Kamp
048069758e Remove break after return. 
Found by:       FlexeLint
 2003-05-31 20:06:27 +00:00
Poul-Henning Kamp
bf975fe45b Remove unsed variables. 
Add explicit breaks to switch

Found by:       FlexeLint
 2003-05-31 20:05:25 +00:00
Poul-Henning Kamp
8eab8cefd8 Remove unused variable. 
Found by:       FlexeLint
 2003-05-31 20:04:19 +00:00
Poul-Henning Kamp
50cc8392cc Remove unused variables. 
Remove now unused pointer to ether header.
Remove break after return

Found by:       FlexeLint
 2003-05-31 20:02:43 +00:00
Poul-Henning Kamp
674ebf0f6b Remove break after return; 
Found by:       FlexeLint
 2003-05-31 20:01:14 +00:00
Poul-Henning Kamp
f22cfda31c Remove break after return 
Found by:       FlexeLint
 2003-05-31 19:59:29 +00:00
Poul-Henning Kamp
9c96882e80 Remove unused variables. 
Found by:       FlexeLint
 2003-05-31 19:58:45 +00:00
Poul-Henning Kamp
1000b87f2a Remove now unused pointer to etherheader. 
Found by:       FlexeLint
 2003-05-31 19:56:35 +00:00
Poul-Henning Kamp
61301f74d0 Remove unused variable. 
Found by:       FlexeLint
 2003-05-31 19:56:09 +00:00
Poul-Henning Kamp
29382d1af7 Remove double return() 
Found by:       FlexeLint
 2003-05-31 19:55:32 +00:00
Marcel Moolenaar
a063facbf6 Fix ia32 compat on ia64. Recent ia64 MD changes caused the garbage on 
the stack to be changed in a way incompatible with elf32_map_insert()
where we used data_buf without initializing it for when the partial
mapping resulting in a misaligned image (typical when the page size
implied by the image is not the same as the page size in use by the
kernel). Since data_buf is passed by reference to vm_map_find(), the
compiler cannot warn about it.

While here, move all local variables to the top of the function.
 2003-05-31 19:55:05 +00:00
Poul-Henning Kamp
c5d771b807 Prepend _ to internal union members to avoid ambiguity. 
Found by:       FlexeLint
 2003-05-31 19:52:15 +00:00
Poul-Henning Kamp
0b074f6c93 Remove unused variables 
Found by:       FlexeLint
 2003-05-31 19:51:05 +00:00
Poul-Henning Kamp
a0fb4cf18d Remove unused variables 
Add /* FALLTHROUGH */

Found by:       FlexeLint
 2003-05-31 19:49:49 +00:00
Poul-Henning Kamp
19ca58475e Remove unnecessary breaks. 
Remove unused variables.
Add XXX comment where a break may be missing. [lxtphy.c]

Found by:       FlexeLint
 2003-05-31 19:48:33 +00:00
Poul-Henning Kamp
5a87a6f702 Move some FALLTHROUGH comments so they work. 
Fix indentation error.
Make boardid string long enough.
Remove unused variable.

Found by:       FlexeLint
 2003-05-31 19:46:58 +00:00
Poul-Henning Kamp
b77052e617 Remove unused variable. 
Remove unneeded return;

Found by:       FlexeLint
 2003-05-31 19:41:33 +00:00
Alan Cox
34567de7fc Add vm object locking to vm_object_madvise(). 2003-05-31 19:40:57 +00:00
Poul-Henning Kamp
3bae8877f4 Remove unused variables. 
Found by:       FlexeLint
 2003-05-31 19:40:43 +00:00
Poul-Henning Kamp
16cef37ea3 Don't define memcpy() to bcopy() and in particular not memset() to 
bzero() when we have them all already.

Found by:       FlexeLint
 2003-05-31 19:38:43 +00:00
Poul-Henning Kamp
b2bf0c7f48 Fix indentation. 
Found by:       FlexeLint
 2003-05-31 19:38:00 +00:00
Poul-Henning Kamp
7fd69a8064 Remove unused variables. 
Rename struct h0h0 to g_hh01 in order to make it unique over files.

Found by:       FlexeLint
 2003-05-31 19:37:21 +00:00
Poul-Henning Kamp
2f613363c7 Remove unused variable. 
Found by:       FlexeLint
 2003-05-31 19:34:52 +00:00
Poul-Henning Kamp
5578b9263b Do not define memset() to bzero(). We have a memset(). 
Found by:       FlexeLint
 2003-05-31 19:31:46 +00:00
Poul-Henning Kamp
c543626797 Remove unused variables. 
Remove #ifdef notyet which will never become.

Found by:       FlexeLint
 2003-05-31 19:30:52 +00:00
Poul-Henning Kamp
23bfa598a8 Remove unused variable. 
Remove unneeded return.

Found by:       FlexeLint
 2003-05-31 19:29:38 +00:00
Poul-Henning Kamp
68283a9b5a Remove unused variable. 
Found by:       FlexeLint
 2003-05-31 19:28:53 +00:00
Poul-Henning Kamp
ce67c955ca Add a destroy_geom method to the slice "library". 
If a slice class has no destroy_geom method, use this one.

This should allow all slicers to kldload.
 2003-05-31 19:25:05 +00:00
Poul-Henning Kamp
fc29c9de5c Don't use & in front of arrays. 
Found by:       FlexeLint
 2003-05-31 19:23:11 +00:00
Poul-Henning Kamp
a980e07369 Remove unused variable. 
Found by:       FlexeLint
 2003-05-31 19:08:23 +00:00
Poul-Henning Kamp
e4d2978dd8 Add /* FALLTHROUGH */ 
Found by:       FlexeLint
 2003-05-31 19:07:22 +00:00
Poul-Henning Kamp
8aa2b5ce7e We cannot use the normal strlen() and strcpy, but don't #define strlen and 
strcpy to get private versions, use private versions directly.

Found by:       FlexeLint
 2003-05-31 19:06:38 +00:00
Poul-Henning Kamp
76e4a2dc72 Add missing break; 
Found by:       FlexeLint
 2003-05-31 19:04:37 +00:00
Poul-Henning Kamp
c9e61fbb81 Protect macro with do { ... } while (0) 
Found by:       FlexeLint
 2003-05-31 19:04:07 +00:00
Poul-Henning Kamp
80fcafb161 Remove unused variable. 
Found by:       FlexeLint
 2003-05-31 19:03:20 +00:00
Poul-Henning Kamp
78b52202d0 Fix indentation. 
Found by:       FlexeLint
 2003-05-31 19:02:20 +00:00
Robert Watson
05e830f1e7 Rewrite Biba and MLS label externalization code to use sbufs instead 
of C strings internally; C strings require a lot of return value
checking that (a) takes a lot of space, and (b) is difficult to get
right.  Prior to the advent of compartment support, modeling APIs
for helper functions on snprintf worked fine; with the additional
complexity, the sbuf_printf() API makes a lot more sense.

While doing this, break out the printing of sequential compartment
lists into a helper function, mac_{biba,mls}_compartment_to_string().
This permits the main body of mac_{biba,mls}_element_to_string()
to be concerned only with identifying sequential ranges rather
than rendering.

At a less disruptive moment, we'll push the move from snprintf()-like
interface to sbuf()-like interface up into the MAC Framework layer.

Obtained from:	TrustedBSD Project
Sponsored by:	DARPA, Network Associates Laboratories
 2003-05-31 19:01:44 +00:00
Poul-Henning Kamp
01bfa91fa2 Fix off-by-one error in range check of VC index. 
Found by:       FlexeLint
 2003-05-31 19:01:08 +00:00
Poul-Henning Kamp
9a4b535c7a Add /* FALLTHROUGH */ 
Found by:       FlexeLint
 2003-05-31 19:00:02 +00:00