d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
90,250 Commits 4 Branches 49 Tags
Commit Graph

40095 Commits

Author SHA1 Message Date
Poul-Henning Kamp
9c96882e80 Remove unused variables. 
Found by:       FlexeLint
 2003-05-31 19:58:45 +00:00
Poul-Henning Kamp
1000b87f2a Remove now unused pointer to etherheader. 
Found by:       FlexeLint
 2003-05-31 19:56:35 +00:00
Poul-Henning Kamp
61301f74d0 Remove unused variable. 
Found by:       FlexeLint
 2003-05-31 19:56:09 +00:00
Poul-Henning Kamp
29382d1af7 Remove double return() 
Found by:       FlexeLint
 2003-05-31 19:55:32 +00:00
Marcel Moolenaar
a063facbf6 Fix ia32 compat on ia64. Recent ia64 MD changes caused the garbage on 
the stack to be changed in a way incompatible with elf32_map_insert()
where we used data_buf without initializing it for when the partial
mapping resulting in a misaligned image (typical when the page size
implied by the image is not the same as the page size in use by the
kernel). Since data_buf is passed by reference to vm_map_find(), the
compiler cannot warn about it.

While here, move all local variables to the top of the function.
 2003-05-31 19:55:05 +00:00
Poul-Henning Kamp
c5d771b807 Prepend _ to internal union members to avoid ambiguity. 
Found by:       FlexeLint
 2003-05-31 19:52:15 +00:00
Poul-Henning Kamp
0b074f6c93 Remove unused variables 
Found by:       FlexeLint
 2003-05-31 19:51:05 +00:00
Poul-Henning Kamp
a0fb4cf18d Remove unused variables 
Add /* FALLTHROUGH */

Found by:       FlexeLint
 2003-05-31 19:49:49 +00:00
Poul-Henning Kamp
19ca58475e Remove unnecessary breaks. 
Remove unused variables.
Add XXX comment where a break may be missing. [lxtphy.c]

Found by:       FlexeLint
 2003-05-31 19:48:33 +00:00
Poul-Henning Kamp
5a87a6f702 Move some FALLTHROUGH comments so they work. 
Fix indentation error.
Make boardid string long enough.
Remove unused variable.

Found by:       FlexeLint
 2003-05-31 19:46:58 +00:00
Poul-Henning Kamp
b77052e617 Remove unused variable. 
Remove unneeded return;

Found by:       FlexeLint
 2003-05-31 19:41:33 +00:00
Alan Cox
34567de7fc Add vm object locking to vm_object_madvise(). 2003-05-31 19:40:57 +00:00
Poul-Henning Kamp
3bae8877f4 Remove unused variables. 
Found by:       FlexeLint
 2003-05-31 19:40:43 +00:00
Poul-Henning Kamp
16cef37ea3 Don't define memcpy() to bcopy() and in particular not memset() to 
bzero() when we have them all already.

Found by:       FlexeLint
 2003-05-31 19:38:43 +00:00
Poul-Henning Kamp
b2bf0c7f48 Fix indentation. 
Found by:       FlexeLint
 2003-05-31 19:38:00 +00:00
Poul-Henning Kamp
7fd69a8064 Remove unused variables. 
Rename struct h0h0 to g_hh01 in order to make it unique over files.

Found by:       FlexeLint
 2003-05-31 19:37:21 +00:00
Poul-Henning Kamp
2f613363c7 Remove unused variable. 
Found by:       FlexeLint
 2003-05-31 19:34:52 +00:00
Poul-Henning Kamp
5578b9263b Do not define memset() to bzero(). We have a memset(). 
Found by:       FlexeLint
 2003-05-31 19:31:46 +00:00
Poul-Henning Kamp
c543626797 Remove unused variables. 
Remove #ifdef notyet which will never become.

Found by:       FlexeLint
 2003-05-31 19:30:52 +00:00
Poul-Henning Kamp
23bfa598a8 Remove unused variable. 
Remove unneeded return.

Found by:       FlexeLint
 2003-05-31 19:29:38 +00:00
Poul-Henning Kamp
68283a9b5a Remove unused variable. 
Found by:       FlexeLint
 2003-05-31 19:28:53 +00:00
Poul-Henning Kamp
ce67c955ca Add a destroy_geom method to the slice "library". 
If a slice class has no destroy_geom method, use this one.

This should allow all slicers to kldload.
 2003-05-31 19:25:05 +00:00
Poul-Henning Kamp
fc29c9de5c Don't use & in front of arrays. 
Found by:       FlexeLint
 2003-05-31 19:23:11 +00:00
Poul-Henning Kamp
a980e07369 Remove unused variable. 
Found by:       FlexeLint
 2003-05-31 19:08:23 +00:00
Poul-Henning Kamp
e4d2978dd8 Add /* FALLTHROUGH */ 
Found by:       FlexeLint
 2003-05-31 19:07:22 +00:00
Poul-Henning Kamp
8aa2b5ce7e We cannot use the normal strlen() and strcpy, but don't #define strlen and 
strcpy to get private versions, use private versions directly.

Found by:       FlexeLint
 2003-05-31 19:06:38 +00:00
Poul-Henning Kamp
76e4a2dc72 Add missing break; 
Found by:       FlexeLint
 2003-05-31 19:04:37 +00:00
Poul-Henning Kamp
c9e61fbb81 Protect macro with do { ... } while (0) 
Found by:       FlexeLint
 2003-05-31 19:04:07 +00:00
Poul-Henning Kamp
80fcafb161 Remove unused variable. 
Found by:       FlexeLint
 2003-05-31 19:03:20 +00:00
Poul-Henning Kamp
78b52202d0 Fix indentation. 
Found by:       FlexeLint
 2003-05-31 19:02:20 +00:00
Robert Watson
05e830f1e7 Rewrite Biba and MLS label externalization code to use sbufs instead 
of C strings internally; C strings require a lot of return value
checking that (a) takes a lot of space, and (b) is difficult to get
right.  Prior to the advent of compartment support, modeling APIs
for helper functions on snprintf worked fine; with the additional
complexity, the sbuf_printf() API makes a lot more sense.

While doing this, break out the printing of sequential compartment
lists into a helper function, mac_{biba,mls}_compartment_to_string().
This permits the main body of mac_{biba,mls}_element_to_string()
to be concerned only with identifying sequential ranges rather
than rendering.

At a less disruptive moment, we'll push the move from snprintf()-like
interface to sbuf()-like interface up into the MAC Framework layer.

Obtained from:	TrustedBSD Project
Sponsored by:	DARPA, Network Associates Laboratories
 2003-05-31 19:01:44 +00:00
Poul-Henning Kamp
01bfa91fa2 Fix off-by-one error in range check of VC index. 
Found by:       FlexeLint
 2003-05-31 19:01:08 +00:00
Poul-Henning Kamp
9a4b535c7a Add /* FALLTHROUGH */ 
Found by:       FlexeLint
 2003-05-31 19:00:02 +00:00
Poul-Henning Kamp
89e3693051 Remove extra ';' 
Found by:       FlexeLint
 2003-05-31 18:57:41 +00:00
Poul-Henning Kamp
e64f402ff1 Hang softc from dev_t 2003-05-31 18:56:58 +00:00
Poul-Henning Kamp
d6b602d4b2 Remove unused variable. 
Found by:       FlexeLint
 2003-05-31 18:55:18 +00:00
Poul-Henning Kamp
04d0f26703 Fix off-by-one errors in range checks of state machine states & events. 
Found by:       FlexeLint
 2003-05-31 18:54:02 +00:00
Poul-Henning Kamp
5eed219cef Remove extra ';' 
Found by:       FlexeLint
 2003-05-31 18:52:38 +00:00
Poul-Henning Kamp
ff81e317d4 Use temporary variable to avoid double expansion of macro with side effects. 
Found by:       FlexeLint
 2003-05-31 18:46:45 +00:00
Poul-Henning Kamp
c7b24d7dcd Remove unused variable. 
Found by:       FlexeLint
 2003-05-31 18:45:32 +00:00
Poul-Henning Kamp
777d1b3990 Fix off-by-one error in drive number check. 
Don't return(foo(...)) in function returning void.

Found by:       FlexeLint
 2003-05-31 18:41:09 +00:00
Poul-Henning Kamp
0623afde6f Remove extra unused variable. 
Found by:       FlexeLint
 2003-05-31 18:39:29 +00:00
Poul-Henning Kamp
9d4b1fa40e Remove extra ';' 
Found by:       FlexeLint
 2003-05-31 18:37:30 +00:00
Poul-Henning Kamp
5d9bef6473 Add GEOM module compilation shims. 2003-05-31 18:36:41 +00:00
Poul-Henning Kamp
da507a2181 Fix \ alignment in macro. 
Remove breaks after return.
Remove unused variable.

Found by:       FlexeLint
 2003-05-31 18:21:40 +00:00
Poul-Henning Kamp
7379c88f4f Add /* FALLTHROUGH */ 
Found by:       FlexeLint
 2003-05-31 18:20:26 +00:00
Poul-Henning Kamp
6280ed26af Remove unused local variables. 
Found by:       FlexeLint
 2003-05-31 18:17:32 +00:00
Poul-Henning Kamp
6c87f8d5ea Introduce a init and fini member functions on a class. 
Use ->init() and ->fini() to handle the mutex in geom_disk.c

Remove the g_add_class() function and replace it with a standardized
g_modevent() function.

This adds the basic infrastructure for loading/unloading GEOM classes
 2003-05-31 18:13:07 +00:00
Garrett Wollman
6e49b1fe55 Don't generate an ip_id for packets with the DF bit set; ip_id is 
only meaningful for fragments.  Also don't bother to byte-swap the
ip_id when we do generate it; it is only used at the receiver as a
nonce.  I tried several different permutations of this code with no
measurable difference to each other or to the unmodified version, so
I've settled on the one for which gcc seems to generate the best code.
(If anyone cares to microoptimize this differently for an architecture
where it actually matters, feel free.)

Suggested by:	Steve Bellovin's paper in IMW'02
 2003-05-31 17:55:21 +00:00
Poul-Henning Kamp
03841f4eec Eliminate potential overflows by allocating softc dynamically, 
removing at the same time the need for this to be a "count" config
option.

Found by:       FlexeLint
 2003-05-31 17:06:20 +00:00