Commit Graph

33 Commits

Author SHA1 Message Date
eadler
a603c87b02 Check the return error of set[e][ug]id. While this can never fail in the
current version of FreeBSD, this isn't guarenteed by the API.
Custom security modules, or future implementations of the setuid and
setgid may fail.

Submitted by:	Erik Cederstrand
Approved by:	cperciva
MFC after:	3 days
2012-10-22 03:07:05 +00:00
glebius
77afb41a4e Add multibyte char support.
PR:		165429
Submitted by:	amdmi3
2012-03-21 08:03:07 +00:00
ed
6ad23491ec Add missing static keywords to wall(1) 2011-11-06 08:18:55 +00:00
obrien
003e9442e5 If one's message is longer than the buffer size, then we reset 'cnt' at the
wrong point and the actual column # get out of sync across the buffer size.
2011-07-12 00:31:11 +00:00
joel
29af67e52c Remove the advertising clause from UCB copyrighted files in usr.bin. This
is in accordance with the information provided at
ftp://ftp.cs.berkeley.edu/pub/4bsd/README.Impt.License.Change

Also add $FreeBSD$ to a few files to keep svn happy.

Discussed with:	imp, rwatson
2010-12-11 08:32:16 +00:00
ed
a618bd1a15 Perform all trivial ports to utmpx for usr.bin/.
They were already converted to use libulog, so it's easy to convert them
to utmpx.
2010-01-13 18:09:54 +00:00
ed
5f412839eb Add missing `void' keyword. 2009-12-29 22:32:43 +00:00
ed
149e4bd942 Let wall(1) use utmpx.
Because our implementation guarantees the strings inside struct utmpx to
be null terminated, we don't need to copy everything out, which makes
the code nicer to read.

Also set WARNS to 6 and add $FreeBSD$ to keep SVN silent.
2009-12-05 20:05:25 +00:00
das
409fbbd08f Fix some bugs in wall(1):
- Handle wrapping correctly when \r appears in the input, and don't
  remove the \r from the output.
- For lines longer than 79 characters, don't drop every 80th character.
- Style: Braces around compound while statement.

PR:		114498
Submitted by:	Niclas Zeising <niclas.zeising@gmail.com> (earlier version)
2008-01-15 07:40:30 +00:00
cognet
06cfdceb6c In wall and who, check that the utmp entry isn't stalled, as it is done in w.
Apparently with the new pts code stalled entries are printed, when they are
not with the BSD ptys.

Submitted by:	Michal Mertl <mime at traveller dot cz>
2006-02-21 13:01:00 +00:00
tjr
e63d1e49ed Remove "sleeper" nonsense. 2003-02-21 08:46:44 +00:00
markm
c6dc21807e WARNS=2 fix, use __FBSDID().
Not added to Makefile as WARNS=2 will be made default.
2001-12-11 22:22:15 +00:00
dd
2b3c9b5598 - Move the prototype of ttymsg() into ttymsg.h. syslogd and talkd
also use this, and they shouldn't have to have their own prototypes.

- Silence warnings about constness and signedness in ttymsg().  This
  includes changing the return value to a `const char *', and changing
  the types of `left' and `wret' (both byte counts) to ssize_t.

Reviewed by:	bde
2001-09-09 14:23:31 +00:00
ru
cebe3d6800 Make ``wall -g'' really DTRT.
Reviewed by:	imp, markm
2001-09-05 15:31:07 +00:00
kris
fd84041b00 When opening the file to broadcast, do it with the user's gid, not the
egid (tty).

Obtained from:	OpenBSD
Submitted by:	Maxime Henrion <mux@qualys.com>
Reviewed by:	imp
2001-05-08 11:11:42 +00:00
imp
3318e2474c Add -g group to usage message.
Don't treat pointer as a boolean, but instead test it against NULL.
Add warning for groups that don't exist

Submitted by: ru
2001-03-02 07:30:37 +00:00
imp
6da2732b8b o Add support for wall -g. This will send a message to all members of
a given group.
o Minor code style cleanups while I'm here

Reviewed by: bde, kris, markm, audit@
2001-03-01 05:43:12 +00:00
kris
24d7d40917 Cleanup this code a bit by attempting to sync it up with NetBSD and
with each other.

Reviewed by:	markm, dwmalone
2000-11-26 22:36:35 +00:00
n_hibma
d4edaae88f Instead of printing '(null)' if there is no tty, print 'no tty'.
In the case where the program is executed by a daemon running in the
background the terminal might not have a tty. The '(null)' is confusing.
2000-10-02 17:31:57 +00:00
asmodai
73a0a27f04 Let wall report the local timezone as well on output.
PR:		17867
Submitted by:	Joel Ray Holveck <joelh@gnu.org>
Nagged by:	nrahlstr
2000-07-27 07:58:47 +00:00
dbaker
e15986424e column counter (cnt) not reset to 0 on display of '\r' which could cause
unnecessary forced linewraps on some terminals.

Submitted by:	David McNett <nugget@slacker.com>
1999-09-01 23:07:29 +00:00
dbaker
029cf048cd Corrected apparent omission in program logic which was causing the
insertion of redundant crlf's.  Eliminated the venetian-blind effect
in walled text.

Submitted by:	David McNett <nugget@slacker.com>
1999-09-01 22:21:24 +00:00
peter
3b842d34e8 $Id$ -> $FreeBSD$ 1999-08-28 01:08:13 +00:00
dillon
762deff9e1 PR: bin/8680
Increase the size of a number of buffers and replace strcpy/strcat/sprintf
    with snprintf().  There was a minor and possibly not exploitable security
    hole related to one sprintf().
1998-12-13 03:42:51 +00:00
ache
be830b8d98 Change manual declarations of some functions to proper includes
Rewrote allowed character test to be more efficient
Fix screen position calculations: control and 8bit characters was
not counted properly
1997-09-15 01:03:16 +00:00
charnier
b4ee63a927 Use err(3). Add usage(). 1997-08-25 06:43:22 +00:00
ache
ec9763a7fa Add locale-independent control checks for security reason 1997-05-14 09:37:54 +00:00
ache
62e3660838 Localize it 1997-05-13 11:30:01 +00:00
ache
e71376d204 Fix 8bit chars handling 1997-04-08 13:52:53 +00:00
imp
141381e1cb compare return value from getopt against -1 rather than EOF, per the final
posix standard on the topic.
1997-03-29 04:34:07 +00:00
alex
057f2934d8 Fix some improperly wrapped lines in the code. 1996-08-11 02:20:05 +00:00
guido
be99ddf809 The talkd security hole can ealso be exploited by wall (and thus rwall).
write and talk are not affected.
Now print out escape sequences in the same way as is done by write(1).
1994-10-23 15:33:55 +00:00
rgrimes
f9ab90d9d6 BSD 4.4 Lite Usr.bin Sources 1994-05-27 12:33:43 +00:00