d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
241,566 Commits 4 Branches 49 Tags
Commit Graph

31 Commits

Author SHA1 Message Date
bapt
8204e4e32a Remove usage of _WITH_GETLINE from usr.sbin 2016-07-30 01:10:05 +00:00
asomers
3cee0b0310 pw should sanitize the argument of -w. 
Otherwise, it will silently disable the login for the selected account if
the argument is unrecognizable.

usr.sbin/pw/pw.h
usr.sbin/pw/pw_conf.c
usr.sbin/pw/pw_user.c
	Use separate rules to validate boolean parameters and passwd
	parameters.  Error out if a password parameter cannot be parsed.

usr.sbin/pw/tests/Makefile
usr.sbin/pw/tests/crypt.c
usr.sbin/pw/tests/pw_useradd.sh
usr.sbin/pw/tests/pw_usermod.sh
	Add tests for the validation.  Also, enhance existing
	password-related tests to actually validate that the correct hash is
	written to master.passwd.

Reviewed by:	bapt
MFC after:	4 weeks
Sponsored by:	Spectra Logic Corp
Differential Revision:	https://reviews.freebsd.org/D6840
 2016-07-13 17:09:20 +00:00
bapt
4469579834 Cleanup a bit includes 2015-08-02 13:22:46 +00:00
bapt
1890bfce80 Remove dead code 2015-08-02 12:48:36 +00:00
bapt
4f6bdcfb5d Rewrite parsing subcommands arguments of pw(8) 
Now each subcommands checks its arguments in a dedicated functions.

This helps improving input validation, code readability/maintainability
While here:
- Add a -y option to pw userdel/usermod so it can maintain NIS servers if
  nispasswd is not defined in pw.conf(5)
- Allow pw -r <rootdir> to remove directory with userdel -r
- Fix bug when renaming a user which was not renaming the user name it groups
  it is a member of.
- Only parse pw.conf(5) when needed.
 2015-08-02 12:47:50 +00:00
bapt
1567d1bb44 Improve strtounum 
Fix many style bugs
Better variable naming
Use C99 'restrict' were apropriate
Fix potential errno race

Submitted by:	bde
 2015-07-30 06:14:47 +00:00
bapt
4eb9f59af4 Create a strtounum function using the same API as strtonum 
This function returns uintmax_t
Use this function to convert to gid_t/uid_t
 2015-07-29 06:22:41 +00:00
bapt
032c1600ec Separate usernext/groupnext from the main functions 2015-07-11 16:58:47 +00:00
bapt
3be2bba5d7 Refactor input validation 
Mutualize code to validate inputs of both 'user' and 'group' command
Test that the input name fits into MAXLOGNAME
 2015-06-07 19:03:41 +00:00
bapt
c6afeed630 Add a new global struct pwconf to store etcpath, rootdir and struct userconf 
Do not add anymore -R and -V to arglist
Add an error message if both -V and -R are set in arguments
 2015-06-07 14:34:38 +00:00
bapt
3b86c3ab1d Instead of always casting the pw_checkname input to u_char * and casting it back 
to char *, change pw_checkname to directly take char * in input
 2015-06-07 10:57:02 +00:00
bapt
418b7ad781 Simplify reading pw.conf(5) by using getline(3) 2014-04-22 21:07:56 +00:00
bapt
cfea627c58 Teach pw(8) about how to use pw/gr API to reduce code duplication 
MFC after:	2 months
 2012-10-30 08:00:53 +00:00
jkim
2a03b255b4 Stop hard-coding default directory mode as 0777. 2011-03-08 20:13:29 +00:00
le
f17fbfd9be Add home directory creation mode to pw.conf(5) and be a bit 
more specific about the effect of the current umask on -M.
 2007-03-30 11:23:10 +00:00
stefanf
e1328da3d7 The variable `arglist' has internal linkage in pw.c, don't declare it as extern 
here.
 2005-02-10 09:05:27 +00:00
kris
5a1251c5ff Fix a harmless format string bogon and mark a function as __printflike(). 
There is still one instance of non-constant format string use inside that
function, but it's hard to fix.

MFC after:	1 week
 2001-07-05 08:01:15 +00:00
jake
961b97d434 Back out the previous change to the queue(3) interface. 
It was not discussed and should probably not happen.

Requested by:		msmith and others
 2000-05-26 02:09:24 +00:00
jake
d93fbc9916 Change the way that the queue(3) structures are declared; don't assume that 
the type argument to *_HEAD and *_ENTRY is a struct.

Suggested by:	phk
Reviewed by:	phk
Approved by:	mdodd
 2000-05-23 20:41:01 +00:00
davidn
091d630070 Add new functionality "lock" and "unlock" to provide a simple password 
locking mechanism for users. This works by prepending the string
"*LOCKED*" to the password field in master.passwd to prevent successful
decoding.
 1999-10-26 08:34:09 +00:00
peter
efabb9ccb1 $Id$ -> $FreeBSD$ 1999-08-28 01:35:59 +00:00
davidn
aea1f6bc3c 1) Do not blindly ignore file update errors which may occur due to concurrent 
updating
2) Add -V <etcdir>, which allows maintaining user/group database in alternate
   locations other than /etc.
 1999-02-23 07:15:11 +00:00
charnier
c4198a70c7 Use err(3) instead of local redefinition. Add rcsid string. 1997-10-10 06:23:42 +00:00
peter
b782f4df30 Revert $FreeBSD$ to $Id$ 1997-02-22 16:15:28 +00:00
jkh
808a36ef65 Make the long-awaited change from $Id$ to $FreeBSD$ 
This will make a number of things easier in the future, as well as (finally!)
avoiding the Id-smashing problem which has plagued developers for so long.

Boy, I'm glad we're not using sup anymore.  This update would have been
insane otherwise.
 1997-01-14 07:20:47 +00:00
davidn
ced6786ae2 Adds optional NIS passwd file updating and optionally rebuilding 
NIS maps.

Suggested by:	Peter Wemm
 1997-01-05 07:15:37 +00:00
davidn
ae5c463397 1) 200 users per group limitation removed and pw 
will handle lines of any length in /etc/group.
2)	Fixed bug with usermod -d not updating user's home
	directory.
3)	Minor formatting display changes/fixes with *show -P.
 1996-12-21 15:35:45 +00:00
davidn
104734a133 Allow 8-bit characters in the passwd gecos field, and adds a paragraph 
to the mangpage explaining the consequences (to be updated at a later
date after login class conf support is added).
 1996-12-19 15:22:45 +00:00
joerg
7b15aed015 Copyright update by the author, to be more in line with our sample 
copyright.

Submitted by:	David Nugent
 1996-12-10 23:59:04 +00:00
joerg
cb39d6c976 Upgrade from the author, reflecting all my wishes resulting out of the 
sysinstall use of this tool (plus some bug fixes).

2.2 candidate...

Submitted by:	David Nugent <davidn@nserver.usn.blaze.net.au>
 1996-12-09 23:55:27 +00:00
joerg
4a198ee0cb pw(8) -- a backend utility to manage the user and group databases. 
sysinstall's new User&group menu will use it, hence it's a 2.2
candidate despite of providing new functionality.

Submitted by:	David L. Nugent, <davidn@blaze.net.au>
 1996-12-09 14:05:35 +00:00