Commit Graph

38 Commits

Author SHA1 Message Date
Bill Paul
e49249921c Fix for PR #3141: check for NULL before strdup()ing pw->pw_class.
(I'm not sure why this happens, though I suspect it may be because
the server is configured with only passwd maps instead of both passwd
and master.passwd maps. This is allowed, but I think in this case
pw_class is left NULL, hence the problem.)

Also applied similar patch to chpass/pw_yp.c just for paranoia's sake.
1997-03-29 20:29:12 +00:00
Warner Losh
1c8af87873 compare return value from getopt against -1 rather than EOF, per the final
posix standard on the topic.
1997-03-29 04:34:07 +00:00
Mike Pritchard
bac06c08b7 If an administrator somehow manages to break the hardlinks
on chpass & passwd and turn the links into individual files
with the schg flag set, make install will fail to install all
of the proper links.

Fixed by removing the schg flag on all of the links before installing.

Closes PR# 2040.

Submitted by:	 Ph. Charnier <charnier@xp11.frmug.org>
1997-02-26 05:31:52 +00:00
Peter Wemm
c115df18cd Revert $FreeBSD$ to $Id$ 1997-02-22 19:58:13 +00:00
Wolfram Schneider
da1ff3cb8a Sort cross references. 1997-01-15 23:25:55 +00:00
Jordan K. Hubbard
1130b656e5 Make the long-awaited change from $Id$ to $FreeBSD$
This will make a number of things easier in the future, as well as (finally!)
avoiding the Id-smashing problem which has plagued developers for so long.

Boy, I'm glad we're not using sup anymore.  This update would have been
insane otherwise.
1997-01-14 07:20:47 +00:00
Peter Wemm
0587e3a417 pw_scan() was being used to convert a string into a struct passwd, with
an auto stack variable that was about to disappear.  It broke with some
nis passwd changes because of a gethostbyname() call that uses a fair bit
of stack..  This was a timebomb waiting to go off at any time and could
have been causing subtle corruption for a while.

AARGH!!

This is HIGHLY reccomended for 2.2 and presumably 2.1.6
1996-11-15 17:36:20 +00:00
Bill Paul
d7f248ea9f Add a flag to allow the 'use NIS or local?' logic to tell when NIS is
enabled in /etc/master.passwd & friends. This allows the 'USER_YP_AND_LOCAL'
case to make a more sensible guess (if NIS is enabled, default to NIS,
otherwise default to local -- this is better than defaulting to NIS
all the time).
1996-10-23 14:43:39 +00:00
Bill Paul
fac16cb516 *blush* Whoops: got the format strings wrong. 1996-10-22 03:43:34 +00:00
Bill Paul
900520ed02 Part 2 of fix for PR #1519. The problem here is similar to what
was going on in pwd_mkdb, except here we also have to deal with
the pw_change and pw_expire fields.
1996-10-22 03:27:12 +00:00
Bill Paul
eb66ca7b64 Modify the 'couldn't create udp handle' message so it tell you
the name of the host that couldn't be connected to. This will hopefully
make it easier to diagnose problems with certain NIS configuration
problems.
1996-10-22 00:41:55 +00:00
Peter Wemm
366982a550 Add new option to chpass: -e "expire" ; change the account expire time
from a script as if it was done in the interactive editor.

When reassembling the gecos string, trim any excess trailing commas, they
look ugly in the passwd file. :-)

Have a simple Makefile tweak to prevent mortal users from changing their
fullname.  As ISP's we have seem some real bizzare stuff here..

When decoding the change/expire string, allow the month number as a
synonym for the name of the month.. (ie: 1 as well as Jan or January)
Note that using numbers means there's a chance that you can get bitten
if you're not used to the American DD-MM-YY order.
1996-08-12 14:45:26 +00:00
Guido van Rooij
72383443f2 Move setting of username to the correcft place; also initialize it.
Reviewed by:	peter@freebsd.org
1996-07-14 16:42:33 +00:00
Guido van Rooij
79a1b8d9e2 Implement incremental passwd database updates. This is done by ading a '-u'
option to pwd_mkdb and adding this option to utilities invoking it.
Further, the filling of both the secure and insecure databases has been
merged into one loop giving also a performance improvemnet.
Note that I did *not* change the adduser command. I don't read perl
(it is a write only language anyway).
The change will drastically improve performance for passwd and
friends with large passwd files. Vipw's performance won't change.
In order to do that some kind of diff should be made between the
old and new master.passwd and depending the amount of changes, an
incremental or complete update of the databases should be agreed
upon.
1996-07-01 19:38:50 +00:00
Bill Paul
8e92f56a01 Add missing semicolon so that this module compiles whithout -DYP.
Submitted (via Usenet) by: Nathan Torkington <gnat@frii.com>
1996-06-15 16:17:42 +00:00
Bill Paul
a7aa11b1a0 Fix the -l flag. For some reason I can't fathom, I left in some code
that would cause it to fail if anyone but the superuser tried to use it.

Also fix a couple of harmless typos since I'm in the area.
1996-05-25 01:05:17 +00:00
Bill Paul
5741059082 In use_yp(), call _yp_check() to make ultra, super-duper sure that NIS
is available before trying to go hunting for a domain name. This fixes
the following problem: you have +::::::::: in /etc/master.passwd but
NIS isn't running (no ypbind, no domain name set) -- passwd and chpass
will still try to change an NIS password instead of the local one.
1996-05-07 21:05:12 +00:00
Mike Pritchard
d33c4953e7 Print some warnings if root invokes chpass and sets the
shell to one of the following:

- a non-existent file
- a non-regular file
- a file without any execute bits set

The shell is still set to whatever they entered even if the above
conditions exist (hey, it is the super user doing this after all :-),
but this might give the admin. some warning that they are about to screw
themselves and give them a chance to fix it before it is too late.

Inspired by: some new FreeBSD user on USENET who set his root shell
  to a shell that doesn't exist and now can't gain access to root (don't
  worry, I sent him some mail on how to recover from this).
1996-04-11 05:30:18 +00:00
Bill Paul
c3d77d3003 Fix small bug in get_yp_master(): this function is used to look for
a master server and initialize the suser_override flag, but in a non-NIS
environment is should be smart enough to just leave the flag cleared
and return (unless forced with a command-line argument like -y).
Otherwise, it will return an NIS-related error even if NIS isn't
turned on.

Pointed out by: ache
1996-03-04 15:34:43 +00:00
Bill Paul
c2dfe9fe01 Merge in changes to support the new rpc.yppasswdd(8) and fix a few bugs.
In passwd(1):

- Gut most of yp_passwd.c and leave only a few things that aren't common
  to pw_yp.c.

- Add support for -d and -h flags to select domains and NIS server hosts
  to use when updating NIS passwords. This allows passwd(1) to be used
  for changing NIS passwords from machines that aren't configured as
  NIS clients. (This is mostly to allow passwd(1) to work on NIS master
  servers that aren't configured as clients -- an NIS server need not
  necessarily be configured as a client itself.)

  NOTE: Realize that having the ability to specify a domain and hostname
  lets you use passwd(1) (and chpass(1) too) to submit update requests
  to yppasswd daemons running on remote servers in remote domains which
  you may not even be bound to. For example, my machine at home is not
  an NIS client of the servers on the network that I manage, yet I can
  easily change my password at work using my FreeBSD box at home by doing:
  'passwd -d work.net.domain -h any.nis.server.on.my.net wpaul'. (Yes,
  I do use securenets at work; temporarily modified my securenets file
  to give my home system access.) Some people may not be too thrilled
  with this idea. Those who don't like this feature can recompile passwd(1)
  and chpass(1) with -DPARANOID to restrict the use of these flags to
  the superuser.

  (Oh, I should be adding proper securenets support to ypserv(8) and
  rpc.yppasswdd(8) over the weekend.)

- Merge in changes to allow root on the NIS master server to bypass
  authentication and change any user's NIS password. (The super-user
  on the NIS master already has privileges to do this, but doing it
  through passwd(1) is much easier than updating the maps by hand.)
  Note that passwd(1) communicates with rpc.yppasswdd(8) via a UNIX
  domain socket instead of via standard RPC/IP in this case.

- Update man page.

In chpass(1):

- Fix pw_yp.c to work properly in environments where NIS client
  services aren't available.

- Use realloc() instead of malloc() in copy_yp_pass() and copy_local_pass().

- Fix silly bug in copy_yp_pass(); some of the members of the passwd
  structure weren't being filled in correctly. (This went unnoticed
  for a while since the old yppasswdd didn't allow changes to the
  fields that were being botched.)

- chpass(1) now also allows the superuser on the NIS master server to
  make unrestricted changes to any user's NIS password information.

- Use UNIX domain comm channel to rpc.yppasswdd(8) when run by the
  superuser on the NIS master. This allows several new things:

   o superuser can update an entire master.passwd.{byname,byuid} entry
   o superuser can update records in arbitrary domains using -d flag to
     select a domain (before you could only change the default domain)
   o superuser can _add_ records to the NIS master.passwd maps, provided
     rpc.yppasswdd(8) has been started with the -a flag (to do this,
     the superuser must force NIS operation by specifying the -y flag
     to chpass(1) along with -a, i.e. 'chpass -y -a 'foo:::::::::')

- Back out the 'chpass -a <new password entry> breaks with NIS' fix
  from the last revision and fix it properly this time. The previous
  revision fixed the immediate problem but broke NIS operation in
  some cases.

- In edit.c, be a little more reasonable about deciding when to
  prevent the shell field from being changed.

  Submitted by Charles Owens <owensc@enc.edu>, who said:

  "I made a minor (one-line) modification to chpass, with regards
   to whether or not it allows the changing of shells.  In the 2.0.5 code,
   field changing follows the settings specified in the "list" structure
   defined in table.c .  For the shell, though, this is ignored.  A quick
   look in edit.c showed me why, but I don't understand why it was written as
   such.  The logic was

        if shell is standard shell, allow changing

   I changed it to

        if shell changing is allowed (per table.c) and it is a standard shell
             OR if uid=0, then allow changing."

   Makes sense to me.

- Update man page.
1996-02-23 16:08:59 +00:00
Mike Pritchard
c8ead7a6cf Fix typo in xref in NOTES section. 1996-02-14 22:26:04 +00:00
Joerg Wunsch
049ceb634f Move the YP initialization earlier, so it's done before the evaluation
of -p/-s/-a related cruft.

Closes PR # misc/933 "chpass -s <shell>" does not work
1996-01-06 15:03:02 +00:00
Andreas Schulz
98c88647d9 Correct a typo :-). 1995-09-02 19:25:40 +00:00
Bill Paul
9219423651 Make use_yp() smarter about figuring out whether a user is local or
NIS (or both, or neither). Also add support for -l and -y flags to
force behavior to local or NIS. use_yp() also goes out of its way to
retrieve the correct password database information (local or NIS)
depending on what the situation since getpwent() & co. can't
necessarily be trusted in some cases.

Also document new flags in man page.
1995-09-02 03:56:21 +00:00
Bruce Evans
c555738304 Remove bogus ${DESTDIR}s from LINKS.
Keep DPADD up to date with LDADD.

bsd.prog.mk's install rule can't handle schg'ed links, so ugly
beforeinstall and afterinstall rules are required.
1995-08-17 11:26:42 +00:00
Bill Paul
367157222f Take the ypchfn/ypchsh stuff that was removed from passwd
and graft it into chpass.

Chpass can now tell when it's being asked to operate on an NIS
user and it displayes the appropriate message in the editor
template ("Changing NIS information for foo"). After the changes
have been made, chpass will promte the user for his NIS password.
If the password is correct, the changes are committed to yppasswdd.

Hopefully, this should make NIS more transparent to the end user.

Note that even the superuser needs to know a user's password before
he can change any NIS information (such is the nature of yppasswdd).
Also, changes to the password field are not permitted -- that's what
yppasswd is for. (The superuser may specify a new password, but
again, he needs to know the user's original password before he can
change it.)
1995-08-13 16:12:28 +00:00
Garrett Wollman
656dcd4316 Delete bogus referneces to timezone code internal header file `tzfile.h',
which is no longer bogusly installed in /usr/include.
1995-08-07 19:17:46 +00:00
Mike Pritchard
55cc991796 Fix chpass so that it doesn't advance the password
change and expire dates by 1 day anytime root
edits a user that has a change/expire date set.
1995-07-16 18:49:12 +00:00
Bill Paul
7cb00bd6b4 Somewhere along the line, somebody decided to make the 'full name' field
restricted. Am I the only one who sees the absurdity of having chfn be
a link to chpass, and then denying users permission to use chpass to
change their full names?

Of course, chpass has a much more severe bug in it, which is that it
allows users to change their password database info without first
asking them for their password. I hope to fix this at some point
so that I can merge ypchpass, ypchfn, ypchsh and chpass into one
program (password authentication is required for changing NIS data).
1995-06-23 16:24:34 +00:00
Rodney W. Grimes
7799f52a32 Remove trailing whitespace. 1995-05-30 06:41:30 +00:00
Rodney W. Grimes
144b71fe74 Missing ${DESTDIR} on chflags commands added. 1995-04-17 19:15:38 +00:00
Andrey A. Chernov
9dc5391c1c Bug fixed: even root was unable to edit restricted fields 1995-03-21 15:30:59 +00:00
Jordan K. Hubbard
e17312113c Fixes for chpass.
Submitted by: Heikki Suonsivu <hsu@cs.hut.fi>
1995-02-09 11:14:39 +00:00
Garrett Wollman
0e10ef2ea0 Add a `-p' option, allowing the super-user to directly set a user's
encrypted password.  Kerberized `login' might use this, if I get around
to implementing the complete Allspice System behavior.
1995-01-14 23:14:25 +00:00
Bruce Evans
d6238d7915 Fix logic in previous commit. 1994-11-14 07:13:12 +00:00
Andrey A. Chernov
3e7520144b Fix beforeinstall target:
use chflags /usr/bin/chpass ONLY if chpass present
1994-11-08 14:59:22 +00:00
Rodney W. Grimes
432f44f5e4 Add a beforeinstall rule to turn off the immutable flag on chpass so you
can install a new copy of it.
1994-05-30 14:03:53 +00:00
Rodney W. Grimes
9b50d90275 BSD 4.4 Lite Usr.bin Sources 1994-05-27 12:33:43 +00:00