428 Commits

Author SHA1 Message Date
dteske
d861b88db5 Rest in peace Ron (Ron McDowell Jul.12, 1955 - Aug.26, 2012).
I'll carry-on from here. Thank you so much for your hard work.
2013-07-05 17:44:53 +00:00
dteske
08639ea4ac Update e-mails. 2013-07-05 17:38:54 +00:00
dteske
d00c81143b Since r251908, bsdconfig(8) has no direct ties to sade(8) (instead uses
`bsdinstall partedit'). Update references (s/sade/bsdinstall/) and change
the BUGS section to be based on reality.
2013-07-05 17:35:13 +00:00
dteske
5c5880a226 Don't refer to a port manual. 2013-07-05 17:31:05 +00:00
dteske
71f71d97c3 mdoc: begin sentences on a new line. 2013-07-05 17:27:55 +00:00
dteske
3057277318 Update date on the back of r252802. 2013-07-05 17:23:00 +00:00
dteske
d8c69f1ae5 Fix a typo. 2013-07-05 17:22:10 +00:00
dteske
68e775341d Whitespace. 2013-07-05 17:21:40 +00:00
dteske
0ac55ea171 Use f_show_msg() instead of f_dialog_msgbox() where appropriate. The main
difference between these two functions:

	Usage: f_show_msg() $format_string [ $format_args ... ]
	Usage: f_dialog_msgbox() $text [ $hline ]

The former lends itself well to displaying the $msg_* i18n text, prompts,
etc. While the latter is better for text you do not control (error strings
captured as a response from external commands) -- or if you have to control
the hline.
2013-07-05 16:00:01 +00:00
dteske
f53995138b Add the necessary code to uninstall packages (re-install still pending).
Both scripted access (packageDelete) and UI access have been tested
successfully with a variation of different situations including:
+ Uninstall a package which no other installed package depends
+ Uninstall multiple packages which no other installed packages depend
+ Uninstall multiple packages which depend on each other
+ Similar to above but when ordered removal requires tracing dependencies
+ Purposefully do things like uninstall a package that is not installed
+ Try to uninstall a package which other installed packages still depend
+ Try to uninstall multiple packages which other installed packages depend
+ And many more.
2013-07-05 06:52:07 +00:00
dteske
d9933606bc Add minor debugging. 2013-07-05 06:46:11 +00:00
dteske
3ce89a7979 Prevent f_package_add() from re-performing f_package_detect_installed()
even though f_package_config() may have already detected the installed
packages.
2013-07-05 06:24:18 +00:00
dteske
e6d392abc6 Don't deselect a package right after installing it (this went unnoticed
because [currently] we exit after performing requests actions -- if we
ever change this to returning to the package selection screen, this would
have made an impact).
2013-07-05 06:22:25 +00:00
dteske
6d30095d01 Minor debugging changes/additions. 2013-07-05 06:20:01 +00:00
dteske
8e6b84b998 Fix a typo in a comment. 2013-07-05 03:12:29 +00:00
dteske
92088d5133 Add the beginnings of the old networking services functionality of
sysinstall(8). The UI for this will come later while this exposes the
functionality to the scripted interface. Tested successfully to first
install the pcnfsd package from the `Latest' repository, and second to
configure mountd_flags="-n" in rc.conf(5).
2013-07-05 01:49:20 +00:00
dteske
af1e83ac6e Add the necessary code to install packages (uninstall and re-install still
pending). Both scripted access (packageAdd) and UI access have been tested
successfully with a variation of different situations including:
+ Install a package with no dependencies
+ Install a package with dependencies that are already installed
+ Install a package with dependencies where some are already installed
+ Repeat each of the above from FTP and local Directory
+ Purposefully do things like try to install a package that does not exist
+ Try to install a package for which a dependency could not be loaded
+ Try to install a package that is in the INDEX bot not on the media
+ And many more.
2013-07-05 01:44:59 +00:00
dteske
4b3ea1b62b Add debugging for each of the initialized default variables. 2013-07-05 01:38:42 +00:00
dteske
30085c64d0 Add mustberoot.subr to the list of includes for scripts, exposing the helper
function f_mustberoot_init() to make it easy to write scripts that can more
easily transition to the super-user via sudo(8).
2013-07-05 01:37:35 +00:00
dteske
7b1053a0cd Remove separate processing of dependent packages from the "Review" screen
since f_package_add (packageAdd resword) processes dependencies itself.
NOTE: This is in preparation for incoming package management code.
2013-07-05 01:32:39 +00:00
dteske
88c7fca8dc Get rid of place-holder in preparation for incoming package mgmt code. 2013-07-05 01:30:13 +00:00
dteske
9a0edc7cfe Comments. 2013-07-05 01:28:30 +00:00
dteske
38518412eb Allow global default as general fall-back for package management routines. 2013-07-05 01:21:01 +00:00
dteske
9e8c439119 Set name of device to directory path (displayed during package operations). 2013-07-05 01:18:54 +00:00
dteske
d22cbd9996 Implement $probe_only for the media access modules. sysinstall(8) was
allowed to ignore the probe_only argument of its member functions solely
because in the C language, the file accessor methods open and return a file
descriptor and reading of the data is optional. In shell, the file accessor
methods return data on stdout and that data should not be ignored (large
files could block execution).

So, we must adhere to the probe_only flags and in some cases (in the case of
FTP, for example) change the `get' strategy to simply test existence and
return an appropriate status.

This was required because the up-coming package management stuff makes heavy
use of the probe_only argument to try different package suffixes. Every
media access module must implement $probe_only for the `get' accessor.
2013-07-04 20:12:12 +00:00
dteske
b023066a1d More whitespace. 2013-06-24 20:58:54 +00:00
dteske
8cfebcfd45 Whitespace. 2013-06-24 20:39:07 +00:00
dteske
c553e460ee Add a newline character to the end of the "Check URL again" error message
because long URLs do not induce extra height despite wrapping by dialog(1).
NOTE: For even longer lines, the cursor up/down keys work to scroll through
2013-06-23 10:51:26 +00:00
dteske
f6abdf341e Merge r248313 from stable/9 sysinstall(8) to head bsdconfig(8):
Add support for installation directly via HTTP.

While we're here, remove the menu-item for Passive FTP (since moving to
ftp(1) and switching FTPMODE to `auto' by default -- see r251613 -- the
single remaining FTP menu-item works for both ftp.f.o and ftp-archive.f.o;
previously each requiring separately active versus passive both work with
the `auto' setting). In scripting you still have mediaSetFTPActive and
mediaSetFTPPassive but the remaining FTP menu-item uses mediaSetFTP which
defaults to `auto' (aforementioned SVN r251613).
2013-06-23 10:48:26 +00:00
dteske
0af114bd22 Implement the $probe_only parameter (previously unimplemented). 2013-06-23 10:04:23 +00:00
dteske
b9bf1edc0c Fine-tune the parsing of the URL. Re-order, comment, and add debugging to
each case of unique URL format.
2013-06-23 09:41:47 +00:00
dteske
0c17385f8d Fix a code typo that prevented the probing of the current defaultrouter
in-order to pre-populate the editor.
2013-06-22 03:54:17 +00:00
dteske
68a4ce1f3f Oops, previous revision (r252084) broke non-full-path resolution (e.g.,
ftp://ftp.freebsd.org or ftp://ftp.freebsd.org/). Now both full-path and
non-full resolution is working regardless of trailing-slash.
2013-06-22 03:50:14 +00:00
dteske
29cd5ea9df Trim the trailing `/' from the ftp_dir when validating that the directory
exists on the FTP server. This now means that when you specify a full-path
to the repository on the FTP server that it doesn't matter whether you have
a trailing `/' or not.
2013-06-22 03:44:49 +00:00
dteske
172bc62ff0 Take advantage of the fact that f_getvar evaluates the $var_to_get parameter
within braces, allowing all manner of parameter expansions (properly quoted
or escaped, of course).
2013-06-22 02:57:52 +00:00
dteske
70fc88c567 Fix a regression introduced by r251967, resulting in:
/usr/libexec/bsdconfig/110.mouse/mouse: 134:
Syntax error: ";;" unexpected (expecting "fi")
2013-06-22 02:51:22 +00:00
dteske
1c4c4f02ae Fix a regression introduced by r251967, resulting in:
/usr/libexec/bsdconfig/080.console/console: 136:
Syntax error: ";;" unexpected (expecting "fi")
2013-06-22 02:47:54 +00:00
dteske
ef5284d910 Add missing local declaration. 2013-06-21 23:21:16 +00:00
dteske
a463f986b4 Remove unused library include. 2013-06-21 23:18:29 +00:00
dteske
ddfb5b732f Alphabetize library includes. 2013-06-21 23:13:55 +00:00
dteske
ce72a91142 Style. 2013-06-21 22:53:51 +00:00
dteske
e3578808e0 Typo and grammar fixes to comments. 2013-06-21 22:47:31 +00:00
dteske
10da02bc8d Fix a code typo in a case-statement match expression that prevented IPv6
URLs with port designator from working properly (e.g. http://[::1]:80/).
2013-06-20 07:29:42 +00:00
dteske
6dd0be38a0 When the fall-back of a case-statement is the last thing executed in a
while-loop _and_ all prior matches in the same case-statement either break
or continue, we can safely break the fall-back out of the case-statement.
This should improve readability and allow for longer-lines by reducing the
level of indentation by-one for the fall-back case.
(a continuation of SVN r252019)
2013-06-20 05:51:44 +00:00
dteske
1a1d811a61 When the fall-back of a case-statement is the last thing executed in a
while-loop _and_ all prior matches in the same case-statement either break
or continue, we can safely break the fall-back out of the case-statement.
This should improve readability and allow for longer-lines by reducing the
level of indentation by-one for the fall-back case.
2013-06-20 05:48:08 +00:00
dteske
8fb422656d Remove pedanticism and consolidate some logic. 2013-06-20 05:42:21 +00:00
dteske
511962e186 Add debugging (for a case that shouldn't arise, but makes it more obvious
if a menu addition is made in one plce but forgotten in another).
2013-06-20 05:40:11 +00:00
dteske
77503946ef Style -- no ;; needed on fallback clause within case-statement. 2013-06-19 18:44:55 +00:00
dteske
4eff756ffc Whitespace. 2013-06-19 18:32:18 +00:00
dteske
9bd5d55beb Whitespace and comments. 2013-06-19 18:13:58 +00:00