d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
260,825 Commits 4 Branches 49 Tags
Commit Graph

9 Commits

Author SHA1 Message Date
rgrimes
445ce42f8b In r340044 an attempt to quiet coverity warning cid 1357336 
was incorrectly implemented leading to a possible double free.

It is possible for both the conditional free,
and the unconditional free added in r340044 to be done,
fix that by initializing uopt to NULL,
removing the conditional free,
and only using the unconditional free at the end.

Reported by:	Patrick Mooney (patrick.mooney@joyent.com)
Reviewed by:	jhb (maintainer), Patrick Mooney (joyent/illumos)
Approved by:	bde (mentor)
CID:		1357336
MFC after:	3 days
MFC with:	340044
Differential Revision:	https://reviews.freebsd.org/D19202
 2019-02-15 16:48:15 +00:00
araujo
7767bbdeda Fix resource leak when using strdup(3). 
Reported by:	Coverity
CID:		1357336
Sponsored by:	iXsystems Inc.
 2018-11-02 08:01:42 +00:00
araujo
077431a537 Fix style(9) space vs tab. 
Reviewed by:	jhb
MFC after:	3 weeks.
Sponsored by:	iXsystems Inc.
Differential Revision:	https://reviews.freebsd.org/D15768
 2018-06-14 01:34:53 +00:00
araujo
7aa635aaa7 Add SPDX tags to bhyve(8). 
Discussed with:	rgrimes, pfg and mav.
Obtained from:	TrueOS
MFC after:	4 weeks.
Sponsored by:	iXsystems Inc.
 2018-06-13 03:22:08 +00:00
glebius
4a27907a6e Make comments match the code. No functional change. 2017-04-28 05:09:51 +00:00
grehan
e2d448a951 Catch another case where an XHCI interrupt was being 
injected without state being set up.

This fixes a core dump when dropping to the UEFI prompt
with graphics enabled and moving the mouse around.

Discussed with:	Leon Dang
MFC after:	3 days
 2016-07-26 23:40:25 +00:00
grehan
f760bee50d Disallow interrupt requests on disabled endpoints. 
Submitted by:	Leon Dang
MFC after:	3 days
 2016-07-17 20:34:46 +00:00
ngie
fa61712b7f Fix gcc warnings 
- Put parentheses around bitwise OR'ed values in the `FIELD_COPY(..)` and
  `FIELD_REPLACE(..)` macros to mute warning from gcc 4.2.1.
- Remove -Wunused-but-set-variable's (`setup_addr`, `status_addr`).

Approved by: re (gjb)
Differential Revision: https://reviews.freebsd.org/D7119
MFC after: 1 week
X-MFC with: r302332
Reported by: Jenkins
Reviewed by: grehan (maintainer)
Sponsored by: EMC / Isilon Storage Division
 2016-07-06 05:09:13 +00:00
grehan
6775e12557 Import bhyve_graphics into CURRENT. Thanks to all who tested 
this on the branch.

Original commit message:
  Initial bhyve native graphics support.

  This adds emulations for a raw framebuffer device, PS2 keyboard/mouse,
  XHCI USB controller and a USB tablet.

  A simple VNC server is provided for keyboard/mouse input, and graphics
  output.

  A VGA emulation is included, but is currently disconnected until an
  additional bhyve change to block out VGA memory is committed.

  Credits:
   - raw framebuffer, VNC server, XHCI controller, USB bus/device emulation
      and UEFI f/w support by Leon Dang
   - VGA, console/g, initial VNC server  by tychon@
   - PS2 keyboard/mouse jointly done by tychon@ and Leon Dang
   - hypervisor framebuffer mem support by neel@

  Tested by: Michael Dexter, in a number of revisions of this code.

  With the appropriate UEFI image, FreeBSD, Windows and Linux guests can
  installed and run in graphics mode using the UEFI/GOP framebuffer.

Approved by:	re (gjb)
 2016-07-04 03:19:06 +00:00