Commit Graph

7286 Commits

Author SHA1 Message Date
ru
de05db1167 Fix a long-standing bug when make(1) is passed the -V and
-f options in MAKEFLAGS environment variable, and some of
these options are also specified on the command line.

Thanks to:	marcel
Reviewed by:	harti
2004-12-16 19:46:50 +00:00
harti
ce24622080 Instead of dynamically allocating list heads allocated them statically
now that their size is only two pointers. This eliminates a lot of calls
to Lst_Init and from there to malloc together with many calls to
Lst_Destroy (in places where the list is obviously empty). This also
reduces the chance to leave a list uninitilized so we can remove more
NULL pointer checks and probably eliminates a couple of memory leaks.
2004-12-16 16:14:16 +00:00
grog
8a7cf4244c Correct the event of 17 December 1770: Ludwig van Beethoven was
christened.  We don't know whether he was born on the same or the
previous day.

From: Die Musik in Gecshichte und Gegenwart (Bärenreiter, Kassel,
      1989), 1:1509
2004-12-16 00:29:35 +00:00
grog
520a59377c Correct the dates and locations relating to Ludwig van Beethoven's
birth:

1.  Remove anachronistic "Germany".  Depending on your viewpoint, he
    was born in the Rheinland or Prussia.
2.  Remove reference to his date of birth.  It's not known, though
    it's possible it was 16t or 17 December.
3.  Get the date of his christening right.
2004-12-16 00:26:53 +00:00
ssouhlal
be55a34f7f If ferror is true, we must reset the error indicator.
Submitted by:	Liam J. Foy <liamfoy@sepulcrum.org>
Approved by:	grehan (mentor)
2004-12-15 06:24:57 +00:00
niels
2bae195f48 Add myself to the committers' birthday calendar
Approved by nectar (mentor)
2004-12-13 12:22:28 +00:00
ceri
985b44e046 Bump document date before ru gets me. 2004-12-11 13:14:54 +00:00
ceri
d0eb6b1f7e Add a -k flag for querying whois.krnic.net (the National Internet
Development Agency of Korea) which hold details of IP address
allocations within Korea.

Approved by:	bms
2004-12-11 13:14:07 +00:00
harti
d78a3892e0 Remove a list that was just used to free all variables just before exiting. 2004-12-10 11:58:34 +00:00
harti
e276a7356e Remove a list that used to hold all the GNodes just to be able
to free them just before exiting.
2004-12-10 10:32:10 +00:00
harti
db4fd70037 Remove a useless list where just all command lines are stuffed onto, never
used and just freed at the end. The idea might have been to be able
to free all the strings, but what's the point to free just before exiting?
2004-12-10 10:13:40 +00:00
harti
972d6db1ca Nobody actually checked the return codes from Lst_Append and Lst_Insert
so don't return anything.
2004-12-09 15:31:32 +00:00
harti
ba2adca5db If a path element directory was never opened it is not on the list of
open directories so there is no need to remove it from there. This fixes
a core dump introduced by removing the run-time check from Lst_Remove.
2004-12-09 10:00:55 +00:00
harti
071557e301 Now that circular lists are gone remove stuff for them. Simplify
somewhat so that we can remove a local variable.
2004-12-08 17:48:15 +00:00
harti
7bfaeaf061 No caller checks the return code from Lst_Remove, so don't return one.
Simplify the algorithm now that circular lists are gone.
2004-12-08 17:43:43 +00:00
harti
d9ec783dcb Don't check the return code from Lst_Remove. There is no way
that the list's first element is not on the list.
2004-12-08 16:50:14 +00:00
harti
bcfafac95e Remove return value from Lst_Concat. None of the callers ever checked
it. Remove stuff that was needed for circular lists.
2004-12-08 16:47:19 +00:00
harti
debc547816 Don't free the second list in Lst_Concat for LST_CONCLINK; free it
in the caller instead.
2004-12-08 16:28:53 +00:00
harti
bcb1f1f6f5 Get rid of the sequential access feature of the lists. This was used
only in a couple of places and all of them except for one were easily
converted to use Lst_First/Lst_Succ. The one place is compatibility
mode in job.c where the it was used to advance to the next command on
each invocation of JobStart. For this case add a pointer to the node to
hold the currently executed command.
2004-12-08 16:22:01 +00:00
harti
4dcbfdf876 Constify the arguments to the list compare function. This temporarily
requires to make a copy of the filename in ReadMakefile and to duplicate
two small functions in suff.c. This hopefully will go away when everything
is constified.

Submitted by:	Max Okumoto <okumoto@ucsd.edu> (partly)
2004-12-08 12:59:27 +00:00
harti
22a68a12ee Constify some calls of Buf_AddBytes.
Submitted by:	Max Okumoto <okumoto@ucsd.edu>
2004-12-08 08:18:13 +00:00
harti
bde7bbf9ad Consify the arguments to str_concat. Remove the STR_DOFREE flag for that
purpose and explicitely free the input string in the one place that was
calling str_concat with that flag.

Submitted by:	Max Okumoto <okumoto@ucsd.edu>
2004-12-08 08:11:59 +00:00
harti
23620cc24f Typedefs of pointers to structs are evil. Make Lst and LstNode typedef of
the structs itself not of pointers to them. This will simplify constification.

Checked by: diff on the object files
2004-12-07 13:49:13 +00:00
harti
9639eb3806 Constification of arguments passed to functions; no change on the
resulting executable.

Checked by:	diff on original and new objects

Submitted by:	Max Okumoto <okumoto@ucsd.edu>
2004-12-07 12:23:45 +00:00
harti
e65ea2146d Make needs no circular lists so remove them from the list code. 2004-12-07 10:14:16 +00:00
bland
f31ff0ee8a Fix -t option processing.
Partially initialized tm structure was passed into mktime(3).

Approved by:	ru
2004-12-06 15:38:24 +00:00
harti
885c50507d Some constification which doesn't require code rewrites. 2004-12-06 15:20:12 +00:00
harti
f237a4f68d Style: fix indentation. 2004-12-06 11:30:36 +00:00
ru
96a90ac8d7 Unbreak sockstat(1) on systems without the divert protocol. 2004-12-06 09:28:05 +00:00
harti
f55a4ad1b5 Remove an unused macro. 2004-12-06 08:57:41 +00:00
harti
6fb43802bf Constify arguments to Hash_FindEntry and Hash_CreateEntry. 2004-12-06 08:56:30 +00:00
harti
cf54e99966 Remove extra empty lines. 2004-12-06 08:52:02 +00:00
harti
c06cfd7434 Style: fix indentation, prototypes for functions even in comment. 2004-12-06 08:51:34 +00:00
ru
0d2cefc65d Show divert(4) sockets as well. 2004-12-05 14:17:14 +00:00
harti
f92a5a2616 Remove an extra space.
Submitted by:	ru
2004-12-03 13:03:16 +00:00
harti
b01c2c6a27 Fix breakage introduced on 64-bit platforms with my last commit. Need
to change to size_t in a couple of other places too.
2004-12-03 12:55:57 +00:00
harti
8edfb13f77 Plug a memory leak. 2004-12-03 12:07:03 +00:00
harti
2156fca38e Put macro arguments in paranthesis.
Submitted by:	johan
2004-12-03 12:02:14 +00:00
harti
41fdfcd45f Make sizes to be of type size_t and correct function arguments that
should be Byte (as the numerous casts to Byte in the function calls show).
2004-12-03 11:59:30 +00:00
harti
51241dfea9 Style: fix indentation, protect macro with do { } while (0).
Checked with: diff on object file.
2004-12-03 08:43:07 +00:00
harti
0ce0c908ff Describe the .SHELL target.
Reviewed by:	ru
2004-12-03 08:03:11 +00:00
harti
8345f29bee Change the algorithm that matches the builtin shells from the name keyword
of the .SHELL target. Formerly it used to select the shell with the
longest common trailing substring, so that bash would select sh, but pocsh
would select csh. Now an exact match is required so that specifying bash
without also giving a path and the other keywords will give an error.

PR:
Submitted by:
Reviewed by:	ru
Approved by:
Obtained from:
MFC after:
2004-12-03 08:02:52 +00:00
dumbbell
8d8086b530 Add myself to the committers' birthday calendar
Reviewed by:	mux
2004-12-03 01:41:55 +00:00
harti
72af789644 Remove a double test for the same ptr != NULL and use the official
macro for this; reorder an if.
2004-12-01 17:44:04 +00:00
harti
cf2c3cae34 Style: remove a lot of unnecessary casts, add some and spell the null
pointer constant as NULL.

Checked by: diff -r on the object files before and after
2004-12-01 10:29:20 +00:00
harti
ba6eb9dcb9 Stylification: missing spaces, extra space after function names, casts
and the sizeof operator, missing empty lines, void casts, extra empty lines.

Checked by: diff on make *.o lst.lib/*.o

Submitted by:	Max Okumoto <okumoto@soe.ucsd.edu> (partly)
2004-11-30 17:46:29 +00:00
wollman
82f18a9482 Use ?= with WARNS.
Requested by: ru
2004-11-30 16:41:40 +00:00
harti
6a1de54fc3 Constify the array of predefined shells. It turns out that we need two
versions of the structure definition for this: one with const char
pointers, because otherwise gcc won't let us initialize the fields with
constant strings, and one without the const, because we need to work
with the structure.
2004-11-30 15:35:51 +00:00
harti
6660eab42e Change a couple of the primitve list functions to be macros. This changes
the semantic of Lst_Datum which formerly returned NULL when the argument
node was NULL. There was only one place in the source that relied on this
so change that place.
2004-11-30 10:35:04 +00:00
harti
8ebdc3e0c2 Fix a bug that would truncate the full name of an archive member if
the length of happens to be larger than MAXPATHLEN.

PR:		bin/74368
Submitted by:	Max Okumoto <okumoto@ucsd.edu>
Obtained from:	DragonFlyBSD
2004-11-29 16:23:34 +00:00