opened. This should not be necessary, and it is known to confuse
certain devices.
Remove the UQ_NO_OPEN_CLEARSTALL quirk, as this is now the default
behaviour for all devices.
Approved by: re (scottl)
sys/dev/uart/uart_cpu_sparc64.c 1.20, 1.22
- Add support for using LOM (Lights Out Management) and RSC (Remote System
Control) devices as console.
- Add my copyright to uart_cpu_sparc64.c.
- Recognize the SAB82532 in USIII machines. This is MFC'ed for consistency
as one part of the original commit, sys/dev/uart/uart_bus_ebus.c rev. 1.7,
was already MFC'ed to RELENG_6 (in rev. 1.6.2.2).
Approved by: re (scottl)
- Use a dedicated kthread to call acctwatch() periodically rather than
a callout from softclock().
- Validate new values for the kern.acct_chkfreq sysctl.
- Whitespace and include sorting.
Approved by: re (scottl)
Convert last four functions in coda_vnops.c to ANSI C function
declarations. I knew I would get to fix something in Coda
eventually.
Approved by: re (scottl)
Cast VFS_STATFS() in vfs_domount() to (void) to indicate that ignoring the
return value is intentional: this is simply an attempt to pre-cache the
statfs state.
Found with: Coverity Prevent (tm)
Approved by: re (scottl)
In ncp_sysctl_connstat(), the SLIST_FOREACH() logic to check 'error'
resulted in deadcode, as 'error' could never be 0. What this logic
was originally meant to handle is not clear -- it's been this way
(broken) since at least RELENG_4.
Found with: Coverity Prevent(tm)
Approved by: re (scottl)
Remove dead code: 'opts' is not used in udp_append(), only in udp_input(),
so no need to assign it to NULL or conditionally free it.
Found with: Coverity Prevent(tm)
Approved by: re (scottl)
When storing the results of malloc() in a pointer to a pointer, check
the pointer to a pointer for NULL, not the pointer for NULL.
Noticed by: Coverity Prevent analysis tool
Approved by: re (scottl)
In ipcomp6_input(), check 'md' not 'm' after a call to m_pulldown(): 'm'
may be a stale pointer at this point, and we're interested in whether or
not m_pulldown() failed.
Noticed by: Coverity Prevent analysis tool
Approved by: re (scottl)
Remove dead code associated with 'mcopy' in ipx_forward(): at no point
are the contents of the forwarded mbuf ever copied into mcopy, so there's
no need to have mcopy, conditionally look at mcopy, or conditionally free
it.
Noticed by: Coverity Prevent analysis tool
Approved by: re (scottl)
Check the right ifnet pointer to see if if_alloc() failed or not in
ef_clone(); we were testing the original ifnet, not the one allocated.
When aborting ef_clone() due to if_alloc() failing, free the allocated
efnet structure rather than leaking it.
Noticed by: Coverity Prevent analysis tool
Approved by: re (scottl)
When freeing the chain of if_ef devices on an aborted load, use
SLIST_FOREACH_SAFE() rather than SLIST_FOREACH(), as elements are
freed on each iteration of the loop. This prevents use-after-free.
Noticed by: Coverity Prevent analysis tool
Approved by: re (scottl)
When SC_DISABLE_KDBKEY or SC_DISABLE_REBOOT are not defined allow the
same behavior to be controlled by the sysctls, hw.syscons.kbd_kbdkey
and hw.syscons.kbd_reboot respectively.
PR: kern/72728
Submitted by: Luca Morettoni <morettoni at libero dot it>
Approved by: re (scottl)
- Move the command setup from amr_start1 into the card specific submit
routines.
- Add or replace cpu_spinwait() with DELAY(1) to a few of the busy
loops when reading from the controller to work around firmware bugs
which can crash the controller.
Approved by: re
- Add loader(8) variables for RB_DFLTROOT, RB_MUTE, and RB_PAUSE:
"boot_dfltroot", "boot_mute", and "boot_pause" respectively.
- Cause all flags passed by boot2 to set the respective loader(8)
boot_* variable. The end effect is that all flags from boot2
are now passed to the kernel.
Approved by: re (scottl)
When calling bioq_first() to see if a queue is empty in bioq_disksort(),
don't save the return value as we won't use it.
Noticed by: Coverity Prevent analysis tool
Approved by: re (scottl)
In nfs_dolock(), GC now under-used ioflg, rendered obsolete when we moved
from using a fifo to talk to rpc.lockd to using a special device node.
Approved by: re (scottl)
Reuse ktr_unused field in ktr_header structure as ktr_tid; populate
ktr_tid as part of gathering of ktr header data for new ktrace
records. The continued use of intptr_t is required for file layout
reasons, and cannot be changed to lwpid_t at this point.
Reviewed by: davidxu
Approved by: re (scottl)
Modify the IP fragment reassembly code so that it uses a new UMA zone,
ipq_zone, to allocate fragment headers from, rather than using cast mbuf
storage. This was one of the few remaining uses of mbuf storage for
local data structures that relied on dtom(). Implement the resource
limit on ipq's using UMA zone limits, but preserve current sysctl
semantics using a sysctl proc.
Approved by: re (scottl)
sys/conf/files.sparc64 1.78, sys/modules/Makefile 1.471,
sys/modules/le/Makefile 1.1, sys/sparc64/conf/GENERIC 1.105
Hook up le(4) to the build.
Approved by: re (scottl)
sys/dev/le/am79900reg.h 1.1, sys/dev/le/am79900var.h 1.1,
sys/dev/le/am7990reg.h 1.1, sys/dev/le/am7990var.h 1.1,
sys/dev/le/if_le_ledma.c 1.1, sys/dev/le/if_le_pci.c 1.1,
sys/dev/le/lance.c 1.1, sys/dev/le/lancereg.h 1.1,
sys/dev/le/lancevar.h 1.1
Add le(4), a driver for AMD Am7900 LANCE and Am79C9xx PCnet NICs,
ported from NetBSD.
This version differs from HEAD in that if_le_ledma.c inlines
lsi64854_enet_intr() from rev. 1.8 of sys/sparc64/sbus/lsi64854.c
in le_dma_hwintr() in order to not break the API of the LSI64854
driver in RELENG_6.
Approved by: re (scottl)
- Don't shift the clock frequency in MHz left by 8 before assigning it
to sbus_mdvec.dv_clock as sbus_mdvec.dv_clock is meant to be specified
in MHz. While this was a bug it shouldn't have affected FreeBSD/sparc64
as sbus_mdvec.dv_clock is used to limit the clock rate of chips when
a machine isn't able to support them at maximum speed which isn't the
case for sun4u machines.
- Remove the code that checks whether the clock frequency returned by
sbus_get_clockfreq() is 0 and falls back to 25MHz if it is as that's
already done in sbus(4).
Approved by: re (scottl)
Set IFF_BROADCAST and IFF_MULTICAST on vlan interfaces from the
beginning and simply refuse to attach to a parent without either
flag. Our network stack doesn't like those flags changing and
there is no need in them doing so.
Approved by: re (scottl)
to :: if we have another PCB which is bound to 0.0.0.0. If a PCB has
the INP_IPV6 flag, then we set its cost higher than IPv4 only PCBs.
Approved by: re (scottl)
Avoid creating (and subsequently using) fake opt_*.h files
when the modules are built with the kernel and hence actual
opt_*.h files are available in ${KERNBUILDDIR}. Fix a few
small bugs that would prevent this from working.
At last the build options of the modules become consistent
with those of the kernel unless the MODULES_WITH_WORLD way
still is used.
Approved by: re (kensmith, scottl)
Requested by: ru
Tested on: amd64 i386 sparc64
Tested by: md5
