d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
258,031 Commits 4 Branches 49 Tags
Commit Graph

459 Commits

Author SHA1 Message Date
allanjude
e1ac383b60 bsdinstall: Make ZFS min_auto_ashift adjustment persistent 
Reported by:	feld
Reviewed by:	dteske, tsoome
MFC after:	3 days
Sponsored by:	ScaleEngine Inc.
Differential Revision:	https://reviews.freebsd.org/D10895
 2017-06-12 19:29:31 +00:00
ngie
2b6f093ae4 bsdinstall(8): fix manpage issues 
- Start new sentences on new lines.
- Separate e.g. (more of an igor thing) with commas, and rewrite some examples
  not to be enclosed in parentheses.

Reported by:	igor, make manlint
MFC after:	2 weeks
Sponsored by:	Dell EMC Isilon
 2017-05-23 08:01:11 +00:00
ngie
356b3a6a26 sade(8): start new sentence on new line 
Reported by:	make manlint
MFC after:	2 weeks
Sponsored by:	Dell EMC Isilon
 2017-05-23 07:50:42 +00:00
ngie
efab2d4bf9 style(9): sort headers 
MFC after:	2 weeks
MFC with:	r318693
Sponsored by:	Dell EMC Isilon
 2017-05-23 06:05:54 +00:00
ngie
e32ea47849 Some minor style(9) fixes 
- Wrap at <80 columns.
- Sort by type

MFC after:	2 weeks
Sponsored by:	Dell EMC Isilon
 2017-05-23 06:04:38 +00:00
royger
fbcd8f004d bsdinstall: do not use distextract in scripted mode 
It requires a tty, which might not be available in scripted installs. Instead
extract the sets manually using tar.

Reviewed by:		tsoome
Sponsored by:		Citrix Systems R&D
MFC after:		1 week
Differential revision:	https://reviews.freebsd.org/D10736
 2017-05-22 11:41:17 +00:00
royger
c9043e81ab bsdinstall: mount is not needed for the ZFS install case 
Because the datasets are already mounted by zfsboot, and the mount script
doesn't know anything about ZFS. Also do not execute the "umount" script for
ZFS for the same reasons.

Reviewed by:		dteske, tsoome
Sponsored by:		Citrix Systems R&D
MFC after:		1 week
Differential revision:	https://reviews.freebsd.org/D10738
 2017-05-22 11:38:39 +00:00
araujo
4af5bc6bef Use nitems() from sys/param.h. 
Reviewed by:	ngie
MFC after:	2 weeks.
Differential Revision:	https://reviews.freebsd.org/D9942
 2017-05-03 14:03:46 +00:00
cem
a8899611ac bsdinstall(8): Sprinkle a snprintf to fixed size buffer 
Use a snprintf to write an environment variable to a fixed-size buffer to
avoid stack overflow.

Reported by:	Coverity (CWE-120)
CID:		1238926
Sponsored by:	Dell EMC Isilon
 2017-04-14 00:36:45 +00:00
robak
67c4962715 Revert changes introduced in r314036 on demand by jhb and bapt. 
Approved by:	bapt, jhb
 2017-03-17 11:45:46 +00:00
rgrimes
76d0a7b226 Convert absolute links to relative links. 
Style.Makefile(9) has been ignored to produce minimal diffs.

Approved by:	grehan (mentor)
MFC after:	1 week
 2017-03-07 05:10:38 +00:00
robak
afad54646c Enable bsdinstall hardening options by default. 
As discussed previously, in order to introduce new OS hardening
defaults, we've added them to bsdinstall in 'off by default' mode.
It has been there for a while, so the next step is to change them
to 'on by defaul' mode, so that in future we could simply enable
them in base OS.

Reviewed by:	brd
Approved by:	adrian
Differential Revision:	https://reviews.freebsd.org/D9641
 2017-02-21 09:37:33 +00:00
robak
89f5f9cef3 Add 0-8 as shortcuts for jumping to menu items in the hardening menu. 
Submitted by:	skreuzer
Reviewed by:	allanjude, robak
Approved by:	allanjude
Differential Revision:	https://reviews.freebsd.org/D6826
 2017-02-16 19:58:02 +00:00
garga
0c9abada65 bsdinstall: Make sure chroot filesystems are umounted after use 
* DISTDIR_IS_UNIONFS is set every time BSDINSTALL_DISTDIR is mounted inside
  BSDINSTALL_CHROOT. Use this flag to decide if it needs to be umounted
* BSDINSTALL_CHROOT/dev is mounted when 'bsdinstall mount' is called, there is
  no need to mount it again when user goes to shell after installation

Reviewed by:	allanjude
Obtained from:	pfSense
MFC after:	1 week
Sponsored by:	Rubicon Communications (Netgate)
Differential Revision:	https://reviews.freebsd.org/D8573
 2017-02-08 17:03:52 +00:00
rpokala
43bf655fbc Fix indentation (only line in file w/ 8-space indent rather than hard-tab). 
MFH:		1 week
 2017-02-08 00:02:54 +00:00
nyan
259480b6de Remove pc98 support completely. 
I thank all developers and contributors for pc98.

Relnotes:	yes
 2017-01-28 02:22:15 +00:00
dteske
afc7443a35 Revert r309918 -- modern POSIX has deprecated -<#>/+<#> syntax 
Special thanks to:	jilles
 2016-12-13 22:31:49 +00:00
dteske
ee335e51e1 It's completely pointless to replace newlines with space 
(this is done automatically for you upon shell expansion)
 2016-12-13 02:56:52 +00:00
dteske
7665f7ac67 The flags of a WLAN need to be quoted (they contain things like brackets) 2016-12-13 02:54:44 +00:00
dteske
d208501dc8 Simplify single-line if statements 2016-12-13 02:48:14 +00:00
dteske
21f47b71cd Simplify loop by moving predicate to clause 2016-12-13 02:47:39 +00:00
dteske
66dc7693d3 Wordsmithing 2016-12-13 02:46:36 +00:00
dteske
aea80b05f3 Why test $? when you can test the command 2016-12-13 02:45:52 +00:00
dteske
4e07ba017a Restore previous comment 2016-12-13 02:45:07 +00:00
dteske
4c7fbd1f3b Both simplify bringup of interface after changes and catch errors in debug 2016-12-13 02:44:33 +00:00
dteske
a35c1dd28a Calculate proper size of menu list dialog 2016-12-13 02:42:10 +00:00
dteske
8e2e3ae3dd There's an API function for catching errors and displaying them or 
logging them to debug output
 2016-12-13 02:40:54 +00:00
dteske
397585b6bb There's an API function for displaying pauses 2016-12-13 02:30:24 +00:00
dteske
52245df7f6 There's an API function for displaying yes/no dialogs 2016-12-13 02:29:20 +00:00
dteske
b2bffd29c0 There's an API function for displaying errors 2016-12-13 02:27:38 +00:00
dteske
ace145d56c Comment 2016-12-13 02:25:23 +00:00
dteske
b37902302b Whitespace alignment 2016-12-13 02:23:48 +00:00
dteske
04ee6d2bc0 Relying on dialog auto-sizing (width/height/rows = 0) is a mistake 
Use the provided API for calculating the appropriate size of menus
 2016-12-13 02:22:21 +00:00
dteske
ae195a31a8 Remove unnecessary quotes 2016-12-13 02:16:00 +00:00
dteske
cbd36b071a Add missing quotes 2016-12-13 02:15:36 +00:00
dteske
d811f94e7f In awk, if you're going to append a newline to your printf 
AND you're going to print only the argument, just use print
 2016-12-13 02:14:40 +00:00
dteske
8179d41c00 This statement has too many backslashes 2016-12-13 02:13:20 +00:00
dteske
970dd61e8b Neither printf (and as is commonly known) nor print need parens in awk 2016-12-13 02:12:00 +00:00
dteske
caa88d1b07 Whitespace and alignment 2016-12-13 02:11:09 +00:00
dteske
071e4a0235 You don't need parentheses for awk's printf 2016-12-13 02:07:12 +00:00
dteske
4442ea7869 Continued resolution of conveluted statement 
We shouldn't be coding things like "x || (x && x) || x || x || x ..."
 2016-12-13 02:04:50 +00:00
dteske
3af2400435 These two error messages have always been backwards since inception 2016-12-13 02:02:14 +00:00
dteske
e9c0e67f16 Why use $? when you can use the command itself 2016-12-13 01:59:35 +00:00
dteske
466c31033e If the first ping succeeded, why on Earth should we ping it again? 2016-12-13 01:56:28 +00:00
dteske
89fc8acc2d Start deconstructing a conveluted hunk of code 2016-12-13 01:54:44 +00:00
dteske
8216db0e54 Remove completely unnecesary parentheses 2016-12-13 01:52:10 +00:00
dteske
69fc9cb69a Why repeat yourself when you can send stderr to the same place as stdout? 2016-12-13 01:50:22 +00:00
dteske
7940685748 Properly quote variable 2016-12-13 01:44:18 +00:00
dteske
d302140ee4 Use more generic f_yesno() from provided API 2016-12-13 01:42:13 +00:00
dteske
c52826dc16 The output of dialog needs to be sanitized 
for portability/compatibility requirements
 2016-12-13 01:41:06 +00:00