freebsd-skq/sys
Dimitry Andric 05b1ae81f6 Tentatively apply D23730:
Fix compile errors in altera_sdcard_io.c after r357647

Summary:
After rS357647, building universe results in compilation errors for
_.mips.BERI_DE4_SDROOT:

```
sys/dev/altera/sdcard/altera_sdcard_io.c: In function 'altera_sdcard_io_start_internal':
sys/dev/altera/sdcard/altera_sdcard_io.c:299:13: error: '*bp' is a pointer; did you mean to use '->'?
  switch (*bp->bio_cmd) {
             ^~
             ->
sys/dev/altera/sdcard/altera_sdcard_io.c:301:38: error: '*bp' is a pointer; did you mean to use '->'?
   altera_sdcard_write_cmd_arg(sc, *bp->bio_pblkno *
                                      ^~
                                      ->
sys/dev/altera/sdcard/altera_sdcard_io.c:307:42: error: '*bp' is a pointer; did you mean to use '->'?
   altera_sdcard_write_rxtx_buffer(sc, *bp->bio_data,
                                          ^~
                                          ->
sys/dev/altera/sdcard/altera_sdcard_io.c:308:10: error: '*bp' is a pointer; did you mean to use '->'?
       *bp->bio_bcount);
          ^~
          ->
sys/dev/altera/sdcard/altera_sdcard_io.c:309:38: error: '*bp' is a pointer; did you mean to use '->'?
   altera_sdcard_write_cmd_arg(sc, *bp->bio_pblkno *
                                      ^~
                                      ->
sys/dev/altera/sdcard/altera_sdcard_io.c: In function 'altera_sdcard_io_start':
sys/dev/altera/sdcard/altera_sdcard_io.c:336:20: error: incompatible types when assigning to type 'struct bio *' from type 'struct bio'
  sc->as_currentbio = *bp;
                    ^
```

The first few are because `->` has a higher precedence than `*`, so the
expressions should use `(*bp)->foo` instead.  I also renamed the
variable to `bpp` to make it clearer that it is a pointer-to-pointer.

The last one is because `sc->as_currentbio` is already a `struct bio *`,
there is no need to dereference `bp` there.

Last but not least, I would really suggest rewriting the
`altera_sdcard_io_start_internal()` function to just return success or
failure, so the caller can decide to set `bp` to NULL.
2020-02-17 18:31:32 +00:00
..
amd64 Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (4 of many) 2020-02-15 18:57:49 +00:00
arm Implement atomic_testandclear_{32,int,long} for 32-bit arm. Also, replace 2020-02-10 00:05:04 +00:00
arm64 arm64: remove no longer needed atomic_load_ptr casts 2020-02-14 23:17:18 +00:00
bsm Jail and capability mode for shm_rename; add audit support for shm_rename 2019-11-18 13:31:16 +00:00
cam The KASSERT is too strict: revert r357897 2020-02-15 18:14:23 +00:00
cddl Remove duplicate dbufs accounting. 2020-02-07 15:50:47 +00:00
compat Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (2 of many) 2020-02-15 18:54:59 +00:00
conf Add chacha20poly1305 support to crypto build 2020-02-16 00:03:09 +00:00
contrib Add chacha20poly1305 support to crypto build 2020-02-16 00:03:09 +00:00
crypto
ddb Add KERNEL_PANICKED macro for use in place of direct panicstr tests 2020-01-12 06:07:54 +00:00
dev Tentatively apply D23730: 2020-02-17 18:31:32 +00:00
dts Add an overlay for RK3328 USB3 node. 2020-01-29 12:10:42 +00:00
fs Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (1 of many) 2020-02-15 18:48:38 +00:00
gdb Add KERNEL_PANICKED macro for use in place of direct panicstr tests 2020-01-12 06:07:54 +00:00
geom geli taste: allow GELIBOOT tagged providers as well 2020-02-07 21:36:14 +00:00
gnu Import DTS files for riscv from Linux 5.4 2019-12-03 09:12:53 +00:00
i386 i386: remove no longer needed atomic_load_ptr casts 2020-02-14 23:17:37 +00:00
isa sc(4) md bits: stop setting sc->kbd entirely 2019-12-30 02:07:55 +00:00
kern vfs: fix vlrureclaim ->v_object access 2020-02-16 03:33:34 +00:00
kgssapi
libkern random(9): Deprecate random(9), remove meaningless srandom(9) 2019-12-26 19:41:09 +00:00
mips mips: fix kernel build after r357804 2020-02-14 20:25:04 +00:00
modules Disable new clang 10.0.0 warnings about misleading indentation in ce(4) 2020-02-13 19:25:49 +00:00
net Use NET_TASK_INIT() and NET_GROUPTASK_INIT() for drivers that process 2020-02-12 09:19:47 +00:00
net80211 net80211: Move rate printing in amrr_node_stats() to a separate method 2020-01-17 22:04:11 +00:00
netgraph ng_nat: avoid panic if attached directly to ng_ether and got short packet 2020-02-12 00:31:00 +00:00
netinet sctp: use new capsicum helpers 2020-02-15 01:29:40 +00:00
netinet6 Fix NOINET builds. 2020-01-31 02:23:48 +00:00
netipsec netipsec: fix a mismatched uma_zfree -> uma_zfree_pcpu 2020-02-12 20:18:29 +00:00
netpfil Add missing EPOCH(9) wrapper in ipfw(8). 2020-02-11 18:16:29 +00:00
netsmb
nfs vfs: drop the mostly unused flags argument from VOP_UNLOCK 2020-01-03 22:29:58 +00:00
nfsclient
nfsserver
nlm vfs: drop the mostly unused flags argument from VOP_UNLOCK 2020-01-03 22:29:58 +00:00
ofed Make sure the VNET is properly set when reaping mbufs in ipoib. 2020-01-11 12:02:16 +00:00
opencrypto Miscellaneous typo fixes 2020-02-07 19:53:07 +00:00
powerpc powerpc: Fix altivec disabling in set_mcontext() 2020-02-06 01:25:30 +00:00
riscv Implement vm.pmap.kernel_maps for RISC-V 2020-02-12 14:06:02 +00:00
rpc Change r355157 to make svc_rpc_gss_lifetime_max a static. 2019-11-28 02:18:51 +00:00
security Merge audit and systrace checks 2020-02-14 13:09:41 +00:00
sys refcount: add missing release fence to refcount_release_if_gt 2020-02-16 03:14:55 +00:00
teken
tests
tools vfs: stop null checking routines in vop wrappers 2020-01-26 00:41:38 +00:00
ufs ufs: use faster lockgmr entry points in ffs_lock 2020-02-15 21:48:48 +00:00
vm Slightly restructure uma_zalloc* to generate better code from clang and 2020-02-16 01:07:19 +00:00
x86 Make atomic_load_ptr type-aware 2020-02-14 23:15:41 +00:00
xdr typo: s/impelmentation/implementation/. 2020-02-07 15:14:29 +00:00
xen
Makefile Remove sparc64 kernel support 2020-02-03 17:35:11 +00:00