freebsd kernel with SKQ
Go to file
Adrian Chadd 0d4e4e5ea4 Fix a WME corner case found by the FreeBSD 802.11n testing crew.
The symptom: sometimes 11n (and non-11n) throughput is great.
Sometimes it isn't. Much teeth gnashing occured, and much kernel
bisecting happened, until someone figured out it was the order
of which things were rebooted, not the kernel versions.
(Which was great news to me, it meant that I hadn't broken if_ath.)

What we found was that sometimes the WME parameters for the best-effort
queue had a burst window ("txop") in which the station would be allowed
to TX as many packets as it could fit inside that particular burst
window. This improved throughput.

After initially thinking it was a bug - the WME parameters for the
best-effort queue -should- have a txop of 0, Bernard and I discovered
"aggressive mode" in net80211 - where the WME BE queue parameters
are changed if there's not a lot of high priority traffic going on.
The WME parameters announced in the association response and beacon
frames just "change" based on what the current traffic levels are.
So in fact yes, the STA was acutally supposed to be doing this higher
throughput stuff as it's just meant to be configuring things based on
the WME parameters - but it wasn't.

What was eventually happening was this:

* at startup, the wme qosinfo count field would be 0;
* it'd be parsed in ieee80211_parse_wmeparams();
* and it would be bumped (to say 10);
* .. and the WME queue parameters would be correctly parsed and set.

But then, when you restarted the assocation (eg hostap goes away and
comes back with the same qosinfo count field of 10, or if you
destroy the sta VIF and re-create it), the WME qosinfo count field -
which is associated not to the VIF, but to the main interface -
wouldn't be cleared, so the queue default parameters would be used
(which include no burst setting for the BE queue) and would remain
that way until the hostap qosinfo count field changed, or the STA
was actually rebooted.

This fix simply cleares the wme capability field (which has the count
field) to 0, forcing it to be reset by the next received beacon.

Thanks go to Milu for finding it and helping me track down what was
going on, and Bernard Schmidt for working through the net80211 and
WME specific magic.
2011-03-24 15:27:15 +00:00
bin sh(1): Describe subshell environment, command substitution more correctly. 2011-03-20 23:52:45 +00:00
cddl Properly print characters larger than 127. 2011-03-24 14:12:41 +00:00
contrib - Merge in OFED 1.5.3 from projects/ofed/head 2011-03-21 09:58:24 +00:00
crypto Fix Incorrectly formatted ClientHello SSL/TLS handshake messages could 2011-02-12 21:30:46 +00:00
etc - Merge in OFED 1.5.3 from projects/ofed/head 2011-03-21 09:58:24 +00:00
games Improve the distributeworld target in Makefile.inc1 and update the release 2011-03-02 14:39:26 +00:00
gnu Change the load address from offset 0 in region 1 to offset 4G in region 0. 2011-03-22 17:19:35 +00:00
include Add missing declarations that I intended to commit with r219359. 2011-03-07 16:05:45 +00:00
kerberos5 Fix a typo. 2010-01-09 18:53:03 +00:00
lib humanize_number(3) multiply the input number by 100, which could cause an 2011-03-23 22:08:01 +00:00
libexec - Add support for TLS relocations. 2011-03-11 21:08:02 +00:00
release Add support for memstick generation on PowerPC. This is a little suboptimal 2011-03-23 16:22:08 +00:00
rescue Finally... Import the latest open-source ZFS version - (SPA) 28. 2011-02-27 19:41:40 +00:00
sbin It's possible to unmount multiple items at once, make it clear. 2011-03-24 12:35:09 +00:00
secure Fix some leftover binaries and shared libraries in the system that still 2011-02-15 22:03:09 +00:00
share Give better URL to the list of available CVSup mirrors. 2011-03-22 04:31:35 +00:00
sys Fix a WME corner case found by the FreeBSD 802.11n testing crew. 2011-03-24 15:27:15 +00:00
tools Oops, fix badness i must've introduced earlier. 2011-03-23 11:16:06 +00:00
usr.bin Discourage from using "cp -r". 2011-03-24 13:52:59 +00:00
usr.sbin Really fix the confusion, sorry for noise 2011-03-24 12:35:59 +00:00
COPYRIGHT Happy New Year 2011. 2010-12-31 18:07:16 +00:00
LOCKS
MAINTAINERS - Initial release of bxe(4) to support Broadcom NetXtreme II 10GbE. 2011-03-14 22:42:41 +00:00
Makefile Improve the distributeworld target in Makefile.inc1 and update the release 2011-03-02 14:39:26 +00:00
Makefile.inc1 - Merge in OFED 1.5.3 from projects/ofed/head 2011-03-21 09:58:24 +00:00
Makefile.mips Retire TARGET_ABI. 2011-01-07 20:26:33 +00:00
ObsoleteFiles.inc Add sticky.8 to the obsolete files since it had been 2011-02-24 18:13:53 +00:00
README Add the cddl/ directory. 2010-11-14 11:32:56 +00:00
UPDATING Merge binutils 2.17.50 to head. This brings a number of improvements to 2011-02-18 20:54:12 +00:00

This is the top level of the FreeBSD source directory.  This file
was last revised on:
$FreeBSD$

For copyright information, please see the file COPYRIGHT in this
directory (additional copyright information also exists for some
sources in this tree - please see the specific source directories for
more information).

The Makefile in this directory supports a number of targets for
building components (or all) of the FreeBSD source tree, the most
commonly used one being ``world'', which rebuilds and installs
everything in the FreeBSD system from the source tree except the
kernel, the kernel-modules and the contents of /etc.  The ``world''
target should only be used in cases where the source tree has not
changed from the currently running version.  See:
http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/makeworld.html
for more information, including setting make(1) variables.

The ``buildkernel'' and ``installkernel'' targets build and install
the kernel and the modules (see below).  Please see the top of
the Makefile in this directory for more information on the
standard build targets and compile-time flags.

Building a kernel is a somewhat more involved process, documentation
for which can be found at:
   http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/kernelconfig.html
And in the config(8) man page.
Note: If you want to build and install the kernel with the
``buildkernel'' and ``installkernel'' targets, you might need to build
world before.  More information is available in the handbook.

The sample kernel configuration files reside in the sys/<arch>/conf
sub-directory (assuming that you've installed the kernel sources), the
file named GENERIC being the one used to build your initial installation
kernel.  The file NOTES contains entries and documentation for all possible
devices, not just those commonly used.  It is the successor of the ancient
LINT file, but in contrast to LINT, it is not buildable as a kernel but a
pure reference and documentation file.


Source Roadmap:
---------------
bin		System/user commands.

cddl		Various commands and libraries under the Common Development
		and Distribution License.

contrib		Packages contributed by 3rd parties.

crypto		Cryptography stuff (see crypto/README).

etc		Template files for /etc.

games		Amusements.

gnu		Various commands and libraries under the GNU Public License.
		Please see gnu/COPYING* for more information.

include		System include files.

kerberos5	Kerberos5 (Heimdal) package.

lib		System libraries.

libexec		System daemons.

release		Release building Makefile & associated tools.

rescue		Build system for statically linked /rescue utilities.

sbin		System commands.

secure		Cryptographic libraries and commands.

share		Shared resources.

sys		Kernel sources.

tools		Utilities for regression testing and miscellaneous tasks.

usr.bin		User commands.

usr.sbin	System administration commands.


For information on synchronizing your source tree with one or more of
the FreeBSD Project's development branches, please see:

  http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/synching.html