dexuan
922c675756
hyperv/storvsc: storvsc_io_done(): do not use CAM_SEL_TIMEOUT
...
CAM_SEL_TIMEOUT was introduced in
https://reviews.freebsd.org/D7521 (r304251), which claimed:
"VM shall response to CAM layer with CAM_SEL_TIMEOUT to filter those
invalid LUNs. Never use CAM_DEV_NOT_THERE which will block LUN scan
for LUN number higher than 7."
But it turns out this is not correct:
I think what really filters the invalid LUNs in r304251 is that:
before r304251, we could set the CAM_REQ_CMP without checking
vm_srb->srb_status at all:
ccb->ccb_h.status |= CAM_REQ_CMP.
r304251 checks vm_srb->srb_status and sets ccb->ccb_h.status properly,
so the invalid LUNs are filtered.
I changed my code version to r304251 but replaced the CAM_SEL_TIMEOUT
with CAM_DEV_NOT_THERE, and I confirmed the invalid LUNs can also be
filtered, and I successfully hot-added and hot-removed 8 disks to/from
the VM without any issue.
CAM_SEL_TIMEOUT has an unwanted side effect -- see cam_periph_error():
For a selection timeout, we consider all of the LUNs on
the target to be gone. If the status is CAM_DEV_NOT_THERE,
then we only get rid of the device(s) specified by the
path in the original CCB.
This means: for a VM with a valid LUN on 3:0:0:0, when the VM inquires
3:0:0:1 and the host reports 3:0:0:1 doesn't exist and storvsc returns
CAM_SEL_TIMEOUT to the CAM layer, CAM will detech 3:0:0:0 as well: this
is the bug I reported recently:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=226583
PR: 226583
Reviewed by: mav
MFC after: 1 week
Sponsored by: Microsoft
Differential Revision: https://reviews.freebsd.org/D14690
2018-04-10 18:05:02 +00:00
..
2018-04-06 17:35:35 +00:00
2018-04-06 17:35:35 +00:00
2018-04-06 17:35:35 +00:00
2017-11-27 14:52:40 +00:00
2018-03-23 15:35:19 +00:00
2018-01-29 04:04:52 +00:00
2017-11-27 14:52:40 +00:00
2017-11-27 14:52:40 +00:00
2017-11-27 14:52:40 +00:00
2018-01-29 00:14:46 +00:00
2018-04-03 23:49:35 +00:00
2018-01-29 00:14:46 +00:00
2018-02-23 18:15:50 +00:00
2017-12-25 04:48:39 +00:00
2017-11-27 14:52:40 +00:00
2017-11-27 14:52:40 +00:00
2018-04-08 22:59:34 +00:00
2018-01-10 17:35:00 +00:00
2017-09-14 15:34:45 +00:00
2017-11-27 14:52:40 +00:00
2017-11-27 14:52:40 +00:00
2018-03-30 18:50:13 +00:00
2017-11-27 14:52:40 +00:00
2018-03-08 18:52:47 +00:00
2018-01-29 00:22:30 +00:00
2018-03-30 18:50:13 +00:00
2018-04-08 22:59:34 +00:00
2017-11-27 14:52:40 +00:00
2017-12-25 04:48:39 +00:00
2017-11-20 19:36:21 +00:00
2018-01-21 15:42:36 +00:00
2017-11-27 14:52:40 +00:00
2017-11-18 14:26:50 +00:00
2018-03-29 19:48:50 +00:00
2018-03-08 19:24:10 +00:00
2017-11-27 14:52:40 +00:00
2018-01-21 15:42:36 +00:00
2018-01-29 00:14:46 +00:00
2017-11-27 14:52:40 +00:00
2017-11-27 14:52:40 +00:00
2018-03-09 11:33:56 +00:00
2018-01-10 20:05:19 +00:00
2017-12-27 03:23:21 +00:00
2018-03-20 22:01:18 +00:00
2017-11-27 14:52:40 +00:00
2018-04-09 23:36:52 +00:00
2017-11-27 14:52:40 +00:00
2017-11-27 14:52:40 +00:00
2018-03-25 06:08:18 +00:00
2018-03-30 20:27:47 +00:00
2017-11-27 14:52:40 +00:00
2017-11-27 14:52:40 +00:00
2018-01-31 14:36:27 +00:00
2018-04-09 22:06:16 +00:00
2017-12-23 06:49:27 +00:00
2018-01-24 05:16:11 +00:00
2018-04-04 22:52:24 +00:00
2018-04-06 17:35:35 +00:00
2017-11-18 14:26:50 +00:00
2017-11-18 14:26:50 +00:00
2018-03-29 15:58:49 +00:00
2018-04-09 22:06:16 +00:00
2017-11-20 19:36:21 +00:00
2018-01-29 00:14:46 +00:00
2018-03-22 01:00:55 +00:00
2018-04-06 17:35:35 +00:00
2018-03-21 15:57:36 +00:00
2018-03-23 15:35:07 +00:00
2018-03-23 02:45:09 +00:00
2017-11-09 13:38:17 +00:00
2017-12-30 19:27:22 +00:00
2018-01-21 15:42:36 +00:00
2017-11-20 19:36:21 +00:00
2018-04-10 08:35:43 +00:00
2017-11-20 19:25:22 +00:00
2018-03-30 20:24:29 +00:00
2017-11-27 14:52:40 +00:00
2018-04-09 22:06:16 +00:00
2018-01-21 15:42:36 +00:00
2017-12-23 06:49:27 +00:00
2018-04-09 22:06:16 +00:00
2017-12-23 06:49:27 +00:00
2017-11-27 14:52:40 +00:00
2018-04-06 17:35:35 +00:00
2018-04-01 00:25:47 +00:00
2018-03-18 18:58:47 +00:00
2017-11-27 14:52:40 +00:00
2017-11-27 14:52:40 +00:00
2017-11-27 14:52:40 +00:00
2017-11-27 14:52:40 +00:00
2018-04-09 22:06:16 +00:00
2017-11-27 14:52:40 +00:00
2017-11-27 14:52:40 +00:00
2017-11-27 14:52:40 +00:00
2018-01-02 18:29:44 +00:00
2017-11-27 14:52:40 +00:00
2017-11-27 14:52:40 +00:00
2018-01-02 18:31:32 +00:00
2018-01-02 18:31:32 +00:00
2018-01-17 16:41:22 +00:00
2018-04-10 18:05:02 +00:00
2017-11-27 14:52:40 +00:00
2018-03-06 23:39:43 +00:00
2017-11-27 14:52:40 +00:00
2017-11-27 14:52:40 +00:00
2018-03-30 18:50:13 +00:00
2018-04-08 22:59:34 +00:00
2017-11-27 14:52:40 +00:00
2018-03-03 01:53:51 +00:00
2017-12-22 17:53:27 +00:00
2017-11-27 14:52:40 +00:00
2017-12-22 17:53:27 +00:00
2018-04-06 15:15:21 +00:00
2017-11-27 14:52:40 +00:00
2017-11-27 14:52:40 +00:00
2018-02-23 20:01:42 +00:00
2018-03-14 18:27:06 +00:00
2017-11-27 14:52:40 +00:00
2017-11-23 14:28:14 +00:00
2018-03-15 01:07:21 +00:00
2018-03-02 19:50:41 +00:00
2018-03-30 18:50:13 +00:00
2018-03-28 07:59:16 +00:00
2018-01-02 00:07:28 +00:00
2018-03-30 20:24:29 +00:00
2018-03-19 20:55:05 +00:00
2018-03-30 18:50:13 +00:00
2018-03-22 06:31:05 +00:00
2017-09-13 13:03:29 +00:00
2017-11-27 14:52:40 +00:00
2018-01-29 00:14:46 +00:00
2018-01-21 15:42:36 +00:00
2018-04-06 17:35:35 +00:00
2017-11-27 14:52:40 +00:00
2018-04-08 22:59:34 +00:00
2017-11-30 20:33:45 +00:00
2017-11-18 14:26:50 +00:00
2018-01-21 15:42:36 +00:00
2017-12-22 17:15:02 +00:00
2017-11-27 14:52:40 +00:00
2017-11-30 15:48:35 +00:00
2018-04-06 17:35:35 +00:00
2017-11-27 14:52:40 +00:00
2018-04-06 17:35:35 +00:00
2017-11-20 19:36:21 +00:00
2017-12-25 04:48:39 +00:00
2017-11-27 14:52:40 +00:00
2017-11-27 14:52:40 +00:00
2018-03-30 18:50:13 +00:00
2018-04-04 10:45:06 +00:00
2017-11-27 14:52:40 +00:00
2018-02-28 19:05:25 +00:00
2017-11-30 20:33:45 +00:00
2018-04-06 17:35:35 +00:00
2018-04-06 17:35:35 +00:00
2018-01-21 15:42:36 +00:00
2018-04-06 17:35:35 +00:00
2018-01-29 00:14:46 +00:00
2017-11-18 14:26:50 +00:00
2018-03-05 14:34:52 +00:00
2017-12-27 03:23:21 +00:00
2018-03-30 18:50:13 +00:00
2018-02-15 03:22:04 +00:00
2017-11-27 14:52:40 +00:00
2017-11-27 14:52:40 +00:00
2018-01-02 20:58:05 +00:00
2018-01-29 00:14:46 +00:00
2018-04-08 22:59:34 +00:00
2018-04-09 09:24:26 +00:00
2017-11-18 14:26:50 +00:00
2017-11-20 19:36:21 +00:00
2018-01-29 00:14:46 +00:00
2018-01-31 01:04:36 +00:00
2018-04-06 17:35:35 +00:00
2017-11-27 14:52:40 +00:00
2018-03-20 03:37:14 +00:00
2017-11-27 14:52:40 +00:00
2017-11-27 14:52:40 +00:00
2018-04-01 18:53:27 +00:00
2018-03-30 18:50:13 +00:00
2018-03-30 16:44:54 +00:00
2018-04-09 22:06:16 +00:00
2018-03-11 00:38:08 +00:00
2018-03-20 00:03:49 +00:00
2017-11-27 14:52:40 +00:00
2018-03-20 22:01:18 +00:00
2018-03-20 22:01:18 +00:00
2017-11-27 14:52:40 +00:00
2018-04-09 22:59:10 +00:00
2017-11-18 14:26:50 +00:00
2018-03-30 20:27:47 +00:00
2017-10-21 07:23:45 +00:00
2017-11-27 14:52:40 +00:00
2017-11-30 20:33:45 +00:00
2017-12-23 06:49:27 +00:00
2018-01-09 15:57:09 +00:00
2018-01-21 15:42:36 +00:00
2017-11-27 14:52:40 +00:00
2017-11-27 14:52:40 +00:00
2018-03-30 18:50:13 +00:00
2017-11-27 14:52:40 +00:00
2018-03-29 17:36:34 +00:00
2017-11-27 14:52:40 +00:00
2017-11-27 14:52:40 +00:00
2018-03-09 11:33:56 +00:00
2018-03-16 18:50:26 +00:00
2017-11-27 14:52:40 +00:00
2017-11-18 14:26:50 +00:00
2017-11-27 14:52:40 +00:00
2018-04-06 17:35:35 +00:00
2017-11-27 14:52:40 +00:00
2018-03-16 01:03:10 +00:00
2017-11-27 14:52:40 +00:00
2018-03-30 18:50:13 +00:00
2017-11-27 14:52:40 +00:00
2018-03-08 22:49:36 +00:00
2017-11-27 14:52:40 +00:00
2017-11-18 14:26:50 +00:00
2018-03-30 18:50:13 +00:00
2017-11-18 14:26:50 +00:00
2017-11-27 14:52:40 +00:00
2018-04-06 17:35:35 +00:00
2017-11-18 14:26:50 +00:00
2017-11-18 14:26:50 +00:00
2017-11-27 14:52:40 +00:00
2017-12-25 04:48:39 +00:00
2017-11-27 14:52:40 +00:00
2017-11-27 14:52:40 +00:00
2018-01-29 00:22:30 +00:00
2018-04-08 17:06:30 +00:00
2017-11-18 14:26:50 +00:00
2018-01-29 00:14:46 +00:00
2017-11-27 14:52:40 +00:00
2017-11-27 14:52:40 +00:00
2018-04-06 17:35:35 +00:00
2018-03-24 12:48:10 +00:00
2017-11-27 14:52:40 +00:00
2017-11-27 14:52:40 +00:00
2017-11-18 14:26:50 +00:00
2017-11-18 14:26:50 +00:00
2017-11-27 14:52:40 +00:00
2017-11-27 14:52:40 +00:00
2017-11-27 14:52:40 +00:00
2017-11-27 14:52:40 +00:00
2017-11-27 14:52:40 +00:00
2017-11-27 14:52:40 +00:00
2017-12-29 00:59:56 +00:00
2018-04-06 17:35:35 +00:00
2017-11-27 14:52:40 +00:00
2018-04-08 22:59:34 +00:00
2017-11-18 14:26:50 +00:00
2017-11-27 14:52:40 +00:00
2018-02-19 19:31:18 +00:00
2018-04-06 17:35:35 +00:00
2018-04-08 01:32:56 +00:00
2018-04-09 22:06:16 +00:00
2017-11-18 14:26:50 +00:00
2018-04-06 17:35:35 +00:00
2017-11-27 14:52:40 +00:00
2017-11-27 14:52:40 +00:00
2018-03-30 20:24:29 +00:00
2018-01-03 00:56:30 +00:00
2017-11-18 14:26:50 +00:00
2018-01-13 16:31:07 +00:00
2017-11-18 14:26:50 +00:00
2018-01-02 00:07:28 +00:00
2017-11-27 14:52:40 +00:00
2017-11-27 14:52:40 +00:00
2018-02-23 18:15:50 +00:00
2018-03-23 15:35:15 +00:00