asomers 67f6441ba4 Fix file descriptor and memory leaks in pr(1) ...

Also, hook NetBSD's pr test into the build, and add three more test cases.

Reported by:	Coverity, Valgrind
CID:		271650 271651 271652 271653 271654 271655 271656 271656
CID:		271657 271658 271659 1006939 1006940 1006941 1006942 1009098
Reviewed by:	ngie
MFC after:	3 weeks
Sponsored by:	Spectra Logic Corp
Differential Revision:	https://reviews.freebsd.org/D9137

2017-04-04 20:03:57 +00:00

..

addr2line

elftoolchain: Use ${SRCTOP} for the top of the FreeBSD tree

2016-04-21 12:58:29 +00:00

alias

…

apply

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

ar

ar: enable reproducible output by default when invoked as 'ar -s'

2016-06-16 21:22:26 +00:00

asa

…

at

Use nitems() from sys/param.h

2016-07-30 06:32:18 +00:00

atm

Use SRCTOP instead of .CURDIR relative paths with ".."

2017-02-11 20:19:04 +00:00

awk

Import the awk(1) manpage from OpenBSD

2017-03-09 03:27:53 +00:00

banner

strcpy => strlcpy, strcat => strlcat

2017-04-04 19:46:23 +00:00

basename

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

bc

bc/dc/patch: make some use of reallocarray(3).

2017-03-05 16:10:35 +00:00

biff

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

bluetooth

Use SRCTOP to define .include with usr.bin/Makefile.inc

2017-02-11 20:27:53 +00:00

bmake

Merge bmake-20170301

2017-03-06 23:02:33 +00:00

brandelf

…

bsdcat

MFV r315633, 315635:

2017-03-20 13:02:27 +00:00

bsdiff

Revert debugging that was accidently committed in r316314

2017-03-31 03:11:25 +00:00

bzip2

Adopt SRCTOP in usr.bin

2017-03-12 18:58:44 +00:00

bzip2recover

Adopt SRCTOP in usr.bin

2017-03-12 18:58:44 +00:00

c89

…

c99

…

caesar

…

calendar

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

cap_mkdb

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

catman

Instead of ignoring the EEXIST from link(), unconditionally unlink

2016-05-13 05:49:02 +00:00

chat

Delete dead code in chat(8)

2017-01-04 16:24:40 +00:00

checknr

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

chkey

Adopt SRCTOP in usr.bin

2017-03-12 18:58:44 +00:00

chpass

Adopt SRCTOP in usr.bin

2017-03-12 18:58:44 +00:00

cksum

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

clang

Merge ^/head r312720 through r312893.

2017-01-27 20:01:46 +00:00

cmp

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

col

Rename tests from <foo> to <foo>_test to match the FreeBSD test suite

2017-03-23 03:28:24 +00:00

colcrt

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

colldef

Note that mklocale(1) and colldef(1) are no longer used

2016-04-17 23:02:49 +00:00

colrm

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

column

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

comm

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

compile_et

Adopt SRCTOP in usr.bin

2017-03-12 18:58:44 +00:00

compress

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

cpio

MFV r315633, 315635:

2017-03-20 13:02:27 +00:00

cpuset

Fix markup for -j in cpuset(1) synopsis

2016-07-29 21:18:20 +00:00

csplit

Rename getline with get_line to avoid collision with getline(3)

2016-05-10 11:11:23 +00:00

ctags

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

ctlstat

Adopt SRCTOP in usr.bin

2017-03-12 18:58:44 +00:00

cut

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

cxxfilt

elftoolchain: Use ${SRCTOP} for the top of the FreeBSD tree

2016-04-21 12:58:29 +00:00

dc

bc/dc/patch: make some use of reallocarray(3).

2017-03-05 16:10:35 +00:00

diff

diff: Show nanoseconds in -u/-c header line.

2017-03-26 19:47:43 +00:00

dirname

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

dpv

…

drill

Adopt SRCTOP in usr.bin

2017-03-12 18:58:44 +00:00

dtc

Fix build of BSD dtc when NDEBUG is defined (MK_ASSERT_DEBUG=no):

2017-02-13 20:56:53 +00:00

du

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

ee

Adopt SRCTOP in usr.bin

2017-03-12 18:58:44 +00:00

elf2aout

…

elfcopy

Adopt SRCTOP in usr.bin

2017-03-12 18:58:44 +00:00

elfdump

DIRDEPS_BUILD: Update dependencies.

2016-11-13 00:11:30 +00:00

enigma

Remove bdes(1)

2017-02-06 08:27:19 +00:00

env

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

expand

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

factor

Adopt SRCTOP in usr.bin

2017-03-12 18:58:44 +00:00

false

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

fetch

Add phttpget(8) .Xr to fetch(1).

2016-03-29 11:56:00 +00:00

file

Adopt SRCTOP in usr.bin

2017-03-12 18:58:44 +00:00

file2c

Merge ^/user/ngie/release-pkg-fix-tests to unbreak how test files are installed

2016-05-04 23:20:53 +00:00

find

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

finger

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

fmt

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

fold

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

fortune

strcpy => strlcpy, strcat => strlcat

2017-04-04 19:46:23 +00:00

from

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

fstat

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

fsync

…

ftp

Adopt SRCTOP in usr.bin

2017-03-12 18:58:44 +00:00

gcore

Add support for capturing 'struct ptrace_lwpinfo' for signals

2017-03-30 18:21:36 +00:00

gencat

Rename getline with get_line to avoid collision with getline(3)

2016-05-10 11:12:31 +00:00

getaddrinfo

Port the getaddrinfo(1) utility from NetBSD

2017-03-20 16:44:55 +00:00

getconf

Revert crap accidentally committed

2017-01-28 16:31:23 +00:00

getent

Document getent(1)'s ability to enumerate netgroup members.

2016-06-04 21:34:06 +00:00

getopt

DIRDEPS_BUILD: Update dependencies.

2016-11-13 00:11:30 +00:00

gprof

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

grdc

…

grep

bsdgrep(1): Fix errors with invalid expressions

2017-04-04 17:05:37 +00:00

gzip

Reflect actual NetBSD revision we already have.

2017-02-06 07:02:17 +00:00

head

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

hesinfo

…

hexdump

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

host

Adopt SRCTOP in usr.bin

2017-03-12 18:58:44 +00:00

iconv

iconv(1): Capsicumify

2016-12-16 02:06:34 +00:00

id

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

ident

Rename tests from <foo> to <foo>_test to match the FreeBSD test suite

2017-03-23 03:28:24 +00:00

indent

Integrate indent tests added in r313544 into ATF/Kyua and the FreeBSD

2017-03-03 20:15:22 +00:00

ipcrm

Adopt SRCTOP in usr.bin

2017-03-12 18:58:44 +00:00

ipcs

…

iscsictl

Adopt SRCTOP in usr.bin

2017-03-12 18:58:44 +00:00

join

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

jot

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

kdump

Decode arguments to chflagsat().

2017-03-15 22:36:26 +00:00

keylogin

…

keylogout

…

killall

…

ktrace

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

ktrdump

ktrdump(8): Capsicumify

2016-12-16 01:59:28 +00:00

lam

Do not die on system built without CAPSICUM

2017-03-15 15:57:11 +00:00

last

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

lastcomm

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

ldd

Increase size of argv[] array to avoid running off the end.

2016-05-16 16:01:46 +00:00

leave

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

less

Adopt SRCTOP in usr.bin

2017-03-12 18:58:44 +00:00

lessecho

Adopt SRCTOP in usr.bin

2017-03-12 18:58:44 +00:00

lesskey

Adopt SRCTOP in usr.bin

2017-03-12 18:58:44 +00:00

lex

Adopt SRCTOP in usr.bin

2017-03-12 18:58:44 +00:00

limits

strcpy => strlcpy, strcat => strlcat

2017-04-04 19:46:23 +00:00

locale

Adopt SRCTOP in usr.bin

2017-03-12 18:58:44 +00:00

localedef

Adopt SRCTOP in usr.bin

2017-03-12 18:58:44 +00:00

locate

Revert prior commit to restore the files mangled by my "fixing" merge

2017-03-01 02:10:40 +00:00

lock

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

lockf

…

logger

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

login

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

logins

…

logname

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

look

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

lorder

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

lsvfs

…

lzmainfo

Adopt SRCTOP in usr.bin

2017-03-12 18:58:44 +00:00

m4

Adopt SRCTOP in usr.bin

2017-03-12 18:58:44 +00:00

mail

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

man

- Remove separate handling of /bin and /usr/bin in manpath. They are no

2017-03-12 10:56:19 +00:00

mandoc

Adopt SRCTOP in usr.bin

2017-03-12 18:58:44 +00:00

mesg

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

minigzip

Adopt SRCTOP in usr.bin

2017-03-12 18:58:44 +00:00

ministat

ministat(1): Capsicumify

2016-12-16 01:51:12 +00:00

mkcsmapper

Adopt SRCTOP in usr.bin

2017-03-12 18:58:44 +00:00

mkcsmapper_static

Adopt SRCTOP in usr.bin

2017-03-12 18:58:44 +00:00

mkdep

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

mkesdb

Adopt SRCTOP in usr.bin

2017-03-12 18:58:44 +00:00

mkesdb_static

Adopt SRCTOP in usr.bin

2017-03-12 18:58:44 +00:00

mkfifo

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

mkimg

Rename tests from <foo> to <foo>_test to match the FreeBSD test suite

2017-03-23 03:28:24 +00:00

mklocale

Adopt SRCTOP in usr.bin

2017-03-12 18:58:44 +00:00

mkstr

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

mktemp

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

mkuzip

Remove spaces at EOL and sort correctly the SEE ALSO section

2017-02-11 23:40:57 +00:00

morse

…

msgs

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

mt

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

nc

Adopt SRCTOP in usr.bin

2017-03-12 18:58:44 +00:00

ncal

ncal: fix a reference to an out-of-scope stack buffer

2016-11-05 14:08:14 +00:00

netstat

Hide struct inpcb, struct tcpcb from the userland.

2017-03-21 06:39:49 +00:00

newgrp

Remove useless calls to basename().

2016-05-01 08:22:11 +00:00

newkey

Squelch clang 3.9.0 warnings about BASE (which is 32768) being converted

2016-08-30 19:02:15 +00:00

nfsstat

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

nice

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

nl

Remove another occurence of _WITH_GETLINE

2016-07-31 19:02:19 +00:00

nm

elftoolchain: Use ${SRCTOP} for the top of the FreeBSD tree

2016-04-21 12:58:29 +00:00

nohup

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

numactl

Don't repeat the the word 'the'

2016-05-17 12:52:31 +00:00

number

…

opieinfo

Adopt SRCTOP in usr.bin

2017-03-12 18:58:44 +00:00

opiekey

Adopt SRCTOP in usr.bin

2017-03-12 18:58:44 +00:00

opiepasswd

Adopt SRCTOP in usr.bin

2017-03-12 18:58:44 +00:00

pagesize

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

pamtest

Adopt SRCTOP in usr.bin

2017-03-12 18:58:44 +00:00

passwd

Convert absolute links to relative links.

2017-03-07 05:10:38 +00:00

paste

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

patch

bc/dc/patch: make some use of reallocarray(3).

2017-03-05 16:10:35 +00:00

pathchk

Add -P to pathchk usage

2016-07-09 04:56:28 +00:00

perror

Remove spaces at end of line

2017-02-11 23:45:50 +00:00

pom

…

pr

Fix file descriptor and memory leaks in pr(1)

2017-04-04 20:03:57 +00:00

primes

primes: trivially capsicumize

2016-09-30 13:50:59 +00:00

printenv

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

printf

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

proccontrol

DIRDEPS_BUILD: Connect new directories.

2016-09-23 22:46:19 +00:00

procstat

Add support for capturing 'struct ptrace_lwpinfo' for signals

2017-03-30 18:21:36 +00:00

protect

…

quota

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

random

Fix a (false positive?) Argument cannot be negative coverity defect.

2016-06-08 02:14:05 +00:00

rctl

Add four new RCTL resources - readbps, readiops, writebps and writeiops,

2016-04-07 04:23:25 +00:00

readelf

Adopt SRCTOP in usr.bin

2017-03-12 18:58:44 +00:00

renice

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

resizewin

Make resizewin.1 manpage use .Fx macro

2016-07-29 21:05:17 +00:00

rev

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

revoke

Remove empty space at EOL and escept Ed

2017-02-11 23:39:56 +00:00

rlogin

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

rpcgen

rpcgen(1): Check getrlimit() return for generated code.

2017-01-12 14:44:41 +00:00

rpcinfo

strcpy => strlcpy, strcat => strlcat

2017-04-04 19:46:23 +00:00

rs

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

rsh

Adopt SRCTOP in usr.bin

2017-03-12 18:58:44 +00:00

rup

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

ruptime

Fix formatting. ruptime output on FreeBSD cluster machines annoyed me

2017-03-04 04:06:33 +00:00

rusers

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

rwall

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

rwho

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

script

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

sdiff

Rename tests from <foo> to <foo>_test to match the FreeBSD test suite

2017-03-23 03:28:24 +00:00

sed

Add some useful examples to the sed man page.

2017-03-27 16:01:44 +00:00

send-pr

…

seq

Update history. Patch supplied by Sevan Janiyan <venture37@geeklan.co.uk>.

2016-09-16 14:23:16 +00:00

setchannel

…

shar

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

showmount

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

size

elftoolchain: Use ${SRCTOP} for the top of the FreeBSD tree

2016-04-21 12:58:29 +00:00

smbutil

Adopt SRCTOP in usr.bin

2017-03-12 18:58:44 +00:00

sockstat

Shut up gcc.

2017-03-21 08:57:20 +00:00

soelim

Rename tests from <foo> to <foo>_test to match the FreeBSD test suite

2017-03-23 03:28:24 +00:00

sort

sort(1): Remove unneeded initializations.

2017-02-17 19:53:20 +00:00

split

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

ssh-copy-id

…

stat

Use MIN() instead of MAX() as the previous syntax was wrote in a weird and

2016-04-26 00:29:00 +00:00

stdbuf

…

strings

elftoolchain: Use ${SRCTOP} for the top of the FreeBSD tree

2016-04-21 12:58:29 +00:00

su

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

svn

Adopt SRCTOP in usr.bin

2017-03-12 18:58:44 +00:00

systat

Hide struct inpcb, struct tcpcb from the userland.

2017-03-21 06:39:49 +00:00

tabs

…

tail

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

talk

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

tar

MFV r315875:

2017-03-24 00:02:12 +00:00

tcopy

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

tee

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

telnet

Adopt SRCTOP in usr.bin

2017-03-12 18:58:44 +00:00

tests

Merge ^/user/ngie/release-pkg-fix-tests to unbreak how test files are installed

2016-05-04 23:20:53 +00:00

tftp

Adopt SRCTOP in usr.bin

2017-03-12 18:58:44 +00:00

time

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

timeout

Rename some tests to end in _test.

2017-03-09 04:20:00 +00:00

tip

…

top

fix top(1) ZFS compressed ARC support

2017-03-31 03:08:07 +00:00

touch

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

tput

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

tr

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

true

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

truncate

Merge ^/user/ngie/release-pkg-fix-tests to unbreak how test files are installed

2016-05-04 23:20:53 +00:00

truss

Improve decoding of last arguments to ioctl() and sendto().

2017-03-19 00:36:29 +00:00

tset

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

tsort

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

tty

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

ul

Do not truncate lines longer than 512 chars.

2016-07-11 08:05:46 +00:00

uname

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

unexpand

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

unifdef

…

uniq

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

units

Escape No to avoid confusion with the No macro

2017-02-11 23:38:28 +00:00

unvis

Adopt SRCTOP in usr.bin

2017-03-12 18:58:44 +00:00

unzip

Add missing section after .Xr reference

2017-02-11 23:37:48 +00:00

usbhidaction

…

usbhidctl

…

users

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

uudecode

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

uuencode

Use nitems() from sys/param.h.

2017-03-10 06:23:15 +00:00

vacation

Adopt SRCTOP in usr.bin

2017-03-12 18:58:44 +00:00

vgrind

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

vi

Adopt SRCTOP in usr.bin

2017-03-12 18:58:44 +00:00

vis

Adopt SRCTOP in usr.bin

2017-03-12 18:58:44 +00:00

vmstat

Bring back the cast removed in my previous commit to allow us build vmstat

2017-03-11 04:36:15 +00:00

vtfontcvt

vtfontcvt: remove superfluous newlines in errx messages

2016-09-14 18:22:12 +00:00

w

Adopt SRCTOP in usr.bin

2017-03-12 18:58:44 +00:00

wall

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

wc

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

what

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

whereis

usr.bin: minor spelling fixes on comments.

2016-05-01 16:13:05 +00:00

which

…

who

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

whois

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

write

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

xargs

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

xinstall

Adopt SRCTOP in usr.bin

2017-03-12 18:58:44 +00:00

xlint

Fix improper use of "its".

2016-11-08 23:59:41 +00:00

xo

Merge ^/user/ngie/release-pkg-fix-tests to unbreak how test files are installed

2016-05-04 23:20:53 +00:00

xstr

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

xz

Adopt SRCTOP in usr.bin

2017-03-12 18:58:44 +00:00

xzdec

Adopt SRCTOP in usr.bin

2017-03-12 18:58:44 +00:00

yacc

Adopt SRCTOP in usr.bin

2017-03-12 18:58:44 +00:00

yes

Renumber copyright clause 4

2017-02-28 23:42:47 +00:00

ypcat

…

ypmatch

…

ypwhich

Adopt SRCTOP in usr.bin

2017-03-12 18:58:44 +00:00

Makefile

Port the getaddrinfo(1) utility from NetBSD

2017-03-20 16:44:55 +00:00

Makefile.amd64

…

Makefile.arm

…

Makefile.i386

…

Makefile.inc

…

Makefile.powerpc

…

Makefile.sparc64

…