avg 234556c450 MFV r316925: 6101 attempt to lzc_create() a filesystem under a volume results in a panic ... illumos/illumos-gate@b127fe3c05 b127fe3c05 https://www.illumos.org/issues/6101 lzc_create(), or more correctly, zfs_ioc_create() does not reject an attempt to create a filesystem as a child of a volume, instead it proceeds to a crash. A crash stack obtained on FreeBSD: page fault while in kernel mode zap_leaf_lookup() fzap_lookup() zap_lookup_norm() zap_lookup() zfs_get_zplprop() zfs_fill_zplprops_impl() zfs_ioc_create() zfsdev_ioctl() devfs_ioctl_f() kern_ioctl() sys_ioctl() This crash happened with a kernel without debugging assertions. The immediate cause of crash appears to an attempt to interpret a zvol object as a zap object. For filesystems: #define MASTER_NODE_OBJ 1 For zvols: #define ZVOL_OBJ 1ULL #define ZVOL_ZAP_OBJ 2ULL So, I see two problems here: 1. an attempt to create a filesystem under a zvol should be rejected as early as possible, maybe in zfs_fill_zplprops() 2. maybe zap_lookup / zap_lockdir should reject objects that are not of one of the zap object types Reviewed by: Matthew Ahrens <mahrens@delphix.com> Approved by: Dan McDonald <danmcd@omniti.com> Author: Andriy Gapon <avg@FreeBSD.org> MFC after: 2 weeks		2017-05-24 22:34:54 +00:00
..
boot/zfs	loader: update symlink support in zfs reader	2017-02-22 22:00:50 +00:00
compat/opensolaris	Commit the 64-bit inode project.	2017-05-23 09:29:05 +00:00
contrib/opensolaris	MFV r316925: 6101 attempt to lzc_create() a filesystem under a volume results in a panic	2017-05-24 22:34:54 +00:00
dev	Ensure that profile and tick probes provide a non-zero PC value.	2017-05-15 21:44:40 +00:00